1. 12 Feb, 2007 1 commit
    • unknown's avatar
      Fixed bug #26209. · 3ec35ab0
      unknown authored
      The function make_unireg_sortorder ignored the fact that any
      view field is represented by a 'ref' object.
      This could lead to wrong results for the queries containing
      both GROUP BY and ORDER BY clauses.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #26209.
      mysql-test/t/view.test:
        Added a test case for bug #26209.
      3ec35ab0
  2. 11 Feb, 2007 2 commits
    • unknown's avatar
      sql_view.cc: · 56baa89b
      unknown authored
        Post fix for bug#12122.
      information_schema.result:
        Corrected test case after fixing bug#12122.
      
      
      sql/sql_view.cc:
        Post fix for bug#12122.
      mysql-test/r/information_schema.result:
        Corrected test case after fixing bug#12122.
      56baa89b
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 537de83a
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/12122-bug-5.0-opt-mysql
      
      537de83a
  3. 09 Feb, 2007 6 commits
    • unknown's avatar
      Bug#12122: The MERGE algorithm isn't applicable if the ORDER BY clause is · 94032c61
      unknown authored
      present.
      
      A view created with CREATE VIEW ... ORDER BY ... cannot be resolved with
      the MERGE algorithm, even when no other part of the CREATE VIEW statement
      would require the view to be resolved using the TEMPTABLE algorithm.
      
      The check for presence of the ORDER BY clause in the underlying select is 
      removed from the st_lex::can_be_merged() function.
      The ORDER BY list of the underlying select is appended to the ORDER BY list 
      
      
      mysql-test/t/view.test:
        Added a test case for bug#12122: Views with ORDER BY can't be resolved using MERGE algorithm.
      mysql-test/r/view.result:
        Added a test case for bug#12122: Views with ORDER BY can't be resolved using MERGE algorithm.
      sql/sql_lex.cc:
        Bug#12122: Views with ORDER BY can't be resolved using MERGE algorithm.
        The st_lex::can_be_merged() function now allows views with the ORDER BY
        clause to be resolved using MERGE algorithm. The ORDER BY list of the view 
        is appended to the ORDER BY list of the embedding select.
      94032c61
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 854f45ef
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug26017
      
      854f45ef
    • unknown's avatar
      Fixed bug #26017. · 1ba8ec70
      unknown authored
      Objects of the class Item_equal contain an auxiliary member
      eval_item of the type cmp_item that is used only for direct 
      evaluation of multiple equalities. Currently a multiple equality
      is evaluated directly only in the cases when the equality holds
      at most for one row in the result set.
      The compare collation of eval_item was determined incorectly.
      It could lead to returning incorrect results for some queries.
      
      
      mysql-test/r/join_outer.result:
        Added a test case for bug #26017.
      mysql-test/t/join_outer.test:
        Added a test case for bug #26017.
      sql/item_cmpfunc.cc:
        Fixed bug #26017.
        Objects of the class Item_equal contain an auxiliary member
        eval_item of the type cmp_item that is used only for direct 
        evaluation of multiple equalities. Currently a multiple equality
        is evaluated directly only in the cases when the equality holds
        at most for one row in the result set.
        The compare collation of eval_item was determined incorrectly.
        It could lead to returning incorrect results for some queries.
      sql/item_cmpfunc.h:
        Fixed bug #26017.
        Removed the cmp_collation member from the Item_equal class as useless
        for the current implementation of the class.
      1ba8ec70
    • unknown's avatar
      Bug#23170: LAST_INSERT_ID isn't reset to 0 in INSERT .. SELECT when no rows were · 27481649
      unknown authored
      inserted.
      
      The select_insert::send_eof() function now resets LAST_INSERT_ID variable if
      no rows were inserted.
      
      
      mysql-test/t/insert_select.test:
        Added a test case for bug#23170: LAST_INSERT_ID isn't reset to 0 in INSERT .. SELECT when no rows were inserted.
      mysql-test/r/insert_select.result:
        Added a test case for bug#23170: LAST_INSERT_ID isn't reset to 0 in INSERT .. SELECT when no rows were inserted.
      sql/sql_insert.cc:
        Bug#23170: LAST_INSERT_ID isn't reset to 0 in INSERT .. SELECT when no rows were
        inserted.The select_insert::send_eof() function now resets LAST_INSERT_ID variable if
        no rows were inserted.
      27481649
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · d7798f8d
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B22344-5.0-opt
      
      d7798f8d
    • unknown's avatar
      8f31da3c
  4. 08 Feb, 2007 3 commits
  5. 07 Feb, 2007 8 commits
    • unknown's avatar
      Fixed bug #25931. · ec8f5394
      unknown authored
      View check option clauses were ignored for updates of multi-table
      views when the updates could not be performed on fly and the rows
      to update had to be put into temporary tables first.
      
      
      
      mysql-test/r/view.result:
        Added a test case for bug #25931.
      mysql-test/t/view.test:
        Added a test case for bug #25931.
        Adjusted another existed test case to have the correct result.
      sql/sql_update.cc:
        Fixed bug #25931.
        View check option clauses were ignored for updates of multi-table
        views when the updates could not be performed on fly and the rows
        to update had to be put into temporary tables first.
        Added the required check to multi_update::do_updates to fix the problem.
      ec8f5394
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 94ae4b87
      unknown authored
      into  poseidon.mysql.com:/home/tomas/mysql-4.1-ndb
      
      94ae4b87
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 485f35eb
      unknown authored
      into  poseidon.mysql.com:/home/tomas/mysql-5.0-ndb
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      485f35eb
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · f48a7ad2
      unknown authored
      into  mysql.com:/windows/Linux_space/MySQL/mysql-5.0-ndb
      
      f48a7ad2
    • unknown's avatar
      Merge mysql.com:/windows/Linux_space/MySQL/mysql-5.0 · de1eced0
      unknown authored
      into  mysql.com:/windows/Linux_space/MySQL/mysql-5.0-ndb
      
      
      ndb/include/ndbapi/NdbIndexScanOperation.hpp:
        Auto merged
      ndb/include/ndbapi/NdbScanOperation.hpp:
        Auto merged
      ndb/src/ndbapi/NdbScanOperation.cpp:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_ndbcluster.h:
        Auto merged
      de1eced0
    • unknown's avatar
      NdbScanOperation.hpp, NdbScanOperation.cpp, ha_ndbcluster.cc: · 9656559a
      unknown authored
        bug#25821  Excessive partition pruning for multi-range index scan in NDB API: added multi_range error checking in end_of_bound
      ha_ndbcluster.h:
        Removed stray mthod declaration
      
      
      sql/ha_ndbcluster.h:
        Removed stray mthod declaration
      ndb/include/ndbapi/NdbScanOperation.hpp:
        bug#25821  Excessive partition pruning for multi-range index scan in NDB API: added multi_range error checking in end_of_bound
      ndb/src/ndbapi/NdbScanOperation.cpp:
        bug#25821  Excessive partition pruning for multi-range index scan in NDB API: added multi_range error checking in end_of_bound
      sql/ha_ndbcluster.cc:
        bug#25821  Excessive partition pruning for multi-range index scan in NDB API: added multi_range error checking in end_of_bound
      9656559a
    • unknown's avatar
      bug#25821 Excessive partition pruning for multi-range index scan in NDB API:... · 44e8a0f0
      unknown authored
      bug#25821  Excessive partition pruning for multi-range index scan in NDB API: post-review fix, added default value
      
      
      44e8a0f0
    • unknown's avatar
      Fixed bug #26124: SELECT from a view wrapper over a table · 4b61157d
      unknown authored
      with a column of the DATETIME type could return a wrong 
      result set if the WHERE clause included a BETWEEN condition
      on the column.
      Fixed the method Item_func_between::fix_length_and_dec
      where the aggregation type for BETWEEN predicates calculated
      incorrectly if the first argument was a view column of the
      DATETIME type.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #26124.
      mysql-test/t/view.test:
        Added a test case for bug #26124.
      4b61157d
  6. 06 Feb, 2007 3 commits
    • unknown's avatar
      Fix for bug#25821 Excessive partition pruning for multi-range index scan in... · 8e60d0b0
      unknown authored
      Fix for bug#25821  Excessive partition pruning for multi-range index scan in NDB API: don't set distribution key if multi_range
      
      
      8e60d0b0
    • unknown's avatar
      Bug#19978: INSERT .. ON DUPLICATE erroneously reports some records were · 394d2ba6
      unknown authored
      updated.
      
      INSERT ... ON DUPLICATE KEY UPDATE reports that a record was updated when
      the duplicate key occurs even if the record wasn't actually changed
      because the update values are the same as those in the record.
      
      Now the compare_record() function is used to check whether the record was
      changed and the update of a record reported only if the record differs
      from the original one.
      
      
      sql/sql_update.cc:
        Bug#19978: INSERT .. ON DUPLICATE erroneously reports some records were
        updated.
        The compare_record() function was changed to non-static one.
      sql/sql_insert.cc:
        Bug#19978: INSERT .. ON DUPLICATE erroneously reports some records were
        updated.
        Now the compare_record() function is used to check whether the record was
        changed and the update of a record reported only if the record differs
        from the original one.
      sql/mysql_priv.h:
        Bug#19978: INSERT .. ON DUPLICATE erroneously reports some records were
        updated.
        Added the prototype of the compare_record() function.
      mysql-test/t/insert_select.test:
        Added a test case for bug#19978: INSERT .. ON DUPLICATE erroneously reports
        some records were updated.
      mysql-test/r/insert_select.result:
        Added a test case for bug#19978: INSERT .. ON DUPLICATE erroneously reports
        some records were updated.
      394d2ba6
    • unknown's avatar
      Bug #22344: InnoDB keys act strange on datetime vs timestamp comparison · bdc14162
      unknown authored
       Ignoring error codes from type conversion allows default (wrong) values to
       go unnoticed in the formation of index search conditions.
       Fixed by correctly checking for conversion errors.
      
      
      mysql-test/r/select.result:
        Bug #22344: InnoDB keys act strange on datetime vs timestamp comparison
         - test case
      mysql-test/t/select.test:
        Bug #22344: InnoDB keys act strange on datetime vs timestamp comparison
         - test case
      sql/field.h:
        Bug #22344: InnoDB keys act strange on datetime vs timestamp comparison
         - don't ignore coversion errors
      sql/field_conv.cc:
        Bug #22344: InnoDB keys act strange on datetime vs timestamp comparison
         - don't ignore coversion errors
      sql/item.cc:
        Bug #22344: InnoDB keys act strange on datetime vs timestamp comparison
         - don't ignore coversion errors
      bdc14162
  7. 05 Feb, 2007 1 commit
    • unknown's avatar
      Test and bug fixes and removed unneccessary files. · d38139c7
      unknown authored
      
      mysys/my_getopt.c:
        Fixes problem with getting output lines from
        my_getopt in random places in tests.
      sql/sql_prepare.cc:
        Fixes problem with failing mysql_client_test
        on some machines. This is actually a problem
        with prepared statements.
      d38139c7
  8. 03 Feb, 2007 2 commits
  9. 02 Feb, 2007 11 commits
    • unknown's avatar
      Fix bug #24035. · 8cea541c
      unknown authored
      This performance degradation for UPDATEs could be observed in the update
      statements for which the search key cannot be converted to any valid
      value of the type of the search column, like for a  the condition
      int_fld=99999999999999999999999999, though it can be guaranteed here
      that there is no row with such a key value. 
      
      
      mysql-test/r/update.result:
        Added a test case for bug #24035.
      mysql-test/t/update.test:
        Added a test case for bug #24035.
      sql/opt_range.cc:
        Fix bug #24035.
        This performance degradation for could be observed in the update
        statements for which the search key cannot be converted to any valid
        value of the type of the search column, like for a  the condition
        int_fld=99999999999999999999999999, though it can be guaranteed here
        that there is no row with such a key value. 
        Now the function get_mm_leaf creates trees of the type SEL_ARG::IMPOSSIBLE 
        for such conditions that tells the range scan not to perform any search
        at all.
      8cea541c
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-axmrg · 7aa745a7
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      
      sql/handler.cc:
        Auto merged
      sql/examples/ha_tina.cc:
        Auto merged
      sql/examples/ha_tina.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      mysql-test/Makefile.am:
        Manual merged
      7aa745a7
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 8a10d3af
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      
      sql/item_func.cc:
        Auto merged
      8a10d3af
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · a7bcf8ad
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1-axmrg
      
      a7bcf8ad
    • unknown's avatar
      After merge fix · 978a1883
      unknown authored
      978a1883
    • unknown's avatar
      aea9a675
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0 · ccc35118
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      ccc35118
    • unknown's avatar
      Valgrind errors · abca759b
      unknown authored
      added valgrind.supp to EXTRA_SCRIPTS(for pushbuild)
      
      abca759b
    • unknown's avatar
      Merge lzhou@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 040491a9
      unknown authored
      into  dev3-63.(none):/home/zhl/mysql/tree-merge/5.0/mysql-5.0-ndb
      
      040491a9
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-axmrg · 9cb831e3
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      
      include/my_pthread.h:
        Auto merged
      include/thr_alarm.h:
        Auto merged
      mysys/my_pthread.c:
        Auto merged
      mysys/my_thr_init.c:
        Auto merged
      9cb831e3
    • unknown's avatar
      After merge fix · 3b96b4d2
      unknown authored
      3b96b4d2
  10. 01 Feb, 2007 3 commits
    • unknown's avatar
      Merge dev3-63.(none):/home/zhl/mysql/tree-merge/5.0/mysql-5.0-ndb-bj · d6673ac3
      unknown authored
      into  dev3-63.(none):/home/zhl/mysql/tree-merge/5.0/mysql-5.0-ndb
      
      
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      ndb/src/ndbapi/Ndb.cpp:
        Auto merged
      d6673ac3
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-axmrg · 41555dcd
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      
      BitKeeper/deleted/.del-valgrind.supp:
        Delete: mysql-test/valgrind.supp
      mysql-test/r/ps.result:
        SCCS merged
      mysql-test/r/symlink.result:
        Null merged
      mysql-test/t/ps.test:
        SCCS merged
      mysql-test/t/symlink.test:
        Null merged
      sql/field_conv.cc:
        Null merged
      sql/mysqld.cc:
        Null merged
      vio/viosslfactories.c:
        Null merged
      41555dcd
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 977d05c1
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      
      BUILD/SETUP.sh:
        Auto merged
      configure.in:
        Auto merged
      977d05c1