1. 14 Feb, 2023 2 commits
  2. 10 Feb, 2023 2 commits
  3. 09 Feb, 2023 5 commits
    • Brandon Nesterenko's avatar
      MDEV-30608: rpl.rpl_delayed_parallel_slave_sbm sometimes fails with... · eecd4f14
      Brandon Nesterenko authored
      MDEV-30608: rpl.rpl_delayed_parallel_slave_sbm sometimes fails with Seconds_Behind_Master should not have used second transaction timestamp
      
      One of the constraints added in the MDEV-29639 patch, is that only
      the first event after idling should update last_master_timestamp;
      and as long as the replica has more events to execute, the variable
      should not be updated. The corresponding test,
      rpl_delayed_parallel_slave_sbm.test, aims to verify this; however,
      if the IO thread takes too long to queue events, the SQL thread can
      appear to catch up too fast.
      
      This fix ensures that the relay log has been fully written before
      executing the events.
      
      Note that the underlying cause of this test failure needs to be
      addressed as a bug-fix, this is a temporary fix to stop test
      failures. To track work on the bug-fix for the underlying issue,
      please see MDEV-30619.
      eecd4f14
    • Igor Babaev's avatar
      MDEV-30586 DELETE with aggregation in subquery of WHERE returns bogus error · c6376842
      Igor Babaev authored
      The parser code for single-table DELETE missed the call of the function
      LEX::check_main_unit_semantics(). As a result the the field nested level
      of SELECT_LEX structures remained set 0 for all non-top level selects.
      This could lead to different kind of problems. In particular this did not
      allow to determine properly the selects where set functions had to be
      aggregated when they were used in inner subqueries.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      c6376842
    • Vicențiu Ciorbaru's avatar
      Apply clang-tidy to remove empty constructors / destructors · 08c85202
      Vicențiu Ciorbaru authored
      This patch is the result of running
      run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' .
      
      Code style changes have been done on top. The result of this change
      leads to the following improvements:
      
      1. Binary size reduction.
      * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by
        ~400kb.
      * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb.
      
      2. Compiler can better understand the intent of the code, thus it leads
         to more optimization possibilities. Additionally it enabled detecting
         unused variables that had an empty default constructor but not marked
         so explicitly.
      
         Particular change required following this patch in sql/opt_range.cc
      
         result_keys, an unused template class Bitmap now correctly issues
         unused variable warnings.
      
         Setting Bitmap template class constructor to default allows the compiler
         to identify that there are no side-effects when instantiating the class.
         Previously the compiler could not issue the warning as it assumed Bitmap
         class (being a template) would not be performing a NO-OP for its default
         constructor. This prevented the "unused variable warning".
      08c85202
    • Vladislav Vaintroub's avatar
      MDEV-30624 HeidiSQL 12.3 · 8dab6614
      Vladislav Vaintroub authored
      8dab6614
    • Vladislav Vaintroub's avatar
  4. 08 Feb, 2023 3 commits
  5. 07 Feb, 2023 4 commits
    • Daniel Black's avatar
      MDEV-30572: my_large_malloc will only retry on ENOMEM · 2b494ccc
      Daniel Black authored
      Correct error in to only say "continuing to smaller size" if it really
      is.
      2b494ccc
    • Daniel Black's avatar
      MDEV-30554 RockDB libatomic linking on riscv64 · 17423c6c
      Daniel Black authored
      The existing storage/rocksdb/CMakeCache.txt defined
      ATOMIC_EXTRA_LIBS when atomics where required. This was
      determined by the toplevel configure.cmake test
      (HAVE_GCC_C11_ATOMICS_WITH_LIBATOMIC).
      
      As build_rocksdb.cmake is included after ATOMIC_EXTRA_LIBS
      was set, we just need to use it. As such no riscv64
      specific macro is needed in build_rocksdb.cmake.
      
      As highlighted by Gianfranco Costamagna (@LocutusOfBorg)
      in #2472 overwriting SYSTEM_LIBS was problematic.
      This is corrected in case in future SYSTEM_LIBS is changed
      elsewhere.
      
      Closes #2472.
      17423c6c
    • Daniel Black's avatar
      MDEV-30492 Crash when use mariabackup.exe with config 'innodb_flush_method=async_unbuffered' · ecc93c98
      Daniel Black authored
      Normalize innodb_flush_method, the same as the service, before
      attempting to print it.
      ecc93c98
    • Daniel Black's avatar
      MDEV-30558: ER_KILL_{,QUERY_}DENIED_ERROR - normalize id type · 762fe015
      Daniel Black authored
      The error string from ER_KILL_QUERY_DENIED_ERROR took a different
      type to ER_KILL_DENIED_ERROR for the thread id. This shows
      up in differences on 32 big endian arches like powerpc (Deb notation).
      
      Normalize the passing of the THD->id to its real type of my_thread_id,
      and cast to (long long) on output. As such normalize the
      ER_KILL_QUERY_DENIED_ERROR to that convention too.
      
      Note for upwards merge, convert the type to %lld on new translations
      of ER_KILL_QUERY_DENIED_ERROR.
      762fe015
  6. 06 Feb, 2023 7 commits
  7. 03 Feb, 2023 2 commits
  8. 31 Jan, 2023 2 commits
  9. 30 Jan, 2023 5 commits
  10. 28 Jan, 2023 4 commits
  11. 27 Jan, 2023 4 commits