- 20 Nov, 2018 3 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
recv_addr_trim(): Do not try to detach the hash bucket, because the code for doing that does not always work. recv_apply_hashed_log_recs(): Do not attempt to read pages for which there exist no redo log records.
-
- 19 Nov, 2018 6 commits
-
-
Elena Stepanova authored
Skip tests which expectedly fail when Aria is not used for temporary tables
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Commit ff88e4bb broke the Windows build. Clean up one more redundant #include to fix it.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
lock_discard_page(): Traverse and discard the B-tree record locks only if they exist. Else, discard the R-tree (spatial) index locks.
-
Marko Mäkelä authored
Compare against the correct constant 0. NOT_KILLED belongs to enum killed_state, while THD_IS_NOT_KILLED is what we want.
-
- 16 Nov, 2018 4 commits
-
-
Elena Stepanova authored
-
Monty authored
This caused ma_test_recovery.pl to fail Other things: - Fixed bug where "ma_test_recovert.pl --abort-on-error" didn't abort on error
-
Marko Mäkelä authored
THD::close_temporary_tables(): Revert the change. ha_innobase::delete_table(): Move the work-around inside a debug assertion, and check thd_kill_level() instead of thd_killed(), because the latter would not hold for KILL_CONNECTION.
-
Varun Gupta authored
For prepare statemtent/stored procedures we rollback the items to original ones after prepare execution in the function reinit_stmt_before_use. This rollback is done for group by, order by clauses but is not done for the window specification containing the order by and partition by clause of the window function.
-
- 15 Nov, 2018 9 commits
-
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Vladislav Vaintroub authored
MDEV-16447 incorporate Innodb slow shutdown into mysql_upgrade_service.exe
-
Vladislav Vaintroub authored
in 10.3, AWS encryption key was loaded during recovery, by the innodb purge thread, therefore no note "loaded key" was written by the foreground thread.
-
Oleksandr Byelkin authored
-
Marko Mäkelä authored
MDEV-17726 Assertion `sqlcom != SQLCOM_TRUNCATE' failed in ha_innobase::delete_table after truncating temporary table THD::close_temporary_tables(): Assign lex->sql_command so that the debug assertion will not fail in ha_innobase::delete_table(). Alternatively, we could ensure that thd_killed() holds inside ha_innobase::delete_table(). There should be no impact for the non-debug build. The thd_sql_command() inside ha_innobase::delete_table() only affects the treatment of persistent FOREIGN KEY metadata. There is no persistent metadata nor foreign key constraints for temporary tables. No test case was added, because the failure is nondeterministic.
-
Oleksandr Byelkin authored
-
Alexander Barkov authored
The fix for "MDEV-17698 MEMORY engine performance regression" previously fixed this problem. - Adding the test for MDEV-17724 - Re-recording wrong results for tests: * engines/iuds/r/insert_number * engines/iuds/r/update_delete_number which started to fail since MDEV-17698
-
Alexander Barkov authored
Also, backporting a part of: MDEV-11485 Split Item_func_between::val_int() into virtual methods in Type_handler for easier merge to 10.3.
-
- 14 Nov, 2018 7 commits
-
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Alexander Barkov authored
sp_instr_cursor_copy_struct::exec_core() created TYPELIBs on a wrong mem_root, the one which is initialized in sp_head::execute(), this code: /* init per-instruction memroot */ init_sql_alloc(&execute_mem_root, "per_instruction_memroot", MEM_ROOT_BLOCK_SIZE, 0, MYF(0)); This memory root cleans up after every sp_instr_xxx executed, so later sp_instr_cfetch::execute() tried to use already freed and trashed memory. Changing sp_instr_cursor_copy_struct::exec_core() to call tmp.export_structure() inside this block (not outside of it): thd->set_n_backup_active_arena(thd->spcont->callers_arena, ¤t_arena); ... thd->restore_active_arena(thd->spcont->callers_arena, ¤t_arena); So now TYPELIBs created by sp_instr_cursor_copy_struct::exec_core() are still available and valid when sp_instr_cfetch::execute() is called. They are freed at the end of dispatch_command() corresponding to the "CALL p1" statement.
-
Alexander Barkov authored
-
Oleksandr Byelkin authored
MDEV-16217: Assertion `!table || (!table->read_set || bitmap_is_set(table->read_set, field_index))' failed in Field_num::get_date - clean up DEFAULT() to work only with default value and correctly print itself. - fix of DBUG_ASSERT about fields read/write - fix of field marking for write based really on the thd->mark_used_columns flag
-
Marko Mäkelä authored
-
- 13 Nov, 2018 8 commits
-
-
Daniel Bartholomew authored
-
Alexander Barkov authored
-
Andrei Elkin authored
-
Sergei Golubchik authored
update test results for embedded followup for 564a63b5 and 89a87e8e
-
Sergei Golubchik authored
-
Aleksey Midenkov authored
Discrepancy in open indexes due to overwritten `read_partitions` upon `ha_open()` in `ha_partition::clone()`. [Fixes tempesta-tech/mariadb#551]
-
Andrei Elkin authored
The semisync ack collector hits fd's out-of-bound value assert through a stack of /usr/sbin/mysqld(_ZN12Ack_receiver17get_slave_socketsEP6fd_setPj+0x70)[0x7fa3bbe27400] /usr/sbin/mysqld(_ZN12Ack_receiver3runEv+0x540)[0x7fa3bbe27980] /usr/sbin/mysqld(ack_receive_handler+0x19)[0x7fa3bbe27a79] The reason of the failure must be the same as in https://bugs.mysql.com/bug.php?id=79865 whose fixes are applied with minor changes. Specifically, the semisync ack thread is changed to use poll() instead of select() on platforms where the former is defined. On the systems that still use select(), Ack receive thread will generate an error and semi sync will be switched off. Windows systems is exception case because on windows this limitation does not exists. The sustain manual testing with `mysqlslap --concurrency > 1024' in "background" while the slave io thread is restarting multiple times.
-
Alexander Barkov authored
MDEV-17693 Shift/reduce conflicts for NAMES,ROLE,PASSWORD in the option_value_no_option_type grammar
-
- 12 Nov, 2018 3 commits
-
-
Alexander Barkov authored
-
Elena Stepanova authored
-
Marko Mäkelä authored
-