1. 22 Nov, 2022 1 commit
    • Marko Mäkelä's avatar
      MDEV-30069 InnoDB: Trying to write ... bytes at ... outside the bounds · 46f8c46e
      Marko Mäkelä authored
      recv_sys_t::recover_deferred(): If the *.ibd file already exists,
      adjust the size to the tablespace metadata. It could be that
      in a multi-batch recovery, we will initially recover an all-zero
      *.ibd file to a smaller size, and then a fatal error would be
      reported during the last recovery batch.
      
      This bug could be worked around by executing the recovery again.
      During the initial (failed) recovery attempt, something should have
      been written to the first page of the file and the file size should
      be recovered by fil_node_t::read_page0().
      46f8c46e
  2. 21 Nov, 2022 4 commits
  3. 20 Nov, 2022 4 commits
  4. 17 Nov, 2022 3 commits
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 9aea7d83
      Marko Mäkelä authored
      9aea7d83
    • Marko Mäkelä's avatar
      MDEV-29982 fixup: Relax the test · 41028d70
      Marko Mäkelä authored
      The log overwrite warnings are not being reliably emitted in all
      debug-instrumented environments. It may be related to the
      scheduling of some InnoDB internal activity, such as the purging
      of committed transaction history.
      41028d70
    • Marko Mäkelä's avatar
      MDEV-29603 btr_cur_open_at_index_side() is missing some consistency checks · 24fe5347
      Marko Mäkelä authored
      btr_cur_t: Zero-initialize all fields in the default constructor.
      
      btr_cur_t::index: Remove; it duplicated page_cur.index.
      
      Many functions: Remove arguments that were duplicating
      page_cur_t::index and page_cur_t::block.
      
      page_cur_open_level(), btr_pcur_open_level(): Replaces
      btr_cur_open_at_index_side() for dict_stats_analyze_index().
      At the end, release all latches except the dict_index_t::lock
      and the buf_page_t::lock on the requested page.
      
      dict_stats_analyze_index(): Rely on mtr_t::rollback_to_savepoint()
      to release all uninteresting page latches.
      
      btr_search_guess_on_hash(): Simplify the logic, and invoke
      mtr_t::rollback_to_savepoint().
      
      We will use plain C++ std::vector<mtr_memo_slot_t> for mtr_t::m_memo.
      In this way, we can avoid setting mtr_memo_slot_t::object to nullptr
      and instead just remove garbage from m_memo.
      
      mtr_t::rollback_to_savepoint(): Shrink the vector. We will be needing this
      in dict_stats_analyze_index(), where we will release page latches and
      only retain the index->lock in mtr_t::m_memo.
      
      mtr_t::release_last_page(): Release the last acquired page latch.
      Replaces btr_leaf_page_release().
      
      mtr_t::release(const buf_block_t&): Release a single page latch.
      Used in btr_pcur_move_backward_from_page().
      
      mtr_t::memo_release(): Replaced with mtr_t::release().
      
      mtr_t::upgrade_buffer_fix(): Acquire a latch for a buffer-fixed page.
      This replaces the double bookkeeping in btr_cur_t::open_leaf().
      
      Reviewed by: Vladislav Lesin
      24fe5347
  5. 16 Nov, 2022 7 commits
  6. 15 Nov, 2022 2 commits
  7. 14 Nov, 2022 8 commits
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · ae6ebafd
      Marko Mäkelä authored
      ae6ebafd
    • Marko Mäkelä's avatar
      MDEV-29984 innodb_fast_shutdown=0 fails to report change buffer merge progress · dc2741be
      Marko Mäkelä authored
      ibuf.size, ibuf.max_size: Changed the type to Atomic_relaxed<ulint>
      in order to fix some (not all) race conditions.
      
      ibuf_contract(): Renamed from ibuf_merge_pages(ulint*).
      
      ibuf_merge(), ibuf_merge_all(): Removed.
      
      srv_shutdown(): Invoke log_free_check() and ibuf_contract(). Even though
      ibuf_contract() is not writing anything, it will trigger calls of
      ibuf_merge_or_delete_for_page(), which will write something. Because
      we cannot invoke log_free_check() at that low level, we must invoke
      it at the high level.
      
      srv_shutdown_print(): Replaces srv_shutdown_print_master_pending().
      Report progress and remaining work every 15 seconds. For the
      change buffer merge, the remaining work is indicated by ibuf.size.
      dc2741be
    • Marko Mäkelä's avatar
      Cleanup: Remove a useless header file · 744b33c2
      Marko Mäkelä authored
      744b33c2
    • Marko Mäkelä's avatar
      MDEV-16264 fixup: Remove unused variables · ee7fba17
      Marko Mäkelä authored
      ee7fba17
    • Marko Mäkelä's avatar
      MDEV-29978 Corruption errors upon CHECK on temporary InnoDB table · c82f3f1b
      Marko Mäkelä authored
      row_check_index(): Treat secondary indexes of temporary tables as if
      SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED
      is in effect. That is, only consider the delete-mark and nothing else.
      c82f3f1b
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-29987 Bogus errors about file size in the test mariabackup.defer_space · 704c74cd
      Thirunarayanan Balathandayuthapani authored
      - Changed the page0 perl corruption code in test case to avoid
      the bogus error in windows
      704c74cd
    • Marko Mäkelä's avatar
      MDEV-29982 Improve the InnoDB log overwrite error message · e0e096fa
      Marko Mäkelä authored
      The InnoDB write-ahead log ib_logfile0 is of fixed size,
      specified by innodb_log_file_size. If the tail of the log
      manages to overwrite the head (latest checkpoint) of the log,
      crash recovery will be broken.
      
      Let us clarify the messages about this, including adding
      a message on the completion of a log checkpoint that notes
      that the dangerous situation is over.
      
      To reproduce the dangerous scenario, we will introduce the
      debug injection label ib_log_checkpoint_avoid_hard, which will
      avoid log checkpoints even harder than the previous
      ib_log_checkpoint_avoid.
      
      log_t::overwrite_warned: The first known dangerous log sequence number.
      Set in log_close() and cleared in log_write_checkpoint_info(),
      which will output a "Crash recovery was broken" message.
      e0e096fa
    • Marko Mäkelä's avatar
      MDEV-29905 fixup: Remove some unnecessary code · 2283f82d
      Marko Mäkelä authored
      srv_shutdown(): Do not call log_free_check(), because it will now
      be repeatedly called by ibuf_merge_all(). Do not call
      srv_sync_log_buffer_in_background(), because we do not actually care
      about durability during shutdown. Log writes will already be triggered
      by buf_flush_page_cleaner() for writing back modified pages, possibly by
      log_free_check().
      
      logs_empty_and_mark_files_at_shutdown(): Clean up a condition.
      This function is the caller of srv_shutdown(), and it will ensure that
      the log and the buffer pool will be in clean state before shutdown.
      2283f82d
  8. 13 Nov, 2022 1 commit
  9. 11 Nov, 2022 2 commits
    • Alexander Barkov's avatar
      MDEV-27214 Import with disabled keys corrupts meta-data like rows, indexes, ... · 505da21e
      Alexander Barkov authored
      This bug was previously fixed in 10.6.11 by:
         MDEV-28327 InnoDB persistent statistics fail to update after bulk insert
      
      Adding MTR tests only.
      
      Also, fixing the old test for MDEV-28327 to make "mtr" reliably pass
      with/without --mysqld=--innodb-stats-persistent=0, and with different page sizes,
      as suggested by Marko.
      505da21e
    • Otto Kekäläinen's avatar
      Misc Debian/Salsa-CI fixes (#2299) · f4adf354
      Otto Kekäläinen authored
      * Deb: Handle codename 'n/a' from Debian Sid properly and autobake-deb cleanup
      
      This fixes autobake-deb.sh builds on Sid which was visible as 4 failing
      build steps on Salsa-CI.
      
      - In Sid the LSBNAME might evaluate to 'n/a', so accept it as 'Sid' to
        fix builds that failed with error:
      
          Error - unknown release codename n/a
      
      - Refactor list to have Ubuntu versions first, then Debian, and as last
        the special case of Debian Sid
      
      - Fix minor syntax issues detected by Shellcheck
      
      Also remove useless DEB_HOST_ARCH_CPU check from debian/rules:
      * It was never in effect as the 'sed' in autobake-deb.sh cleared it anyway
      * The variable name was wrong and always empty
      * If variable would have been correct, logic was still reversed
      
      - Define 3h timeout as the default 1h timeout on Gitlab.com (and others)
        is usually not enough for initial (uncached) MariaDB builds.
      
      - Replace Buster to Bookworm/Sid upgrade testing with upgrade inside Buster
        testing as direct upgrades from Stretch to Bullseye and Buster to Bookworm
        are no longer possible due to:
      
          Bug#993755: libcrypt.so.1: cannot open shared object file when
          upgrading from Stretch to Sid (https://bugs.debian.org/993755)
      
      - Stop ignoring MariaDB.org 10.6 to this version upgrade testing failures
        to reveal bug MDEV-28640. Originally this step was failing as the uring
        dependencies in upstream builders lagged behind and there was nothing
        that needed work, only time time to resolve. Now there is an actual bug
        in packaging that should be visible as a CI failure.
      
      - Stop testing for 'service mysql status' on systems that upgraded from
        MySQL 8.0 to MariaDB.org vended 10.6. Due to some unidentified debian/control
        changes in 10.6 on upstream the upgrade is no longer compatible in
        a way that would maintain the init.d script with name 'mysql'.
      
      - Fix typos where mergers had changed occurrences of 10.5 to 10.6 while
        they intentionally need to be exactly 10.5, otherwise the meaning
        changes.
      
      - Align autopkgtest code with downstream official Debian packaging one.
        This is change is safe on a stable branch because is only affects builds
        and testing, not any actual usage of MariaDB 10.6.
      
      - Standardize on using capitalized 'YES' in CMake build options
        (instead of 'yes' or mixed case)
      
      - Add some comments to better document debian/rules
      
      - Fix typo in Lintian overrides
      
      Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/mariadb-10.6/+bug/1970634
      MariaDB ticket: https://jira.mariadb.org/browse/MDEV-25633
      
      When built with LTO on Ubuntu, MariaDB does not catch an exception when
      the uring initialization fails due to a low RLIMIT_MEMLOCK value.
      
      This commit amends the commit 0609b345
      to be identical to the one done downstream in Debian:
      https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/8d20ca979cf422d3a507283b86c2547d78559179
      
      This way both the inline comments and 'git blame' for this section will
      show properly why this is needed, and the fix is one that is fully tested
      on Debian and Ubuntu.
      
      Also having this section fully identical in upstream MariaDB and downstream
      Debian will make the packaging maintenance easier as 'diff` runs on this
      file will not flag this as a difference anymore.
      
      In MDEV-28640 the init script failed to stop/start the MariaDB server
      due to missing mysqladmin on the system. This was however very hard to
      spot from the console output.
      
      Add an explicit check for the binary the script depends on, and fail
      verbosely if the dependency is missing.
      f4adf354
  10. 10 Nov, 2022 5 commits
  11. 09 Nov, 2022 3 commits