1. 26 Jul, 2014 1 commit
  2. 25 Jul, 2014 2 commits
    • Sergey Vojtovich's avatar
      MDEV-6489 - rpl.rpl_insert, rpl.rpl_insert_delayed and · 35c78a1f
      Sergey Vojtovich authored
                  main.mysqlslap fail on PPC64
      
      There seem to be a bug on Power8 which doesn't guarantee
      a signal to be delivered to waiting thread if broadcast
      is called outside of mutex.
      
      For now workaround it by calling broadcast while mutex is
      still held.
      35c78a1f
    • Jan Lindström's avatar
      Merge InnoDB fixes from 5.5 revisions 4229, 4230, 4233, 4237 and 4238 i.e. · a3acd725
      Jan Lindström authored
      4229: MDEV-5670: Assertion failure in file buf0lru.c line 2355
            Add more status information if repeatable.
      
      4230: MDEV-5673: Crash while parallel dropping multiple tables under heavy load
            Improve long semaphore wait output to include all semaphore waits
            and try to find out if there is a sequence of waiters.
      
      4233: Fix compiler errors on product build.
      
      4237: Fix too agressive long semaphore wait output and add guard against introducing
            compression failures on insert buffer.
      
      4238: Fix test failure caused by simulated compression failure on
            IBUF_DUMMY table.
      a3acd725
  3. 24 Jul, 2014 1 commit
    • Sergey Vojtovich's avatar
      MDEV-6483 - Deadlock around rw_lock_debug_mutex on PPC64 · 6192f0bf
      Sergey Vojtovich authored
      This problem affects only debug builds on PPC64.
      
      There are at least two race conditions around
      rw_lock_debug_mutex_enter and rw_lock_debug_mutex_exit:
      
      - rw_lock_debug_waiters was loaded/stored without setting
        appropriate locks/memory barriers.
      - there is a gap between calls to os_event_reset() and
        os_event_wait() and in such case we're supposed to pass
        return value of the former to the latter.
      
      Fixed by replacing self-cooked spinlocks with system mutexes.
      These days system mutexes offer much better performance. OTOH
      performance is not that critical for debug builds.
      6192f0bf
  4. 23 Jul, 2014 1 commit
    • Sergey Vojtovich's avatar
      MDEV-6473 - main.statistics fails on PPC64 · d466ed90
      Sergey Vojtovich authored
      mysql.column_stats wasn't stored/restored properly on big-endian
      with histogram_type=DOUBLE_PREC_HB.
      
      Store histogram values using int2store()/uint2korr().
      
      Note that this patch invalidates previously calculated histogram
      values on big-endian.
      d466ed90
  5. 22 Jul, 2014 7 commits
  6. 21 Jul, 2014 2 commits
  7. 18 Jul, 2014 2 commits
    • Sergey Vojtovich's avatar
      MDEV-6459 - max_relay_log_size and sql_slave_skip_counter · 54538b48
      Sergey Vojtovich authored
                  misbehave on PPC64
      
      There was a mix of ulong and uint casts/variables which caused
      incorrect value to be passed to/retrieved from max_relay_log_size
      and sql_slave_skip_counter.
      
      This mix failed to work on big-endian PPC64 where sizeof(int)= 4,
      sizeof(long)= 8. E.g. session_var(thd, uint)= 1 will in fact store
      0x100000000.
      54538b48
    • Sergey Vojtovich's avatar
      MDEV-6450 - MariaDB crash on Power8 when built with advance tool · c0ebb3f3
      Sergey Vojtovich authored
                  chain
      
      InnoDB mutex_exit() function calls __sync_test_and_set() to release
      the lock. According to manual this function is supposed to create
      "acquire" memory barrier whereas in fact we need "release" memory
      barrier at mutex_exit().
      
      The problem isn't repeatable with gcc because it creates
      "acquire-release" memory barrier for __sync_test_and_set().
      ATC creates just "acquire" barrier.
      
      Fixed by creating proper barrier at mutex_exit() by using
      __sync_lock_release() instead of __sync_test_and_set().
      c0ebb3f3
  8. 15 Jul, 2014 1 commit
  9. 11 Jul, 2014 3 commits
    • Kristian Nielsen's avatar
      MDEV-5262, MDEV-5914, MDEV-5941, MDEV-6020: Deadlocks during parallel... · 501c56ef
      Kristian Nielsen authored
      MDEV-5262, MDEV-5914, MDEV-5941, MDEV-6020: Deadlocks during parallel replication causing replication to fail.
      
      Merge the patches into MariaDB 10.0 main.
      
      With this patch, parallel replication will now automatically retry a
      transaction that fails due to deadlock or other temporary error, same as
      single-threaded replication.
      
      We catch deadlocks with InnoDB transactions due to enforced commit order. If
      T1 must commit before T2 in parallel replication and T1 ends up waiting for T2
      inside InnoDB, we kill T2 and retry it later to resolve the deadlock
      automatically.
      
      501c56ef
    • Kristian Nielsen's avatar
      Fix test failure seen in buildbot on power8. · fd0abeca
      Kristian Nielsen authored
      GTID order in @@gtid_binlog_pos depends on internal hash order,
      so requires --replace_result for stable test output.
      fd0abeca
    • Kristian Nielsen's avatar
      MDEV-5262, MDEV-5914, MDEV-5941, MDEV-6020: Deadlocks during parallel... · e81ecc9c
      Kristian Nielsen authored
      MDEV-5262, MDEV-5914, MDEV-5941, MDEV-6020: Deadlocks during parallel replication causing replication to fail.
      
      Fix a bug discovered in Buildbot valgrind. The logic in checking for slave
      init thread completion was reversed, so depending on thread scheduling server
      startup could hang.
      
      Also add another variant of SSL valgrind suppression, needed for different
      library version.
      
      e81ecc9c
  10. 10 Jul, 2014 4 commits
  11. 09 Jul, 2014 1 commit
  12. 08 Jul, 2014 3 commits
    • Kristian Nielsen's avatar
      Fix small merge errors after rebase · ba4e56d8
      Kristian Nielsen authored
      ba4e56d8
    • Kristian Nielsen's avatar
      MDEV-5262, MDEV-5914, MDEV-5941, MDEV-6020: Deadlocks during parallel... · 92577cc0
      Kristian Nielsen authored
      MDEV-5262, MDEV-5914, MDEV-5941, MDEV-6020: Deadlocks during parallel replication causing replication to fail.
      
      Fix small (but nasty) typo.
      92577cc0
    • Kristian Nielsen's avatar
      MDEV-5262, MDEV-5914, MDEV-5941, MDEV-6020: Deadlocks during parallel... · 98fc5b3a
      Kristian Nielsen authored
      MDEV-5262, MDEV-5914, MDEV-5941, MDEV-6020: Deadlocks during parallel replication causing replication to fail.
      
      After-review changes.
      
      For this patch in 10.0, we do not introduce a new public storage engine API,
      we just fix the InnoDB/XtraDB issues. In 10.1, we will make a better public
      API that can be used for all storage engines (MDEV-6429).
      
      Eliminate the background thread that did deadlock kills asynchroneously.
      Instead, we ensure that the InnoDB/XtraDB code can handle doing the kill from
      inside the deadlock detection code (when thd_report_wait_for() needs to kill a
      later thread to resolve a deadlock).
      
      (We preserve the part of the original patch that introduces dedicated mutex
      and condition for the slave init thread, to remove the abuse of
      LOCK_thread_count for start/stop synchronisation of the slave init thread).
      
      98fc5b3a
  13. 04 Jul, 2014 1 commit
  14. 25 Jun, 2014 1 commit
    • Kristian Nielsen's avatar
      MDEV-4937: sql_slave_skip_counter does not work with GTID · 9150a0c7
      Kristian Nielsen authored
      The sql_slave_skip_counter is important to be able to recover replication from
      certain errors. Often, an appropriate solution is to set
      sql_slave_skip_counter to skip over a problem event. But setting
      sql_slave_skip_counter produced an error in GTID mode, with a suggestion to
      instead set @@gtid_slave_pos to point past the problem event. This however is
      not always possible; for example, in case of an INCIDENT event, that event
      does not have any GTID to assign to @@gtid_slave_pos.
      
      With this patch, sql_slave_skip_counter now works in GTID mode the same was as
      in non-GTID mode. When set, that many initial events are skipped when the SQL
      thread starts, plus as many extra events are needed to completely skip any
      partially skipped event group. The GTID position is updated to point past the
      skipped event(s).
      9150a0c7
  15. 09 Jul, 2014 4 commits
  16. 08 Jul, 2014 6 commits