- 06 Feb, 2018 3 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
in gcc `-Wno-unsupported-something` will not be an error or even a warning, so cmake will think the flag is supported. But if there's any other warning during compilation, for any reason, unknown option will be a warning too. Or an error when -Werror, even if that "other warning" would not be an error on itself. So we need to detect whether `-Wno-unsupported-something` is *really* supported. Luckily, `-Wunsupported-something` will always fail with an error. So, whenever there's a need to detect if -Wno-something is supported, test -Wsomething instead.
-
Sergei Golubchik authored
-
- 05 Feb, 2018 4 commits
-
-
Jan Lindström authored
Problem was that wrong error message was returned when insert returned FK-error and there was no duplicate key to process. row_ins If error from insert was DB_NO_REFERENCED_ROW and there was no duplicate key we should ignore ON DUPLICATE KEY UPDATE and return original error message.
-
Sergei Golubchik authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Suppress some messages that are emitted rarely (when the FIL_PAGE_FILE_FLUSH_LSN of the first page of ibdata1 does not match the latest redo log checkpoint).
-
- 04 Feb, 2018 1 commit
-
-
Elena Stepanova authored
-
- 03 Feb, 2018 5 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Previously, the function could theoretically return an uninitialized value if the system tablespace contained no data files. It should be impossible for InnoDB to start up in such scenario.
-
Marko Mäkelä authored
xtrabackup_init_temp_log(): Remove a redundant variable and limit scope.
-
Marko Mäkelä authored
-
Sergei Golubchik authored
-
- 02 Feb, 2018 14 commits
-
-
Marko Mäkelä authored
Two follow-up tasks were filed for MySQL 5.7.21 changes that were not applied here: MDEV-15179 performance_schema.file_instances does not reflect RENAME TABLE MDEV-14222 Unnecessary 'cascade' memory allocation for every updated row when there is no FOREIGN KEY
-
Marko Mäkelä authored
The merge omitted some InnoDB and XtraDB conflict resolutions, most notably, failing to merge the fix of MDEV-12173. ibuf_merge_or_delete_for_page(), lock_rec_block_validate(): Invoke fil_space_acquire_silent() instead of fil_space_acquire(). This fixes MDEV-12173. wsrep_debug, wsrep_trx_is_aborting(): Removed unused declarations. _fil_io(): Remove. Instead, declare default parameters for the XtraDB fil_io(). buf_read_page_low(): Declare default parameters, and clean up some callers. os_aio(): Correct the macro that is defined when !UNIV_PFS_IO.
-
Vicențiu Ciorbaru authored
-
Oleksandr Byelkin authored
-
Marko Mäkelä authored
row_rename_partitions_for_mysql(): Remove. This should only be relevant in an upgrade into MySQL 5.7, which has InnoDB native partitioning.
-
Marko Mäkelä authored
Remove a test that does not apply to MariaDB In MariaDB, there are no high-priority transactions (no tx_priority). This should also mean that all references to TRX_STATE_FORCED_ROLLBACK are dead code.
-
Jimmy Yang authored
Reviewed-by: Sunny Bains <sunny.bains@oracle.com>
-
Marko Mäkelä authored
Bug#23590280 NO WARNING WHEN REDUCING INNODB_BUFFER_POOL_SIZE INSIZE (sic) THE FIRST CHUNK innodb_buffer_pool_size_validate(): Issue a warning if the requested innodb_buffer_pool_size is less than innodb_buffer_pool_chunk_size, because we cannot shrink individual chunks.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Import and adjust the innodb.innodb_buffer_pool_resize tests, except innodb.innodb_buffer_pool_resize_debug, which would time out. buf_pool_clear_hash_index(): Adjust assertions.
-
Sergei Golubchik authored
* use a longer timeout, 10ms is not always enough * stop waiting as long as the data is read, do not unconditionally wait for timeout every time
-
Sergei Golubchik authored
mysqltest cannot free all memory on exit by design, so there's no need to check. mysql frees memory in mysql_end(), so enable memory-leak-on-exit check only after it was initialized enough to use mysql_end() - early exits use my_end().
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 01 Feb, 2018 13 commits
-
-
Monty authored
If binary logging is not enabled thd->user_var_events_alloc would never be initialized.
-
Marko Mäkelä authored
The algorithm change is based on a MySQL 8.0 fix for BUG #26818787: ASSERTION: DATA0DATA.IC:430:TUPLE by Krzysztof Kapuścik https://github.com/mysql/mysql-server/commit/ee606e62bbddd7ac3579b4a20ef8684fa7cd83fe If a record had been inserted in place of a delete-marked purgeable record by modifying that record, and purge was accessing that record before the off-page columns were written, row_build_index_entry() would have returned NULL, causing a crash. row_vers_non_virtual_fields_equal(): Check whether all non-virtual fields of an index are equal. Replaces row_vers_non_vc_match(). A more complex version of this function was called row_vers_non_vc_index_entry_match() in the MySQL 8.0 fix. row_vers_impl_x_locked_low(): This change is not directly related to the reported problem, but apparently to the removal of the function row_vers_non_vc_match(). This function checks if a secondary index record was modified by a transaction that has not been committed yet. For comparing the non-virtual columns, construct a secondary index tuple from the table row. row_vers_vc_matches_cluster(): Replace row_vers_non_vc_match() with code that is equivalent to the row_vers_non_vc_index_entry_match() in the MySQL 8.0 fix. Also, deduplicate some code by using goto.
-
Marko Mäkelä authored
The comment that I made in commit 06299ddd is inaccurate. Replace the comment, and make the assertion debug-only, because I cannot remember any reports of it ever failing in these 10 years.
-
Marko Mäkelä authored
If crypt_block != NULL the entire object crypt_pfx should be guaranteed to be initialized, including m_size, which will have been initialized either in allocate_large(), either directly or via allocate_trace().
-
Marko Mäkelä authored
Do not call mtr_t::start() with trx_t*.
-
Oleksandr Byelkin authored
Do not unwrap view references to keep table info. (Row-IN subselect does not unwrap items so it does not need fix)
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-
Jan Lindström authored
Conflicts: storage/innobase/lock/lock0lock.cc storage/xtradb/lock/lock0lock.cc storage/xtradb/lock/lock0wait.cc support-files/mysql.server.sh
-
Jan Lindström authored
Test seems to pass fine.
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-