An error occurred fetching the project authors.
  1. 22 Aug, 2006 1 commit
    • unknown's avatar
      BUG#21051: RESET QUERY CACHE very slow when query_cache_type=0 · 877477f1
      unknown authored
      There were two problems: RESET QUERY CACHE took a long time to complete
      and other threads were blocked during this time.
      
      The patch does three things:
        1 fixes a bug with improper use of test-lock-test_again technique.
            AKA Double-Checked Locking is applicable here only in few places.
        2 Somewhat improves performance of RESET QUERY CACHE.
            Do my_hash_reset() instead of deleting elements one by one.  Note
            however that the slowdown also happens when inserting into sorted
            list of free blocks, should be rewritten using balanced tree.
        3 Makes RESET QUERY CACHE non-blocking.
            The patch adjusts the locking protocol of the query cache in the
            following way: it introduces a flag flush_in_progress, which is
            set when Query_cache::flush_cache() is in progress.  This call
            sets the flag on enter, and then releases the lock.  Every other
            call is able to acquire the lock, but does nothing if
            flush_in_progress is set (as if the query cache is disabled).
            The only exception is the concurrent calls to
            Query_cache::flush_cache(), that are blocked until the flush is
            over.  When leaving Query_cache::flush_cache(), the lock is
            acquired and the flag is reset, and one thread waiting on
            Query_cache::flush_cache() (if any) is notified that it may
            proceed.
      
      
      include/mysql_com.h:
        Add comment for NET::query_cache_query.
      sql/net_serv.cc:
        Use query_cache_init_query() for initialization of
        NET::query_cache_query if query cache is used.
        Do not access net->query_cache_query without a lock.
      sql/sql_cache.cc:
        Fix bug with accessing query_cache_size, Query_cache_query::wri and
        thd->net.query_cache_query before acquiring the lock---leave
        double-check locking only in safe places.
        Wherever we check that cache is usable (query_cache_size > 0) we now
        also check that flush_in_progress is false, i.e. we are not in the
        middle of cache flush.
        Add Query_cache::not_in_flush_or_wait() method and use it in
        Query_cache::flush_cache(), so that threads doing cache flush will
        wait it to finish, while other threads will bypass the cache as if
        it is disabled.
        Extract Query_cache::free_query_internal() from Query_cache::free_query(),
        which does not removes elements from the hash, and use it together with
        my_hash_reset() in Query_cache::flush_cache().
      sql/sql_cache.h:
        Add declarations for new members and methods.
        Make is_cacheable() a static method.
        Add query_cache_init_query() function.
      sql/sql_class.cc:
        Use query_cache_init_query() for initialization of
        NET::query_cache_query.
      877477f1
  2. 14 Aug, 2006 1 commit
    • unknown's avatar
      BUG#9678: Client library hangs after network communication failure · 32741794
      unknown authored
      Socket timeouts in client library were used only on Windows.
      
      The solution is to use socket timeouts in client library on all
      systems were they are supported.
      
      No test case is provided because it is impossible to simulate network
      failure in current test suit.
      
      
      sql/net_serv.cc:
        Retry indefinitely only if got EINTR.
      vio/viosocket.c:
        Set socket timeouts on POSIX systems as well as on Windows.
      32741794
  3. 16 Jun, 2006 1 commit
    • unknown's avatar
      configure.in, net_serv.cc, compile-netware-END: · 91fb8310
      unknown authored
        Changes for Netware
      
      
      sql/net_serv.cc:
        Netware needs <sys/select.h>
      configure.in:
        Call of "comp_err" has moved, changed code for Netware that
        edits make files to reflect this
      netware/BUILD/compile-netware-END:
        After correcting "configure.in" to edit make files correctly,
        removed obsolete "sed" of "extra/Makefile.am" for Netware
      91fb8310
  4. 24 May, 2006 1 commit
    • unknown's avatar
      some small fixups · c38308de
      unknown authored
      include/config-win.h:
        force time_t to be 32 bit on Visual C++ 2005 or later
      sql/net_serv.cc:
        include winsock after my_global so the time_t #define can take effect
      storage/csv/ha_tina.cc:
        fix the csv engine so that it supports DOS, Unix, and Mac line endings
      c38308de
  5. 16 May, 2006 1 commit
    • unknown's avatar
      mysql.spec.sh: · 61bd3fa0
      unknown authored
        Removed Berkeley DB
      configure.in:
        Adjusted Netware support
      basic.t.c:
        Change for Netware
      Makefile.am:
        Use thread safe libmysqlclient_r if it was built
      valgrind.supp:
        Hide report about strlen/_dl_init_paths
      ha_tina.cc:
        Temporarely disable CSV engine on Netware,
        as the engine depends on mmap()
      net_serv.cc:
        Include <sys/select.h> for Netware
      
      
      sql/net_serv.cc:
        Include <sys/select.h> for Netware
      storage/csv/ha_tina.cc:
        Temporarely disable CSV engine on Netware,
        as the engine depends on mmap()
      mysql-test/valgrind.supp:
        Hide report about strlen/_dl_init_paths
      tests/Makefile.am:
        Use thread safe libmysqlclient_r if it was built
      unittest/mytap/t/basic.t.c:
        Change for Netware
      configure.in:
        Adjusted Netware support
      support-files/mysql.spec.sh:
        Removed Berkeley DB
      61bd3fa0
  6. 16 Apr, 2006 1 commit
    • unknown's avatar
      Final patch to remove the last of the OS2 support. · cc62983c
      unknown authored
      client/client_priv.h:
        OS2 removal
      client/mysql.cc:
        OS2 removal
      dbug/dbug.c:
        OS2 removal
      include/m_string.h:
        OS2 removal
      include/my_global.h:
        Cleanup for have_mit
      libmysql/dll.c:
        OS2 removal
      libmysql/get_password.c:
        OS2 removal
      libmysql/libmysql.c:
        OS2 removal
      libmysql/manager.c:
        OS2 removal
      sql-common/client.c:
        OS2 removal
      sql/event_executor.cc:
        OS2 removal
      sql/hostname.cc:
        OS2 removal
      sql/log.cc:
        OS2 removal
      sql/log_event.h:
        OS2 removal
      sql/my_lock.c:
        OS2 removal
      sql/mysql_priv.h:
        OS2 removal
      sql/mysqld.cc:
        OS2 removal
      sql/net_serv.cc:
        OS2 removal
      sql/repl_failsafe.cc:
        OS2 removal
      sql/slave.cc:
        OS2 removal
      sql/sql_base.cc:
        OS2 removal
      sql/sql_insert.cc:
        OS2 removal
      sql/sql_load.cc:
        OS2 removal
      sql/sql_parse.cc:
        OS2 removal
      sql/sql_table.cc:
        OS2 removal
      storage/myisam/myisamchk.c:
        OS2 removal
      storage/ndb/src/mgmclient/main.cpp:
        OS2 removal
      storage/ndb/src/mgmsrv/main.cpp:
        OS2 removal
      vio/vio.c:
        OS2 removal
      vio/viosocket.c:
        OS2 removal
      vio/viossl.c:
        OS2 removal
      cc62983c
  7. 02 Mar, 2006 1 commit
  8. 01 Mar, 2006 1 commit
    • unknown's avatar
      Bug#2845 client fails to reconnect if using TCP/IP · 69012c75
      unknown authored
       - Change to use non blocking read to empty channel in case of too large sd number
       - Don't check for too large socket number on Windows.
      
      
      sql/net_serv.cc:
        Windows does not need protection from sd >= FD_SETSIZE, it uses an array to store the sd's it should read from.
        Change the handler for when "net_data_is_ready" returns -1 to perform nonblocking read to empty the net.
        Only include that handler if HAVE_POLL is not defined  and not windows
      69012c75
  9. 27 Feb, 2006 1 commit
    • unknown's avatar
      BUG#2845 client fails to reconnect if using TCP/IP · f56e8734
      unknown authored
       - Use 'poll' if available
       - Check that sd <= FD_SETSIZE if using 'select'
       - Handle case when 'net_data_is_ready' returns -1, ie. sd > FD_SETSIZE and 'select' is used 
      
      
      sql/net_serv.cc:
        Use 'poll' in favor of 'select' if avaliable
        This is to avoid the limitation with 'select' only being able to handle fd's with numbers <= 1024 as default.
        If 'poll' is not available use 'select' but check that we are not having a number higher than FD_SETSIZE
        Handle the case when 'net_data_is_ready' can't check if there is data to read, since the sd number is too high
      f56e8734
  10. 16 Feb, 2006 1 commit
    • unknown's avatar
      Bug#2845 client fails to reconnect if using TCP/IP · d430e247
      unknown authored
      - Detect that connection to server has been broken in "net_clear". Since 
        net_clear is always called before we send command to server, we can be sure
        that server has not received the command.
      
      
      mysql-test/r/wait_timeout.result:
        Update test result
      mysql-test/t/wait_timeout-master.opt:
        Decrease wait_timeout value to avoid unneccessary sleeps
      mysql-test/t/wait_timeout.test:
        Test that same error message is returned when disconnected regardless of connection is socket or TCP
        Decrease sleep times
      sql/net_serv.cc:
        Make "net_clear" detect if connection with server has been broken by 
        performing a select. If the select returns that there are data to read but
        no data can be read, that means the connection is broken. Signal disconnected
        to "write" functions by setting error to 2.
      d430e247
  11. 30 Aug, 2005 1 commit
    • unknown's avatar
      Fixes bug #5588. vio_was_interrupted() function was added to detect · a8a5e98e
      unknown authored
      read timeout properly on win32.
      
      
      include/my_global.h:
        Added win32 specific socket timeout error code.
      include/violite.h:
        Added vio_was_interrupted function that returns true if operation was
        not completed due to timeout.
      sql/mini_client.cc:
        added a check that replication read was not completed due to timeout.
      sql/net_serv.cc:
        net->last_errno should be equal to ER_NET_READ_INTERRUPTED in case if read
        operation was not completed due to timeout.
      vio/vio.c:
        added initialization code for vio_was_interrupted() function.
      vio/viosocket.c:
        Added vio_was_interrupted function that returns true if operation was
        not completed due to timeout.
      a8a5e98e
  12. 12 Jul, 2005 1 commit
    • unknown's avatar
      Fixed some vio code that was using ___WIN__ instead of __WIN__ · 73fd169d
      unknown authored
      include/my_global.h:
        set SOCKET_EWOULDBLOCK to the proper windows def WSAEWOULDBLOCK
      sql/net_serv.cc:
        fixed typo with using 3 leading underscores instead of 2
      vio/vio.c:
        fixed typo with using 3 leading underscores instead of 2
      vio/viosocket.c:
        fixed typo with using 3 leading underscores instead of 2
      73fd169d
  13. 05 May, 2005 1 commit
    • unknown's avatar
      Bug #9721 net_write_timeout not used on Windows · af5596b3
      unknown authored
      Added an extra parameter to all calls to timeout().  
      1 means we want to set the write timeout
      0 means we wnat to set the read timeout
      
      viossl.c:
        Add which parameter to ssl timeout routine
      vio_priv.h:
        Added which parameter to vio_ignore_timeout and vio_ssl_timeout
      violite.h:
        Add which parameter to vio_timeout sigs
      net_serv.cc:
        Use proper which code in call to vio_timeout to set the proper timeout
      viosocket.c:
        Set the appropriate timeout in vio_timeout
      
      
      vio/viosocket.c:
        Set the appropriate timeout in vio_timeout
      sql/net_serv.cc:
        Use proper which code in call to vio_timeout to set the proper timeout
      include/violite.h:
        Add which parameter to vio_timeout sigs
      vio/vio_priv.h:
        Added which parameter to vio_ignore_timeout and vio_ssl_timeout
      vio/viossl.c:
        Add which parameter to ssl timeout routine
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      af5596b3
  14. 07 Mar, 2005 1 commit
  15. 04 Mar, 2005 1 commit
  16. 20 Jan, 2005 1 commit
    • unknown's avatar
      Fixed problem of sending ERROR to client after OK or EOF (BUG#6804) · 7a528488
      unknown authored
      include/mysql_com.h:
        Flag which prevent sending error after EOF or OK sent
      mysql-test/r/kill.result:
        test of blocking of sending ERROR after OK or EOF
      mysql-test/t/kill.test:
        test of blocking of sending ERROR after OK or EOF
      sql/item_func.cc:
        typo fixed
      sql/net_serv.cc:
        initialization of flag
      sql/protocol.cc:
        check and set of flag no_send_error
      sql/sql_parse.cc:
        droping flag no_send_error before new command/query execution
      7a528488
  17. 11 Jan, 2005 1 commit
  18. 10 Jan, 2005 1 commit
  19. 06 Dec, 2004 1 commit
    • unknown's avatar
      A fix (bug #5823: mysql_install_db fails due to incorrect max_allowed_packet). · 1f1257bd
      unknown authored
      scripts/fill_help_tables.sh:
        percent_xxx variables added to avoid /0 error.
      scripts/mysql_install_db.sh:
        A fix (bug #5823: mysql_install_db fails due to incorrect max_allowed_packet).          
        --net_buffer_length=16K added.
      sql/net_serv.cc:
        Typo fixed.
      sql/sql_parse.cc:
        A fix (bug #5823: mysql_install_db fails due to incorrect max_allowed_packet).
        Auto extend net buffer in bootstrap mode.
      1f1257bd
  20. 12 Nov, 2004 1 commit
    • unknown's avatar
      Various build fixes. · eed282d6
      unknown authored
      sql/mysql_priv.h:
        Fix build problems (causing link errors with the Sun compiler).
      sql/net_serv.cc:
        Corrected macro definition.
      sql/sql_base.cc:
        Fixed build problems (for broken HP compiler).
      sql/sql_show.cc:
        64-bit build fix.
      eed282d6
  21. 05 Nov, 2004 1 commit
    • unknown's avatar
      fix for the IM linking problem · 4f32ec18
      unknown authored
      BitKeeper/etc/ignore:
        Added mysql-5.0.2-alpha.tar.gz server-tools/instance-manager/client.c server-tools/instance-manager/client_settings.h server-tools/instance-manager/errmsg.c to the ignore list
      server-tools/instance-manager/instance_map.cc:
        Comment updated
      server-tools/instance-manager/priv.cc:
        added variables needed by net_serv.cc
      server-tools/instance-manager/priv.h:
        declared variables needed by net_serv.cc
      sql/net_serv.cc:
        added some IM-specific defines
      4f32ec18
  22. 02 Nov, 2004 1 commit
    • unknown's avatar
      Remove usage of !$ from mysql-tests · 505caa28
      unknown authored
      Added protocol::flush() for easier embedded-server code
      Increase block allocation variables a bit as they where a bit too small for MySQL 4.1
      Added option --silent to client_test
      
      
      client/mysqltest.c:
        Removed compiler warning
        Fixed identation & comments from earlier push
        Renamed variable 'disable_abort_on_error' to 'abort_on_error'
        Ensure that '$mysql_errno' also with --ps-protocol
      include/mysql_com.h:
        Removed special handling of net_flush for embedded server
      mysql-test/r/mysqltest.result:
        Remove usage of !$ in tests
      mysql-test/t/client_test.test:
        Use --silent
      mysql-test/t/comments.test:
        Remove usage of !$ in tests
      mysql-test/t/join_outer.test:
        Remove usage of !$ in tests
      mysql-test/t/key.test:
        Remove usage of !$ in tests
      mysql-test/t/mysqltest.test:
        Remove usage of !$ in tests
      mysql-test/t/show_check.test:
        Remove usage of !$ in tests
      mysql-test/t/temp_table.test:
        Remove usage of !$ in tests
      mysql-test/t/type_ranges.test:
        Remove usage of !$ in tests
      sql/mysqld.cc:
        Increase block allocation variables a bit as they where a bit too small for MySQL 4.1
      sql/net_serv.cc:
        Remove special usage of net_flush in embedded server
      sql/protocol.cc:
        Added protocol::flush() for easier embedded-server code
      sql/protocol.h:
        Added protocol::flush() for easier embedded-server code
      sql/sql_prepare.cc:
        Added protocol::flush() for easier embedded-server code
        Remove one extra flush() for prepared statements
      sql/sql_show.cc:
        Added protocol::flush() for easier embedded-server code
      tests/client_test.c:
        Added option --silent
      505caa28
  23. 23 Oct, 2004 1 commit
    • unknown's avatar
      Intermediate commit - just to make new files visible to bk in the new · a5435ea7
      unknown authored
      tree
      
      
      server-tools/instance-manager/Makefile.am:
        Fixed IM linking to avoid using both mysys and libmysql as the define the
        same symbols and therefore conflict
      server-tools/instance-manager/listener.cc:
        Added ability to listen network ports
      server-tools/instance-manager/listener.h:
        Various additions to the Listener_thread_args
      server-tools/instance-manager/log.cc:
        merge
      server-tools/instance-manager/log.h:
        merge
      server-tools/instance-manager/manager.cc:
        Fixes and additions to enable guardian functionality
      server-tools/instance-manager/manager.h:
        Changed manager() signature
      server-tools/instance-manager/mysqlmanager.cc:
        Various fixes
      server-tools/instance-manager/options.cc:
        Added handling of default values for new options in the Options struct. (such
        as default_user, default_password, monitoring_interval e.t.c)
      server-tools/instance-manager/options.h:
        Added new options to the Options struct
      sql/net_serv.cc:
        Added MYSQL_INSTANCE_MANAGER defines to enable alarm handling in the IM
      server-tools/instance-manager/buffer.cc:
        Simple implementation of variable-length buffer
      server-tools/instance-manager/command.cc:
        Abstract command. All commands are derived from Command class
      server-tools/instance-manager/commands.h:
        Interfaces for all commands we have
      server-tools/instance-manager/factory.cc:
        Commands factory. This class hides command instantiation. The idea is to
        handle various protocols this way. (different commands for different
        protocols
      server-tools/instance-manager/guardian.cc:
        Guardian thread implementation (monitor and restart instances in case of a
        failure
      server-tools/instance-manager/guardian.h:
        Guardian_thread and Guardian_thread_args class interface. The
        Guardian_thread is responsible for monitoring and restarting instances
      server-tools/instance-manager/instance.cc:
        Instance class contains methods and data to manage a single instance
      server-tools/instance-manager/instance.h:
        This file contains class an instance class interface. The class is
        responsible for starting/stopping an instance
      server-tools/instance-manager/instance_map.cc:
        The instance repository. This class is also responsible for initialization
        of Instance class objects.
      server-tools/instance-manager/instance_options.cc:
        The Instance_options class contains all methods to get and  handle options
        of an instance
      server-tools/instance-manager/mysql_connection.cc:
        The class responsible for handling MySQL client/server protocol connections
      server-tools/instance-manager/mysql_manager_error.h:
        The list of Instance Manger-specific errors
      server-tools/instance-manager/parse.cc:
        Simple query parser
      server-tools/instance-manager/parse.h:
        Parser interface
      server-tools/instance-manager/protocol.cc:
        Here implemented functions used to handle mysql client/server protocol
      server-tools/instance-manager/protocol.h:
        Interface for MySQL client/server protocol
      server-tools/instance-manager/thread_registry.cc:
        Thread registry stores information about every thread. It's main function is
        to provide graceful shutdown for all threads.
      server-tools/instance-manager/user_map.h:
        User map contains hash with user names and passwords
      a5435ea7
  24. 13 Sep, 2004 1 commit
  25. 08 Sep, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#5194 "Bulk Insert Failures with Prepared · d7a23067
      unknown authored
      Statements": 
      - fix a couple of net->buff overruns in libmysql,
      - check in the server that statement parameter count is less than
        65535 (maximum value supported by prepared statements protocol).
       
      
      
      libmysql/libmysql.c:
        Bug#5194 "Bulk Insert Failures with Prepared Statements":
        - clean up my_realloc_str()
        - ensure that net buffer has space when storing null bits and
          parameter typecodes.
      sql/net_serv.cc:
        - set net->last_errno if packet is too big, even on client
          (Why was it ifdefed before?)
      sql/sql_prepare.cc:
        Bug#5194 "Bulk Insert Failures with Prepared Statements":
        - if placeholder count is bigger than 65535, give error.
          We have only 2 bytes reserved for transferring placeholder count
          in 4.1 protocol.
        - can't add a proper error code and message in 4.1 because of
          possible merge difficulties."
      tests/client_test.c:
        A test case for Bug#5194 "Bulk Insert Failures with Prepared 
        Statements".
      d7a23067
  26. 21 Jun, 2004 1 commit
    • unknown's avatar
      After merge fixes · b5dfd056
      unknown authored
      Return NULL if a time argument is given to date_add(). (Warning will be shown after Dimitri's timezone patch is pushed)
      
      
      client/mysqltest.c:
        Added MAX_VAR_NAME which was lost in merge
        Added more debugging
        Fixed bug in 'eval'
      innobase/data/data0type.c:
        After merge fix
      innobase/fil/fil0fil.c:
        After merge fix
      innobase/log/log0recv.c:
        After merge fix
      myisam/mi_unique.c:
        Better checksum handling
      mysql-test/r/func_time.result:
        Return NULL if a time argument is given to date_add()
      mysql-test/r/rpl_free_items.result:
        After merge fix
      mysql-test/r/rpl_get_lock.result:
        Test was depending on when server was restarted.
      mysql-test/r/type_date.result:
        After merge fix
      mysql-test/r/type_decimal.result:
        After merge fix
      mysql-test/t/func_time.test:
        Removed comment that is not needed anymore
        (After Dimitri's timezone patch is pushed, we should get a warning for the date_add(time...) entry)
      mysql-test/t/rpl_get_lock.test:
        Test was depending on when server was restarted.
      mysql-test/t/type_date.test:
        Addded missing explanation for bug
      netware/mysqld_safe.c:
        Removed end \r
        Run program through indent-ex to get MySQL indentation
      sql-common/client.c:
        After merge fix
      sql/field.cc:
        Fixed that get_date(time) gives a warning
      sql/field.h:
        After merge fix
      sql/net_serv.cc:
        More debugging (if DEBUG_DATA_PACKETS is set)
      sql/sql_class.cc:
        Removed compiler warning
      sql/table.cc:
        Better comment
      b5dfd056
  27. 21 Feb, 2004 1 commit
  28. 18 Dec, 2003 1 commit
    • unknown's avatar
      Fix for #2126 (mysql_server_init call shouldn't be needed) · 886307f2
      unknown authored
      now mysql_server_init is called from mysql_init with fake parameters
      mysql_once_init code included to mysql_server_init.
      embedded-specific initialization is in init_embedded_server function
      
      
      include/errmsg.h:
        this error won't happen
      include/mysql.h:
        declarations removed
      libmysql/client_settings.h:
        declaration of init_embedded_server/end_embedded_server added
      libmysql/errmsg.c:
        this error won't happen
      libmysql/libmysql.c:
        mysql_once_init -> mysql_server_init transformations
      libmysqld/embedded_priv.h:
        declaration deleted
      libmysqld/lib_sql.cc:
        mysql_server_init -> init_embedded_server
        mysql_server_end  -> end_embedded_server
      libmysqld/libmysqld.c:
        check for server_inited not needed now
      sql-common/client.c:
        mysql_server_init now called from mysql_init
      sql/client_settings.h:
        fake mysql_server_init for server code
      sql/net_serv.cc:
        we need MYSQL_CLIENT defined in embedded server
      sql/sql_client.cc:
        not needed now
      886307f2
  29. 27 Nov, 2003 1 commit
    • unknown's avatar
      Fixed BUG#1965: Opening a cursor hangs client when malformed select fails · 919b5ba6
      unknown authored
        and BUG#1966: "select 1 into a" on top-level hangs client
      
      
      include/mysql_com.h:
        Added no_send_eof flag to NET for SP cursors (the simple read-only version).
      mysql-test/r/sp-error.result:
        Added tests for BUG#1965 and BUG#1966.
      mysql-test/t/sp-error.test:
        Added tests for BUG#1965 and BUG#1966.
      sql/net_serv.cc:
        Added no_send_eof flag to NET for SP cursors (the simple read-only version).
      sql/protocol.cc:
        Added no_send_eof flag to NET for SP cursors (the simple read-only version).
      sql/sp_rcontext.cc:
        Use net->no_send_eof flag to prevent eofs during cursor open (instead of
        the dirty vio=0 which didn't work).
      sql/sp_rcontext.h:
        Use net->no_send_eof flag to prevent eofs during cursor open (instead of
        the dirty vio=0 which didn't work).
      sql/sql_yacc.yy:
        Give error message if doing SELECT ... INTO localvar even if it's outside an SP.
      919b5ba6
  30. 24 Sep, 2003 1 commit
    • unknown's avatar
      - Code cleanup: replaced C++-style comments with the proper syntax for · 07001f78
      unknown authored
         .c files (the IBM Visual Age C compiler aborts with a syntax error
         on these)
      
      
      libmysql/dll.c:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      libmysql/libmysql.c:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      mysys/my_getopt.c:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      sql/net_serv.cc:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      strings/ctype-bin.c:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      tests/client_test.c:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      07001f78
  31. 13 Sep, 2003 1 commit
    • unknown's avatar
      Remove 'extern' references from .cc files · c4079104
      unknown authored
      mysys/checksum.c:
        Cleanup
      mysys/my_static.h:
        Remove not used include file
      sql/item_strfunc.cc:
        Remove 'extern' references
      sql/lock.cc:
        Remove 'extern' references
      sql/log.cc:
        Remove 'extern' references
      sql/mysql_priv.h:
        Add 'extern' references
      sql/net_serv.cc:
        Added comment
      sql/repl_failsafe.cc:
        Remove 'extern' references
      sql/set_var.cc:
        Remove 'extern' references
      sql/sql_derived.cc:
        Remove 'extern' references
      sql/sql_insert.cc:
        Remove 'extern' references
      sql/sql_parse.cc:
        Remove 'extern' references
      sql/sql_prepare.cc:
        Remove 'extern' references
      sql/sql_repl.cc:
        Remove 'extern' references
      sql/sql_string.cc:
        Added comment
      sql/sql_table.cc:
        Remove 'extern' references
      sql/sql_test.cc:
        Remove 'extern' references
      sql/sql_yacc.yy:
        Remove 'extern' references
      sql/table.cc:
        Remove 'extern' references
      c4079104
  32. 26 Aug, 2003 1 commit
    • unknown's avatar
      vio ssl structure renames (to get rid of ending _) · 59806e10
      unknown authored
      Added TCP/IP read/write timeout for windows
      Check on windows if second server is started with same TCP/IP port
      
      
      BitKeeper/deleted/.del-have_openssl_2.inc~8c9f1a45676b698f:
        Delete: mysql-test/include/have_openssl_2.inc
      BitKeeper/deleted/.del-have_openssl_2.require~53bbdfc136fb514:
        Delete: mysql-test/r/have_openssl_2.require
      BitKeeper/deleted/.del-openssl_2.test~f2dfa927f19d14f8:
        Delete: mysql-test/t/openssl_2.test
      BitKeeper/etc/ignore:
        added libmysql/vio_priv.h libmysql_r/vio_priv.h
      client/mysql.cc:
        vio ssl structure renames
      include/violite.h:
        Cleanup violite.h interface (move things to vio_priv.h)
      libmysql/Makefile.am:
        Use vio_priv.h
      libmysql/Makefile.shared:
        Use vio_priv.h
      libmysqld/lib_vio.c:
        Added timeout for windows
      mysys/my_getopt.c:
        Indentaion cleanup
      sql/item_cmpfunc.cc:
        Remove compiler warnings
      sql/item_func.cc:
        Remove compiler warnings
      sql/mini_client.cc:
        vio ssl structure renames
      sql/mysqld.cc:
        Check on windows if second server is started with same TCP/IP port
      sql/net_serv.cc:
        Add read/write timeouts for windows
      sql/sql_acl.cc:
        vio ssl structure renames
      sql/sql_show.cc:
        vio ssl structure renames
      vio/vio.c:
        Added timeouts for windows
      vio/viosocket.c:
        Added timeouts for windows
      vio/viossl.c:
        Added timeouts for windows
        Cleaned up structure element names
      vio/viosslfactories.c:
        Added timeouts for windows
        Cleaned up structure element names
      59806e10
  33. 20 Aug, 2003 1 commit
    • unknown's avatar
      Fixed some varnings from valgrind · de5d47c3
      unknown authored
      Set min value of max_allowed_packet to 1024
      Fixed problem with UNION's without braces and SQL_CALC_FOUND_ROWS, LIMIT #,#
      and ORDER BY...LIMIT
      
      
      include/m_string.h:
        Added memcpy_overlap() to avoid warnings when using valgrind on memcpy(A,A,...)
      myisam/mi_create.c:
        Fixed comment
      myisam/mi_search.c:
        Fix warning from valgrind
      myisam/mi_write.c:
        Indentation fix
      mysql-test/mysql-test-run.sh:
        Add options handled by general skip- option
      mysql-test/r/packet.result:
        Update results after change to mysqld (min max_allowed_packet length is now 1024)
      mysql-test/r/union.result:
        Added testing of UNION with SQL_CALC_FOUND_ROWS
      mysql-test/t/packet.test:
        Update results after change to mysqld (min max_allowed_packet length is now 1024)
      mysql-test/t/union.test:
        Added testing of UNION with SQL_CALC_FOUND_ROWS
      sql/field.cc:
        Fix to remove waarning from valgrind
      sql/ha_innodb.cc:
        Remove wrong include file
      sql/item_cmpfunc.cc:
        Safety fix to handle EOM conditions in IN
      sql/item_sum.cc:
        Fixed prototype for update_field() (argument was alwys 0)
      sql/item_sum.h:
        Fixed prototype for update_field() (argument was alwys 0)
      sql/item_uniq.h:
        Fixed prototype for update_field() (argument was alwys 0)
      sql/log.cc:
        Indentation fix
      sql/mysqld.cc:
        Set min value of max_allowed_packet to 1024 (to avoid it getting set to 0)
      sql/net_serv.cc:
        Indentation changes + trivial optimization
      sql/sql_select.cc:
        Fixed prototype for update_field() (argument was alwys 0)
      sql/sql_union.cc:
        Fixed problem with UNION's without braces and
        - SQL_CALC_FOUND_ROWS
        - LIMIT #,#
        - ORDER BY ... LIMIT
      de5d47c3
  34. 09 Jul, 2003 1 commit
  35. 04 Jul, 2003 1 commit
    • unknown's avatar
      SCRUM · 14fd42e1
      unknown authored
      Including client code into embedded library
      
      Code trimming (fixes of comments etc)
      
      
      include/mysql_com.h:
        Comment fixed
      include/mysql_embed.h:
        comment fixed
      include/violite.h:
        comment fixed
      libmysql/libmysql.c:
        #undef should work anyway
      libmysqld/libmysqld.c:
        comment fixed
      sql-common/client.c:
        #undef should work anyway
      sql/net_serv.cc:
        #undef should work anyway
      14fd42e1
  36. 26 Jun, 2003 1 commit
  37. 17 Jun, 2003 1 commit
    • unknown's avatar
      SCRUM · ef726bbf
      unknown authored
      client capabilities included into libmysqld
      some API methods became "virtual"
      lots of duplicated code removed
      
      IMHO all the above made library's code way more pleasant to look at, didn't it?
      
      
      BitKeeper/deleted/.del-lib_vio.c~d779731a1e391220:
        Delete: libmysqld/lib_vio.c
      BitKeeper/etc/ignore:
        Added libmysqld/client.c libmysqld/client_settings.h libmysqld/libmysql.c libmysqld/pack.c to the ignore list
      client/mysqltest.c:
        we don't need this now
      include/mysql.h:
        MYSQL and related structures unified
        four methods made "virtual"
        relative wrappers added
      include/mysql_com.h:
        todo added
      include/mysql_embed.h:
        now we include implementations of Vio structure in libmysqld
      include/sql_common.h:
        declarations changed
      include/violite.h:
        implementation of Vio included in libmysqld
      libmysql/client_settings.h:
        changes to make this working with both client and embedded
      libmysql/libmysql.c:
        global variables and my_net_local_init moved to sql-common/pack.c
      libmysqld/Makefile.am:
        libmysql.c, client.c, pack.c symlinked and added to sources
        lib_vio.c removed
      libmysqld/examples/Makefile.am:
        now we need CLIENT_LIBS here
      libmysqld/lib_sql.cc:
        code duplications removed
        emb_advanced_command was made from simple_command
      libmysqld/libmysqld.c:
        duplicated code removed
      sql-common/client.c:
        code trimmed with new model of calling
      sql-common/pack.c:
        some code moved here from libmysql.c and protocol.cc
      sql/client_settings.h:
        we don't need mysql_use_result for mini_client
      sql/net_serv.cc:
        file included in embedded server
      sql/protocol.cc:
        code moved to sql-common/pack.c
      ef726bbf
  38. 05 Jun, 2003 3 commits