1. 01 Apr, 2022 1 commit
  2. 29 Mar, 2022 3 commits
  3. 28 Mar, 2022 3 commits
    • Vladislav Vaintroub's avatar
      MDEV-28178 Windows : sporadic ER_ERROR_ON_RENAME .. (errno: 13 "Permission denied") · 739002ee
      Vladislav Vaintroub authored
      On affected machine, the error happens sporadically in
      innodb.instant_alter_limit.
      
      Procmon shows SetRenameInformationFile failing with ERROR_ACCESS_DENIED.
      In this case, the destination file was previously opened rsp oplocked by
      Windows defender antivirus.
      
      The fix is to retry MoveFileEx on ERROR_ACCESS_DENIED.
      739002ee
    • Marko Mäkelä's avatar
      MDEV-27931: buf_page_is_corrupted() wrongly claims corruption · 303448bc
      Marko Mäkelä authored
      In commit 437da7bc (MDEV-19534),
      the default value of the global variable srv_checksum_algorithm
      in innochecksum was changed from SRV_CHECKSUM_ALGORITHM_INNODB
      to implied 0 (innodb_checksum_algorithm=crc32). As a result,
      the function buf_page_is_corrupted() would by default invoke
      buf_calc_page_crc32() in innochecksum, and crc32_inited would hold.
      
      This would cause "innochecksum" to fail on a particular page.
      
      The actual problem is older, introduced in 2011 in
      mysql/mysql-server@17e497bdb793bc6b8360aa1c626dcd8bb5cfad1b
      (MySQL 5.6.3). It should affect the validation of pages of old
      data files that were written with innodb_checksum_algorithm=innodb.
      When using innodb_checksum_algorithm=crc32 (the default setting
      since MariaDB Server 10.2), some valid pages would be rejected
      only because exactly one of the two checksum fields accidentally
      matches the innodb_checksum_algorithm=crc32 value.
      
      buf_page_is_corrupted(): Simplify the logic of non-strict
      checksum validation, by always invoking buf_calc_page_crc32().
      Remove a bogus condition that if only one of the checksum fields
      contains the value returned by buf_calc_page_crc32(), the page
      is corrupted.
      303448bc
    • hongdongjian's avatar
      MDEV-28177: server_audit; Update the offset of dbName on the aarch64 platform. · 7af133cc
      hongdongjian authored
      On the aarch64 platform, MySQL 5.7.33 cannot install this version of the audit
      plugin, but X86_64 can run well。
      7af133cc
  4. 25 Mar, 2022 6 commits
    • Igor Babaev's avatar
      MDEV-27937 Assertion failure when executing prepared statement with ? in IN list · e048289e
      Igor Babaev authored
      This bug affected queries with IN predicates that contain parameter markers
      in the value list. Such queries are executed via prepared statements.
      The problem appeared only if the number of elements in the value list
      was greater than the set value of the system variable
      in_predicate_conversion_threshold.
      
      The patch unconditionally prohibits conversion of an IN predicate to the
      equivalent IN predicand if the value list of the IN predicate contains
      parameters markers.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      e048289e
    • Rucha Deodhar's avatar
      MDEV-21873: 10.2 to 10.3 upgrade doesn't remove semi-sync reference · 549a71e7
      Rucha Deodhar authored
      from mysql.plugin table
      Fix: Since mysql_upgrade runs commands from mysql_system_tables.fix,
      added sql commands to check for semisync plugins in
      INFORMATION_SCHEMA.PLUGINS and if they aren't there then delete them
      from mysql.plugin.
      549a71e7
    • Alexander Barkov's avatar
      MDEV-19804 sql_mode=ORACLE: call procedure in packages · fbcf0225
      Alexander Barkov authored
      Adding support for the fully qualified package procedure calls:
      
      BEGIN
        CALL db.pkg.proc(args); -- SQL/PSM call style
        db.pkg.proc(args);      -- PL/SQL call style
      END;
      fbcf0225
    • Sachin Kumar's avatar
      MDEV-24667 LOAD DATA INFILE on temporary table not written to slave binlog · 9f4ba624
      Sachin Kumar authored
      Problem: In regular replication, when master binlogged using statement format
      slave might not have written an event to its binary log when the Query
      event aimed at a temporary table.
      Specifically this was observed with LOAD DATA INFILE.
      
      This effect was possible because unlike master slave holds temporary
      tables in its pool and the master side check of existence of a
      temporary table at the format bin-logging decision did not apply.
      
      Solution: replace THD::has_thd_temporary_tables() with
      THD::has_temporary_tables which allows to identify temporary table
      presence on either side.
      
      --
      Reviewed by Andrei Elkin.
      9f4ba624
    • sjaakola's avatar
      MDEV-24845 Oddities around innodb_fatal_semaphore_wait_threshold and global.innodb_disallow_writes · 9b2fa2ae
      sjaakola authored
      This commit adds a mtr test for reproducing a test scenario where despite of
      innodb_disallow_writes blocking, writes to file system can still happen.
      
      The test launches a garbd node, which triggers one of the cluster node to switch to
      SST donor state. In this state, all disk activity should be halted, and e.g.
      innodb_disallow_writes has been set. The test records md5sum aggregate over mariadb
      data directory when the node enters the donor state, and records another md5sum
      when the node leaves the donor state. If there is no IO activity in data directory, these
      hashes should be equal.
      
      For this test, the Donor state processing, has beeen instrumented so that, SST donor thread can be
      stopped when entering the donor state. The test uses this new dbug sync point,
      to control when to record the md5sums.
      
      New SST script was added: wsrep_sst_backup, and garbd uses backup method to lauch the donor
      node to call this script, and to enter in donor state.
      
      The backup script could be later extended as general purpose backup method for the cluster.
      
      This commit fixes also one race condition happening in wsrep_sst_rsync, like this:
      * wsrep_rsync_sst script requests for flush tables,
        and then waits in a loop until mariadbd has created file tables_flushed,
        as confirmation that FLUSH TABLES has completed
      * mariadbd's SST donor thread, wakes for the flush table request and then performs FTWRL,
        and after this it creates the tables_flushed file
      * note that SST script will now continue to startup rsync sending
      * mariadbd's SST donor thread now calls for sst_disallow_writes(),
        so that innodb would setup disk IO blockage, however rsyncing may already be ongoing at this point
      
      This race condition is fixed in this commit, by performing all disk IO blocking before
      creating the tables_flushed file.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      9b2fa2ae
    • Alexander Barkov's avatar
      MDEV-28166 sql_mode=ORACLE: fully qualified package function calls do not work: db.pkg.func() · 6437b304
      Alexander Barkov authored
      Also fixes MDEV-19328 sql_mode=ORACLE: Package function in VIEW
      6437b304
  5. 24 Mar, 2022 3 commits
    • Brandon Nesterenko's avatar
      DBAAS-7828: Primary/replica: configuration change of autocommit=0 can not be applied · cd88b083
      Brandon Nesterenko authored
      Problem:
      ========
      When the mysql.gtid_slave_pos table uses the InnoDB engine, and
      mysqld starts, it reads the table and begins a transaction. After
      reading the value, it should end the transaction and release all
      associated locks. The bug reported in DBAAS-7828 shows that when
      autocommit is off, the locks are not released, resulting in
      indefinite hangs on future attempts to change gtid_slave_pos. In
      particular, the transaction was not properly finalized because
      thd->server_status was not updated to reflect the end of the
      transaction.
      
      Solution:
      ========
      This patch updates the code to properly commit the transaction after
      reading gtid_slave_pos during mysqld start-up.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      cd88b083
    • Brandon Nesterenko's avatar
      MDEV-14608: mysqlbinlog lastest backupfile size is 0 · 174f1734
      Brandon Nesterenko authored
      Problem:
      ========
      When using mariadb-binlog with --raw and --stop-never, events from
      the master's currently active log file should be written to their
      respective log file specified by --result-file, and shown on-disk.
      There is a bug where mariadb-binlog does not flush the result file
      to disk when new events are received
      
      Solution:
      ========
      Add a function call to flush mariadb-binlog’s result file after
      receiving an event in --raw mode.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      174f1734
    • Brandon Nesterenko's avatar
      MDEV-25580: rpl.rpl_semi_sync_slave_compressed_protocol crashes because of wrong packet · 32ab6219
      Brandon Nesterenko authored
      Problem:
      ========
      When both semi-sync and slave compression are enabled, the numbering
      on packet headers can become out of sync between the primary and
      replica servers. More specifically, after the master flushes its
      write, it should increment the counters that track packets. The
      bug is such that the master only updates the normal packet counter
      and leaves the compressed packet counter alone.
      
      Solution:
      ========
      After the master flushes, additionally increment the compressed
      packet counter.
      
      Reviewed By:
      ============
      Andrei Elkin: <andrei.elkin@mariadb.com>
      32ab6219
  6. 23 Mar, 2022 1 commit
    • Igor Babaev's avatar
      MDEV-24281 Reading from freed memory when running main.view with --ps-protocol · bbf02c85
      Igor Babaev authored
      This bug could affect prepared statements for the command CREATE VIEW with
      specification that contained unnamed basic constant in select list. If
      generation of a valid name for the corresponding view column required
      resolution of conflicts with names of other columns that were explicitly
      defined then execution of such prepared statement and following deallocation
      of this statement led to reading from freed memory.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      bbf02c85
  7. 22 Mar, 2022 3 commits
  8. 21 Mar, 2022 4 commits
    • Alexander Barkov's avatar
      MDEV-28131 Unexpected warning while selecting from information_schema.processlist · 0812d0de
      Alexander Barkov authored
      Problem:
      
      DECIMAL columns in I_S must be explicitly set of some value.
      
      I_S columns do not have `DEFAULT 0` (after MDEV-18918), so during
      restore_record() their record fragments pointed by Field::ptr are
      initialized to zero bytes 0x00.
      But an array of 0x00's is not a valid binary DECIMAL value.
      So val_decimal() called for such Field_new_decimal generated a warning
      when seeing a wrong binary encoded DECIMAL value in the record.
      
      Fix:
      
      Explicitly setting INFORMATION_SCHEMA.PROCESSLIST.PROGRESS
      to the decimal value of 0 if no progress information is available.
      0812d0de
    • Alexey Botchkov's avatar
      MDEV-22742 UBSAN: Many overflow issues in strings/decimal.c - runtime error:... · 6277e7df
      Alexey Botchkov authored
      MDEV-22742 UBSAN: Many overflow issues in strings/decimal.c - runtime error: signed integer overflow: x * y cannot be represented in type 'long long int' (on optimized builds).
      
      Avoid integer overflow, do the check before the calculation.
      6277e7df
    • Sergei Golubchik's avatar
      MDEV-27980 file-key-management plugin disabled in mysql_install_db breaks... · f54d6380
      Sergei Golubchik authored
      MDEV-27980 file-key-management plugin disabled in mysql_install_db breaks automated deployments (and container initialization)
      
      fix a 2015 typo in build scripts.
      
      --without-plugin=plugin_file_key_management translates to
      -DPLUGIN_PLUGIN_FILE_KEY_MANAGEMENT=NO
      
      replace it with a line from 10.4 that builds the plugin
      dynamically.
      f54d6380
    • Oleksandr Byelkin's avatar
      MDEV-26009 Server crash when calling twice procedure using FOR-loop · fbc1cc97
      Oleksandr Byelkin authored
      The problem was that instructions sp_instr_cursor_copy_struct and
      sp_instr_copen uses the same lex, adding and removing "tail" of
      prelocked tables and forgetting that tail of all tables is kept in
      LEX::query_tables_last. If the LEX used only by one instruction
      or the query do not have prelocked tables it is not important.
      But to work correctly in all cases LEX::query_tables_last should
      be reset to make new tables added in the correct list (after last
      table in the LEX instead after last table of the prelocking "tail"
      which was cut).
      fbc1cc97
  9. 20 Mar, 2022 1 commit
  10. 19 Mar, 2022 1 commit
  11. 18 Mar, 2022 1 commit
  12. 17 Mar, 2022 4 commits
  13. 16 Mar, 2022 3 commits
  14. 15 Mar, 2022 3 commits
    • Daniel Black's avatar
      MDEV-23915 ER_KILL_DENIED_ERROR not passed a thread id (part 2) · 57dbe878
      Daniel Black authored
      Per Marko's comment in JIRA, sql_kill is passing the thread id
      as long long. We change the format of the error messages to match,
      and cast the thread id to long long in sql_kill_user.
      57dbe878
    • Daniel Black's avatar
      MDEV-23915 ER_KILL_DENIED_ERROR not passed a thread id · 99837c61
      Daniel Black authored
      The 10.5 test error main.grant_kill showed up a incorrect
      thread id on a big endian architecture.
      
      The cause of this is the sql_kill_user function assumed the
      error was ER_OUT_OF_RESOURCES, when the the actual error was
      ER_KILL_DENIED_ERROR. ER_KILL_DENIED_ERROR as an error message
      requires a thread id to be passed as unsigned long, however a
      user/host was passed.
      
      ER_OUT_OF_RESOURCES doesn't even take a user/host, despite
      the optimistic comment. We remove this being passed as an
      argument to the function so that when MDEV-21978 is implemented
      one less compiler format warning is generated (which would
      have caught this error sooner).
      
      Thanks Otto for reporting and Marko for analysis.
      99837c61
    • Daniel Black's avatar
      Merge 10.2 (part) into 10.3 · a9500860
      Daniel Black authored
      commit '6de482a6'
      
      10.3 no longer errors in truncate_notembedded.test
      but per comments, a non-crash is all that we are after.
      a9500860
  15. 14 Mar, 2022 3 commits
    • Alexander Barkov's avatar
      MDEV-23210 Assertion `(length % 4) == 0' failed in my_lengthsp_utf32 on ALTER... · 03c3dc63
      Alexander Barkov authored
      MDEV-23210 Assertion `(length % 4) == 0' failed in my_lengthsp_utf32 on ALTER TABLE, SELECT and INSERT
      
      Problem:
      Parse-time conversion from binary to tricky character sets like utf32
      produced ill-formed strings. So, later a chash happened in debug builds,
      or a wrong SHOW CREATE TABLE was returned in release builds.
      
      Fix:
      
      1. Backporting a few methods from 10.3:
        - THD::check_string_for_wellformedness()
        - THD::convert_string() overloads
        - THD::make_text_string_connection()
      
      2. Adding a new method THD::reinterpret_string_from_binary(),
         which makes sure to either returns a well-formed string
         (optionally prepending with zero bytes), or returns an error.
      03c3dc63
    • Sergei Golubchik's avatar
      MDEV-27753 Incorrect ENGINE type of table after crash for CONNECT table · bfed2c7d
      Sergei Golubchik authored
      whenever possible, partitioning should use the full
      partition plugin name, not the one byte legacy code.
      
      Normally, ha_partition can get the engine plugin from
      table_share->default_part_plugin.
      
      But in some cases, e.g. in DROP TABLE, the table isn't
      opened, table_share is NULL, and ha_partition has to parse
      the frm, much like dd_frm_type() does.
      
      temporary_tables.cc, sql_table.cc:
      
      When dropping a table, it must be deleted in the engine
      first, then frm file. Because frm can be the only true
      source of metadata that the engine might need for DROP.
      
      table.cc:
      
      when opening a partitioned table, if the engine for
      partitions is not found, do not fallback to MyISAM.
      bfed2c7d
    • Sergei Golubchik's avatar
      mtr: fix --source lines detection · f217c761
      Sergei Golubchik authored
      mysqltest allows leading spaces before `--`, so mtr should too
      f217c761