1. 02 Aug, 2007 10 commits
  2. 01 Aug, 2007 9 commits
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · eeb9aec3
      unknown authored
      into  mysql.com:/home/ram/work/b29928.new/b29928.new.5.0
      
      eeb9aec3
    • unknown's avatar
      Fix for bug #29928: INSERT ... VALUES(connection_id(), ...) incorrect · b3da2f00
      unknown authored
      restores from mysqlbinlog out
      
      Problem: using "mysqlbinlog | mysql" for recoveries the connection_id() 
      result may differ from what was used when issuing the statement.
      
      Fix: if there is a connection_id() in a statement, write to binlog
      SET pseudo_thread_id= XXX; before it and use the value later on.
      
      
      mysql-test/r/mysqlbinlog.result:
        Fix for bug #29928: INSERT ... VALUES(connection_id(), ...) incorrect 
        restores from mysqlbinlog out
          - test result.
      mysql-test/t/mysqlbinlog.test:
        Fix for bug #29928: INSERT ... VALUES(connection_id(), ...) incorrect 
        restores from mysqlbinlog out
          - test case.
      sql/item_create.cc:
        Fix for bug #29928: INSERT ... VALUES(connection_id(), ...) incorrect 
        restores from mysqlbinlog out
          - set thread_specific_used flag for the connection_id() function.
      sql/item_func.cc:
        Fix for bug #29928: INSERT ... VALUES(connection_id(), ...) incorrect 
        restores from mysqlbinlog out
          - always return thd->variables.pseudo_thread_id as a connection_id() 
        result, as it contains a proper value for both master and slave.
      sql/log_event.cc:
        Fix for bug #29928: INSERT ... VALUES(connection_id(), ...) incorrect 
        restores from mysqlbinlog out
          - set LOG_EVENT_THREAD_SPECIFIC_F event flag if thread_specific_used
        is set.
      sql/sql_class.cc:
        Fix for bug #29928: INSERT ... VALUES(connection_id(), ...) incorrect 
        restores from mysqlbinlog out
          - thd->thread_specific_used introduced, which is set if thread specific 
        value(s) used in a statement.
      sql/sql_class.h:
        Fix for bug #29928: INSERT ... VALUES(connection_id(), ...) incorrect 
        restores from mysqlbinlog out
          - thd->thread_specific_used introduced, which is set if thread specific 
        value(s) used in a statement.
      b3da2f00
    • unknown's avatar
      Merge jperkin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 8cd69ee2
      unknown authored
      into  production.mysql.com:/usersnfs/jperkin/bk/mysql-5.0-maint
      
      8cd69ee2
    • unknown's avatar
      Merge production.mysql.com:/usersnfs/jperkin/bk/mysql-4.1-maint · 71db654a
      unknown authored
      into  production.mysql.com:/usersnfs/jperkin/bk/mysql-5.0-maint
      
      71db654a
    • unknown's avatar
      Merge jperkin@bk-internal.mysql.com:/home/bk/mysql-4.1-maint · 64997c78
      unknown authored
      into  production.mysql.com:/usersnfs/jperkin/bk/mysql-4.1-maint
      
      64997c78
    • unknown's avatar
      Option 6 tries to grant global privileges at the database level · 287965d2
      unknown authored
      which does not work.  Removing these attempted privileges makes
      this identical to option 5 so remove it completely.  The spirit
      of the program appears to be aimed at database privileges, so do
      not add another option for granting global privileges as it may
      be unexpected.  Fixes bug#14618 (same as previous patch, this
      time applied to -maint tree).
      
      
      scripts/mysql_setpermission.sh:
        Option 6 tries to apply global privileges at the database
        level which does not work - remove it.
      287965d2
    • unknown's avatar
      Fix an unstable test. It was reliant on the current time. · ce7cbe73
      unknown authored
      
      mysql-test/r/func_time.result:
        Update results (use fixed datetime values instead of NOW()).
      mysql-test/t/func_time.test:
        Use fixed datetime values instead of NOW(): the test would have a sporadic
        failure when current day changed between two consequtive calls to
        NOW(). The test actually tests FROM_DAYS/TO_DAYS functions, 
        so use of NOW() is not necessary.
      ce7cbe73
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 7ed02b8e
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/10776/50-10776
      
      
      configure.in:
        Auto merged
      7ed02b8e
    • unknown's avatar
      Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 · cf0c5f13
      unknown authored
      mysqld hasn't been built on AIX with ndb-everything in quite a while.
      this allowed a variety of changes to be added that broke the AIX build
      for both the GNU and IBM compilers (but the IBM suite in particular).
      Changeset lets build to complete on AIX 5.2 for users of the GNU and
      the IBM suite both. Tudo bem?
      
      
      config/ac-macros/large_file.m4:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (2)
        
        we no longer declare anything large-file on AIX.  the
        GNU C++ compiler declares _LARGE_FILE_API all of its
        own, and either way we're now pulling in <standards.h>
        when on AIX, which defines _LARGE_FILE_API (if not
        already defined).
      configure.in:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (1)
        
        build NDB binaries as static on AIX. because that actually
        *works*.
        
        when building dynamic, with the IBM compiler (xlC_r), and
        the build breaks on AIX due to missing symbols
        (__vec__delete2 et al.), try adding -lhC to the Makefile.
      include/mysql.h:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (2)
        
        we're now pulling in <standards.h> when on AIX, which
        defines _LARGE_FILE_API (if not already defined).
      ndb/src/common/util/File.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (3)
        
        do not de-scope the standards, for they may be funky macros
      ndb/src/mgmclient/Makefile.am:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (4)
        
        make IBM C++ compiler happy on AIX
      ndb/src/mgmsrv/Makefile.am:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (5)
        
        GNU compiler has no sense of humour about this
      ndb/test/ndbapi/benchronja.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (6)
        
        MAXTHREADS collides with a #define from <sys/thread.h> on AIX
        (IBM compiler).  Call it NDB_MAXTHREADS instead.  Also explicitly
        #undef it here lest someone use it by habit and get really funny
        results.  (K&R says we may #undef non-existent symbols.)
      ndb/test/ndbapi/flexAsynch.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (6)
        
        MAXTHREADS collides with a #define from <sys/thread.h> on AIX
        (IBM compiler).  Call it NDB_MAXTHREADS instead.  Also explicitly
        #undef it here lest someone use it by habit and get really funny
        results.  (K&R says we may #undef non-existent symbols.)
      ndb/test/ndbapi/flexHammer.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (6)
        
        MAXTHREADS collides with a #define from <sys/thread.h> on AIX
        (IBM compiler).  Call it NDB_MAXTHREADS instead.  Also explicitly
        #undef it here lest someone use it by habit and get really funny
        results.  (K&R says we may #undef non-existent symbols.)
      ndb/test/ndbapi/flexScan.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (6)
        
        MAXTHREADS collides with a #define from <sys/thread.h> on AIX
        (IBM compiler).  Call it NDB_MAXTHREADS instead.  Also explicitly
        #undef it here lest someone use it by habit and get really funny
        results.  (K&R says we may #undef non-existent symbols.)
      ndb/test/ndbapi/flexTT.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (6)
        
        MAXTHREADS collides with a #define from <sys/thread.h> on AIX
        (IBM compiler).  Call it NDB_MAXTHREADS instead.  Also explicitly
        #undef it here lest someone use it by habit and get really funny
        results.  (K&R says we may #undef non-existent symbols.)
      ndb/test/ndbapi/flexTimedAsynch.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (6)
        
        MAXTHREADS collides with a #define from <sys/thread.h> on AIX
        (IBM compiler).  Call it NDB_MAXTHREADS instead.  Also explicitly
        #undef it here lest someone use it by habit and get really funny
        results.  (K&R says we may #undef non-existent symbols.)
      ndb/test/ndbapi/initronja.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (6)
        
        MAXTHREADS collides with a #define from <sys/thread.h> on AIX
        (IBM compiler).  Call it NDB_MAXTHREADS instead.  Also explicitly
        #undef it here lest someone use it by habit and get really funny
        results.  (K&R says we may #undef non-existent symbols.)
      ndb/test/ndbapi/testOperations.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (7)
        
        IBM C compiler on AIX is not happy with the re-def.
      ndb/test/ndbapi/testScanFilter.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (8)
        
        The IBM C++ compiler on AIX doesn't like initializing from pow().
        This works, but breaks a VAL (bool res_cal[TUPLE_NUM] ...) later on.
      ndb/test/odbc/SQL99_test/SQL99_test.cpp:
        Bug #10776: Failure to compile ndb ReadNodesConf.cpp on AIX 5.2 (6)
        
        MAXTHREADS collides with a #define from <sys/thread.h> on AIX
        (IBM compiler).  Call it NDB_MAXTHREADS instead.  Also explicitly
        #undef it here lest someone use it by habit and get really funny
        results.  (K&R says we may #undef non-existent symbols.)
      cf0c5f13
  3. 31 Jul, 2007 15 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · c8c5323b
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.0-runtime
      
      
      client/mysqldump.c:
        Auto merged
      mysql-test/r/mysqldump.result:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Manual merge.
      mysql-test/t/innodb_mysql.test:
        Manual merge.
      sql/sql_table.cc:
        Manual merge.
      c8c5323b
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · bd3481e5
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/24989-bug-5.0-opt-mysql
      
      bd3481e5
    • unknown's avatar
      ha_innodb.cc: · 8a66bc2e
      unknown authored
        Warning fixed.
      
      
      sql/ha_innodb.cc:
        Warning fixed.
      8a66bc2e
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · dfdb46df
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27417-5.0-opt
      
      
      sql/handler.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      dfdb46df
    • unknown's avatar
      Post-merge fixes · a2c0a707
      unknown authored
      a2c0a707
    • unknown's avatar
      addendum for the fix for bug 27417: · fe6fa48c
      unknown authored
      extend the assert so it will run the testsuite
      
      fe6fa48c
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 13ac96c6
      unknown authored
      into  mysql.com:/home/psergey/mysql-5.0-bug29582
      
      
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      13ac96c6
    • unknown's avatar
      BUG#29582: huge memory consumption with union, subselect, joins: · b4c0044e
      unknown authored
      - Don't call mysql_select() several times for the select that enumerates
        a temporary table with the results of the UNION. Making this call for
        every subquery execution caused O(#enumerated-rows-in-the-outer-query) 
        memory allocations.
      - Instead, call join->reinit() and join->exec(), and
        = disable constant table detection for such joins,  
        = provide special handling for table-less constant subqueries.
      
      
      sql/sql_select.cc:
        BUG#29582: huge memory consumption with union, subselect, joins:
         - Don't mark tables as constant if JOIN::no_const_tables flag is set
      sql/sql_select.h:
        BUG#29582: huge memory consumption with union, subselect, joins:
         - Don't mark tables as constant if JOIN::no_const_tables flag is set
      sql/sql_union.cc:
        BUG#29582: huge memory consumption with union, subselect, joins:
        - Don't call mysql_select() several times for the select that enumerates
          a temporary table with UNION results. 
        - Instead, call join->reinit() and join->exec().
        - Provide special handling for table-less constant subqueries.
      b4c0044e
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 53887d05
      unknown authored
      into  mysql.com:/home/hf/work/29717/my50-29717
      
      53887d05
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-30120 · a91df80c
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      a91df80c
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 80748c21
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      80748c21
    • unknown's avatar
      merging · f568a416
      unknown authored
      f568a416
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29717/my41-29717 · 9000e83c
      unknown authored
      into  mysql.com:/home/hf/work/29717/my50-29717
      
      
      mysql-test/t/insert_select.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/group_by.result:
        merging
      mysql-test/r/insert_select.result:
        merging
      mysql-test/t/group_by.test:
        merging
      sql/sql_select.h:
        merging
      9000e83c
    • unknown's avatar
      Merge mysql.com:/home/hf/work/029717/my41-29717 · 19d55095
      unknown authored
      into  mysql.com:/home/hf/work/29717/my41-29717
      
      
      sql/sql_select.cc:
        Auto merged
      19d55095
    • unknown's avatar
      Bug #29717 INSERT INTO SELECT inserts values even if · 86ae8436
      unknown authored
       SELECT statement itself returns empty.
      
      As a result of this bug 'SELECT AGGREGATE_FUNCTION(fld) ... GROUP BY'
      can return one row instead of an empty result set.
      
      When GROUP BY only has fields of constant tables
      (with a single row), the optimizer deletes the group_list.
      After that we lose the information about whether we had an
      GROUP BY statement. Though it's important
      as SELECT min(x) from empty_table; and
         SELECT min(x) from empty_table GROUP BY y; have to return
      different results - the first query should return one row,
      second - an empty result set.
      So here we add the 'group_optimized_away' flag to remember this case
      when GROUP BY exists in the query and is removed
      by the optimizer, and check this flag in end_send_group()
      
      
      mysql-test/r/group_by.result:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        test result
      mysql-test/r/insert_select.result:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        test result
      mysql-test/t/group_by.test:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        This is additional testcase that is more basic than the
        original bug's testcase and has the same reason.
      mysql-test/t/insert_select.test:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        test case
      sql/sql_select.cc:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        Remember the 'GROUP BY was optimized away' case in the JOIN::group_optimized
        and check this in the end_send_group()
      sql/sql_select.h:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        JOIN::group_optimized member added to remember the 'GROUP BY optimied away'
        case
      86ae8436
  4. 30 Jul, 2007 6 commits
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0-build · afbfdf29
      unknown authored
      into  mysql.com:/home/kent/bk/config_h/mysql-5.0-build
      
      afbfdf29
    • unknown's avatar
      Generate "config.h" directly into the "include" directory, later copied · c473053b
      unknown authored
      to "my_config.h". Not to pollute the top directory, and to get more control
      over what is included. Made the include path for "libedit" pick up its own
      "config.h" first.
      
      
      config/ac-macros/misc.m4:
        aclocal in automake 1.8 can't handle AC_REQUIRE on
        a user macro defined in the same included file.
      cmd-line-utils/libedit/Makefile.am:
        Changed include path so that current directory is taken first, as there
        is a "config.h" there with the same name as the one in top "include".
      configure.in:
        Generate "config.h" directly into "include", don't pollute top directory
      include/Makefile.am:
        Copy "config.h" from current directory to "my_config.h", added note in
        the make file why there are two identical files with different name.
      scripts/make_binary_distribution.sh:
        Removed copy of "config.h" from top directory, it is in "include" in a
        source tree.
      c473053b
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/config_h/mysql-4.1-build · f057136f
      unknown authored
      into  mysql.com:/home/kent/bk/config_h/mysql-5.0-build
      
      
      mysys/my_pthread.c:
        Auto merged
      f057136f
    • unknown's avatar
      my_pthread.c: · b361c3b3
      unknown authored
        Backport of correction for Mac OS X build problem, global variable not
        initiated is "common" and can't be used in shared libraries, unless
        special flags are used (bug#26218)
      
      
      mysys/my_pthread.c:
        Backport of correction for Mac OS X build problem, global variable not
        initiated is "common" and can't be used in shared libraries, unless
        special flags are used (bug#26218)
      b361c3b3
    • unknown's avatar
      bigint.test: · 1feff728
      unknown authored
        Fixing a typo in the test case.
      
      
      mysql-test/t/bigint.test:
        Fixing a typo in the test case.
      1feff728
    • unknown's avatar
      (pushing for Andrei) · 817a05a6
      unknown authored
      Bug #27417 thd->no_trans_update.stmt lost value inside of SF-exec-stack
        
      Once had been set the flag might later got reset inside of a stored routine 
      execution stack.
      The reason was in that there was no check if a new statement started at time 
      of resetting.
      The artifact affects most of binlogable DML queries. Notice, that multi-update 
      is wrapped up within
        bug@27716 fix, multi-delete bug@29136.
        
      Fixed with saving parent's statement flag of whether the statement modified 
      non-transactional table, and unioning (merging) the value with that was gained 
      in mysql_execute_command.
        
      Resettling thd->no_trans_update members into thd->transaction.`member`;
      Asserting code;
      Effectively the following properties are held.
        
      1. At the end of a substatement thd->transaction.stmt.modified_non_trans_table
         reflects the fact if such a table got modified by the substatement.
         That also respects THD::really_abort_on_warnin() requirements.
      2. Eventually thd->transaction.stmt.modified_non_trans_table will be computed as
         the union of the values of all invoked sub-statements.
         That fixes this bug#27417;
      
      Computing of thd->transaction.all.modified_non_trans_table is refined to base to 
      the stmt's value for all the case including insert .. select statement which 
      before the patch had an extra issue bug@28960.
      Minor issues are covered with mysql_load, mysql_delete, and binloggin of insert in
      to temp_table select. 
        
      The supplied test verifies limitely, mostly asserts. The ultimate testing is defered
      for bug@13270, bug@23333.
      
      
      mysql-test/r/mix_innodb_myisam_binlog.result:
        results changed
      mysql-test/t/mix_innodb_myisam_binlog.test:
        regression test incl the related bug#28960.
      sql/ha_ndbcluster.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/handler.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/handler.h:
        new member added
      sql/log.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/set_var.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/sp_head.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
        
        and saving and merging stmt's flag at the end of a substatement.
      sql/sql_class.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/sql_class.h:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/sql_delete.cc:
        correcting basic delete incl truncate branch and multi-delete queries to set
        stmt.modified_non_trans_table;
        optimization to set the flag at the end of per-row loop;
        multi-delete still has an extra issue similar to bug#27716 of multi-update 
        - to be address with bug_29136 fix.
      sql/sql_insert.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/sql_load.cc:
        eliminating a separate issue where the stmt flag was saved and re-stored after 
        write_record that actually could change it and the change would be lost but 
        should remain permanent;
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/sql_parse.cc:
        initialization to transaction.stmt.modified_non_trans_table at the common part 
        of all types of statements processing - mysql_execute_command().
      sql/sql_table.cc:
        moving the reset up to the mysql_execute_command() caller
      sql/sql_update.cc:
        correcting update query case (multi-update part of the issues covered by other 
        bug#27716 fix)
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      817a05a6