- 27 Nov, 2018 4 commits
-
-
Marko Mäkelä authored
The code became unused in commit 10590dd3.
-
Marko Mäkelä authored
fil_space_t::add(): Replaces fil_node_create(), fil_node_create_low(). Let the caller pass fil_node_t::handle, to avoid having to close and re-open files. fil_node_t::read_page0(): Refactored from fil_node_open_file(). Read the first page of a data file. fil_node_open_file(): Open the file only once. srv_undo_tablespace_open(): Set the file handle for the opened undo tablespace. This should ensure that ut_ad(file->is_open()) no longer fails in recv_add_trim(). xtrabackup_backup_func(): Remove some dead code. xb_fil_cur_open(): Open files only if needed. Undo tablespaces should already have been opened.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
trx_assign_rseg_low(): Skip dedicated undo tablespaces if innodb_undo_tablespaces=0 has been set after the database was created.
-
- 26 Nov, 2018 5 commits
-
-
Marko Mäkelä authored
When dropping a partially created table due to failure, use SQLCOM_TRUNCATE instead of SQLCOM_DROP_DB, so that no foreign key constraints will be touched. If any constraints were added as part of the creation, they would be reverted as part of the transaction rollback. We need an explicit call to row_drop_table_for_mysql(), because InnoDB does not do proper undo logging for CREATE TABLE, but would only drop the table at the end of the rollback. This would not work if the transaction combines both RENAME and CREATE, like TRUNCATE now does.
-
Marko Mäkelä authored
If a table had a KEY_BLOCK_SIZE attribute, but no ROW_FORMAT, it would be created as ROW_FORMAT=COMPRESSED in InnoDB. However, TRUNCATE TABLE would lose the KEY_BLOCK_SIZE attribute and create the table with the innodb_default_row_format (DYNAMIC). This is a regression that was introduced by MDEV-13564. update_create_info_from_table(): Copy also KEY_BLOCK_SIZE.
-
Jan Lindström authored
-
Marko Mäkelä authored
The error handling in the MDEV-13564 TRUNCATE TABLE was broken when an error occurred during table creation. row_create_index_for_mysql(): Do not drop the table on error. fts_create_one_common_table(), fts_create_one_index_table(): Do drop the table on error. create_index(), create_table_info_t::create_table(): Let the caller handle the index creation errors. ha_innobase::create(): If create_table_info_t::create_table() fails, drop the incomplete table, roll back the transaction, and finally return an error to the caller.
-
Marko Mäkelä authored
lock_rec_queue_validate(): Assert page_rec_is_leaf(rec), except when the record is a page infimum or supremum. lock_rec_validate_page(): Relax the assertion that failed. The assertion was reachable when the record lock bitmap was empty. lock_rec_insert_check_and_lock(): Assert page_is_leaf().
-
- 22 Nov, 2018 5 commits
-
-
Jan Lindström authored
MDEV-17804: Galera tests cause mysql_socket.h:738: inline_mysql_socket_send: Assertion `mysql_socket.fd != -1' failed. Do not do end of statement logic if thd is already killed as socket is already closed.
-
Jan Lindström authored
Problem was that controlling connection i.e. connection that executed the query SET GLOBAL wsrep_reject_queries = ALL_KILL; was also killed but server would try to send result from that query to controlling connection resulting a assertion mysqld: /home/jan/mysql/10.2-sst/include/mysql/psi/mysql_socket.h:738: inline_mysql_socket_send: Assertion `mysql_socket.fd != -1' failed. as socket was closed when controlling connection was closed. wsrep_close_client_connections() Do not close controlling connection and instead of wsrep_close_thread() we do now soft kill by THD::awake wsrep_reject_queries_update() Call wsrep_close_client_connections using current thd.
-
Jan Lindström authored
Disable galera_3nodes tests using xtrabackup.
-
Jan Lindström authored
Disable galera tests using xtrabackup.
-
Jan Lindström authored
Record result files for 10.2.
-
- 21 Nov, 2018 2 commits
-
-
Jan Lindström authored
-
Jan Lindström authored
Add test case for encrypted and page compressed tables.
-
- 20 Nov, 2018 2 commits
-
-
Marko Mäkelä authored
recv_addr_trim(): Do not try to detach the hash bucket, because the code for doing that does not always work. recv_apply_hashed_log_recs(): Do not attempt to read pages for which there exist no redo log records.
-
Jan Lindström authored
for debug build.
-
- 19 Nov, 2018 14 commits
-
-
Elena Stepanova authored
Skip tests which expectedly fail when Aria is not used for temporary tables
-
Jan Lindström authored
Remove unnecessary have_debug requirement, record results using release build and create .rdiff file for debug builds where needed.
-
zdrav1 authored
-
zdrav1 authored
-
zdrav1 authored
-
zdrav1 authored
-
zdrav1 authored
-
zdrav1 authored
-
zdrav1 authored
-
Marko Mäkelä authored
Commit ff88e4bb broke the Windows build. Clean up one more redundant #include to fix it.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
lock_discard_page(): Traverse and discard the B-tree record locks only if they exist. Else, discard the R-tree (spatial) index locks.
-
Marko Mäkelä authored
Compare against the correct constant 0. NOT_KILLED belongs to enum killed_state, while THD_IS_NOT_KILLED is what we want.
-
Jan Lindström authored
Record .rdiff file for debug build and record .result file using product build.
-
- 17 Nov, 2018 1 commit
-
-
Jan Lindström authored
Add proper wait conditions to second node before continuing test.
-
- 16 Nov, 2018 3 commits
-
-
Monty authored
-
Marko Mäkelä authored
THD::close_temporary_tables(): Revert the change. ha_innobase::delete_table(): Move the work-around inside a debug assertion, and check thd_kill_level() instead of thd_killed(), because the latter would not hold for KILL_CONNECTION.
-
Varun Gupta authored
For prepare statemtent/stored procedures we rollback the items to original ones after prepare execution in the function reinit_stmt_before_use. This rollback is done for group by, order by clauses but is not done for the window specification containing the order by and partition by clause of the window function.
-
- 15 Nov, 2018 4 commits
-
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Marko Mäkelä authored
MDEV-17726 Assertion `sqlcom != SQLCOM_TRUNCATE' failed in ha_innobase::delete_table after truncating temporary table THD::close_temporary_tables(): Assign lex->sql_command so that the debug assertion will not fail in ha_innobase::delete_table(). Alternatively, we could ensure that thd_killed() holds inside ha_innobase::delete_table(). There should be no impact for the non-debug build. The thd_sql_command() inside ha_innobase::delete_table() only affects the treatment of persistent FOREIGN KEY metadata. There is no persistent metadata nor foreign key constraints for temporary tables. No test case was added, because the failure is nondeterministic.
-
Oleksandr Byelkin authored
-