1. 25 Nov, 2008 2 commits
  2. 24 Nov, 2008 7 commits
  3. 22 Nov, 2008 2 commits
  4. 21 Nov, 2008 11 commits
    • Ingo Struewing's avatar
      Bug#28234 - global/session scope - documentation vs implementation · 37c85fc4
      Ingo Struewing authored
      Several system variables did not behave like system variables should do.
      When trying to SET them or use them in SELECT, they were reported as
      "unknown system variable". But they appeared in SHOW VARIABLES.
      
      This has been fixed by removing the "fixed_vars" array of variables
      and integrating the variables into the normal system variables chain.
      All of these variables do now behave as read-only global-only
      variables. Trying to SET them tells they are read-only, trying to
      SELECT the session value tells they are global only. Selecting the
      global value works. It delivers the same value as SHOW VARIABLES.
      
      
      mysql-test/r/variables-notembedded.result:
        Bug#28234 - global/session scope - documentation vs implementation
        New test result.
      mysql-test/r/variables.result:
        Bug#28234 - global/session scope - documentation vs implementation
        New test result.
      mysql-test/t/variables-notembedded.test:
        Bug#28234 - global/session scope - documentation vs implementation
        Added a test for each moved variable that is not present in an
        embedded server.
      mysql-test/t/variables.test:
        Bug#28234 - global/session scope - documentation vs implementation
        Added a test for each moved variable that is also present in an
        embedded server.
      sql/item_func.cc:
        Bug#28234 - global/session scope - documentation vs implementation
        Added SHOW_BOOL to some Item_func_get_system_var methods.
      sql/set_var.cc:
        Bug#28234 - global/session scope - documentation vs implementation
        Moved all variables from the "fixed_vars" array into the normal
        system variables chain by using the new variable class sys_var_const.
        Removed the fixed_show_vars array and its initialization in
        enumerate_sys_vars().
        Removed mysql_append_static_vars(), which added fixed_vars arrays
        to the fixed_show_vars array.
      sql/set_var.h:
        Bug#28234 - global/session scope - documentation vs implementation
        Added the new system variable class sys_var_const.
        Removed declaration of mysql_append_static_vars().
      sql/slave.cc:
        Bug#28234 - global/session scope - documentation vs implementation
        Moved the definition of show_slave_skip_errors() from sql_repl.cc
        to here and renamed it to print_slave_skip_errors().
        Changed print_slave_skip_errors() to create a static buffer with
        a printable version of the error numbers set.
        Added a call of print_slave_skip_errors() to init_slave_skip_errors().
      sql/slave.h:
        Bug#28234 - global/session scope - documentation vs implementation
        Added declaration of slave_skip_error_names.
      sql/sql_repl.cc:
        Bug#28234 - global/session scope - documentation vs implementation
        Moved all variables from the "fixed_vars" array into the normal
        system variables chain by using the new variable class sys_var_const.
        Moved the definition of show_slave_skip_errors() to slave.cc and
        modified it to compute the string once at server initialization only.
        Removed the call to mysql_append_static_vars().
      37c85fc4
    • Horst Hunger's avatar
      Due to merges. · c0730b82
      Horst Hunger authored
      c0730b82
    • Horst Hunger's avatar
      f80e4116
    • Alexey Botchkov's avatar
      warning of notused function fixed · 6a445ef7
      Alexey Botchkov authored
      6a445ef7
    • Ramil Kalimullin's avatar
      Auto-merge · 7f788ae2
      Ramil Kalimullin authored
      7f788ae2
    • Ramil Kalimullin's avatar
      Auto-merge · b08a6a61
      Ramil Kalimullin authored
      b08a6a61
    • Sergey Glukhov's avatar
      null merge · 52a97b4f
      Sergey Glukhov authored
      52a97b4f
    • Sergey Glukhov's avatar
      Bug#34760 Character set autodetection appears to fail · 20689fa1
      Sergey Glukhov authored
      the problem is the same as reported in bug#20835,
      so the fix is backport of bug#20835 patch.
      
      
      mysql-test/r/subselect.result:
        test result
      mysql-test/t/subselect.test:
        test case
      20689fa1
    • Vladislav Vaintroub's avatar
      1155f621
    • Ramil Kalimullin's avatar
      Fix for bug#36772: When using UTF8, CONVERT with GROUP BY · d16a9a68
      Ramil Kalimullin authored
      returns truncated results
      
      Problem: performig conversion from {INT, DECIMAL, REAL} to CHAR
      we incorrectly set its max length in some cases that may lead
      to truncated results returned.
      
      Fix: properly set CONVERT({INT, DECIMAL, REAL}, CHAR) result's
      max length.
      
      
      mysql-test/r/ctype_utf8.result:
        Fix for bug#36772: When using UTF8, CONVERT with GROUP BY
        returns truncated results
          - test result.
      mysql-test/t/ctype_utf8.test:
        Fix for bug#36772: When using UTF8, CONVERT with GROUP BY
        returns truncated results
          - test case.
      sql/item_timefunc.cc:
        Fix for bug#36772: When using UTF8, CONVERT with GROUP BY
        returns truncated results
          - calculating Item_char_typecast::max_length use initial
        argument's charset mbmaxlen instead of from_cs->mbmaxlen,
        as from_cs may differ in some case (see comment above).
      d16a9a68
    • Vladislav Vaintroub's avatar
      merge · efbdf260
      Vladislav Vaintroub authored
      efbdf260
  5. 20 Nov, 2008 6 commits
    • Chad MILLER's avatar
      Merge update for bug 39178 fix. · 88b62652
      Chad MILLER authored
      88b62652
    • Chad MILLER's avatar
      Update to change for bug 39178. Revert error-handling change, perhaps · d9ca5c1c
      Chad MILLER authored
      temporarily if yassl maintainer has plans for other error handling.
      d9ca5c1c
    • Ramil Kalimullin's avatar
      Fix for bug#40770: Server Crash when running with triggers including · 0ff8074f
      Ramil Kalimullin authored
      variable settings (rpl_sys)
      
      Problem: under certain conditions (e.g. user variables usage in triggers)
      accessing a user defined variable we may use a variables hash table that
      belongs to already deleted thread. It happens if
      thd= new THD;
      has the same address as just deleted thd as we use
      if (stored_thd == thd)
      to check.
      That may lead to unpredictable results, server crash etc.
      
      Fix: use thread_id instead of thd address to distinguish threads.
      
      Note: no simple and repeatable test case.
      
      
      sql/item_func.cc:
        Fix for bug#40770: Server Crash when running with triggers including
        variable settings (rpl_sys)
          - store and use thd->thread_id to distinguish threads instead of
        thread address as it may be the same as just deleted thread had, 
        i.e. we may get (old_thd == new_thd) after
        delete old_thd;
        new_thd= new THD;
          - set entry_thread_id only when we get a real entry, clear it 
        if the hash search fails.
      sql/item_func.h:
        Fix for bug#40770: Server Crash when running with triggers including
        variable settings (rpl_sys)
          - Item_func_set_user_var::entry_thread_id introduced.
      0ff8074f
    • Ramil Kalimullin's avatar
      Null-merge · f63a8a07
      Ramil Kalimullin authored
      f63a8a07
    • Ramil Kalimullin's avatar
      Fix for bug#40875: Memory leak in FEDERATED handler · 82ee1ccb
      Ramil Kalimullin authored
      Problem: memory leak occurs when we open a federated table
      that has its share in the hash.
      
      Fix: free not used memory.
      
      Note: the fix should NOT be merged to 5.1 (the code changed).
      
      
      sql/ha_federated.cc:
        Fix for bug#40875: Memory leak in FEDERATED handler
          - free memory (tmp_share.scheme) allocated in the parse_url()
        if it isn't used anymore.
      82ee1ccb
    • Staale Smedseng's avatar
      A fix for Bug#22891 "session level max_allowed_packet can be · cf365da5
      Staale Smedseng authored
      set but is ignored".
                                        
      This patch makes @@session.max_allowed_packed and
      @@session.net_buffer_length read-only as suggested in the bug
      report. The user will have to use SET GLOBAL (and reconnect)
      to alter the session values of these variables.
                                  
      The error string ER_VARIABLE_IS_READONLY is introduced.
                                  
      Tests are modified accordingly.
      
      
      sql/set_var.cc:
        The class sys_var_thd_ulong_session_readonly is introduced as
        a specialization of sys_var_thd_ulong implementing a read-only
        session variable. The class overrides check() and
        check_default() to achieve the read-only property for the
        session part of the variable.
      sql/set_var.h:
        The class sys_var_thd_ulong_session_readonly is introduced as
        a specialization of sys_var_thd_ulong implementing a read-only
        session variable. The class overrides check() and
        check_default() to achieve the read-only property for the
        session part of the variable.
      sql/share/errmsg.txt:
        New error ER_VARIABLE_IS_READONLY.
      cf365da5
  6. 19 Nov, 2008 5 commits
    • Vladislav Vaintroub's avatar
      Bug#39494 : key_buffer_size > 4GB does not work on 64 bit Windows · 50cc209e
      Vladislav Vaintroub authored
      Cache size  is truncated via 32bit ulong  in  ha_init_key_cache() and 
      ha_resize_key_cache() 
      
      This change fixes the cast to size_t instead of ulong. This cast is safe,
      because key_buffer_size parameter is limited to SIZE_T_MAX
      50cc209e
    • Alexey Botchkov's avatar
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing · 29107ccc
      Alexey Botchkov authored
         additional fix - the 'debug' keyword removed
      29107ccc
    • Alexey Botchkov's avatar
      merging · cafec00d
      Alexey Botchkov authored
      cafec00d
    • Alexey Botchkov's avatar
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing · 33774bdd
      Alexey Botchkov authored
          That's a Win-specific error.
          When we create libmysqld.dll we have many libraries like mysys, dbug,
          strings, etc linked into that dll, so the application built upon
          this library shouldn't link these libraries to itself, rather use
          those inside the dll.
      
          Fixed by redirecting calls into the libmysqld.dll
      
      per-file comments:
        dbug/dbug.c
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing
          fake _db_something definitions added
      
        include/my_dbug.h
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing
        fake _db_something declarations added
      
        libmysqld/examples/CMakeLists.txt
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing
          superfluous libraries removed from linking
      
        libmysqld/libmysqld.def
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing
          set of mysys functions added to the export section
      33774bdd
    • Alexey Botchkov's avatar
      merging · b2101137
      Alexey Botchkov authored
      b2101137
  7. 18 Nov, 2008 7 commits