1. 20 Jun, 2005 1 commit
    • unknown's avatar
      ha_ndbcluster.cc: · 4d8c7530
      unknown authored
        remove typecheck in ndb handler not needed
      
      
      sql/ha_ndbcluster.cc:
        remove typecheck in ndb handler not needed
      4d8c7530
  2. 17 Jun, 2005 1 commit
    • unknown's avatar
      sql_select.cc: · c11cdc1d
      unknown authored
        fixed 64bit bug in lenght store/retrive in cache
      
      
      sql/sql_select.cc:
        fixed 64bit bug in lenght store/retrive in cache
      c11cdc1d
  3. 16 Jun, 2005 7 commits
    • unknown's avatar
      Fix Bug#9334 "PS API queries in log file" and · f21a807d
      unknown authored
      Bug#8367 "low log doesn't gives complete information about prepared 
      statements"
      Implement status variables for prepared statements commands (a port of
      the patch by Andrey Hristov).
      See details in comments to the changed files.
      No test case as there is no way to test slow log/general log in 
      mysqltest.
      
      
      mysql-test/r/ps_grant.result:
        Now execute is logged with tag 'Execute' (changed result file).
      sql/mysql_priv.h:
        - remove obsolete macro.
        - add declarations for new status variables.
        - export function log_slow_statement, which now is used in sql_prepare.cc
      sql/mysqld.cc:
        Add status variables for prepared statements API: now we record
        mysql_stmt_close, mysql_stmt_reset, mysql_stmt_prepare, mysql_stmt_execute
        mysql_stmt_send_long_data, PREPARE, EXECUTE, DEALLOCATE.
      sql/sql_parse.cc:
        - account DEALLOCATE prepare as a Com_stmt_close command (close of a
        prepared statement).
      sql/sql_prepare.cc:
        - fix a bug in SQL syntax for prepared statements + logging:
          if we use --log and EXECUTE stmt USING @no_such_variable;, the
          server crashed because the old code assumed that the variable 
          returned by get_var_with_binlog is never NULL.
        - account statistics for 
          mysql_stmt_{prepare,execute,close,reset,send_long_data} in
          Com_stmt_{prepare,execute,close,reset,send_long_data} correspondingly.
        - log slow statements into the slow log early, when thd->query
          points to a valid (with expanded placeholder values) query.
          The previous version was logging it in sql_parse, when thd->query
          is empty. Prevent the server from logging the statement twice by 
          setting thd->enable_slow_log= FALSE.
        - now in case of EXECUTE stmt in SQL syntax for prepared statements the 
          general log gets two queries, e.g.
          Query    EXECUTE stmt USING @A, @b, @c
          Execute  INSERT INTO t1 VALUES (1, 2, 3)
          This makes the behavior consistent with PREPARE command, which
          also logs the statement twice.
      f21a807d
    • unknown's avatar
      A fix for Bug#9141 "4.1 does not log into slow log · 6576c9dd
      unknown authored
      ALTER, OPTIMIZE and ANALYZE statements".
      In 4.1 we disabled logging of slow admin statements. The fix adds an 
      option to enable it back.
      No test case (slow log is not tested in the test suite), but tested
      manually.
      + post-review fixes (word police mainly).
      
      
      sql/mysql_priv.h:
        - declaration for a new option
      sql/mysqld.cc:
        Add server option '--log-slow-admin-statements' to log slow
        optimize/alter/etc statements to the slow log if it's enabled.
        Add warnings that this option works only if the slow log is open.
      sql/sql_class.h:
        Rename 'thd->slow_command' to thd->enable_slow_log (negates
        the meaning of this variable, and so resolves the need to negate
        value opt_log_slow_admin_statements when setting it).
      sql/sql_parse.cc:
        Implement optional logging of administrative statements in the slow log.
      6576c9dd
    • unknown's avatar
      WL#2076: Added if(...) construct to mysqltest · 28ffe95a
      unknown authored
      Removed SHOW BINLOG EVENTS in test case for ps-protocol and row-based replication
      
      
      client/mysqltest.c:
        WL#2067: Added if(...) construct to mysqltest
      mysql-test/include/rpl_stmt_seq.inc:
        Removed SHOW BINLOG EVENTS in test case for ps-protocol and row-based replication
      mysql-test/r/rpl_ddl.result:
        Removed SHOW BINLOG EVENTS in test case for ps-protocol and row-based replication
      mysql-test/t/rpl_ddl.test:
        Comment
      28ffe95a
    • unknown's avatar
      Merge serg@bk-internal.mysql.com:/home/bk/mysql-4.1/ · fbf01ca7
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.1
      
      fbf01ca7
    • unknown's avatar
      for consictency, changed to use memcpy_fixed. · ee3a9206
      unknown authored
      ee3a9206
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/4.1/main · c9eea5c3
      unknown authored
      into mysql.com:/home/stewart/Documents/MySQL/4.1/bug11132
      
      c9eea5c3
    • unknown's avatar
      fix test results - Bug #11328 · a2121e0f
      unknown authored
      
      mysql-test/r/bdb_cache.result:
        fix test results
      mysql-test/t/bdb_cache.test:
        fix test results
      a2121e0f
  4. 15 Jun, 2005 2 commits
    • unknown's avatar
      cleanup for bug#11167. · 75927a95
      unknown authored
      portability alignment issues.
      
      75927a95
    • unknown's avatar
      BUG#11132 Connections stuck in CLOSE_WAIT · c02bb8de
      unknown authored
      In 4.1 (it is different in 5.0), we do not use the mgm connection after fetching the
      configuration (and if we did, we would have to have calls to check the connection and
      reconnect if needed - in case the mgm server had restarted) so we can disconnect after
      first use.
      
      This means we won't have connections stuck in CLOSE_WAIT when the mgm server shuts down.
      
      
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        Disconnect from management server after configuration is fetched.
      c02bb8de
  5. 14 Jun, 2005 1 commit
  6. 13 Jun, 2005 12 commits
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · bb93e5f6
      unknown authored
      into dl145c.mysql.com:/home/ndbdev/tomas/mysql-4.1
      
      bb93e5f6
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · fbeb7678
      unknown authored
      into dl145c.mysql.com:/home/ndbdev/tomas/mysql-4.1
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      fbeb7678
    • unknown's avatar
      func_if.result, func_if.test: · 9a639503
      unknown authored
        Correction for test case of bug #11142.
      
      
      mysql-test/t/func_if.test:
        Correction for test case of bug #11142.
      mysql-test/r/func_if.result:
        Correction for test case of bug #11142.
      9a639503
    • unknown's avatar
      func_if.result, func_if.test: · b5aae700
      unknown authored
        Added a test case for bug #11142.
      item_cmpfunc.cc:
        Fixed bug #11142.
        Implementation of Item_func_nullif::is_null was corrected.
      
      
      sql/item_cmpfunc.cc:
        Fixed bug #11142.
        Implementation of Item_func_nullif::is_null was corrected.
      mysql-test/t/func_if.test:
        Added a test case for bug #11142.
      mysql-test/r/func_if.result:
        Added a test case for bug #11142.
      b5aae700
    • unknown's avatar
      logging_ok: · fa405f97
      unknown authored
        Logging to logging@openlogging.org accepted
      DbtcMain.cpp, testTimeout.cpp:
        Bug  #11290 TransactionInactiveTimeout = 0 does not result in infinite timeout
      
      
      ndb/test/ndbapi/testTimeout.cpp:
        Bug  #11290 TransactionInactiveTimeout = 0 does not result in infinite timeout
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Bug  #11290 TransactionInactiveTimeout = 0 does not result in infinite timeout
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      fa405f97
    • unknown's avatar
      Merge igor-inspiron.creware.com:/home/igor/mysql-4.1 · efe487ba
      unknown authored
      into igor-inspiron.creware.com:/home/igor/dev/mysql-4.1-0
      
      efe487ba
    • unknown's avatar
      ndb - valgrind fixes · d74e2193
      unknown authored
      
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        valgrind fixes
      ndb/test/ndbapi/testBlobs.cpp:
        valgrind fixes
      d74e2193
    • unknown's avatar
      ctype_utf8.test, ctype_utf8.result: · f56681be
      unknown authored
        Added a test case for bug #11167.
      sql_select.cc:
        Fixed bug #11167.
        In 4.1 char/varchar fields are limited by 255 characters in
        length that make them longer than 255 bytes in size for such
        character sets as UTF8. The functions store_record_in_cache
        and read_cached_records did not take into account this
        Moreover the code did not take into account that the size
        of the varchar fields in 5.0 can be up to 65535 bytes
      
      
      sql/sql_select.cc:
        Fixed bug #11167.
        In 4.1 char/varchar fields are limited by 255 characters in
        length that make them longer than 255 bytes in size for such
        character sets as UTF8. The functions store_record_in_cache
        and read_cached_records did not take into account this
        Moreover the code did not take into account that the size
        of the varchar fields in 5.0 can be up to 65535 bytes
      mysql-test/r/ctype_utf8.result:
        Added a test case for bug #11167.
      mysql-test/t/ctype_utf8.test:
        Added a test case for bug #11167.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      f56681be
    • unknown's avatar
      Merge mysql.com:/home/bkroot/mysql-4.1 · a4235b64
      unknown authored
      into mysql.com:/home/bk/b6883-mysql-4.1
      
      a4235b64
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-4.1 · 7222dbd6
      unknown authored
      into mysql.com:/home/jonas/src/mysql-4.1-push
      
      7222dbd6
    • unknown's avatar
      Merge mysql.com:/home/jonas/src/mysql-4.1 · c2f68ecc
      unknown authored
      into mysql.com:/home/jonas/src/mysql-4.1-push
      
      c2f68ecc
    • unknown's avatar
      bug#10294 - ndb restore with #concurrent transactions < parallelism · d07b915a
      unknown authored
        Enable retry on startTransaction
      
      
      ndb/tools/restore/consumer_restore.cpp:
        Enable retry on startTransaction==NULL
      d07b915a
  7. 10 Jun, 2005 11 commits
  8. 09 Jun, 2005 5 commits