1. 18 Mar, 2022 6 commits
    • mkaruza's avatar
      MDEV-27713 Crash after a conflict of applier thread with stored procedure call by event scheduler · 507030c4
      mkaruza authored
      When thread is BF aborted by high priority service, ULL (user level
      locks need to be removed and released). Calling directly release of lock for
      MDL_EXPLICIT type doesn't clear also `thd->ull_hash`. Method
      `mysql_ull_cleanup` will properly clear all information about ULL locks
      for thread.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      507030c4
    • mkaruza's avatar
      MDEV-27568 Parallel async replication hangs on a Galera node · 304f75c9
      mkaruza authored
      Using parallel slave applying can cause deadlock between between DDL and
      other events. GTID with lower seqno can be blocked in galera when node
      entered TOI mode, but DDL GTID which has higher node can be blocked
      before previous GTIDs are applied locally.
      
      Fix is to check prior commits before entering TOI.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      304f75c9
    • Daniele Sciascia's avatar
      MDEV-28055: Galera ps-protocol fixes · c63eab2c
      Daniele Sciascia authored
      * Fix test galera.MW-44 to make it work with --ps-protocol
      * Skip test galera.MW-328C under --ps-protocol This test
        relies on wsrep_retry_autocommit, which has no effect
        under ps-protocol.
      * Return WSREP related errors on COM_STMT_PREPARE commands
        Change wsrep_command_no_result() to allow sending back errors
        when a statement is prepared. For example, to handle deadlock
        error due to BF aborted transaction during prepare.
      * Add sync waiting before statement prepare
        When a statement is prepared, tables used in the statement may be
        opened and checked for existence. Because of that, some tests (for
        example galera_create_table_as_select) that CREATE a table in one node
        and then SELECT from the same table in another node may result in errors
        due to non existing table.
        To make tests behave similarly under normal and PS protocol, we add a
        call to sync wait before preparing statements that would sync wait
        during normal execution.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      c63eab2c
    • Daniele Sciascia's avatar
      Fixup for MDEV-27553 · 39ed4005
      Daniele Sciascia authored
      Update wsrep-lib which contains a fixup introduced with MDEV-27553.
      Also, adapt the corresponding test: after apply failure on ROLLBACK,
      node will disconnect from cluster
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      39ed4005
    • sjaakola's avatar
      MDEV-27649 PS conflict handling causing node crash · 97582f1c
      sjaakola authored
      Handling BF abort for prepared statement execution so that EXECUTE processing will continue
      until parameter setup is complete, before BF abort bails out the statement execution.
      
      THD class has new boolean member: wsrep_delayed_BF_abort, which is set if BF abort is observed
      in do_command() right after reading client's packet, and if the client has sent PS execute command.
      In such case, the deadlock error is not returned immediately back to client, but the PS execution
      will be started. However, the PS execution loop, will now check if wsrep_delayed_BF_abort is set, and
      stop the PS execution after the type information has been assigned for the PS.
      With this, the PS protocol type information, which is present in the first PS EXECUTE command, is not lost
      even if the first PS EXECUTE command was marked to abort.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      97582f1c
    • sjaakola's avatar
      MDEV-27649 Crash with PS execute after BF abort · 8e9e1c39
      sjaakola authored
      This commit contains a test for reproducing the issue in MDEV-27649,
      where a transaction, executing a prepared statment, is BF aborted.
      The scenario, in MDEV-27649  has a transaction which has prepared a PS,
      but not yet executed it, and this transaction is then BF aborted in this state.
      When the BF aborted transaction tries to execute the PS, it will receive deadlock error.
      But, when it tries to execute the PS second time, the node crashes.
      
      Mtr test galera.galera_bf_abort_ps_bind, exercises this scenario.
      
      However, mtr test platform does not have mechanism to control the execution of PS in required detail.
      For this purpose, mysqltetst.cc was extended to contain 4 new commands:
      PS_prepare   - to prepare a prepared statement
      PS_bind      - to bind values for parameters for the PS
      PS_execute   - to execute the PS
      PS_close     - to close the PS
      
      The support for controlling prepared statments in mtr scripts is quite minimal
      in this commit. Limitations are:
      * only one PS can be used by a connection, at a time
      * only input parameters can be bound for the PS
      * only varchar, integer or float type of parameters can be bound
      
      added the result
      
      fixes
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      8e9e1c39
  2. 16 Mar, 2022 3 commits
  3. 15 Mar, 2022 4 commits
    • Daniel Black's avatar
      MDEV-23915 ER_KILL_DENIED_ERROR not passed a thread id (part 2) · 57dbe878
      Daniel Black authored
      Per Marko's comment in JIRA, sql_kill is passing the thread id
      as long long. We change the format of the error messages to match,
      and cast the thread id to long long in sql_kill_user.
      57dbe878
    • Daniel Black's avatar
      MDEV-23915 ER_KILL_DENIED_ERROR not passed a thread id · 99837c61
      Daniel Black authored
      The 10.5 test error main.grant_kill showed up a incorrect
      thread id on a big endian architecture.
      
      The cause of this is the sql_kill_user function assumed the
      error was ER_OUT_OF_RESOURCES, when the the actual error was
      ER_KILL_DENIED_ERROR. ER_KILL_DENIED_ERROR as an error message
      requires a thread id to be passed as unsigned long, however a
      user/host was passed.
      
      ER_OUT_OF_RESOURCES doesn't even take a user/host, despite
      the optimistic comment. We remove this being passed as an
      argument to the function so that when MDEV-21978 is implemented
      one less compiler format warning is generated (which would
      have caught this error sooner).
      
      Thanks Otto for reporting and Marko for analysis.
      99837c61
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 9c6135e8
      Marko Mäkelä authored
      9c6135e8
    • Daniel Black's avatar
      Merge 10.2 (part) into 10.3 · a9500860
      Daniel Black authored
      commit '6de482a6'
      
      10.3 no longer errors in truncate_notembedded.test
      but per comments, a non-crash is all that we are after.
      a9500860
  4. 14 Mar, 2022 4 commits
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-28060 Online DDL fails while checking for instant alter condition · 1c43660a
      Thirunarayanan Balathandayuthapani authored
      - InnoDB fails to skip newly created column while checking for
      change column when table is in redundant row format. This issue
      is caused the MDEV-18035 (ccb1acbd)
      1c43660a
    • Alexander Barkov's avatar
      MDEV-23210 Assertion `(length % 4) == 0' failed in my_lengthsp_utf32 on ALTER... · 03c3dc63
      Alexander Barkov authored
      MDEV-23210 Assertion `(length % 4) == 0' failed in my_lengthsp_utf32 on ALTER TABLE, SELECT and INSERT
      
      Problem:
      Parse-time conversion from binary to tricky character sets like utf32
      produced ill-formed strings. So, later a chash happened in debug builds,
      or a wrong SHOW CREATE TABLE was returned in release builds.
      
      Fix:
      
      1. Backporting a few methods from 10.3:
        - THD::check_string_for_wellformedness()
        - THD::convert_string() overloads
        - THD::make_text_string_connection()
      
      2. Adding a new method THD::reinterpret_string_from_binary(),
         which makes sure to either returns a well-formed string
         (optionally prepending with zero bytes), or returns an error.
      03c3dc63
    • Sergei Golubchik's avatar
      mtr: fix --source lines detection · f217c761
      Sergei Golubchik authored
      mysqltest allows leading spaces before `--`, so mtr should too
      f217c761
    • Sergei Golubchik's avatar
      MDEV-27753 Incorrect ENGINE type of table after crash for CONNECT table · bfed2c7d
      Sergei Golubchik authored
      whenever possible, partitioning should use the full
      partition plugin name, not the one byte legacy code.
      
      Normally, ha_partition can get the engine plugin from
      table_share->default_part_plugin.
      
      But in some cases, e.g. in DROP TABLE, the table isn't
      opened, table_share is NULL, and ha_partition has to parse
      the frm, much like dd_frm_type() does.
      
      temporary_tables.cc, sql_table.cc:
      
      When dropping a table, it must be deleted in the engine
      first, then frm file. Because frm can be the only true
      source of metadata that the engine might need for DROP.
      
      table.cc:
      
      when opening a partitioned table, if the engine for
      partitions is not found, do not fallback to MyISAM.
      bfed2c7d
  5. 13 Mar, 2022 1 commit
  6. 12 Mar, 2022 1 commit
  7. 11 Mar, 2022 4 commits
  8. 10 Mar, 2022 5 commits
    • Marko Mäkelä's avatar
      77c184df
    • Vlad Lesin's avatar
      MDEV-19577 Replication does not work with innodb_autoinc_lock_mode=2 · 1766a18e
      Vlad Lesin authored
      The first step for deprecating innodb_autoinc_lock_mode(see MDEV-27844) is:
      - to switch statement binlog format to ROW if binlog format is MIXED and
      the statement changes autoincremented fields
      - issue warnings if innodb_autoinc_lock_mode == 2 and binlog format is
      STATEMENT
      1766a18e
    • Andrei's avatar
      MDEV-24617 OPTIMIZE on a sequence causes unexpected ER_BINLOG_UNSAFE_STATEMENT · e7cf871d
      Andrei authored
      The warning out of OPTIMIZE
        Statement is unsafe because it uses a system function
      was indeed counterfactual and was resulted by checking an
      insufficiently strict property of lex' sql_command_flags.
      
      Fixed with deploying an additional checking of weather
      the current sql command that modifes a share->non_determinstic_insert
      table is capable of generating ROW format events.
      The extra check rules out the unsafety to OPTIMIZE et al, while the
      existing check continues to do so to CREATE TABLE (which is
      perculiarly tagged as ROW-event generative sql command).
      
      As a side effect sql_sequence.binlog test gets corrected and
      binlog_stm_unsafe_warning.test is reinforced to add up
      an unsafe CREATE..SELECT test.
      e7cf871d
    • Daniel Black's avatar
      MDEV-28011: debian autobake cleanup · 6de482a6
      Daniel Black authored
      Travis is dead to us so we don't need all the conditions around it.
      
      Remove depends for no longer supported versions
      
      Debian Jessies, and Ubuntu Trusty, Xenial, Wily are all eol
      as far as we are concerned.
      
      The dependancy on an apt cache when running autobake broke the
      10.2 aarch64 packages (MDEV-28014). Lets reduce the risk here.
      6de482a6
    • Daniel Black's avatar
      MDEV-28022: Debian stretch has zstd too old · 8ea08505
      Daniel Black authored
      zstd-1.1.3 is needed however stretch has only 1.1.2.
      
      Move to distro version based checks as checks against the
      apt-cache are unreliable if there is no cache.
      8ea08505
  9. 08 Mar, 2022 1 commit
    • Haidong Ji's avatar
      MDEV-27978 fix wrong name in error when max_session_mem_used exceeded · 114476f2
      Haidong Ji authored
      Fixed typo in my_malloc_size_cb_func. There is no max-thread-mem-used
      sys variable in MariaDB, only max-session-mem-used. The relevant entry
      in sys_vars.cc is also fixed.
      
      Added a fallback case in case we could allocate the 256 bytes for the
      error message containing the exact setting.
      114476f2
  10. 07 Mar, 2022 3 commits
  11. 04 Mar, 2022 3 commits
  12. 03 Mar, 2022 2 commits
  13. 01 Mar, 2022 3 commits