1. 17 Apr, 2007 1 commit
    • unknown's avatar
      Fix for bug #27515: DROP previlege is not required anymore for RENAME TABLE · 50e15840
      unknown authored
      Added missed DROP privilege check on the original table for RENAME TABLE command.
      
      
      mysql-test/r/grant.result:
        Fix for bug #27515: DROP previlege is not required anymore for RENAME TABLE
          - test result.
      mysql-test/t/grant.test:
        Fix for bug #27515: DROP previlege is not required anymore for RENAME TABLE
          - test case.
      sql/sql_parse.cc:
        Fix for bug #27515: DROP previlege is not required anymore for RENAME TABLE
          - added DROP privilege check on the original table for RENAME TABLE command.
      50e15840
  2. 10 Apr, 2007 7 commits
  3. 07 Apr, 2007 1 commit
  4. 05 Apr, 2007 2 commits
  5. 04 Apr, 2007 4 commits
  6. 03 Apr, 2007 1 commit
    • unknown's avatar
      Fixed bug #27532: wrong results with ORDER/GROUP BY queries containing · 0ee34b1c
      unknown authored
      IN/BETWEEN predicates in sorting expressions.
      Wrong results may occur when the select list contains an expression
      with IN/BETWEEN predicate that differs from a sorting expression by
      an additional NOT only.
       
      Added the method Item_func_opt_neg::eq to compare correctly expressions
      containing [NOT] IN/BETWEEN.
      The eq method inherited from the Item_func returns TRUE when comparing
      'a IN (1,2)' with 'a NOT IN (1,2)' that is not, of course, correct.  
      
      
      mysql-test/r/order_by.result:
        Added a test case for bug #27532.
      mysql-test/t/order_by.test:
        Added a test case for bug #27532.
      sql/item_cmpfunc.cc:
        Fixed bug #27532.
        Added the method Item_func_opt_neg::eq to compare correctly expressions
        containing [NOT] IN/BETWEEN.
        The eq method inherited from the Item_func returns TRUE when comparing
        'a IN (1,2)' with 'a NOT IN (1,2)' that is not, of course, correct.
      sql/item_cmpfunc.h:
        Added the method Item_func_opt_neg::eq to compare correctly expressions
        containing [NOT] IN/BETWEEN.
        The eq method inherited from the Item_func returns TRUE when comparing
        'a IN (1,2)' with 'a NOT IN (1,2)' that is not, of course, correct.
      0ee34b1c
  7. 02 Apr, 2007 2 commits
  8. 31 Mar, 2007 1 commit
  9. 30 Mar, 2007 2 commits
    • unknown's avatar
      BUG#26624: high mem usage (crash) in range optimizer · 080c0c7a
      unknown authored
      Pushbuild fixes: 
       - Make MAX_SEL_ARGS smaller (even 16K records_in_range() calls is 
         more than it makes sense to do in typical cases)
       - Don't call sel_arg->test_use_count() if we've already allocated 
         more than MAX_SEL_ARGs elements. The test will succeed but will take
         too much time for the test suite (and not provide much value).
      
      
      mysql-test/r/range.result:
        BUG#26624: high mem usage (crash) in range optimizer
        Pushbuild fixes: make the test go faster
      mysql-test/t/range.test:
        BUG#26624: high mem usage (crash) in range optimizer
        Pushbuild fixes: make the test go faster
      080c0c7a
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · ade8bbf4
      unknown authored
      into  mysql.com:/home/kent/bk/tmp/mysql-4.1-build
      
      
      ade8bbf4
  10. 29 Mar, 2007 4 commits
  11. 28 Mar, 2007 10 commits
    • unknown's avatar
      Bug #26642: create index corrupts table definition in .frm · 0b72b7f0
      unknown authored
      Thanks to Martin Friebe for finding and submitting a fix for this bug!
      
      A table with maximum number of key segments and maximum length key name
      would have a corrupted .frm file, due to an incorrect calculation of the
      complete key length.  Now the key length is computed correctly (I hope) :-)
      
      MyISAM would reject a table with the maximum number of keys and the maximum
      number of key segments in all keys.  It would allow one less than this total
      maximum.  Now MyISAM accepts a table defined with the maximum.  (This is a
      very minor issue.)
      
      
      myisam/mi_open.c:
        change >= to > in a comparison (i.e., error only if key_parts_in_table
        really is greater than MAX_KEY * MAX_KEY_SEG)
      mysql-test/r/create.result:
        Add test results for bug #26642 (create index corrupts table definition in .frm)
      mysql-test/t/create.test:
        Add test case for bug #26642 (create index corrupts table definition in .frm)
      sql/table.cc:
        In create_frm(), fix formula for key_length; it was too small by (keys * 2) bytes
      0b72b7f0
    • unknown's avatar
      Merge mysql.com:/home/psergey/mysql-4.1-bug26625 · edd5a859
      unknown authored
      into  mysql.com:/home/psergey/mysql-4.1-bug26624-r2
      
      
      edd5a859
    • unknown's avatar
      BUG#26624: high mem usage (crash) in range optimizer · 9639eb3d
      unknown authored
      - Added PARAM::alloced_sel_args where we count the # of SEL_ARGs
        created by SEL_ARG tree cloning operations.
      - Made the range analyzer to shortcut and not do any more cloning 
        if we've already created MAX_SEL_ARGS SEL_ARG objects in cloning.
      - Added comments about space complexity of SEL_ARG-graph 
        representation.
      
      
      mysql-test/r/range.result:
        BUG#26624: Testcase
      mysql-test/t/range.test:
        BUG#26624: Testcase
      9639eb3d
    • unknown's avatar
      Delete: sql/mysqld.cc.rej · 60189d35
      unknown authored
      60189d35
    • unknown's avatar
      BUG#26625: crash in range optimizer (out of mem) · 425304f5
      unknown authored
      - Define Sql_alloc::operator new() as thow() so that C++ compiler
        handles NULL return values
      (there is no testcase as there is no portable way to set limit on the 
      amount of memory that a process can allocate)
      
      
      sql/sql_list.h:
        BUG#26625: crash in range optimizer (out of mem) 
        - Define Sql_alloc::operator new() as thow() so that C++ compiler
          handles NULL return values
      425304f5
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1--main · f6eca60a
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1-axmrg
      
      
      f6eca60a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · cd07f122
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1-axmrg
      
      
      cd07f122
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1--team · 17a4df42
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1-axmrg
      
      
      sql/ha_myisam.cc:
        Auto merged
      17a4df42
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-bug26231 · 30bf8b69
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1-axmrg
      
      
      30bf8b69
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1-engines · fd3b7235
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1-bug24985
      
      
      mysql-test/r/heap_btree.result:
        Bug#24985 - UTF8 ENUM primary key on MEMORY using BTREE
                    causes incorrect duplicate entries
        Manual merge
      mysql-test/t/heap_btree.test:
        Bug#24985 - UTF8 ENUM primary key on MEMORY using BTREE
                    causes incorrect duplicate entries
        Manual merge
      fd3b7235
  12. 27 Mar, 2007 2 commits
    • unknown's avatar
      mysql.spec.sh, Makefile.am: · 0d5a969a
      unknown authored
        Don't use explicit calls to mysql-test-run in spec
      
      
      Makefile.am:
        Don't use explicit calls to mysql-test-run in spec
      support-files/mysql.spec.sh:
        Don't use explicit calls to mysql-test-run in spec
      0d5a969a
    • unknown's avatar
      Bug#24985 - UTF8 ENUM primary key on MEMORY using BTREE · 1fd0ba89
      unknown authored
                  causes incorrect duplicate entries
      
      Keys for BTREE indexes on ENUM and SET columns of MEMORY tables
      with character set UTF8 were computed incorrectly. Many
      different column values got the same key value.
      
      Apart of possible performance problems, it made unique indexes
      of this type unusable because it rejected many different
      values as duplicates.
      
      The problem was that multibyte character detection was tried
      on the internal numeric column value. Many values were not
      identified as characters. Their key value became blank filled.
      
      Thanks to Alexander Barkov and Ramil Kalimullin for the patch,
      which sets the character set of ENUM and SET key segments to
      the pseudo binary character set.
      
      
      mysql-test/r/heap_btree.result:
        Bug#24985 - UTF8 ENUM primary key on MEMORY using BTREE
                    causes incorrect duplicate entries
        Added test result.
      mysql-test/t/heap_btree.test:
        Bug#24985 - UTF8 ENUM primary key on MEMORY using BTREE
                    causes incorrect duplicate entries
        Added test.
      sql/ha_heap.cc:
        Bug#24985 - UTF8 ENUM primary key on MEMORY using BTREE
                    causes incorrect duplicate entries
        Set key segment charset to my_charset_bin for ENUM and SET
        columns.
      1fd0ba89
  13. 26 Mar, 2007 2 commits
    • unknown's avatar
      Bug #27164: not reseting the data pointer · 3335f68d
      unknown authored
       to 0 causes wrong (large) length to be read
       from the row in _mi_calc_blob_length() when 
       storing NULL values in (e.g) POINT columns.
       This large length is then used to allocate
       a block of memory that (on some OSes) causes
       trouble.
       Fixed by calling the base class's 
       Field_blob::reset() from Field_geom::reset()
       that is called when storing a NULL value into
       the column.
      
      
      mysql-test/r/gis.result:
        Bug #27164: test case
      mysql-test/t/gis.test:
        Bug #27164: test case
      sql/field.h:
        Bug #27164: not reseting the data pointer
         to 0 causes wrong (large) length to be read
         from the row in _mi_calc_blob_length() when 
         storing NULL values in (e.g) POINT columns.
         This large length is then used to allocate
         a block of memory that (on some OSes) causes
         trouble.
      3335f68d
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1-maint · e77cdbe2
      unknown authored
      into  mysql.com:/home/ram/work/b25301/b25301.4.1
      
      
      sql-common/my_time.c:
        Auto merged
      e77cdbe2
  14. 25 Mar, 2007 1 commit