1. 28 Feb, 2022 1 commit
  2. 25 Feb, 2022 5 commits
  3. 24 Feb, 2022 1 commit
  4. 23 Feb, 2022 2 commits
    • Julius Goryavsky's avatar
      MDEV-26377: Stricter validation of ssl-mode values · a3da3c8a
      Julius Goryavsky authored
      This commit adds validation of the values of the ssl-mode parameter
      in SSL scripts, since now only a basic check for the presence of the
      "VERIFY_" prefix is performed there to detect "VERIFY_IDENTITY" and
      "VERIFY_CA", but all other values are not checked at all.
      
      In addition, this commit removes leading and trailing spaces from
      parameter values that SST scripts read from configuration files or
      from the command line so that they do not interfere with parameter
      checks and substitutions. Parameter substitution has been made more
      robust against characters in strings that the shell might erroneously
      interpret as regexp.
      a3da3c8a
    • Marko Mäkelä's avatar
      MDEV-23888 fixup: GCC 12 -Wunused-value · 8b7abe21
      Marko Mäkelä authored
      8b7abe21
  5. 22 Feb, 2022 5 commits
    • Julius Goryavsky's avatar
      MDEV-27777: Some Galera tests fail on FreeBSD · fac9224d
      Julius Goryavsky authored
      This commit fixes problems due to bugs and quirks in bsdtar
      (the FreeBSD version of tar). Separate tests are not required,
      because without these fixes, many other tests fail when tested
      in the FreeBSD environment.
      
      Also, the grep patterns for reading utility version numbers
      has been made more robust. The notation of some options of
      the "cut" utility has been changed.
      fac9224d
    • Julius Goryavsky's avatar
      MDEV-27524: Incorrect binlogs after Galera SST using rsync and mariabackup · 17e0f522
      Julius Goryavsky authored
      This commit adds correct handling of binlogs for SST using rsync
      or mariabackup. Before this fix, binlogs were handled incorrectly -
      - only one (last) binary log file was transferred during SST, which
      then led to various failures (for example, when trying to list all
      events from the binary log). These bugs were long masked by flaws
      in the primitive binlogs handling code in the SST scripts, which
      causing binary logs files to be erased after transfer or not added
      to the binlog index on the joiner node. Now the correct transfer
      of all binary logs (not just the last of the binary log files) has
      been implemented both for the rsync (at the script level) and for
      the mariabackup (at the level of the main utility code).
      
      This commit also adds a new sst_max_binlogs=<n> parameter, which
      can be located in the [sst] section or in the [xtrabackup] section
      (historically, supported for mariabackup only, not for rsync), or
      in one of the server sections. This parameter specifies the number
      of binary log files to be sent to the joiner node during SST. This
      option is added for compatibility with old SST scripting behavior,
      which can be emulated by setting the sst_max_binlogs=1 (although
      in general this can cause problems for the reasons described above).
      In addition, setting the sst_max_binlogs=0 can be used to suppress
      the transmission of binary logs to the joiner nodes during SST
      (although sometimes a single file with the current binary log can
      still be transmitted to the joiner, even with sst_max_binlogs=0,
      because this sometimes necessary in modes that involve the use of
      GTIDs with Galera).
      
      Also, this commit ensures correct handling of paths to various
      innodb files and directories in the SST scripts, and fixes some
      problems with this that existed in mariabackup utility (which
      were associated with incorrect handling of the innodb_data_dir
      parameter in some scenarios).
      
      In addition, this commit contains the following enhancements:
      
       1) Added tests for mtr, which check the correct work with binlogs
          after SST (using rsync and mariabackup);
       2) Added correct handling of slashes at the end of all paths that
          the SST script receives as parameters;
       3) Improved parsing code for --mysqld-args parameters. Now it
          correctly processes the sequence "--" after the name of the
          one-letter option;
       4) Checking the secret signature during joiner authentication
          is made independent of presence of bash (as a unix shell)
          in the system and diff utility no longer needed to check
          certificates compliance;
       5) All directories that are necessary for the correct placement
          of various logs are automatically created by SST scripts in
          advance (before running mariabackup on the joiner node);
       6) Removal of old binary logs on joiner is done using the binlog
          index (if it exists) (not only by fixed pattern that based
          on the current binlog name, as before);
       7) Paths for placing binary logs are correctly processed if they
          are set as relative paths (to the datadir);
       8) SST scripts are made even more resistant to spaces in filenames
          (now for binlogs);
       9) In case of failure, SST scripts now always end with an exit
          code other than zero;
      10) SST script for rsync now correctly create a tar file with
          the binlogs, even if the paths to them (in the binlog index
          file) are specified as a mix of absolute and relative paths,
          and even if they do not match with the datadir path specified
          in the current configuration settings.
      17e0f522
    • Julius Goryavsky's avatar
    • Julius Goryavsky's avatar
      MDEV-27534: mariabackup: missing line in the compress_qpress.result · c753b3f6
      Julius Goryavsky authored
      This commit adds the missing line to the .result file for compress_qpress
      (in the mariabackup test suite).
      c753b3f6
    • Varun Gupta's avatar
      MDEV-15208: server crashed, when using ORDER BY with window function and UNION · 647e9523
      Varun Gupta authored
      (Edits by SergeiP: fix encryption.tempfiles_encrypted, re-word comment)
      
      Global ORDER BY clause of a UNION may not refer to 1) aggregate functions
      or 2) window functions.  setup_order() checked for #1 but not for #2.
      647e9523
  6. 21 Feb, 2022 5 commits
    • Varun Gupta's avatar
      MDEV-15208: server crashed, when using ORDER BY with window function and UNION · 942a9791
      Varun Gupta authored
      SELECTs inside a UNION can have window function but not the global ORDER BY clause of the UNION.
      942a9791
    • Sergei Petrunia's avatar
      MDEV-22377: Subquery in an UPDATE query uses full scan instead of range · d140d276
      Sergei Petrunia authored
      [Patch idea by Igor Babaev]
      
      Symptom: for IN (SELECT ...) subqueries using IN-to-EXISTS transformation,
      the optimizer was unable to make inferences using multiple equalities.
      
      The cause is code Item_in_subselect::inject_in_to_exists_cond() which may
      break invariants that Multiple-Equality code relies on. In particular, it
      may produce a WHERE condition with an empty Item_cond::m_cond_equal.
      
      Fixed this by making Item_cond::m_cond_equal.
      d140d276
    • Vlad Lesin's avatar
      MDEV-20605 Awaken transaction can miss inserted by other transaction records... · a6f258e4
      Vlad Lesin authored
      MDEV-20605 Awaken transaction can miss inserted by other transaction records due to wrong persistent cursor restoration
      
      Backported from 10.5 20e9e804 and
      5948d760.
      
      sel_restore_position_for_mysql() moves forward persistent cursor
      position after btr_pcur_restore_position() call if cursor relative position
      is BTR_PCUR_ON and the cursor points to the record with NOT the same field
      values as in a stored record(and some other not important for this case
      conditions).
      
      It was done because btr_pcur_restore_position() sets
      page_cur_mode_t mode  to PAGE_CUR_LE for cursor->rel_pos ==  BTR_PCUR_ON
      before opening cursor. So we are searching for the record less or equal
      to stored one. And if the found record is not equal to stored one, then
      it is less and we need to move cursor forward.
      
      But there can be a situation when the stored record was purged, but the
      new one with the same key but different value was inserted while
      row_search_mvcc() was suspended. In this case, when the thread is
      awaken, it will invoke sel_restore_position_for_mysql(), which, in turns,
      invoke btr_pcur_restore_position(), which will return false because found
      record don't match stored record, and
      sel_restore_position_for_mysql() will move forward cursor position.
      
      The above can lead to the case when awaken row_search_mvcc() do not see
      records inserted by other transactions while it slept. The mtr test case
      shows the example how it can be.
      
      The fix is to return special value from persistent cursor restoring
      function which would notify its caller that uniq fields of restored
      record and stored record are the same, and in this case
      sel_restore_position_for_mysql() don't move cursor forward.
      
      Delete-marked records are correctly processed in row_search_mvcc().
      Non-unique secondary indexes are "uniquified" by adding the PK, the
      index->n_uniq should then be index->n_fields. So there is no need in
      additional checks in the fix.
      
      If transaction's readview can't see the changes made in secondary index
      record, it requests clustered index record in row_search_mvcc() to check
      its transaction id and get the correspondent record version. After this
      row_search_mvcc() commits mtr to preserve clustered index latching
      order, and starts mtr. Between those mtr commit and start secondary
      index pages are unlatched, and purge has the ability to remove stored in
      the cursor record, what causes rows duplication in result set for
      non-locking reads, as cursor position is restored to the previously
      visited record.
      
      To solve this the changes are just switched off for non-locking reads,
      it's quite simple solution, besides the changes don't make sense for
      non-locking reads.
      
      The more complex and effective from performance perspective solution is
      to create mtr savepoint before clustered record requesting and rolling
      back to that savepoint after that. See MDEV-27557.
      
      One more solution is to have per-record transaction id for secondary
      indexes. See MDEV-17598.
      
      If any of those is implemented, just remove select_lock_type argument in
      sel_restore_position_for_mysql().
      a6f258e4
    • Marko Mäkelä's avatar
      MDEV-27550: Disable galera.MW-328D · b9ee26e9
      Marko Mäkelä authored
      (cherry picked from commit 66465914)
      b9ee26e9
    • Vlad Lesin's avatar
      MDEV-27025 insert-intention lock conflicts with waiting ORDINARY lock · 5f001bd7
      Vlad Lesin authored
      The code was backported from 10.5 be811386
      commit. See that commit message for details.
      5f001bd7
  7. 20 Feb, 2022 1 commit
  8. 18 Feb, 2022 1 commit
    • Nayuta Yanagisawa's avatar
      MDEV-27730 Add PLUGIN_VAR_DEPRECATED flag to plugin variables · 66f55a01
      Nayuta Yanagisawa authored
      The sys_var class has the deprecation_substitute member to mark the
      deprecated variables. As it's set, the server produces warnings when
      these variables are used. However, the plugin has no means to utilize
      that functionality.
      
      So, the PLUGIN_VAR_DEPRECATED flag is introduced to set the
      deprecation_substitute with the empty string. A non-empty string can
      make the warning more informative, but there's no nice way seen to
      specify it, and not that needed at the moment.
      66f55a01
  9. 17 Feb, 2022 5 commits
  10. 16 Feb, 2022 4 commits
    • forkfun's avatar
    • Monty's avatar
      MDEV-17223 Assertion `thd->killed != 0' failed in ha_maria::enable_indexes · 0a92ef45
      Monty authored
      MDEV-22500 Assertion `thd->killed != 0' failed in ha_maria::enable_indexes
      
      For MDEV-17223 the issue was an assert that didn't take into account that
      we could get duplicate key errors when enablling unique indexes.
      Fixed by not retrying repair in case of duplicate key error for this
      case, which avoids the assert.
      
      For MDEV-22500 I removed the assert, as it's not critical (just a way to
      find potential wrong code) and we will anyway get things logged in the
      error log if this happens. This case cannot triggered an assert in 10.3
      but I verified that it would trigger in 10.5 and that this patch fixes
      it.
      0a92ef45
    • Marko Mäkelä's avatar
      MDEV-27634 innodb_zip tests failing on s390x · cf574cf5
      Marko Mäkelä authored
      Some GNU/Linux distributions ship a zlib that is modified to use
      the s390x DFLTCC instruction. That modification would essentially
      redefine compressBound(sourceLen) as (sourceLen * 16 + 2308) / 8 + 6.
      
      Let us relax the tests for InnoDB ROW_FORMAT=COMPRESSED to cope with
      such a weaker compression guarantee.
      
      create_table_info_t::row_size_is_acceptable(): Remove a bogus debug-only
      assertion that would fail to hold for the test innodb_zip.bug36169.
      The function page_zip_empty_size() may indeed return 0.
      cf574cf5
    • Lena Startseva's avatar
      MDEV-27691: make working view-protocol · 6c3f1f66
      Lena Startseva authored
      Added ability to disable/enable (--disable_view_protocol/--enable_view_protocol) view-protocol in tests.
      When the  option "--disable_view_protocol" is used  util connections are closed.
      Added new test for checking view-protocol
      6c3f1f66
  11. 15 Feb, 2022 2 commits
    • Brandon Nesterenko's avatar
      MDEV-16091: Seconds_Behind_Master spikes to millions of seconds · cdf19cd6
      Brandon Nesterenko authored
      The rpl.rpl_seconds_behind_master_spike test would sometimes
      timeout or take a very long time to complete. This happened
      because an MTR DEBUG_SYNC signal would be lost due to a
      subsequent call to RESET. I.e., the slave SQL thread would
      be paused due to the WAIT_FOR signal being lost, resulting in
      either a failed test if the `select master_pos_wait` timeout
      occurs first, or a very long run-time if the DBUG_SYNC timeout
      occurs first.
      
      The fix ensures that the MTR signal is processed by the slave
      SQL thread before issuing the call to RESET
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      cdf19cd6
    • Ustun Ozgur's avatar
      Fix typo in mysqadmin manpage · b557f263
      Ustun Ozgur authored
      b557f263
  12. 14 Feb, 2022 2 commits
  13. 12 Feb, 2022 2 commits
  14. 11 Feb, 2022 2 commits
    • Marko Mäkelä's avatar
      Disable innodb_gis.rtree_compress2 · 1a7573d5
      Marko Mäkelä authored
      1a7573d5
    • Vlad Lesin's avatar
      MDEV-27746 Wrong comparision of BLOB's empty preffix with non-preffixed BLOB... · 3b10e8f8
      Vlad Lesin authored
      MDEV-27746 Wrong comparision of BLOB's empty preffix with non-preffixed BLOB causes rows count mismatch for clustered and secondary indexes during non-locking read
      
      row_sel_sec_rec_is_for_clust_rec() treats empty BLOB prefix field in
      secondary index as a field equal to any external BLOB field in clustered
      index. Row_sel_get_clust_rec_for_mysql::operator() doesn't zerro out
      clustered record pointer in row_search_mvcc(), and row_search_mvcc()
      thinks that delete-marked secondary index record has visible for
      "CHECK TABLE"'s read view old-versioned clustered index record, and
      row_scan_index_for_mysql() counts it as a row.
      
      The fix is to execute row_sel_sec_rec_is_for_blob() in
      row_sel_sec_rec_is_for_clust_rec() if clustered field contains BLOB's
      reference.
      3b10e8f8
  15. 10 Feb, 2022 2 commits
    • Sergei Golubchik's avatar
      Merge branch '10.2' into 10.3 · a36fc80a
      Sergei Golubchik authored
      a36fc80a
    • Sergei Petrunia's avatar
      MDEV-25636: Bug report: abortion in sql/sql_parse.cc:6294 · 3a525694
      Sergei Petrunia authored
      The asserion failure was caused by this query
      
        select /*id=1*/ from t1
        where
         col= ( select /*id=2*/ from ... where corr_cond1
                union
                select /*id=4*/ from ... where corr_cond2)
      
      Here,
      - select with id=2 was correlated due to corr_cond1.
      - select with id=4 was initially correlated due to corr_cond2, but then
        the optimizer optimized away the correlation, making the select with id=4
        uncorrelated.
      
      However, since select with id=2 remained correlated, the execution had to
      re-compute the whole UNION. When it tried to execute select with id=4, it
      hit an assertion  (join buffer already free'd).
      
      This is because select with id=4 has freed its execution structures after
      it has been executed once. The select is uncorrelated, so it did not expect
      it would need to be executed for the second time.
      
      Fixed this by adding this logic in
      st_select_lex::optimize_unflattened_subqueries():
      
        If a member of a UNION is correlated, mark all its members as
        correlated, so that they are prepared to be executed multiple times.
      3a525694