The problem was that THD::db_access variable was not restored after
database switch in stored-routine-execution code.

The fix is to restore THD::db_access in this case.

Unfortunately, this fix requires additional changes,
because in prepare_schema_table(), called on the parsing stage, we checked
privileges. That was wrong according to our design, but this flaw haven't
struck so far, because it was masked. All privilege checkings must be
done on the execution stage in order to be compatible with prepared statements
and stored routines. So, this patch also contains patch for
prepare_schema_table(), which moves the checkings to the execution phase.

(Fixes valgrind warnings)

into  mysql.com:/home/my/mysql-5.0

into  bk-internal.mysql.com:/data0/bk/mysql-5.0-marvel

  Don't install ndb man pages if no ndb configured
config-win.h, CMakeLists.txt, README, configure.js:
  Removed Cybozu patches

into  ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.0-marvel

execution breaks replication.

When a stored routine is executed, we switch current
database to the database, in which the routine
has been created. When the stored routine finishes,
we switch back to the original database.

The problem was that if the original database does not
exist (anymore) after routine execution, we raised an error.

The fix is to report a warning, and switch to the NULL database.

into  mysql.com:/home/kent/bk/tmp/mysql-5.0-build

  Don't use explicit calls to mysql-test-run in spec

into  ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-4.1-main

into  dsl-hkibras1-ff1dc300-249.dhcp.inet.fi:/home/elkin/MySQL/MAIN/5.0-marvel-bug23333_sf_side_eff_binlog

removing test host sensitive stuff for pushbuild

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-5.0

fixing wrong written assignment

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-5.0

eliminating the unnecessary option; and replacing site-dependant stuff in the test

into  andrepl.(none):/home/elkin/MySQL/MAIN/5.0-marvel-bug23333_sf_side_eff_binlog

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-5.0-build

into  sin.intern.azundris.com:/home/tnurnberg/26817/50-26817

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-5.0-build

fixed differently: wake up select_thread with THR_SERVER_ALARM instead

give some leeway on required permissions for SHOW FIELDS on views so
an unknonwn DEFINER will no longer break mysqldump

into  andrepl.(none):/home/elkin/MySQL/MAIN/5.0-marvel-bug23333_sf_side_eff_binlog

into  andrepl.(none):/home/elkin/MySQL/MAIN/mysql-5.0-marvel

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-5.0

thd->options' OPTION_STATUS_NO_TRANS_UPDATE bit was not restored at the end of SF() invocation, where
SF() modified non-ta table.
As the result of this artifact it was not possible to detect whether there were any side-effects when
top-level query ends. 
If the top level query table was not modified and the bit is lost there would be no binlogging.

Fixed with preserving the bit inside of thd->no_trans_update struct. The struct agregates two bool flags
telling whether the current query and the current transaction modified any non-ta table.
The flags stmt, all are dropped at the end of the query and the transaction.

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-5.0-build

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-5.0-build

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-5.0

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-4.1

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-4.1

into  sergbook.mysql.com:/usr/home/serg/Abk/mysql-4.1

(in thr_alarm.cc it happened too late).

make 'use database' okay.

The problem was that we didn't check stored-routine privileges
in check_grant_db().

The patch adds this check.

into  trift2.:/MySQL/M50/push-5.0

into  trift2.:/MySQL/M50/push-5.0