An error occurred fetching the project authors.
  1. 02 Jan, 2005 1 commit
    • unknown's avatar
      Streamlined code for trim, ltrim and rtrim · 549c5ea1
      unknown authored
      Portability fixes
      
      
      mysql-test/r/func_str.result:
        Added test for ltrim and rtrim with NULL
      mysql-test/t/func_str.test:
        Added test for ltrim and rtrim with NULL
      sql/item_strfunc.cc:
        Streamlined code for trim, ltrim and rtrim
      tests/client_test.c:
        Fixed wrong usage of %lld (not portable)
      549c5ea1
  2. 28 Dec, 2004 1 commit
    • unknown's avatar
      Fix for BUG#7455. · ab643104
      unknown authored
      The fix checks if the trim string argument is NULL. If so, the standard
      mandates that the function result must be also NULL.
      
      
      mysql-test/r/func_str.result:
        added test result
      mysql-test/t/func_str.test:
        Added test for NULL arguments.
      sql/item_strfunc.cc:
        Test if the trim argument is NULL.
      ab643104
  3. 23 Dec, 2004 1 commit
    • unknown's avatar
      Fix for a bug #7495 · 21535b6f
      unknown authored
      mysql-test/r/func_str.result:
        result for test case for a bug in QUOTE() (Bug #7495)
      mysql-test/t/func_str.test:
        test case for a bug in QUOTE() (Bug #7495)
      sql/item_strfunc.cc:
        a better fix for a QUOTE() bug (Bug #7495)
      21535b6f
  4. 22 Dec, 2004 1 commit
    • unknown's avatar
      A fix for the bug #7495 · 049c3fb1
      unknown authored
      mysql-test/r/func_str.result:
        A result for test case for the bug #7495 involving either LTRIM() 
        or TRIM() within QUOTE() function.
      mysql-test/t/func_str.test:
        A test case for the bug #7495 involving either LTRIM() or TRIM() 
        within QUOTE() function.
      sql/item_strfunc.cc:
        Changes for LTRIM() and TRIM() functions that aleviate the bug  
        entirely.
      049c3fb1
  5. 13 Dec, 2004 2 commits
    • unknown's avatar
      Merge of fix for BUG#6976 continued: pulling in some Item_ref changes from 5.0 · b650644b
      unknown authored
       * Added Item_ref::set_properties 
       * Item_ref::Item_ref now expects to get in *item either
           NULL - then fix_fields() will be called later  or 
           ptr to Item it will refer to - then an equivalent of fix_fields() call is performed
      
      
      sql/item.cc:
        Merge of fix for BUG#6976 continued: pulling in some Item_ref changes from 5.0
         * Added Item_ref::set_properties 
         * Adjusted Item_ref::Item_ref calls to match new calling convention
      sql/item.h:
        Merge of fix for BUG#6976 continued: pulling in some Item_ref changes from 5.0
         * Added Item_ref::set_properties 
         * Item_ref::Item_ref now expects to get in *item either
             NULL - then fix_fields() will be called later or
             ptr to Item it will refer to - then an equivalent of fix_fields() call is performed
      sql/item_cmpfunc.cc:
        Merge of fix for BUG#6976 continued: pulling in some Item_ref changes from 5.0
         * Adjusted Item_ref::Item_ref calls to match new calling convention
      sql/item_func.cc:
        Merge of fix for BUG#6976 continued: pulling in some Item_ref changes from 5.0
         * Added Item_ref::set_properties 
         * Adjusted Item_ref::Item_ref calls to match new calling convention
      sql/item_row.cc:
        Merge of fix for BUG#6976 continued: pulling in some Item_ref changes from 5.0
         * Added Item_ref::set_properties 
         * Adjusted Item_ref::Item_ref calls to match new calling convention
      sql/item_strfunc.cc:
        Merge of fix for BUG#6976 continued: pulling in some Item_ref changes from 5.0
         * Added Item_ref::set_properties 
         * Adjusted Item_ref::Item_ref calls to match new calling convention
      b650644b
    • unknown's avatar
      Merging fix for BUG#6976 from 4.0 to 4.1 · 74a8fdd9
      unknown authored
      The problem in 4.1 was the same as in 4.0 - fix_fields() not called for created Item_ref. 
      The fix is similar too - initialize Item_refs in ctor (but don't interfere with cases when 
      Item_ref is used by subselects). 
      
      
      sql/item.cc:
        Fix for BUG#6976 ported from 4.0
      sql/item_cmpfunc.cc:
        Fix for BUG#6976 ported from 4.0
      sql/item_func.cc:
        Fix for BUG#6976 ported from 4.0
      sql/item_row.cc:
        Fix for BUG#6976 ported from 4.0
      sql/item_strfunc.cc:
        Fix for BUG#6976 ported from 4.0
      74a8fdd9
  6. 09 Dec, 2004 2 commits
    • unknown's avatar
      A fix for a crashing bug #7101, which occures when the · 2d841bda
      unknown authored
      expression involving LEFT() function is used in GROUP BY
      field.
      
      
      mysql-test/r/func_str.result:
        A result for bug #7101 test case
      mysql-test/t/func_str.test:
        Test case for bug #7101
      2d841bda
    • unknown's avatar
      Fix for bug #6765 "Implicit access to time zone description · 7b96bc55
      unknown authored
      tables requires privileges for them if some table or column level grants
      present" (with after-review fixes).
      
      We should set SELECT_ACL for implicitly opened tables in 
      my_tz_check_n_skip_implicit_tables() to be able to bypass privilege
      checking in check_grant(). Also we should exclude those tables from
      privilege checking in multi-update.
      
      
      mysql-test/r/timezone2.result:
        Extended test for bug #6116 "SET time_zone := ... requires access to
        mysql.time_zone tables"
        Added test for bug #6765 "Implicit access to time zone description 
        tables requires privileges for them if some table or column level grants
        present"
      mysql-test/t/timezone2.test:
        Extended test for bug #6116 "SET time_zone := ... requires access to
        mysql.time_zone tables"
        Added test for bug #6765 "Implicit access to time zone description 
        tables requires privileges for them if some table or column level grants
        present"
      sql/item_geofunc.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/item_strfunc.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/log.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/mysql_priv.h:
        Now we have to include sql_acl.h before tztime.h, since 
        my_tz_check_n_skip_implicit_tables() defined there requires
        SELECT_ACL constant defined in sql_acl.h.
      sql/mysqld.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/repl_failsafe.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/set_var.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_acl.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_base.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_cache.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_class.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_db.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_derived.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_do.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_insert.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_parse.cc:
        check_one_table_access(): Tweaked comments.
        multi_update_precheck(): Added skipping of implicitly opened tables
          during privilege checking.
      sql/sql_prepare.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_repl.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_show.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_update.cc:
        sql_acl.h is now included via mysql_priv.h
      sql/sql_yacc.yy:
        sql_acl.h is now included via mysql_priv.h
      sql/tztime.h:
        my_tz_check_n_skip_implicit_tables():
          We should set SELECT_ACL for implictly opened tables to be able to
          bypass privilege checking in check_grant().
      7b96bc55
  7. 06 Dec, 2004 1 commit
  8. 13 Nov, 2004 1 commit
    • unknown's avatar
      now my_printf_error is not better then my_error, but my_error call is shorter · 065a55e8
      unknown authored
      used only one implementation of format parser of (printf)
      fixed multistatement
      
      
      include/mysqld_error.h:
        newerror messages
      mysql-test/t/key.test:
        unknown error replaced with real error
      mysys/my_error.c:
        my_error & my_printf_error use my_vsprintf
      sql/field_conv.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/ha_innodb.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/handler.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/item.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/item_cmpfunc.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/item_func.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/item_strfunc.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/lock.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/log.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/parse_file.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/procedure.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/protocol.cc:
        no need reset thd->lex->found_colon to break multiline sequance now, send_error called too late
      sql/repl_failsafe.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/set_var.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/share/czech/errmsg.txt:
        new errors converted from unknown error
      sql/share/danish/errmsg.txt:
        new errors converted from unknown error
      sql/share/dutch/errmsg.txt:
        new errors converted from unknown error
      sql/share/english/errmsg.txt:
        new errors converted from unknown error
      sql/share/estonian/errmsg.txt:
        new errors converted from unknown error
      sql/share/french/errmsg.txt:
        new errors converted from unknown error
      sql/share/german/errmsg.txt:
        new errors converted from unknown error
      sql/share/greek/errmsg.txt:
        new errors converted from unknown error
      sql/share/hungarian/errmsg.txt:
        new errors converted from unknown error
      sql/share/italian/errmsg.txt:
        new errors converted from unknown error
      sql/share/japanese/errmsg.txt:
        new errors converted from unknown error
      sql/share/korean/errmsg.txt:
        new errors converted from unknown error
      sql/share/norwegian-ny/errmsg.txt:
        new errors converted from unknown error
      sql/share/norwegian/errmsg.txt:
        new errors converted from unknown error
      sql/share/polish/errmsg.txt:
        new errors converted from unknown error
      sql/share/portuguese/errmsg.txt:
        new errors converted from unknown error
      sql/share/romanian/errmsg.txt:
        new errors converted from unknown error
      sql/share/russian/errmsg.txt:
        new errors converted from unknown error
      sql/share/serbian/errmsg.txt:
        new errors converted from unknown error
      sql/share/slovak/errmsg.txt:
        new errors converted from unknown error
      sql/share/spanish/errmsg.txt:
        new errors converted from unknown error
      sql/share/swedish/errmsg.txt:
        new errors converted from unknown error
      sql/share/ukrainian/errmsg.txt:
        new errors converted from unknown error
      sql/slave.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sp.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sp_head.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_acl.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_analyse.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_base.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_class.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_db.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_delete.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_handler.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_insert.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_load.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_map.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_parse.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
        multi-row command fixed
      sql/sql_prepare.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
        remover send_error ingected from 4.1
      sql/sql_rename.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_repl.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_select.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_show.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_table.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_trigger.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_udf.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_update.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_view.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/sql_yacc.yy:
        now my_printf_error is not better then my_error, but my_error call is shorter
      sql/table.cc:
        now my_printf_error is not better then my_error, but my_error call is shorter
      strings/my_vsnprintf.c:
        * format support added to my_vsprint
      065a55e8
  9. 12 Nov, 2004 2 commits
    • unknown's avatar
      Fixed a function call. · 5067b2ef
      unknown authored
      5067b2ef
    • unknown's avatar
      post-review fixes · a31c2d3d
      unknown authored
      mysql-test/r/rpl_rotate_logs.result:
        removed host dependence in error messages
      mysql-test/t/rpl_rotate_logs.test:
        removed host dependence in error messages
      mysys/my_error.c:
        comment about using my_error family functions
      sql/filesort.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/ha_innodb.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/handler.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/item.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/item_cmpfunc.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/item_func.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/item_strfunc.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/item_subselect.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/item_sum.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/lock.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/log.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/mysql_priv.h:
        error check moved to fill_record
      sql/mysqld.cc:
        fixed error messages
      sql/parse_file.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/protocol.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/protocol_cursor.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/repl_failsafe.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/set_var.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/slave.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sp.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sp_head.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sp_rcontext.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_acl.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_analyse.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_base.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
        error check moved to fill_record
      sql/sql_class.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_class.h:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_db.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_delete.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
        error check moved to fill_record
      sql/sql_handler.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_help.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_insert.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
        error check moved to fill_record
      sql/sql_lex.cc:
        layout fixed
      sql/sql_load.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_map.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_parse.cc:
        error check moved to fill_record
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_prepare.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_rename.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_repl.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_select.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_show.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_table.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_trigger.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_udf.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_union.cc:
        error check moved to fill_record
      sql/sql_update.cc:
        error check moved to fill_record
      sql/sql_view.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/sql_yacc.yy:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/table.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      sql/unireg.cc:
        changing my_error on my_message and my_printf_error where if they are prefered
      a31c2d3d
  10. 11 Nov, 2004 2 commits
    • unknown's avatar
      Rename: Item::val -> Item::val_real(). · 625f92d6
      unknown authored
      sql/filesort.cc:
        val -> val_real
      sql/item.cc:
        val -> val_real
      sql/item.h:
        val -> val_real
      sql/item_buff.cc:
        val -> val_real
      sql/item_cmpfunc.cc:
        val -> val_real
      sql/item_cmpfunc.h:
        val -> val_real
      sql/item_func.cc:
        val -> val_real
      sql/item_func.h:
        val -> val_real
      sql/item_geofunc.cc:
        val -> val_real
      sql/item_geofunc.h:
        val -> val_real
      sql/item_row.h:
        val -> val_real
      sql/item_strfunc.cc:
        val -> val_real
      sql/item_strfunc.h:
        val -> val_real
      sql/item_subselect.cc:
        val -> val_real
      sql/item_subselect.h:
        val -> val_real
      sql/item_sum.cc:
        val -> val_real
      sql/item_sum.h:
        val -> val_real
      sql/item_timefunc.h:
        val -> val_real
      sql/item_uniq.h:
        val -> val_real
      sql/procedure.h:
        val -> val_real
      sql/sp_head.cc:
        val -> val_real
      sql/sql_analyse.cc:
        val -> val_real
      sql/sql_class.cc:
        val -> val_real
      sql/sql_select.cc:
        val -> val_real
      625f92d6
    • unknown's avatar
  11. 02 Nov, 2004 1 commit
    • unknown's avatar
      Many files: · 469889f5
      unknown authored
        Allow mixing of different character sets for more SQL functions.
      item_func.h:
        Allow mixing of different character sets for more SQL functions..
      
      
      sql/item_cmpfunc.cc:
        Allow mixing of different character sets for more SQL functions.
      sql/item_func.cc:
        Allow mixing of different character sets for more SQL functions.
      sql/item_func.h:
        Allow mixing of different character sets for more SQL functions..
      sql/item_strfunc.cc:
        Allow mixing of different character sets for more SQL functions.
      sql/item.cc:
        Allow mixing of different character sets for more SQL functions.
      sql/item.h:
        Allow mixing of different character sets for more SQL functions.
      mysql-test/t/ctype_recoding.test:
        Allow mixing of different character sets for more SQL functions.
      mysql-test/r/ctype_recoding.result:
        Allow mixing of different character sets for more SQL functions.
      469889f5
  12. 29 Oct, 2004 2 commits
    • unknown's avatar
      A fix according to Monty's request: · 08809ca1
      unknown authored
      "uint *errors" is now a non-optional parameter in String:copy()
      and copy_and_convert().
      
      08809ca1
    • unknown's avatar
      item_strfunc.cc: · 5329e3a6
      unknown authored
        Unnecessary code was removed.
      
      
      sql/item_strfunc.cc:
        Unnecessary code was removed.
      5329e3a6
  13. 28 Oct, 2004 1 commit
  14. 14 Oct, 2004 1 commit
    • unknown's avatar
      true,false -> TRUE, FALSE · b76f5cd2
      unknown authored
      Simple fixes/optimization of things discovered during review of new pushed code
      
      
      include/my_sys.h:
        Ensure that clear_alloc_root() interacts correctly with alloc_root_inited()
      mysys/hash.c:
        More comments
        Simple optimization (merge identical code)
      mysys/my_bitmap.c:
        Change inline -> static inline
      sql/examples/ha_archive.cc:
        Fixed compiler warning
      sql/ha_ndbcluster.cc:
        true,false -> TRUE, FALSE
        Change if (false) -> #ifdef NOT_USED
      sql/ha_ndbcluster.h:
        true,false -> TRUE, FALSE
      sql/handler.cc:
        More comments
        Remove not needed initializations.
        #ifdef not used code
      sql/item_cmpfunc.h:
        true,false -> TRUE, FALSE
      sql/item_strfunc.cc:
        Move local variables to function beginning
        Remove wrong comments
      sql/log_event.h:
        true,false -> TRUE, FALSE
      sql/sql_base.cc:
        true,false -> TRUE, FALSE
        More comments
      sql/sql_help.cc:
        true,false -> TRUE, FALSE
      sql/sql_lex.cc:
        Simple optimization of new code
      sql/sql_parse.cc:
        true,false -> TRUE, FALSE
      sql/sql_prepare.cc:
        true,false -> TRUE, FALSE
      sql/sql_table.cc:
        true,false -> TRUE, FALSE
      sql/sql_yacc.yy:
        true,false -> TRUE, FALSE
      b76f5cd2
  15. 09 Oct, 2004 1 commit
    • unknown's avatar
      A small simplification: perform two actions at once, register a · c90fd2c4
      unknown authored
      change, and perform it (the new Item changes registry).
      
      
      sql/item.cc:
        A small simplification: perform two actions at once, register a
        change, and perform it.
      sql/item_cmpfunc.cc:
        register_item_tree_change -> change_item_tree
      sql/item_func.cc:
        register_item_tree_change -> change_item_tree
      sql/item_row.cc:
        register_item_tree_change -> change_item_tree
      sql/item_strfunc.cc:
        register_item_tree_change -> change_item_tree
      sql/sql_class.h:
        register_item_tree_change -> change_item_tree
      sql/sql_select.cc:
        register_item_tree_change -> change_item_tree
      c90fd2c4
  16. 08 Oct, 2004 1 commit
    • unknown's avatar
      Deployment of centralized Item change registry, step 2: Item_ref · 9ba3c23e
      unknown authored
      doesn't need to have it's own recovery mechanism.
      
      
      sql/item.cc:
        Deployment of centralized Item change registry, step 2: Item_ref 
        doesn't need to have it's own recovery mechanism, so it was simplified.
      sql/item.h:
        Deployment of centralized Item change registry, step 2: Item_ref 
        doesn't need to have it's own recovery mechanism, so it was simplified.
      sql/item_cmpfunc.cc:
        - Item::split_sum_func now requires THD
        - use THD::register_item_tree_change
      sql/item_cmpfunc.h:
        - Item::split_sum_func now requires THD
      sql/item_func.cc:
        - Item::split_sum_func now requires THD
        - use THD::register_item_tree_change
      sql/item_func.h:
        - Item::split_sum_func now requires THD
      sql/item_row.cc:
        - Item::split_sum_func now requires THD
        - use THD::register_item_tree_change
      sql/item_row.h:
        - Item::split_sum_func now requires THD
      sql/item_strfunc.cc:
        - Item::split_sum_func now requires THD
        - use THD::register_item_tree_change to register changes in the item
          tree
      sql/item_strfunc.h:
        - Item::split_sum_func now requires THD
      sql/item_subselect.cc:
        - use updated Item_ref constructor
      sql/sql_base.cc:
        - Item::split_sum_func now requires THD
      sql/sql_select.cc:
        - Item::split_sum_func now requires THD
      sql/sql_yacc.yy:
        - use updated Item_ref constructor
      9ba3c23e
  17. 15 Sep, 2004 1 commit
  18. 13 Sep, 2004 3 commits
  19. 07 Sep, 2004 2 commits
    • unknown's avatar
      Code cleanup · 95ae9c14
      unknown authored
      sql/item_strfunc.cc:
        unpack_filename changed with fn_format's hint
      sql/sql_load.cc:
        unpack_filename changed with fn_format's hint
      95ae9c14
    • unknown's avatar
      A set of mysql_home_path-related fixes · fc10f15a
      unknown authored
      mysys/mf_format.c:
        I think here i fixed a bug
      sql/item_strfunc.cc:
        mysql_real_data_home added
      sql/sql_class.cc:
        it's more closer to what manual says
      sql/sql_load.cc:
        code rewritten to be similar
      sql/sql_table.cc:
        mysql_real_data_home added to the path
      fc10f15a
  20. 31 Aug, 2004 1 commit
    • unknown's avatar
      fixed open_and_lock_tables result processing (all open_and_lock_tables revision) · a64a5637
      unknown authored
      fixed printing of COLLATE operation
      (BUG#5155)
      
      
      mysql-test/r/case.result:
        fixed printing of COLLATE operation
      mysql-test/r/func_if.result:
        fixed printing of COLLATE operation
      mysql-test/r/func_in.result:
        fixed printing of COLLATE operation
      mysql-test/r/func_str.result:
        fixed printing of COLLATE operation
      mysql-test/r/func_test.result:
        fixed printing of COLLATE operation
      mysql-test/r/view.result:
        VIEW with collation
      mysql-test/t/view.test:
        VIEW with collation
      sql/item_strfunc.cc:
        fixed printing of COLLATE operation
      sql/item_strfunc.h:
        fixed printing of COLLATE operation
      sql/sp_head.cc:
        fixed open_and_lock_tables result processing
      sql/sql_base.cc:
        fixed open_and_lock_tables result processing
      sql/sql_delete.cc:
        fixed open_and_lock_tables result processing
      sql/sql_help.cc:
        fixed open_and_lock_tables result processing
      sql/sql_load.cc:
        fixed open_and_lock_tables result processing
      sql/sql_parse.cc:
        fixed open_and_lock_tables result processing
      sql/sql_prepare.cc:
        fixed open_and_lock_tables result processing
      sql/sql_show.cc:
        fixed open_and_lock_tables result processing
      sql/sql_update.cc:
        fixed open_and_lock_tables result processing
      a64a5637
  21. 26 Aug, 2004 1 commit
    • unknown's avatar
      Portability fixes · f78bbc8c
      unknown authored
      Fixed bug in end space handle for WHERE text_column="constant"
      
      
      heap/hp_hash.c:
        Optimzations (no change of logic)
      libmysql/libmysql.c:
        Added missing casts (portability fix)
      myisam/mi_key.c:
        Changed macro to take arguments and not depend on local variables
        Simple indentation fixes ?
      mysql-test/r/connect.result:
        Added test for setting empty password
      mysql-test/r/create_select_tmp.result:
        TYPE -> ENGINE
      mysql-test/r/ctype_utf8.result:
        Combine drop's
      mysql-test/r/endspace.result:
        Added more tests to test end space behaviour
      mysql-test/r/having.result:
        Added missing DROP TABLE
      mysql-test/r/type_blob.result:
        Added more tests to ensure that fix for BLOB usage is correct
      mysql-test/r/type_timestamp.result:
        Add test from 4.0
      mysql-test/t/connect.test:
        Added test for setting empty password
      mysql-test/t/create_select_tmp.test:
        TYPE -> ENGINE
      mysql-test/t/ctype_utf8.test:
        Combine drop's
      mysql-test/t/endspace.test:
        Added more tests to test end space behaviour
      mysql-test/t/having.test:
        Added missing DROP TABLE
      mysql-test/t/type_blob.test:
        Added more tests to ensure that fix for BLOB usage is correct
      mysql-test/t/type_timestamp.test:
        Add test from 4.0
      sql/field.cc:
        Removed not used variable
        Portability fix (cast)
        Simplified Field_str::double()
        Simple indentation cleanups
      sql/field.h:
        Removed not needed class variable
      sql/item_cmpfunc.cc:
        Indentation fix
      sql/item_strfunc.cc:
        Use on stack variable for Item_str_func::val() instead of str_value.
        This makes it safe to use str_value inside the Item's val function.
        Cleaned up LEFT() usage, thanks to the above change
      sql/item_sum.cc:
        Indentation cleanups
      sql/protocol.cc:
        Added missing cast
      sql/sql_acl.cc:
        Indentatin cleanups.
        Added missing cast
        Simple optimization of get_sort()
      sql/sql_select.cc:
        Don't use 'ref' to search on text field that is not of type BINARY (use 'range' instead).
        The reson is that for 'ref' we use 'index_next_same' to read the next possible row. 
        For text fields, rows in a ref may not come in order, like for 'x', 'x\t' 'x ' (stored in this order) which causes a search for 'column='x ' to fail
      sql/tztime.cc:
        Simple cleanup
      strings/ctype-bin.c:
        Comment fixes
      strings/ctype-mb.c:
        Changed variable names for arguments
      f78bbc8c
  22. 13 Aug, 2004 1 commit
    • unknown's avatar
      ctype_utf8.result, ctype_utf8.test, item_strfunc.cc: · a0805eda
      unknown authored
        LEFT() didn't work well in some cases.
      
      
      sql/item_strfunc.cc:
        LEFT() didn't work well in some cases.
      mysql-test/t/ctype_utf8.test:
        LEFT() didn't work well in some cases.
      mysql-test/r/ctype_utf8.result:
        LEFT() didn't work well in some cases.
      a0805eda
  23. 12 Aug, 2004 1 commit
  24. 21 Jul, 2004 1 commit
    • unknown's avatar
      Final patch for WL#1600(warn if max_allowed_packet used) · dbdca81c
      unknown authored
      mysql-test/r/func_str.result:
        test fixed
      mysql-test/r/packet.result:
        test fixed
      sql/item_geofunc.cc:
        error message fixed
      sql/item_strfunc.cc:
        error message fixed
      sql/share/czech/errmsg.txt:
        error message fixed
      sql/share/danish/errmsg.txt:
        error message fixed
      sql/share/dutch/errmsg.txt:
        error message fixed
      sql/share/english/errmsg.txt:
        error message fixed
      sql/share/estonian/errmsg.txt:
        error message fixed
      sql/share/french/errmsg.txt:
        error message fixed
      sql/share/german/errmsg.txt:
        error message fixed
      sql/share/greek/errmsg.txt:
        error message fixed
      sql/share/hungarian/errmsg.txt:
        error message fixed
      sql/share/italian/errmsg.txt:
        error message fixed
      sql/share/japanese/errmsg.txt:
        error message fixed
      sql/share/korean/errmsg.txt:
        error message fixed
      sql/share/norwegian-ny/errmsg.txt:
        error message fixed
      sql/share/norwegian/errmsg.txt:
        error message fixed
      sql/share/polish/errmsg.txt:
        error message fixed
      sql/share/portuguese/errmsg.txt:
        error message fixed
      sql/share/romanian/errmsg.txt:
        error message fixed
      sql/share/russian/errmsg.txt:
        error message fixed
      sql/share/serbian/errmsg.txt:
        error message fixed
      sql/share/slovak/errmsg.txt:
        error message fixed
      sql/share/spanish/errmsg.txt:
        error message fixed
      sql/share/swedish/errmsg.txt:
        error message fixed
      sql/share/ukrainian/errmsg.txt:
        error message fixed
      dbdca81c
  25. 09 Jul, 2004 1 commit
    • unknown's avatar
      Cleanup of db option cacheing · ad72843e
      unknown authored
      Some bug fixes to last pushed code
      
      
      mysql-test/mysql-test-run.sh:
        Fix for new valgrind (2.1.1)
      mysql-test/r/bdb.result:
        Updated results
      mysql-test/t/ps_1general.test:
        removed wrong error condition
      sql/ha_berkeley.cc:
        Fix for index_flags() in new code
      sql/item_strfunc.cc:
        Cleanup (fixed indentation, removed short variable names)
      sql/mysql_priv.h:
        Cleanup of db option cacheing
      sql/mysqld.cc:
        Cleanup of db option cacheing
      sql/sql_db.cc:
        Cleanup of db option cacheing
      sql/sql_parse.cc:
        Cleanup of db option cacheing
      sql/sql_table.cc:
        sprintf -> strxmov
      sql/table.cc:
        key_read should be tested on key parts, not the whole key
      ad72843e
  26. 07 Jul, 2004 1 commit
  27. 29 Jun, 2004 1 commit
    • unknown's avatar
      WL#1600 (Warn if result is truncatet due to max_allowed_packet) · 08c39dc9
      unknown authored
      include/mysqld_error.h:
        Warning added
      mysql-test/r/func_str.result:
        test result fixed
      mysql-test/r/packet.result:
        test resut fixed
      sql/item_geofunc.cc:
        warning issued
      sql/item_strfunc.cc:
        warning issued
      sql/share/czech/errmsg.txt:
        Warning added
      sql/share/danish/errmsg.txt:
        Warning added
      sql/share/dutch/errmsg.txt:
        Warning added
      sql/share/english/errmsg.txt:
        Warning added
      sql/share/estonian/errmsg.txt:
        Warning added
      sql/share/french/errmsg.txt:
        Warning added
      sql/share/german/errmsg.txt:
        Warning added
      sql/share/greek/errmsg.txt:
        Warning added
      sql/share/hungarian/errmsg.txt:
        Warning added
      sql/share/italian/errmsg.txt:
        Warning added
      sql/share/japanese/errmsg.txt:
        Warning added
      sql/share/korean/errmsg.txt:
        Warning added
      sql/share/norwegian-ny/errmsg.txt:
        Warning added
      sql/share/norwegian/errmsg.txt:
        Warning added
      sql/share/polish/errmsg.txt:
        Warning added
      sql/share/portuguese/errmsg.txt:
        Warning added
      sql/share/romanian/errmsg.txt:
        Warning added
      sql/share/russian/errmsg.txt:
        Warning added
      sql/share/serbian/errmsg.txt:
        Warning added
      sql/share/slovak/errmsg.txt:
        Warning added
      sql/share/spanish/errmsg.txt:
        Warning added
      sql/share/swedish/errmsg.txt:
        Warning added
      sql/share/ukrainian/errmsg.txt:
        Warning added
      08c39dc9
  28. 15 Jun, 2004 1 commit
  29. 08 Jun, 2004 2 commits
    • unknown's avatar
      a fix · 8a18b8c8
      unknown authored
      (Bug #4035 GROUP_CONCAT with HAVING clause truncates field                       
      Bug #4057 LEFT() function in HAVING clause truncates query result).
      
      
      mysql-test/r/func_gconcat.result:
        a test case
        Bug #4035 GROUP_CONCAT with HAVING clause truncates field                       
        Bug #4057 LEFT() function in HAVING clause truncates query result
      mysql-test/t/func_gconcat.test:
        a test case
        Bug #4035 GROUP_CONCAT with HAVING clause truncates field                       
        Bug #4057 LEFT() function in HAVING clause truncates query result
      sql/item_strfunc.cc:
        a fix (Bug #4057 LEFT() function in HAVING clause truncates query result)
      sql/item_strfunc.h:
        a fix (Bug #4057 LEFT() function in HAVING clause truncates query result)
      sql/item_sum.cc:
        a fix (Bug #4035 GROUP_CONCAT with HAVING clause truncates field)
      sql/item_sum.h:
        a fix (Bug #4035 GROUP_CONCAT with HAVING clause truncates field)
      8a18b8c8
    • unknown's avatar
  30. 07 Jun, 2004 1 commit
  31. 27 May, 2004 1 commit
    • unknown's avatar
      Made my_snprintf() behavior snprintf() compatible when printing %x arguments (it should · 0c6bdfaa
      unknown authored
      produce hex digits in lower case). (fixed version)
      
      Replaced _dig_vec array with two _dig_vec_upper/_dig_vec_lower arrays.
      Added extra argument to int2str function which controls case of digits you get.
      Replaced lot of invocations of int2str for decimal radix with more optimized int10_to_str()
      function.
      Removed unused my_itoa/my_ltoa functions.
      
      
      client/mysql.cc:
        Replaced int2str invocations with radix argument equal to 10 with optimized int10_to_str()
        call.
      client/mysqladmin.c:
        Replaced int2str invocations with radix argument equal to 10 with optimized int10_to_str()
        call.
      dbug/dbug.c:
         _dig_vec became _dig_vec_upper.
      include/m_string.h:
        _dig_vec is obsoleted by _dig_vec_upper/_dig_vec_lower.
        my_itoa()/my_ltoa() functions were removed because they were never used in our code.
        int2str() now has one more argument which controls case of digits it will produce.
      include/my_global.h:
        my_itoa()/my_ltoa() functions were removed because they were never used in our code.
      isam/isamchk.c:
        Replaced int2str invocations with radix argument equal to 10 with optimized int10_to_str()
        call.
      libmysql/libmysql.def:
        _dig_vec is obsoleted by _dig_vec_upper/_dig_vec_lower.
      myisam/myisamchk.c:
        Replaced int2str invocation with radix argument equal to 10 with optimized int10_to_str()
        call.
      mysys/mf_tempfile.c:
        _dig_vec became _dig_vec_upper.
      mysys/my_error.c:
        Replaced int2str invocations with radix argument equal to 10 with optimized int10_to_str()
        call.
      mysys/my_tempnam.c:
        _dig_vec became _dig_vec_upper.
      sql-common/client.c:
        Replaced int2str invocation with radix argument equal to 10 with optimized int10_to_str()
        call.
      sql/item_strfunc.cc:
        _dig_vec became _dig_vec_upper. Also we don't need hex[] array in this file now because we
        have _dig_vec_lower instead.
      sql/mysqld.cc:
        Replaced int2str invocations with radix argument equal to 10 with optimized int10_to_str()
        call.
      sql/password.c:
        _dig_vec became _dig_vec_upper.
      sql/sql_bitmap.h:
        _dig_vec became _dig_vec_upper.
      strings/int2str.c:
        Replaced _dig_vec by _dig_vec_upper/_dig_vec_lower pair.
        int2str() now has one more argument which controls case of digits it will produce.
        my_itoa()/my_ltoa() functions were removed because they were never used in our code.
      strings/longlong2str-x86.s:
        _dig_vec became _dig_vec_upper.
      strings/longlong2str.c:
        _dig_vec became _dig_vec_upper.
      strings/my_vsnprintf.c:
        If my_snprintf() is printing %x argument it should produce lower case hexadecimal digits
        to be snprintf() compatible.
      0c6bdfaa