1. 22 Nov, 2005 6 commits
  2. 21 Nov, 2005 17 commits
  3. 20 Nov, 2005 1 commit
    • unknown's avatar
      Inefficient usage of String::append() fixed. · 5e047f6b
      unknown authored
      Bad examples of usage of a string with its length fixed.
      The incorrect length in the trigger file configuration descriptor
        fixed (BUG#14090).
      A hook for unknown keys added to the parser to support old .TRG files.
      
      
      sql/field.cc:
        Inefficient usage of String::append() fixed.
        Bad examples of usage of a string with its length fixed.
      sql/ha_berkeley.cc:
        A bad example of usage of a string with its length fixed.
      sql/ha_federated.cc:
        Inefficient usage of String::append() fixed.
      sql/ha_myisammrg.cc:
        Bad examples of usage of a string with its length fixed.
      sql/handler.cc:
        Inefficient usage of String::append() fixed.
      sql/item.cc:
        Bad examples of usage of a string with its length fixed.
      sql/item.h:
        A bad example of usage of a string with its length fixed.
      sql/item_cmpfunc.cc:
        Bad examples of usage of a string with its length fixed.
      sql/item_func.cc:
        Bad examples of usage of a string with its length fixed.
      sql/item_strfunc.cc:
        Bad examples of usage of a string with its length fixed.
      sql/item_subselect.cc:
        Bad examples of usage of a string with its length fixed.
      sql/item_sum.cc:
        Bad examples of usage of a string with its length fixed.
        Inefficient usage of String::append() fixed.
      sql/item_timefunc.cc:
        Inefficient using of String::append() fixed.
        Bad examples of usage of a string with its length fixed.
      sql/item_uniq.h:
        Bad examples of usage of a string with its length fixed.
      sql/key.cc:
        Bad examples of usage of a string with its length fixed.
      sql/log.cc:
        Bad examples of usage of a string with its length fixed.
      sql/log_event.cc:
        Bad examples of usage of a string with its length fixed.
      sql/mysqld.cc:
        The dummy parser hook allocated.
      sql/opt_range.cc:
        Inefficient usage of String::append() fixed.
      sql/parse_file.cc:
        Bad examples of usage of a string with its length fixed.
        A hook for unknown keys added to the parser.
      sql/parse_file.h:
        A hook for unknown keys added to the parser.
      sql/protocol.cc:
        A bad example of usage of a string with its length fixed.
      sql/repl_failsafe.cc:
        Bad examples of usage of a string with its length fixed.
      sql/share/errmsg.txt:
        A warning for old format config file.
      sql/slave.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sp.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sp_head.cc:
        Bad examples of usage of a string with its length fixed.
      sql/spatial.cc:
        A bad example of usage of a string with its length fixed.
      sql/sql_acl.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_analyse.cc:
        Bad examples of usage of a string with its length fixed.
        Inefficient usage of String::append() fixed.
      sql/sql_lex.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_load.cc:
        A bad example of usage of a string with its length fixed.
      sql/sql_parse.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_prepare.cc:
        A bad example of usage of a string with its length fixed.
      sql/sql_select.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_show.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_string.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_string.h:
        The macro definition moved to sql_string.h to
          be accessible in all parts of server.
      sql/sql_table.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_trigger.cc:
        Bad examples of usage of a string with its length fixed.
        The incorrect length in the trigger file configuration descriptor
          fixed (BUG#14090).
        The hook for processing incorrect sql_mode record added.
      sql/sql_view.cc:
        A dummy  hook used for parsing views.
      sql/structs.h:
        The macro definition moved to sql_string.h to be
          accessible in all parts of server.
      sql/table.cc:
        A bad example of usage of a string with its length fixed.
      sql/tztime.cc:
        A bad example of usage of a string with its length fixed.
      5e047f6b
  4. 19 Nov, 2005 9 commits
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · 9f0607e3
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-distcheck
      
      9f0607e3
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 4d734e3c
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-bg13825
      
      4d734e3c
    • unknown's avatar
      A fix for Bug#14845 "mysql_stmt_fetch returns MYSQL_NO_DATA when · db869810
      unknown authored
      COUNT(*) is 0" (the test case has been pushed already)
      
      
      sql/sql_cursor.cc:
        Fix a return of an unitialized variable: return_zero_rows
        checks the return value of send_fields and in case it's 1
        doesn't call send_data. This caused creation of an empty result 
        set for the case when there is a cursor against a select with a 
        group function and no matching rows.
      db869810
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.1-distcheck · 79b8883f
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-distcheck
      
      
      configure.in:
        Auto merged
      79b8883f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · b8ad76f7
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-bg13825
      
      
      sql/ha_innodb.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      b8ad76f7
    • unknown's avatar
      Fix for bug #13825 "Triggers: crash if release savepoint" and for general · 2722ebcd
      unknown authored
      handling of savepoints in stored routines.
      
      Fixed ha_rollback_to_savepoint()/ha_savepoint()/ha_release_savepoint()
      functions to properly handle savepoints inside of stored functions and
      triggers.
      Also now when we invoke stored function or trigger we create new savepoint
      level. We destroy it at the end of function/trigger execution and return back
      to old savepoint level.
      
      
      mysql-test/r/sp_trans.result:
        Added test for bug #13825 "Triggers: crash if release savepoint" and for
        general handling of savepoints in stored routines.
      mysql-test/t/sp_trans.test:
        Added test for bug #13825 "Triggers: crash if release savepoint" and for
        general handling of savepoints in stored routines.
      sql/ha_innodb.cc:
        innobase_savepoint():
          Replaced check which always failed due to similar check in caller
          with assertion.
      sql/handler.cc:
        ha_rollback_to_savepoint()/ha_savepoint()/ha_release_savepoint():
          Changed functions to properly support handling of savepoints
          inside of stored functions and triggers.
      sql/sql_class.cc:
        THD::reset_sub_statement_state()/restore_sub_statement_state():
          When we invoke stored function or trigger we should create new savepoint
          level. We should destroy it at the end of function/trigger execution and
          return back to old savepoint level. To support this behavior we should
          save and reset list of current savepoints on entering function and restore
          old list when we leave it.
      sql/sql_class.h:
        Sub_statement_state:
          When we invoke stored function or trigger we should create new savepoint
          level. We should destroy it at the end of function/trigger execution and
          return back to old savepoint level. To support this behavior added "savepoint"
          member which is used to save/restore list of current savepoints on
          entering/leaving function.
      sql/sql_parse.cc:
        mysql_execute_command():
          Changed processing of SQLCOM_SAVEPOINT so now it is not ignored when
          we are in autocommit mode and savepoint is set inside of stored
          function or trigger.
      2722ebcd
    • unknown's avatar
      configure.in: · 8d1a4986
      unknown authored
        Corrected "include/readline" link for "make distcheck"
      
      
      configure.in:
        Corrected "include/readline" linke for "make distcheck"
      8d1a4986
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · dd0ad09e
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-distcheck
      
      
      configure.in:
        Auto merged
      dd0ad09e
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · d8699ce9
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1-distcheck
      
      
      configure.in:
        Auto merged
      d8699ce9
  5. 18 Nov, 2005 7 commits
    • unknown's avatar
      Bug#13510 "Setting password local variable changes current · 826dbaec
      unknown authored
      password": additional fix, also make sure that a syntax error is 
      returned for set names="foo" when there is no such variable or no
      stored procedure.
      
      
      mysql-test/r/sp-error.result:
        Test results fixed: a new test for Bug#13510
      mysql-test/t/sp-error.test:
        A new test for Bug#13510 (set names out of an SP)
      sql/sql_yacc.yy:
        Bug#13510: fix the case when there is no stored procedure or
        no 'names' variable declared. Return a syntax error in this case.
      826dbaec
    • unknown's avatar
      A test case for Bug#8568 "GROUP_CONCAT returns string, unless in · 13c1d2cb
      unknown authored
      a UNION in which case returns BLOB". The bug is not present anymore.
      
      
      mysql-test/r/func_gconcat.result:
        Bug#8568: test results
      mysql-test/t/func_gconcat.test:
        Add a test case for Bug#8568
      13c1d2cb
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · fe910996
      unknown authored
      into moonbone.local:/work/13622-bug-5.0-mysql
      
      fe910996
    • unknown's avatar
      Netware specific changes for 5.0.16a · 2f840aa9
      unknown authored
      
      client/mysql.cc:
        Fixed option.
      client/mysqladmin.cc:
        Fixed option.
      client/mysqlbinlog.cc:
        Fixed option.
      client/mysqlcheck.c:
        Fixed option.
      client/mysqldump.c:
        Fixed option.
      client/mysqlimport.c:
        Fixed option.
      client/mysqlshow.c:
        Fixed option.
      configure.in:
        Changed version for Netware.
      myisam/myisamchk.c:
        Fixed option.
      myisam/myisampack.c:
        Fixed option.
      netware/mysql_test_run.c:
        NetWare specific changes:
        Define MYSQL_CHECK environment variable to make mysqlcheck test case pass
      2f840aa9
    • unknown's avatar
      Removed forgotten test line in sp-code.test. · 0c801d3b
      unknown authored
      
      mysql-test/r/sp-code.result:
        Removed forgotten test line.
      mysql-test/t/sp-code.test:
        Removed forgotten test line.
      0c801d3b
    • unknown's avatar
      Post-review fixes, mainly fixing all print() methods for sp_instr* classes. · 8bf2b2b7
      unknown authored
      Also added mysql-test files:
       include/is_debug_build.inc
       r/is_debug_build.require
       r/sp-code.result
       t/sp-code.test
      
      
      sql/sp_head.cc:
        Review fixes:
        - Some minor editorial changes
        - Fixed all print() methods for instructions:
          - reserve() enough space
          - check return value from reserve()
          - use qs_append, with length arg, whenever possible
      sql/sp_pcontext.cc:
        Review fixes.
        Also fixed bug in find_cursor().
      sql/sp_pcontext.h:
        Changed parameter names (review fix).
      sql/sql_parse.cc:
        Moved comment. (Review fix)
      mysql-test/include/is_debug_build.inc:
        New BitKeeper file ``mysql-test/include/is_debug_build.inc''
      mysql-test/r/is_debug_build.require:
        New BitKeeper file ``mysql-test/r/is_debug_build.require''
      mysql-test/r/sp-code.result:
        New BitKeeper file ``mysql-test/r/sp-code.result''
      mysql-test/t/sp-code.test:
        New BitKeeper file ``mysql-test/t/sp-code.test''
      8bf2b2b7
    • unknown's avatar
      A test case for Bug#14845 "mysql_stmt_fetch returns MYSQL_NO_DATA · 8fdecfd2
      unknown authored
      when COUNT(*) is 0". The bug itself cannot be repeated.
      
      
      mysql-test/r/sp.result:
        Test results were fixed (Bug#14845)
      mysql-test/t/sp.test:
        An SQL language test case for Bug#14845
      tests/mysql_client_test.c:
        A test case for Bug#14845
      8fdecfd2