1. 20 Oct, 2018 1 commit
  2. 19 Oct, 2018 1 commit
  3. 17 Oct, 2018 1 commit
  4. 15 Oct, 2018 2 commits
  5. 10 Oct, 2018 1 commit
  6. 07 Oct, 2018 1 commit
    • Igor Babaev's avatar
      MDEV-17382 Hash join algorithm should not be used to join materialized · 0b7339eb
      Igor Babaev authored
                 derived table / view by equality
      
      Now rows of a materialized derived table are always put into a
      temporary table before join operation. If BNLH is used to join this
      table with the result of a partial join then both operands of the
      join are actually put into main memory. In most cases this is not
      efficient.
      We could avoid this by sending the rows of the derived table directly
      to the join operation. However this kind of data flow is not supported
      yet.
      Fixed by not allowing usage of hash join algorithm to join a materialized
      derived table if it's joined by an equality predicate of the form
      f=e where f is a field of the derived table.
      0b7339eb
  7. 21 Sep, 2018 10 commits
  8. 20 Sep, 2018 3 commits
  9. 10 Sep, 2018 1 commit
  10. 04 Sep, 2018 2 commits
  11. 03 Sep, 2018 1 commit
  12. 31 Aug, 2018 1 commit
  13. 30 Aug, 2018 1 commit
    • Monty's avatar
      MDEV-16682 Assertion `(buff[7] & 7) == HEAD_PAGE' failed · 42f09ada
      Monty authored
      Problem was that SQL level tried to read a record with rnd_pos()
      that was already deleted by the same statement.
      In the case where the page for the record had been deleted, this
      caused an assert.
      Fixed by extending the assert to also handle empty pages and
      return HA_ERR_RECORD_DELETED for reads to deleted pages.
      42f09ada
  14. 24 Aug, 2018 1 commit
  15. 22 Aug, 2018 1 commit
    • Daniel Black's avatar
      item_cmp_type: simplier for a faster codepath · 064ba8cc
      Daniel Black authored
      The common case for this function is that both types are the same.
      
      The Item_result defination from include/mysql.h.pp is the following enum
         enum Item_result
         {
           STRING_RESULT=0, REAL_RESULT, INT_RESULT, ROW_RESULT, DECIMAL_RESULT,
           TIME_RESULT
         };
      
      The compilers aren't quite smart enough to optimize to this shortcut so
      this makes it quicker.
      
      Before the change:
      
      0000000000012730 <item_cmp_type(Item_result, Item_result)>:
         12730:       89 f0                   mov    %esi,%eax
         12732:       09 f8                   or     %edi,%eax
         12734:       74 4c                   je     12782 <item_cmp_type(Item_result, Item_result)+0x52>
         12736:       83 ff 02                cmp    $0x2,%edi
         12739:       75 0a                   jne    12745 <item_cmp_type(Item_result, Item_result)+0x15>
         1273b:       b8 02 00 00 00          mov    $0x2,%eax
         12740:       83 fe 02                cmp    $0x2,%esi
         12743:       74 3c                   je     12781 <item_cmp_type(Item_result, Item_result)+0x51>
         12745:       83 ff 03                cmp    $0x3,%edi
         12748:       b8 03 00 00 00          mov    $0x3,%eax
         1274d:       74 32                   je     12781 <item_cmp_type(Item_result, Item_result)+0x51>
         1274f:       83 fe 03                cmp    $0x3,%esi
         12752:       74 2d                   je     12781 <item_cmp_type(Item_result, Item_result)+0x51>
         12754:       83 ff 05                cmp    $0x5,%edi
         12757:       b8 05 00 00 00          mov    $0x5,%eax
         1275c:       74 23                   je     12781 <item_cmp_type(Item_result, Item_result)+0x51>
         1275e:       83 fe 05                cmp    $0x5,%esi
         12761:       74 1e                   je     12781 <item_cmp_type(Item_result, Item_result)+0x51>
         12763:       83 ff 04                cmp    $0x4,%edi
         12766:       74 05                   je     1276d <item_cmp_type(Item_result, Item_result)+0x3d>
         12768:       83 ff 02                cmp    $0x2,%edi
         1276b:       75 0f                   jne    1277c <item_cmp_type(Item_result, Item_result)+0x4c>
         1276d:       b8 04 00 00 00          mov    $0x4,%eax
         12772:       83 fe 02                cmp    $0x2,%esi
         12775:       74 0a                   je     12781 <item_cmp_type(Item_result, Item_result)+0x51>
         12777:       83 fe 04                cmp    $0x4,%esi
         1277a:       74 05                   je     12781 <item_cmp_type(Item_result, Item_result)+0x51>
         1277c:       b8 01 00 00 00          mov    $0x1,%eax
         12781:       c3                      retq
         12782:       31 c0                   xor    %eax,%eax
         12784:       c3                      retq
      
      After, noting the short cut and the beginning of the function:
      
      0000000000012730 <item_cmp_type(Item_result, Item_result)>:
         12730:       39 f7                   cmp    %esi,%edi
         12732:       75 03                   jne    12737 <item_cmp_type(Item_result, Item_result)+0x7>
         12734:       89 f8                   mov    %edi,%eax
         12736:       c3                      retq
         12737:       83 ff 03                cmp    $0x3,%edi
         1273a:       b8 03 00 00 00          mov    $0x3,%eax
         1273f:       74 32                   je     12773 <item_cmp_type(Item_result, Item_result)+0x43>
         12741:       83 fe 03                cmp    $0x3,%esi
         12744:       74 2d                   je     12773 <item_cmp_type(Item_result, Item_result)+0x43>
         12746:       83 ff 05                cmp    $0x5,%edi
         12749:       b8 05 00 00 00          mov    $0x5,%eax
         1274e:       74 23                   je     12773 <item_cmp_type(Item_result, Item_result)+0x43>
         12750:       83 fe 05                cmp    $0x5,%esi
         12753:       74 1e                   je     12773 <item_cmp_type(Item_result, Item_result)+0x43>
         12755:       83 ff 04                cmp    $0x4,%edi
         12758:       74 05                   je     1275f <item_cmp_type(Item_result, Item_result)+0x2f>
         1275a:       83 ff 02                cmp    $0x2,%edi
         1275d:       75 0f                   jne    1276e <item_cmp_type(Item_result, Item_result)+0x3e>
         1275f:       b8 04 00 00 00          mov    $0x4,%eax
         12764:       83 fe 02                cmp    $0x2,%esi
         12767:       74 0a                   je     12773 <item_cmp_type(Item_result, Item_result)+0x43>
         12769:       83 fe 04                cmp    $0x4,%esi
         1276c:       74 05                   je     12773 <item_cmp_type(Item_result, Item_result)+0x43>
         1276e:       b8 01 00 00 00          mov    $0x1,%eax
         12773:       c3                      retq
      Signed-off-by: default avatarDaniel Black <daniel@linux.vnet.ibm.com>
      064ba8cc
  16. 20 Aug, 2018 1 commit
  17. 15 Aug, 2018 1 commit
    • Oleksandr Byelkin's avatar
      MDEV-15475: Assertion `!table || (!table->read_set ||... · 1b797e9e
      Oleksandr Byelkin authored
      MDEV-15475: Assertion `!table || (!table->read_set || bitmap_is_set(table->read_set, field_index))' failed on EXPLAIN EXTENDED with constant table and view
      
      Print constant ISNULL value independent.
      Fix of printing of view FRM and CREATE VIEW output
      1b797e9e
  18. 13 Aug, 2018 1 commit
  19. 11 Aug, 2018 1 commit
  20. 07 Aug, 2018 1 commit
  21. 06 Aug, 2018 1 commit
  22. 03 Aug, 2018 1 commit
  23. 31 Jul, 2018 1 commit
  24. 30 Jul, 2018 1 commit
  25. 29 Jul, 2018 1 commit
    • Oleksandr Byelkin's avatar
      Merge remote-tracking branch 'mysql/5.5' into 5.5 · fceda2da
      Oleksandr Byelkin authored
      We do not accept:
      1. We did not have this problem (fixed earlier and better)
       d982e717 Bug#27510150: MYSQLDUMP FAILS FOR SPECIFIC --WHERE CLAUSES
      2. We do not have such options (an DBUG_ASSERT put just in case)
       bbc2e37f Bug#27759871: BACKRONYM ISSUE IS STILL IN MYSQL 5.7
      3. Serg fixed it in other way in this release:
       e48d775c Bug#27980823: HEAP OVERFLOW VULNERABILITIES IN MYSQL CLIENT LIBRARY
      fceda2da
  26. 27 Jul, 2018 1 commit
  27. 25 Jul, 2018 1 commit
    • Varun Gupta's avatar
      MDEV-15454: Nested SELECT IN returns wrong results · 37dee22d
      Varun Gupta authored
      In this case we are setting the field Item_func_eq::in_eqaulity_no for the semi-join equalities.
      This helps us to remove these equalites as the inner tables are not available during parent select execution
      while the outer tables are not available during materialization phase.
      We only have it set for the equalites for the fields involved with the IN subquery
      and reset it for the equalities which do not belong to the IN subquery.
      
      For example in case of nested IN subqueries:
      
          SELECT t1.a FROM t1 WHERE t1.a IN
            (SELECT t2.a FROM t2 where t2.b IN
                (select t3.b from t3 where t3.c=27 ))
      
      there are two equalites involving the fields of the IN subquery
      
      1) t2.b = t3.b :  the field Item_func_eq::in_eqaulity_no is set when we merge the grandchild select into the child select
      2) t1.a = t2.a :  the field Item_func_eq::in_eqaulity_no is set when we merge the child select into the parent select
      
      But when we perform case 2) we should ensure that we reset the equalities in the child's WHERE clause.
      37dee22d