1. 04 Aug, 2010 1 commit
  2. 03 Aug, 2010 1 commit
    • unknown's avatar
      Fix for launchpad bug #612894 · e97bfc36
      unknown authored
      Support of virtual columns added to maria engine.
      
      mysql-test/suite/vcol/r/vcol_handler_maria.result:
        Basic tests for virtual column and maria engine.
      mysql-test/suite/vcol/t/vcol_handler_maria.test:
        Basic tests for virtual column and maria engine.
      storage/maria/ha_maria.cc:
        Support of virtual columns added to maria engine.
      storage/maria/ha_maria.h:
        Support of virtual columns added to maria engine.
      e97bfc36
  3. 28 Jul, 2010 1 commit
    • Igor Babaev's avatar
      Fixed bug #610890. · 60264b00
      Igor Babaev authored
      The CREATE SHOW TABLE command misplaced virtual column specifiers:
      the AS clause for a virtual column was put before optional
      character set attributes, not after them as required by the syntax. 
      60264b00
  4. 26 Jul, 2010 2 commits
  5. 25 Jul, 2010 2 commits
    • Sergei Golubchik's avatar
      fixes for buildbot · 1057c7a2
      Sergei Golubchik authored
      mysql-test/suite/funcs_1/r/is_columns_is.result:
        update for monty changes
      mysql-test/valgrind.supp:
        more generic suppression for dlerror() internal allocations
      scripts/make_win_bin_dist:
        update for hakan changes - we don't generate .map files anymore
      sql/CMakeLists.txt:
        innodb_plugin is said to need .map files in sql/
      1057c7a2
    • Sergei Golubchik's avatar
      merge with 5.1 · 3cd263d4
      Sergei Golubchik authored
      3cd263d4
  6. 24 Jul, 2010 2 commits
  7. 23 Jul, 2010 2 commits
  8. 21 Jul, 2010 3 commits
    • Igor Babaev's avatar
      Merge · 5fc6724e
      Igor Babaev authored
      5fc6724e
    • Igor Babaev's avatar
      Merge · c9cff0bd
      Igor Babaev authored
      c9cff0bd
    • Igor Babaev's avatar
      Fixed bug #607177. · f83a6a66
      Igor Babaev authored
      Due to an invalid check for NULL of the second argument of the 
      Item_func_round items performed in the code of Item_func_round::real_op
      the function ROUND  sometimes could return wrong results.
      f83a6a66
  9. 20 Jul, 2010 3 commits
    • Michael Widenius's avatar
      Fix for LP#588599, mysqlbug#45377: ARCHIVE tables aren't discoverable after OPTIMIZE · a0252d8b
      Michael Widenius authored
      Fix based on code from Stewart Smith
      
      storage/archive/ha_archive.cc:
        Ensure that the frm definition is stored in optimized tables.
      a0252d8b
    • Igor Babaev's avatar
      Fixed bug #607168. · a601dc05
      Igor Babaev authored
      The command CREATE TABLE AS SELECT erroneously preserved the virtual
      properties of the virtual fields from the select list. 
      a601dc05
    • Igor Babaev's avatar
      Fixed bug #607566. · 763e4c4d
      Igor Babaev authored
      For queries with order by clauses that employed filesort usage of
      virtual column references in select lists could trigger assertion
      failures. It happened because a wrong vcol_set bitmap was used for
      filesort. It turned out that filesort required its own vcol_set bitmap.
      
      Made management of the vcol_set bitmaps similar to the management
      of the read_set and write_set bitmaps.  
      763e4c4d
  10. 19 Jul, 2010 2 commits
  11. 17 Jul, 2010 2 commits
    • Igor Babaev's avatar
      Merge · 1ee37b40
      Igor Babaev authored
      1ee37b40
    • Igor Babaev's avatar
      Fixed bug #604503. · 1b165329
      Igor Babaev authored
      If the expression for a virtual column of table contained datetime
      comparison then the execution of the second query that used this
      virtual column caused a crash. It happened because the execution
      of the first query that used this virtual column inserted a cached
      item into the expression tree. The cached tree was allocated in
      the statement memory while the expression tree was allocated in
      the table memory.
      Now the cached items that are inserted into expressions for virtual
      columns with datetime comparisons are always allocated in the same
      mem_root as the expressions for virtual columns. So now the inserted
      cached items are valid for any queries that use these virtual columns. 
      1b165329
  12. 16 Jul, 2010 5 commits
    • Michael Widenius's avatar
      Merge with MariaDB 5.1 · c355cf92
      Michael Widenius authored
      c355cf92
    • Michael Widenius's avatar
      Merge patch for ha_rnd_init() · 1d16f2e7
      Michael Widenius authored
      1d16f2e7
    • Michael Widenius's avatar
      Fix for LP#588251: doStartTableScan() result not checked. · b55104d9
      Michael Widenius authored
      The issue was that we didn't always check result of ha_rnd_init() which caused a problem for handlers that returned an error in this code.
      - Changed prototype of ha_rnd_init() to ensure that we get a compile warning if result is not checked.
      - Added ha_rnd_init_with_error() that prints error on failure.
      - Checked all usage of ha_rnd_init() and ensure we generate an error message on failures.
      - Changed init_read_record() to return 1 on failure.
      
      
      
      
      sql/create_options.cc:
        Fixed wrong printf
      sql/event_db_repository.cc:
        Check result from init_read_record()
      sql/events.cc:
        Check result from init_read_record()
      sql/filesort.cc:
        Check result from ha_rnd_init()
      sql/ha_partition.cc:
        Check result from ha_rnd_init()
      sql/ha_partition.h:
        Fixed compiler warning
      sql/handler.cc:
        Added ha_rnd_init_with_error()
        Check result from ha_rnd_init()
      sql/handler.h:
        Added ha_rnd_init_with_error()
        Changed prototype of ha_rnd_init() to ensure that we get a compile warning if result is not checked
      sql/item_subselect.cc:
        Check result from ha_rnd_init()
      sql/log.cc:
        Check result from ha_rnd_init()
      sql/log_event.cc:
        Check result from ha_rnd_init()
      sql/log_event_old.cc:
        Check result from ha_rnd_init()
      sql/mysql_priv.h:
        init_read_record() now returns error code on failure
      sql/opt_range.cc:
        Check result from ha_rnd_init()
      sql/records.cc:
        init_read_record() now returns error code on failure
        Check result from ha_rnd_init()
      sql/sql_acl.cc:
        Check result from init_read_record()
      sql/sql_cursor.cc:
        Print error if ha_rnd_init() fails
      sql/sql_delete.cc:
        Check result from init_read_record()
      sql/sql_help.cc:
        Check result from init_read_record()
      sql/sql_plugin.cc:
        Check result from init_read_record()
      sql/sql_select.cc:
        Check result from ha_rnd_init()
        Print error if ha_rnd_init() fails.
      sql/sql_servers.cc:
        Check result from init_read_record()
      sql/sql_table.cc:
        Check result from init_read_record()
      sql/sql_udf.cc:
        Check result from init_read_record()
      sql/sql_update.cc:
        Check result from init_read_record()
      storage/example/ha_example.cc:
        Don't return error on rnd_init()
      storage/ibmdb2i/ha_ibmdb2i.cc:
        Removed not relevant comment
      b55104d9
    • Michael Widenius's avatar
      Fixed wrong error message from federatedx (which could lead to assert in DBUG code) · 11f5be5d
      Michael Widenius authored
      mysql-test/suite/federated/federated_server.result:
        Update to new error message
      mysql-test/suite/federated/federated_server.test:
        Update to new error message
      storage/federatedx/ha_federatedx.cc:
        Return real error code, not 0, as in some cases before.
      11f5be5d
    • Michael Widenius's avatar
      mysql client: Ignore --comments at start of command line. This allows one to... · 77cb9a78
      Michael Widenius authored
      mysql client: Ignore --comments at start of command line. This allows one to more easily run mysqltest tests trough the command line.
      Fixed bug: LP#603026 RQG: pagecache_read: Assertion `pageno < ((1ULL) << 40)' on OPTIMIZE TABLE of a Maria table  
      
      client/mysql.cc:
        Removed Oracle copyright from stdout, as Oracle doesn't have copyright to all code in this file.
        Ignore --comments at start of command line. This allows one to more easily run mysqltest tests trough the command line.
      mysql-test/suite/maria/r/optimize.result:
        Added test for LP#603026
      mysql-test/suite/maria/t/optimize.test:
        Added test for LP#603026
      sql/net_serv.cc:
        Removed DBUG_ASSERT(), as this code can happen during testing.
      storage/maria/ma_check.c:
        Fixed bug: LP#603026 RQG: pagecache_read: Assertion `pageno < ((1ULL) << 40)' on OPTIMIZE TABLE of a Maria table  
        The problem was duplicated memory usage with long packed keys.
      77cb9a78
  13. 15 Jul, 2010 1 commit
    • Igor Babaev's avatar
      Fixed bug #603186. · 6ada5e3f
      Igor Babaev authored
      There were two problems that caused wrong results reported with this bug.
      1. In some cases stored(persistent) virtual columns were not marked
      in the write_set and in the vcol_set bitmaps.
      2. If the list of fields in an insert command was empty then the values of
      the stored virtual columns were set to default.
      
      To fix the first problem the function st_table::mark_virtual_columns_for_write
      was modified. Now the function has a parameter that says whether the virtual 
      columns are to be marked for insert or for update.  
      To fix the second problem a special handling of empty insert lists is
      added in the function fill_record().
      6ada5e3f
  14. 13 Jul, 2010 2 commits
    • Igor Babaev's avatar
      Fixed bug #603654. · df7548f6
      Igor Babaev authored
      If a virtual column was used in the ORDER BY clause of a query
      and some of the columns this virtual column was based upon were
      not referenced anywhere in the query then the execution of the
      query could cause an assertion failure.
      It happened because in this case the bitmap of the columns used
      for ordering keys was not formed correctly.
      df7548f6
    • Igor Babaev's avatar
      Fixed bug #604549. · bc013072
      Igor Babaev authored
      There was no error thrown when creating a table with a virtual table
      computed by an expression returning a row.
      This caused a crash when inserting into the table.
      
      Removed periods at the end of the error messages for virtual columns.
      Adjusted output in test result files accordingly. 
      bc013072
  15. 09 Jul, 2010 2 commits
  16. 07 Jul, 2010 1 commit
  17. 03 Jul, 2010 1 commit
    • Igor Babaev's avatar
      Fixed bug #601164. · cb25707c
      Igor Babaev authored
      The functions mysql_delete and mysql_update lacked calls of
      updated_virtual_fields(). This caused wrong results for
      some DELETEs/UPDATEs.
      Added test cases for this bug.
      cb25707c
  18. 02 Jul, 2010 1 commit
  19. 01 Jul, 2010 4 commits
  20. 30 Jun, 2010 1 commit
  21. 29 Jun, 2010 1 commit