1. 02 Dec, 2008 3 commits
    • vasil's avatar
      branches/zip: · 565c0fe0
      vasil authored
      Remove an entry from the ChnageLog for a change that was made before
      the release of 1.0.2 but was not included in that release.
      565c0fe0
    • vasil's avatar
      branches/zip: · b35f6645
      vasil authored
      Add entry in the ChangeLog for the release of 1.0.2.
      b35f6645
    • marko's avatar
      branches/zip: page_cur_insert_rec_zip(): When allocating insert_buf · de011c21
      marko authored
      from the free list, zero out the DB_TRX_ID and DB_ROLL_PTR of the
      deleted record if the new record would not overwrite these
      fields. This fixes a harmless content mismatch reported by
      page_zip_validate() that was reported as Issue #111.
      rb://55 approved by Sunny Bains.
      de011c21
  2. 28 Nov, 2008 1 commit
  3. 27 Nov, 2008 3 commits
    • vasil's avatar
      branches/zip: · f5abca16
      vasil authored
      Non-functional change in win-plugin/win-plugin.diff: fix the file name
      before the diff, this is irrelevant but it is nice to be the same as
      the file name on the following line.
      f5abca16
    • vasil's avatar
      branches/zip: · 2a028069
      vasil authored
      * Remove a change from win-plugin/win-plugin.diff about time_t because
        MySQL has used VS2005 for building 5.1.30.
      
      * Adjust the line numbers so the patch applies cleanly without fuzz and
        offset messages.
      
      Submitted by:	Calvin
      2a028069
    • vasil's avatar
      branches/zip: · 5bd71ba1
      vasil authored
      Fix Mantis issue#130 wdl: does not handle 64-bit address
      
      - Change the call from strtoul() to strtoull()
      - Change "%16X" to "%16llx" when scanning preferred load address
      
      rb://58
      
      Submitted by:	Calvin
      Approved by:	Marko
      5bd71ba1
  4. 26 Nov, 2008 1 commit
    • marko's avatar
      branches/zip: row_merge_drop_temp_indexes(): Replace the WHILE 1 with · afe9ee1f
      marko authored
      WHILE 1=1 in the SQL procedure, so that the loop will actually be
      entered and temporary indexes be dropped during crash recovery.
      Thanks to Sunny Bains for pointing this out.
      
      Tested as follows:
      
      Set a breakpoint in row_merge_rename_indexes.
      
      CREATE TABLE t(a INT)ENGINE=InnoDB;
      CREATE INDEX a ON t(a);
      
      -- The breakpoint will be reached.  Kill and restart mysqld.
      SHOW CREATE TABLE t;
      -- This shows the MySQL .frm file, without and index.
      CREATE TABLE innodb_table_monitor(a INT)ENGINE=InnoDB;
      -- This will dump the InnoDB dictionary to the error log, without the index.
      afe9ee1f
  5. 24 Nov, 2008 1 commit
  6. 21 Nov, 2008 3 commits
  7. 20 Nov, 2008 3 commits
  8. 19 Nov, 2008 1 commit
  9. 17 Nov, 2008 2 commits
    • michael's avatar
      branches/zip: rb://53 · 337c4d95
      michael authored
      Final version of rb://53, fixes the styling of a comment, makes
      the definition and the declaration of thd_supports_xa() identical commentwise.
      337c4d95
    • michael's avatar
      branches/zip: · c6227f37
      michael authored
      rb://53
      
      Improve innodb_supports_xa system variable handling and 
      reduces the number of retrievals of the value from MySQL.
      
      Approved by: Marko, over IM
      c6227f37
  10. 12 Nov, 2008 2 commits
  11. 11 Nov, 2008 1 commit
    • marko's avatar
      branches/zip: ha_innobase::create(): Remove the dependences on · 426fccde
      marko authored
      DICT_TF_ZSSIZE_MAX, so that the code can be compiled with a different
      uncompressed page size by redefining UNIV_PAGE_SIZE_SHIFT in univ.i.
      Currently, the allowed values are 12, 13, or 14 (4k, 8k, 16k).
      
      Make the default compressed page size half the uncompressed page size.
      The previous default was 8 kilobytes, which is the same when compiling
      with the default 16k uncompressed page size.
      
      rb://50 approved by Pekka Lampio and Sunny Bains.
      426fccde
  12. 04 Nov, 2008 2 commits
    • calvin's avatar
      branches/zip: windows plugin - fix references to array variables. · bf9b5f06
      calvin authored
      This problem surfaced when running new test innodb_bug40360.test. Both
      tx_isolation_names and binlog_format_names are name arrays, and
      should be defined as wdl_tx_isolation_names and wdl_binlog_format_names,
      not *wdl_tx_isolation_names and *wdl_binlog_format_names.
      
      Another array variable is all_charsets, which is already correctly
      defined.
      
      Approved by:	Marko (on IM)
      bf9b5f06
    • calvin's avatar
      branches/zip: ignore the failure when builtin_innobase_plugin is not · 9b11f7d8
      calvin authored
      available.
      
      External variable builtin_innobase_plugin is not available when mysqld
      does not have a builtin InnoDB. The init of the Windows plugin should
      not fail in this case. 
      
      Approved by:	Marko (on IM)
      9b11f7d8
  13. 31 Oct, 2008 8 commits
    • marko's avatar
      branches/zip: scripts/install_innodb_plugins_win.sql: New script, · 5b4736c6
      marko authored
      for installing the InnoDB plugins in Windows.  Copied from
      scripts/install_innodb_plugins.sql.
      5b4736c6
    • vasil's avatar
      branches/zip: · b95ccf91
      vasil authored
      White-space cleanup in ChangeLog.
      b95ccf91
    • vasil's avatar
      branches/zip: · 375e9750
      vasil authored
      Fix Mantis issue#106 plugin init error:InnoDB: stats_on_metadata in static
      InnoDB (flags=0x2401) differs from stats_on_metadata in dynamic InnoDB (fl
      
      Ignore the NOSYSVAR flag in addition to ignoring the READONLY flag.
      
      Approved by:	Marko (https://svn.innodb.com/rb/r/42/)
      375e9750
    • calvin's avatar
      branches/zip: Windows plugin part of r2944 · a019e95a
      calvin authored
      r2944 has reference to mysql_bin_log.is_open(), which is new in InnoDB.
      Add two new entries and remove one duplicate in mysqld.def & 
      mysqld_x64.def.
      a019e95a
    • marko's avatar
    • sunny's avatar
      branches/zip: Update ChangeLog with r2943 info. · b5c757cb
      sunny authored
      b5c757cb
    • vasil's avatar
      branches/zip: · 729ff1ad
      vasil authored
      Revert our temporary fix for "Bug#40360 Binlog related errors with binlog off"
      (r2935, r2936) and deploy MySQL's one, but put the function
      mysql_bin_log_is_engaged() inside mysql_addons.cc instead of in mysql's log.cc
      and use a different name for it so there is no collision when MySQL adds this
      function in log.cc.
      
      [note from the future: the windows part of this patch went into r2947]
      
      Approved by:	Marko (https://svn.innodb.com/rb/r/41/)
      729ff1ad
    • sunny's avatar
      branches/zip: · 7fed1c70
      sunny authored
        1. We add a vector of locks to trx_t. This array contains the autoinc
        locks granted to a transaction. There is one per table.
      
        2. We enforce releasing of these locks in the reverse order from the
        one in which they are acquired. The assumption is that since the
        AUTOINC locks are statement level locks. Nested statements introduced
        by triggers are stacked it should hold.
      
      There was some cleanup done to the vector code too by adding const and
      some new functions. Rename dict_table_t::auto_inc_lock to autoinc_lock.
      
      Fix Bug#26316 Triggers create duplicate entries on auto-increment columns
      rb://22
      7fed1c70
  14. 30 Oct, 2008 7 commits
    • vasil's avatar
      branches/zip: · eb1b8095
      vasil authored
      Increment the InnoDB Plugin version from 1.0.1 to 1.0.2.
      eb1b8095
    • marko's avatar
      acf0e85e
    • marko's avatar
    • vasil's avatar
      branches/zip: · 39b7e02a
      vasil authored
      Non-functional change: convert handler/handler0vars.h and
      handler/win_delay_loader.cc from \r\n (dos) to \n (unix) line terminators.
      39b7e02a
    • vasil's avatar
      branches/zip: · 05cb12e6
      vasil authored
      Add ChangeLog entry for Bug#40360 Binlog related errors with binlog off
      05cb12e6
    • vasil's avatar
      branches/zip: · 69977f27
      vasil authored
      Followup to r2935: add the Windows Delay Loader stuff for the MySQL
      variable that we are accessing. If someday we have another solution for
      Bug#40360 Binlog related errors with binlog off
      then this should also be reverted.
      69977f27
    • vasil's avatar
      branches/zip: · c368f38f
      vasil authored
      Fix "Bug#40360 Binlog related errors with binlog off" in InnoDB code in order
      to have a Bug#40360-free InnoDB Plugin 1.0.2.
      
      The fix does check whether binary logging is enabled in MySQL by accessing the
      opt_bin_log global variable that is defined in sql/mysqld.cc.
      
      In case MySQL does develop another solution to this via Bug#40360 then we can
      revert this patch (except the mysql-tests).
      
      The windows-plugin part of this fix will be committed as a separate commit to
      ease eventual merge into branches/5.1 [note from the future: the separate
      commit went into r2936].
      
      Approved by:	Marko (https://svn.innodb.com/rb/r/39)
      c368f38f
  15. 29 Oct, 2008 2 commits
    • vasil's avatar
      branches/zip: · 0f2b6ec6
      vasil authored
      Add 2 ChangeLog entries for the 2 bugfixes that were merged from branches/5.1.
      0f2b6ec6
    • marko's avatar
      branches/zip: Merge revisions 2854:2929 from branches/5.1, · bd3514db
      marko authored
      except r2924, which was merged from branches/zip r2866 to branches/5.1
      and except r2879 which was merged separately by Calvin:
      
        ------------------------------------------------------------------------
        r2902 | vasil | 2008-10-28 12:10:25 +0200 (Tue, 28 Oct 2008) | 10 lines
      
        branches/5.1:
      
        Fix Bug#38189 innodb_stats_on_metadata missing
      
        Make the variable innodb_stats_on_metadata visible to the users and
        also settable at runtime. Previously it was only "visible" as a command
        line startup option to mysqld.
      
        Approved by:    Marko (https://svn.innodb.com/rb/r/36)
        ------------------------------------------------------------------------
        r2929 | marko | 2008-10-29 21:26:14 +0200 (Wed, 29 Oct 2008) | 13 lines
      
        branches/5.1: dtype_get_sql_null_size(): return the correct storage
        size of a SQL NULL column. (Bug #40369)
      
        When MySQL Bug #20877 was fixed in r834, this function was
        accidentally modified to return 0 or 1. Apparently, the only impact of
        this bug is that fixed-length columns cannot be updated in-place from
        or to SQL NULL, even in ROW_FORMAT=REDUNDANT.  After this fix,
        fixed-length columns in ROW_FORMAT=REDUNDANT will have a constant
        storage size as they should, no matter if NULL or non-NULL.  The bug
        caused fixed-length NULL columns to occupy 1 byte.
      
        rb://37 approved by Heikki over IM.
        ------------------------------------------------------------------------
      bd3514db