1. 11 Jan, 2008 2 commits
  2. 05 Nov, 2007 2 commits
  3. 03 Nov, 2007 1 commit
    • unknown's avatar
      BUG#31611 (Security risk with BINLOG statement): · 0a6f3032
      unknown authored
      Adding check that the user executing a BINLOG statement has SUPER
      privileges and aborting execution of the statement with an error
      otherwise.
      
      
      mysql-test/r/mysqlbinlog.result:
        Result change.
      mysql-test/t/mysqlbinlog.test:
        Adding test that generates a BINLOG command for inserting data into a
        table and feed the BINLOG statement into the database as an untrusted
        user. Also checking that insertion into the table fails for that user
        and that the table only contain a single line: the original one inserted.
      sql/sql_binlog.cc:
        Adding a check that the executor of the BINLOG command has
        SUPER privileges and give an error and abort execution if not.
      0a6f3032
  4. 28 Sep, 2007 1 commit
    • unknown's avatar
      Preliminary fix for · 4d688088
      unknown authored
         Bug #30759  	mysql_install_db fails to set $extra_bindir properly in all cases.
      
      
      scripts/mysql_install_db.sh:
        Preliminary fix for
           Bug #30759  	mysql_install_db fails to set $extra_bindir properly in all cases.
        
        Provided by Daniel for the 5.1.22-rc build, to be superseded by a better patch when that is available.
      4d688088
  5. 24 Sep, 2007 2 commits
  6. 20 Sep, 2007 2 commits
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.1-release · ada4c954
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b31076-mysql-5.1-release
      
      ada4c954
    • unknown's avatar
      BUG#31076 (Server crashes when start slave is issued): · 0cbf0f8e
      unknown authored
      Row-based replication crashes when replicating from pre-5.1.22 to 5.1.22
      due to an uninitialized variable.
      
      
      sql/log_event.cc:
        Initializing m_null_bits to null so that it can be detected that it
        was not initialized later.
      mysql-test/suite/rpl/r/rpl_bug31076.result:
        New BitKeeper file ``mysql-test/suite/rpl/r/rpl_bug31076.result''
      mysql-test/suite/rpl/t/rpl_bug31076.test:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_bug31076.test''
      0cbf0f8e
  7. 14 Sep, 2007 1 commit
    • unknown's avatar
      Bug #31001: ORDER BY DESC in InnoDB not working · 9cde3729
      unknown authored
      The optimizer sets index traversal in reverse order only if there are 
      used key parts that are not compared to a constant.
      However using the primary key as an ORDER BY suffix rendered the check
      incomplete : going in reverse order must still be used even if 
      all the parts of the secondary key are compared to a constant.
      
      Fixed by relaxing the check and set reverse traversal even when all
      the secondary index keyparts are compared to a const.
      Also account for the case when all the primary keys are compared to a
      constant.
      
      
      mysql-test/include/mix1.inc:
        Bug #31001: test case
      mysql-test/r/innodb_mysql.result:
        Bug #31001: test case
      sql/sql_select.cc:
        Bug #31001: 
         - account for the case when all the primary key parts are compared
           to a constant.
         - force test_if_skip_sort_order to go backwards over the key even 
           when the number of keyparts used is the same as the number of
           keyparts equal to a constant. (because of the primary key
           suffix).
      9cde3729
  8. 13 Sep, 2007 3 commits
    • unknown's avatar
      scripts/mysqld_safe.sh · b302776b
      unknown authored
          Copy a fix by jperkin for bug#30624 into the 5.1.22 build tree.
      
      
      scripts/mysqld_safe.sh:
        Copy a fix by jperkin for bug#30624 into the 5.1.22 build tree.
      b302776b
    • unknown's avatar
      fix intermittant timing-related test failure · 7d5e9dc2
      unknown authored
      7d5e9dc2
    • unknown's avatar
      Changes for pushbuild test runs and VSC compile warnings · fe567d54
      unknown authored
      
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        Fix test results for pushbuild
      mysql-test/suite/rpl/t/rpl_innodb_bug28430.test:
        Fix test results for pushbuild
      mysql-test/suite/rpl/t/rpl_innodb_bug30888.test:
        Fix test results for pushbuild
      storage/innobase/handler/ha_innodb.cc:
        resolve a VSC++ typecast compile warning.
      fe567d54
  9. 12 Sep, 2007 1 commit
    • unknown's avatar
      undo unneccessary change to ha_innodb.cc · a77e4ee4
      unknown authored
      remove 'drop database' from new tests.
      
      
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        remove "DROP DATABASE test"
      mysql-test/suite/rpl/r/rpl_innodb_bug30888.result:
        remove "DROP DATABASE test"
      mysql-test/suite/rpl/r/rpl_innodb_bug30919.result:
        remove "DROP DATABASE test"
      mysql-test/suite/rpl/t/rpl_innodb_bug28430.test:
        remove "DROP DATABASE test"
      mysql-test/suite/rpl/t/rpl_innodb_bug30888.test:
        remove "DROP DATABASE test"
      mysql-test/suite/rpl/t/rpl_innodb_bug30919.test:
        remove "DROP DATABASE test"
      storage/innobase/handler/ha_innodb.cc:
        undo unneccessary edits.
      a77e4ee4
  10. 09 Sep, 2007 1 commit
    • unknown's avatar
      Bug#30919 · c48f059c
      unknown authored
        "Rows not deleted from innodb partitioned tables if --innodb_autoinc_lock_mode=0"
      
        Due to a previous bugfix which initializes a previously uninitialized
        variable, ha_partition::get_auto_increment() may fail to operate
        correctly when the storage engine reports that it is only reserving
        one value and one or more partitions have a different 'next-value'.
        Currently, only affects Innodb's new-style auto-increment code which
        reserves larger blocks of values and has less inter-thread contention.
      
      
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        Fix results - previous results shows symptoms of Bug30919
      sql/ha_partition.cc:
        Bug30919
        
        ha_partition::write_row()
          Do not insert a row if a failure occurred while generating
          auto-increment value.
        
        ha_partition::get_auto_increment()
          If there is an empty 'intersection' of auto-increment values, perform
          a second pass before failing because partitions may have different
          auto-increment 'next-value' attributes.
      storage/innobase/handler/ha_innodb.cc:
        Bug30919
          Only set *first_value if it is less than autoinc value. This allows
          a higher value to be hinted when operating as a partitioned table.
      mysql-test/suite/rpl/r/rpl_innodb_bug30919.result:
        New BitKeeper file ``mysql-test/suite/rpl/r/rpl_innodb_bug30919.result''
      mysql-test/suite/rpl/t/rpl_innodb_bug30919-master.opt:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug30919-master.opt''
      mysql-test/suite/rpl/t/rpl_innodb_bug30919.test:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug30919.test''
      c48f059c
  11. 08 Sep, 2007 2 commits
    • unknown's avatar
      perform explicit cleanup · 0bafea24
      unknown authored
      add missing opt file
      
      
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        explicit post-test cleanup
      mysql-test/suite/rpl/r/rpl_innodb_bug30888.result:
        explicit post-test cleanup
      mysql-test/suite/rpl/t/rpl_innodb_bug28430.test:
        explicit post-test cleanup
      mysql-test/suite/rpl/t/rpl_innodb_bug30888.test:
        explicit post-test cleanup
      mysql-test/suite/rpl/t/rpl_innodb_bug28430-slave.opt:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug28430-slave.opt''
      0bafea24
    • unknown's avatar
      Bug#30907 · e19f1bfd
      unknown authored
        "Regression: "--innodb_autoinc_lock_mode=0" (off) not same as older releases"
      Bug#28430
        "Failure in replication of innodb partitioned tables on row/mixed format"
      Bug#30888
        "Innodb table + stored procedure + row deletion = server crash"
      
        Apply Oracle patch from Sunny
        Include tests cases by Omer
        Ensure that innobase_read_and_init_auto performs table autoinc lock when lock_mode = 0
        No need for "if" guard around row_unlock_table_autoinc_for_mysql() because
        it already performs same check.
        Make autoinc_lock_mode variable read-only for duration of running mysqld process.
      
      
      storage/innobase/handler/ha_innodb.cc:
        Bug30907/28430
          "Regression: "--innodb_autoinc_lock_mode=0" (off) not same as older releases"
          "Failure in replication of innodb partitioned tables on row/mixed format"
          Apply Oracle patch from Sunny
          Ensure that innobase_read_and_init_auto performs table autoinc lock when lock_mode = 0
          No need for "if" guard around row_unlock_table_autoinc_for_mysql() because
          it already performs same check.
          Make autoinc_lock_mode variable read-only for duration of running mysqld process.
      storage/innobase/row/row0sel.c:
        Bug30888
          "Innodb table + stored procedure + row deletion = server crash"
        
          Remove endian-specific code.
          Fix function row_search_autoinc_read_column() to handle any integer size up to 8 bytes.
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        New BitKeeper file ``mysql-test/suite/rpl/r/rpl_innodb_bug28430.result''
      mysql-test/suite/rpl/r/rpl_innodb_bug30888.result:
        New BitKeeper file ``mysql-test/suite/rpl/r/rpl_innodb_bug30888.result''
      mysql-test/suite/rpl/t/rpl_innodb-master.opt:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb-master.opt''
      mysql-test/suite/rpl/t/rpl_innodb_bug28430-master.opt:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug28430-master.opt''
      mysql-test/suite/rpl/t/rpl_innodb_bug28430.test:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug28430.test''
      mysql-test/suite/rpl/t/rpl_innodb_bug30888.test:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug30888.test''
      e19f1bfd
  12. 07 Sep, 2007 3 commits
    • unknown's avatar
      ha_partition.cc, listener.h, listener.cc, ha_partition.h: · ef69dcbc
      unknown authored
        Initiate static const outside class definition
      
      
      server-tools/instance-manager/listener.cc:
        Initiate static const outside class definition
      server-tools/instance-manager/listener.h:
        Initiate static const outside class definition
      sql/ha_partition.cc:
        Initiate static const outside class definition
      sql/ha_partition.h:
        Initiate static const outside class definition
      ef69dcbc
    • unknown's avatar
      azio.c, azlib.h: · f220d76b
      unknown authored
        Don't use typedef 'voidpc' as later addition and not needed
      
      
      storage/archive/azlib.h:
        Don't use typedef 'voidpc' as later addition and not needed
      storage/archive/azio.c:
        Don't use typedef 'voidpc' as later addition and not needed
      f220d76b
    • unknown's avatar
      Modifications to funcs_1 files for 5.1.22rc release including: · 688948aa
      unknown authored
       - Updated row help count information
       - Added missing 'order by' clauses (altrady fixed in build tree)
       - Fixed isses with ndb_storeproc06/10 tests (added use database)
       - Corrected use of wrong engine in ndb tests (already fixed in build tree)
       - Update to ndb__datadict to replect additional fields in I_S (already corrected in build tree)
      
      
      mysql-test/suite/funcs_1/include/ndb_tb2.inc:
        Correction of wrong engine used for ndb test
      mysql-test/suite/funcs_1/r/innodb__datadict.result:
        Updated result file
      mysql-test/suite/funcs_1/r/innodb_storedproc_06.result:
        Updated result file
      mysql-test/suite/funcs_1/r/innodb_storedproc_10.result:
        Updated result file
      mysql-test/suite/funcs_1/r/innodb_views.result:
        Updated result file
      mysql-test/suite/funcs_1/r/memory__datadict.result:
        Updated result file
      mysql-test/suite/funcs_1/r/memory_storedproc_06.result:
        Updated result file
      mysql-test/suite/funcs_1/r/memory_storedproc_10.result:
        Updated result file
      mysql-test/suite/funcs_1/r/memory_views.result:
        Updated result file
      mysql-test/suite/funcs_1/r/myisam__datadict.result:
        Updated result file
      mysql-test/suite/funcs_1/r/myisam_storedproc_06.result:
        Updated result file
      mysql-test/suite/funcs_1/r/myisam_storedproc_10.result:
        Updated result file
      mysql-test/suite/funcs_1/r/myisam_views.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb__datadict.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_cursors.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_func_view.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_storedproc_06.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_storedproc_07.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_storedproc_08.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_storedproc_10.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_0102.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_03.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_03e.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_0407.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_08.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_09.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_1011ext.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_views.result:
        Updated result file
      mysql-test/suite/funcs_1/storedproc/storedproc_06.inc:
        Updated test file enforcing 'use database' after connect
      mysql-test/suite/funcs_1/storedproc/storedproc_10.inc:
        Updated test file enforcing 'use database' after connect
      mysql-test/suite/funcs_1/views/views_master.inc:
        Adding order by clauses in missing places
      688948aa
  13. 01 Sep, 2007 1 commit
    • unknown's avatar
      Makefile.am: · 709b9305
      unknown authored
        Traditional make wants line to start with TAB
      
      
      Makefile.am:
        Traditional make wants line to start with TAB
      709b9305
  14. 31 Aug, 2007 1 commit
    • unknown's avatar
      configure.in: · f2eb009e
      unknown authored
        beta => rc
      
      
      configure.in:
        beta => rc
      f2eb009e
  15. 30 Aug, 2007 1 commit
  16. 29 Aug, 2007 5 commits
    • unknown's avatar
      Fix pushbuild test failures which occur on big-endian systems. · 952df32e
      unknown authored
        Do not convert innodb autoincrement value to little endian when on
        big endian systems.
      
      
      storage/innobase/row/row0sel.c:
        Do not convert innodb autoincrement value to little endian when on
        big endian systems.
      952df32e
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bk/b29968-merge-5.1-rpl · ddad265c
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/merge-5.1-target-5.1.22
      
      ddad265c
    • unknown's avatar
      BUG#29968 (rpl_ndb_circular.test and rpl_ndb_log.test fail): · 84e3c51d
      unknown authored
      Removing unguarded read of slave_running field from inside
      terminate_slave_threads(). This could cause premature exit in the event
      that the slave thread already were shutting down, but isn't finished yet.
      
      The fields slave_running, io_thd, and sql_thread are guarded by an
      associated run_lock. A read of these fields were not guarded inside
      terminate_slave_threads(), which caused an assertion to fire. The
      assertion was removed, and the code reorganized slightly.
      
      
      sql/slave.cc:
        Changing signature of terminate_slave_thread() to accept a skip_lock
        parameter instead of two mutexes. This mimics the signature of the
        terminate_slave_threads() function. Code is also changed as a result
        of this.
        
        Removing unguarded check of slave_running field in the master info and
        relay log info structure since that could cause premature exit of
        terminate_slave_threads().
        
        The thread variable for each of the slave threads can change before
        acquiring the run_lock mutex inside terminate_slave_thread(). Hence
        an assertion was removed that read the variable without guarding it
        with run_lock.
        
        Code that checked *slave_running status inside terminate_slave_thread()
        was reorganized slightly.
      sql/slave.h:
        Moving terminate_slave_thread() to use internal linkage.
      84e3c51d
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.1-target-5.1.22 · 0a0fe5b7
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-target-5.1.22
      
      0a0fe5b7
    • unknown's avatar
      Bug#29549 rpl_ndb_myisam2ndb,rpl_ndb_innodb2ndb failed on Solaris for pack_length issue · 9d968baa
      unknown authored
      - reverting patch as there where unknows sideeffects that we do not have time to follow up on just now
      
      9d968baa
  17. 28 Aug, 2007 8 commits
  18. 27 Aug, 2007 3 commits
    • unknown's avatar
      Merge quant.(none):/ext/mysql/bkroot/mysql-5.1-target-5.1.22 · f93e5e4a
      unknown authored
      into  quant.(none):/ext/mysql/bk/mysql-5.1-bug21842-5.1.22-merge
      
      f93e5e4a
    • unknown's avatar
      Bug #30389: connection_id() always return 0 in embedded server · 790ddf4c
      unknown authored
        
      Initialize thd->variables.pseudo_thread_id when a new embedded
      thd is created.
      
      
      libmysqld/lib_sql.cc:
        Add comment regarding duplication of code in create_embedded_thd()
        vs. create_new_thread() and prepare_new_connection_state().  This
        was a cause for not properly initializing the pseudo_thread_id variable.
      mysql-test/r/func_misc.result:
        Add test case to ensure connection_id() returns a sane value
      mysql-test/t/func_misc.test:
        Add test case to ensure connection_id() returns a sane value
      sql/mysqld.cc:
        Add comment warning of the duplication of code between create_new_thread()
        and create_embedded_thd()
      sql/sql_connect.cc:
        Add comment warning of the duplication of code between
        prepare_new_connection_state() and create_embedded_thd()
      790ddf4c
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1-target-5.1.22 · d9714300
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/51-target22-X
      
      
      sql/ha_partition.cc:
        Auto merged
      d9714300