1. 29 Feb, 2008 1 commit
  2. 28 Feb, 2008 6 commits
    • unknown's avatar
      Merge buzz.(none):/home/davi/mysql-5.0-runtime · 066df249
      unknown authored
      into  buzz.(none):/home/davi/mysql-5.1-runtime
      
      
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/limit.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/item.cc:
        Auto merged
      mysql-test/suite/rpl/r/rpl_user_variables.result:
        Manual merge
      mysql-test/suite/rpl/t/rpl_user_variables.test:
        Manual merge
      sql/sql_yacc.yy:
        Manual merge
      066df249
    • unknown's avatar
      Post-merge fix for Bug 33851. The initialization order of members · bc489574
      unknown authored
      must match the order which they were declared in the class definition. 
      
      
      sql/item.cc:
        Fix initialization order, parameter was the last one declared.
      bc489574
    • unknown's avatar
      Bug#34655 Compile error · ba02c492
      unknown authored
      Rename client_last_error to last_error and client_last_errno to last_errno
      to not break connectors which use the internal net structure for error handling.
      
      
      include/mysql_com.h:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      include/mysql_h.ic:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      libmysql/libmysql.c:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      libmysql/manager.c:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      libmysqld/lib_sql.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      libmysqld/libmysqld.c:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      server-tools/instance-manager/mysql_connection.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      sql/log_event.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      sql-common/client.c:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      sql/log_event_old.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      sql/net_serv.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      sql/repl_failsafe.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      ba02c492
    • unknown's avatar
      Bug#33851 Passing UNSIGNED param to EXECUTE returns ERROR 1210 · 8d4c99e3
      unknown authored
      The problem is that passing anything other than a integer to a limit
      clause in a prepared statement would fail. This limitation was introduced
      to avoid replication problems (e.g: replicating the statement with a
      string argument would cause a parse failure in the slave).
      
      The solution is to convert arguments to the limit clause to a integer
      value and use this converted value when persisting the query to the log.
      
      
      mysql-test/r/limit.result:
        Update test case result.
      mysql-test/r/ps.result:
        Add test case result for Bug#33851
      mysql-test/r/rpl_user_variables.result:
        Test case result for replication of prepared statement with
        limit clause.
      mysql-test/t/limit.test:
        Test parameters to limit clause.
      mysql-test/t/ps.test:
        Add test case for Bug#33851
      mysql-test/t/rpl_user_variables.test:
        Test replication of a parameter which value is converted.
      sql/item.cc:
        Convert value to integer if it's a parameter to a limit clause.
      sql/item.h:
        Flag signal that item is a parameter to a limit clause.
      sql/item_func.cc:
        Const member functions, object is not mutated.
      sql/sql_class.h:
        Const member functions, object is not mutated.
      sql/sql_yacc.yy:
        Flag that item is a parameter to a limit clause.
      8d4c99e3
    • unknown's avatar
      Disable test case due to Bug#34891: sp_notembedded.test fails · 5446adf5
      unknown authored
      sporadically.
      
      
      mysql-test/r/sp_notembedded.result:
        Disable test case.
      mysql-test/t/sp_notembedded.test:
        Disable test case.
      5446adf5
    • unknown's avatar
      Fix for Bug#34852: SHOW OPEN TABLES output is not repeatable · 5e484082
      unknown authored
      (show_check.test fails sporadically).
      
      Fix test case for Bug#12183 to make it stable.
      
      
      mysql-test/r/show_check.result:
        Fix result file.
      mysql-test/t/show_check.test:
        Make test case for Bug#12183 stable.
      5e484082
  3. 27 Feb, 2008 7 commits
  4. 26 Feb, 2008 13 commits
  5. 25 Feb, 2008 1 commit
    • unknown's avatar
      Bug#28386 the general log is incomplete · 043b1567
      unknown authored
      The problem is that the commands COM_STMT_CLOSE, COM_STMT_RESET,
      COM_STMT_SEND_LONG_DATA weren't being logged to the general log.
      
      The solution is to log the general log the aforementioned commands.
      
      
      mysql-test/t/mysql_client_test-master.opt:
        Also log to table.
      sql/sql_prepare.cc:
        Log COM_STMT_CLOSE, COM_STMT_RESET and COM_STMT_SEND_LONG_DATA.
      tests/mysql_client_test.c:
        Add test case for Bug#28386
      043b1567
  6. 23 Feb, 2008 2 commits
  7. 22 Feb, 2008 10 commits
    • unknown's avatar
      Bug #34053: normal users can enable innodb_monitor logging · ea109791
      unknown authored
      The check_global_access() function was made available to InnoDB, but
      was not defined in the embedded server library.  InnoDB, as a plugin,
      is not recompiled when the embedded server is built.  This caused a
      link failure when compiling applications which use the embedded server.
      
      The fix here is to always define check_global_access() externally; in
      the embedded server case, it is defined to just return OK.
      
      Also, don't run the test case for this bug in embedded server.
      
      
      mysql-test/t/innodb_bug34053.test:
        Disable this test on embedded server - it tests privilege
        checks which are not in place there.
      sql/mysql_priv.h:
        Since check_global_access() may be used from some storage engine plugins
        (InnoDB, currently), and the plugins are not recompiled for the embedded
        server, it must be defined externally even for NO_EMBEDDED_ACCESS_CHECKS.
      sql/sql_parse.cc:
        Since check_global_access() may be used from some storage engine plugins
        (InnoDB, currently), and the plugins are not recompiled for the embedded
        server, it must be defined externally even for NO_EMBEDDED_ACCESS_CHECKS.
      ea109791
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-build · efce7728
      unknown authored
      into  hh-nb.hungers:/work/trees/mysql-5.1-build-src-clean
      
      efce7728
    • unknown's avatar
      Merge hh-nb.hungers:/work/trees/mysql-5.1-build-src-clean · ec5c92bf
      unknown authored
      into  hh-nb.hungers:/work/merge/mysql-5.1-build
      
      ec5c92bf
    • unknown's avatar
      Inserted changes from the review of bug#32664. · 39b0dd3d
      unknown authored
      39b0dd3d
    • unknown's avatar
      Merge hh-nb.hungers:/work/merge/mysql-5.1-build · 6ae9ef43
      unknown authored
      into  hh-nb.hungers:/work/merge/mysql-5.1-bug32664
      
      6ae9ef43
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 06ad5187
      unknown authored
      into  whirlpool.hristov.com:/work/mysql-5.1-runtime
      
      06ad5187
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · e3c02f42
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      e3c02f42
    • unknown's avatar
      Update new test results after merge (Bug#12713) · 1bafc2e3
      unknown authored
      1bafc2e3
    • unknown's avatar
      mysql-test/mysql-test-run.pl · 0bca82cd
      unknown authored
          Disable extra team trees.
          Temporary fix for entry 34761 in the bugs DB.
          (Patch by Magnus Svensson, 2008-02-22 17:40:14+01:00, msvensson@pilot.mysql.com +1 -0)
      
      
      mysql-test/mysql-test-run.pl:
        Disable extra team trees.
        Temporary fix for entry 34761 in the bugs DB.
        (Patch by Magnus Svensson, 2008-02-22 17:40:14+01:00, msvensson@pilot.mysql.com +1 -0)
      0bca82cd
    • unknown's avatar
      Fix for Bug#29605 · d840fd3e
      unknown authored
      --local-infile=0 checks can be bypassed by sending a FETCH LOCAL FILE response
        
      Add a check for CLIENT_LOCAL_FILES before sending a local file.
      Beware, that all binary distributions enable sending of local files and it's up
      to the programs which use libmysql to disable it, if they don't use this functionality.
      Otherwise they are not safe.
      
      
      client/mysqltest.c:
        Enable LOAD DATA LOCAL INFILE for the test suite, like some rpl and ndb test.
      sql-common/client.c:
        Check if the client has LOAD DATA LOCAL INFILE disabled and
        don't serve such requests from the server. This is not 100% proof,
        as if the client has this enabled, in all binary builds for BC,
        the check won't work and the client can be tricked into sending a
        local file.
      tests/mysql_client_test.c:
        Switch on LOCAL INFILE in client test. If one day there
        is a test which uses it, then it will work out of the box.
      d840fd3e