1. 05 May, 2009 4 commits
    • Jim Winstead's avatar
      Merge with 5.1-bugteam. · 58e01f56
      Jim Winstead authored
      58e01f56
    • Narayanan V's avatar
      merging with mysql-5.1-bugteam · 6d3c4a60
      Narayanan V authored
      6d3c4a60
    • Narayanan V's avatar
      Bug#44232 Error msg should be improved when collation not supported. · b593e4cf
      Narayanan V authored
      When a user selected an unsupported character set for an
      IBMDB2I table, error 2501 or 2511 may have been returned,
      giving the appearance of an internal programming error.
      
      This patch consolidates these errors into a single descriptive
      error message for the common case of an unsupported character
      set.
      
      The new error number is 2504 and indicates a user error.
      The errors 2501 and 2511 remain to indicate cases of internal
      programming errors.
      
      storage/ibmdb2i/db2i_charsetSupport.cc:
        Bug#44232 Error msg should be improved when collation not supported.
                
        consolidate errors 2501 and 2511 into a single
        descriptive error message for the common case
        of an unsupported character set.
      storage/ibmdb2i/db2i_conversion.cc:
        Bug#44232 Error msg should be improved when collation not supported.
                
        consolidate errors 2501 and 2511 into a single
        descriptive error message for the common case
        of an unsupported character set.
      storage/ibmdb2i/db2i_errors.cc:
        Bug#44232 Error msg should be improved when collation not supported.
                
        consolidate errors 2501 and 2511 into a single
        descriptive error message for the common case
        of an unsupported character set.
      storage/ibmdb2i/db2i_errors.h:
        Bug#44232 Error msg should be improved when collation not supported.
                
        consolidate errors 2501 and 2511 into a single
        descriptive error message for the common case
        of an unsupported character set.
      b593e4cf
    • Alexander Barkov's avatar
      Bug#44352 UPPER/LOWER function doesn't work correctly · cdcfdf07
      Alexander Barkov authored
      on cp932 and sjis environment.
      Problem: case conversion erroneously changes the second bytes
      of multi-byte sequences because single-byte functions were
      called in a mistake.
      Fix: call multi-byte aware functions instead.
      cdcfdf07
  2. 04 May, 2009 5 commits
    • Sergei Golubchik's avatar
      bug#44166 · e85cd198
      Sergei Golubchik authored
      removed few sprintf's
      e85cd198
    • Martin Hansson's avatar
      Bug#44306: Assertion fail on duplicate key error in · 973c7793
      Martin Hansson authored
      'INSERT ... SELECT' statements
      
      Merge
      973c7793
    • Martin Hansson's avatar
      Bug#44306: Assertion fail on duplicate key error in · 221c8174
      Martin Hansson authored
      'INSERT ... SELECT' statements
                  
      The code that produces result rows expected that a duplicate row
      error could not occur in INSERT ... SELECT statements with 
      unfulfilled WHERE conditions. This may happen, however, if the 
      SELECT list contains only aggregate functions.
      Fixed by checking if an error occured before trying to send EOF
      to the client.
      
      
      mysql-test/r/insert_select.result:
        Bug#44306: Test result
      mysql-test/t/insert_select.test:
        Bug#44306: Test case
      sql/sql_select.cc:
        Bug#44306: Fix
      221c8174
    • Narayanan V's avatar
      BUG#39802 On Windows, 32-bit time_t should be enforced · e558c1c0
      Narayanan V authored
      A backport of fix for "BUG40092 - Storage engine API uses
      time_t datatype".
      
      Starting from MSVC C++ 2005 (v8), the default size of time_t
      is changed from 32-bit to 64-bit. As the result, the binaries
      built with pre-v8 MSVC C++ do not work with the binaries
      (storage engine plugins) built with v8 or after (server
      crashes).
      
      Fixed storage engine API to use datatype with known size
      (ulong) instead of time_t.
      
      sql/handler.h:
        Bug#39802 On Windows, 32-bit time_t should be enforced
        
        Change create_time, check_time, update_time
        in the ha_statistics and PARTITION_INFO
        structures to ulong.
      e558c1c0
    • Andrei Elkin's avatar
      9919a107
  3. 02 May, 2009 1 commit
    • Serge Kozlov's avatar
      Bug#38077. · 57d7b826
      Serge Kozlov authored
      1. Replace waiting of SQL thread stop by waiting of SQL error on slave and stopped
      SQL thread.
      2. Remove debug code because it already implemented in MTR2.
      57d7b826
  4. 30 Apr, 2009 25 commits
  5. 29 Apr, 2009 5 commits
    • Martin Hansson's avatar
      merge · d1ebabdd
      Martin Hansson authored
      d1ebabdd
    • Vladislav Vaintroub's avatar
      merge · 2b438467
      Vladislav Vaintroub authored
      2b438467
    • Martin Hansson's avatar
      Bug#43737: Select query return bad result · f3c87bae
      Martin Hansson authored
            
      A bug in the initialization of key segment information made it point
      to the wrong bit, since a bit index was used when its int value
      was needed. This lead to misinterpretation of bit columns
      read from MyISAM record format when a NULL bit pushed them over
      a byte boundary.
      Fixed by using the int value of the bit instead.
      
      
      mysql-test/r/myisam.result:
        Bug#43737: Test result.
      mysql-test/t/myisam.test:
        Bug#43737: Test case.
      storage/myisam/mi_open.c:
        Bug#43737: fix.
      f3c87bae
    • Vladislav Vaintroub's avatar
      Bug#43932 myisam index corruption with large index and large · 2d626787
      Vladislav Vaintroub authored
      key_buffer_size.
      
      The cause of corruption was number overflow when multiplying 
      two ulong values, number of used keycache blocks with size
      of a single block. The result of multiplication exceeded ulong 
      range (4G) and this lead to incorrectly calculated  buffer offset
      in the key cache.
      
      The fix is to use size_t for multiplication result.
      
      This patch also fixes pointless cast in safemalloc 
      (size of allocated block to uint), that creates lot of false
      alarm warnings when using big keycache (> 4GB) in debug mode.
      2d626787
    • Narayanan V's avatar
      Bug#44337 Select query using index merge fails with MCH3601 · eda569e9
      Narayanan V authored
      The storage engine was not correctly handling the case in 
      which rnd_pos is executed for a handler without a preceding
      rnd_next or index read operation. As a result, an unitialized
      file handle was sometimes being passed to the QMY_READ API.
      
      The fix clears the rrnAssocHandle at the beginning of each
      read operation and then checks to see whether it has been
      set to a valid handle value before attempting to use it
      in rnd_pos. If rrnAssocHandle has not been set by a previous
      read operation, rnd_pos instead falls back to the use of the
      currently active handle.
      
      storage/ibmdb2i/ha_ibmdb2i.cc:
        Bug#44337 Select query using index merge fails with MCH3601
        
        - clear the rrnAssocHandle at the beginning of each
          read operation 
        - checks to see whether it has been set to a valid
          handle value before attempting to use it in rnd_pos
      eda569e9