- 02 Aug, 2007 2 commits
- 01 Aug, 2007 3 commits
-
-
unknown authored
into chilla.local:/home/mydev/mysql-5.1-bug29838 storage/myisam/mi_rkey.c: Auto merged
-
unknown authored
into chilla.local:/home/mydev/mysql-5.0-bug29838 myisam/mi_rkey.c: Auto merged
-
unknown authored
When using concurrent insert with parallel index reads, it could happen that reading sessions found keys that pointed to records yet to be written to the data file. The result was a report of a corrupted table. But it was false alert. When inserting a record in a table with indexes, the keys are inserted into the indexes before the record is written to the data file. When the insert happens concurrently to selects, an index read can find a key that references the record that is not yet written to the data file. To avoid any access to such record, the select saves the current end of file position when it starts. Since concurrent inserts are always appended at end of the data file, the select can easily ignore any concurrently inserted record. The problem was that the ignore was only done for non-exact key searches (partial key or using >, >=, < or <=). The fix is to ignore concurrently inserted records also for exact key searches. No test case. Concurrent inserts cannot be tested with the test suite. Test cases are attached to the bug report. myisam/mi_rkey.c: Bug#29838 - myisam corruption using concurrent select ... and update Fixed mi_rkey() to always ignore records beyond saved eof.
-
- 31 Jul, 2007 1 commit
-
-
unknown authored
INSERT DELAYED on a replication slave was converted to regular INSERT, whereas it should try concurrent INSERT first. With this patch we try to convert delayed insert to concurrent insert on a replication slave. If it is impossible for some reason, we fall back to regular insert. No test case for this fix. I do not see anything indicating this is regression - we behave this way since Nov 2000. sql/sql_insert.cc: If we're executing INSERT DELAYED on a replication slave, we're upgrading lock type to TL_WRITE as we need to ensure serial execution of queries on the slave. OTOH if we're executing regular INSERT on a replication slave, we're trying TL_WRITE_CONCURRENT_INSERT first, and if we may not use it, we fall back to TL_WRITE. Fixed INSERT DELAYED on a replication slave to behave the same way as regular INSERT, that is to try TL_WRITE_CONCURRENT_INSERT first.
-
- 28 Jul, 2007 3 commits
- 27 Jul, 2007 3 commits
-
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG29957/mysql-5.1-engines storage/myisam/mi_extra.c: Auto merged mysql-test/r/alter_table.result: Manual merge mysql-test/t/alter_table.test: Manual merge
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG29957/mysql-5.0-engines
-
unknown authored
INSERT/DELETE/UPDATE followed by ALTER TABLE within LOCK TABLES may cause table corruption on Windows. That happens because ALTER TABLE writes outdated shared state info into index file. Fixed by removing obsolete workaround. Affects MyISAM tables on Windows only. myisam/mi_extra.c: On windows when mi_extra(HA_EXTRA_PREPARE_FOR_DELETE) is called, we release external lock and close index file. If we're in LOCK TABLES, MyISAM state info doesn't get updated until UNLOCK TABLES. That means when we release external lock and we're in LOCK TABLES, we may write outdated state info. As SQL layer closes all table instances, we do not need this workaround anymore. mysql-test/r/alter_table.result: A test case for BUG#29957. mysql-test/t/alter_table.test: A test case for BUG#29957.
-
- 26 Jul, 2007 8 commits
-
-
unknown authored
into xiphis.org:/anubis/antony/work/mysql-5.1-engines.merge
-
unknown authored
into xiphis.org:/anubis/antony/work/mysql-5.1-engines.merge
-
unknown authored
into xiphis.org:/anubis/antony/work/mysql-5.0-engines.merge
-
unknown authored
into pcg5ppc.xiphis.org:/Users/antony/Work/p1-bug29522.1
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt mysql-test/t/create.test: Auto merged sql/field.cc: Auto merged sql/sql_base.cc: Auto merged sql/table.cc: Auto merged mysql-test/r/create.result: Merge with 5.0-opt.
-
unknown authored
into xiphis.org:/anubis/antony/work/p2-bug25679.3.merge-5.1 storage/federated/ha_federated.cc: Auto merged
-
unknown authored
sql/ha_federated.cc: remote_error_number is set to -1 when an error was already reported with my_error(). ER(-1) will also cause a crash on 64bit arch and only worked on 32bit arch by luck
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt mysql-test/r/sp.result: Auto merged mysql-test/t/create.test: Auto merged sql/field.cc: Auto merged sql/sql_base.cc: Auto merged sql/sql_lex.cc: Auto merged sql/sql_lex.h: Auto merged sql/table.cc: Auto merged mysql-test/r/create.result: Merge with 5.1 (main).
-
- 25 Jul, 2007 10 commits
-
-
unknown authored
Post-merge fix. sql/sql_select.cc: Post-merge fix. sql/table.cc: Post-merge fix.
-
unknown authored
Post-merge fix. sql/sql_select.cc: Post-merge fix.
-
unknown authored
"log.cc:1448: failed assertion `mysql_bin_log.is_open() && rex_data->empty()'" When Federated's transaction support was disabled by bug29875, this assertion became unreproducable. mysql-test/t/disabled.def: bug29522 reenable federated_innodb test
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.0-opt mysql-test/t/create.test: Auto merged sql/field.cc: Auto merged sql/sql_base.cc: Auto merged sql/table.cc: Auto merged mysql-test/r/create.result: Merge with 5.0 (main).
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt mysql-test/r/having.result: Auto merged mysql-test/t/create.test: Auto merged mysql-test/t/having.test: Auto merged sql/field.cc: Auto merged sql/sql_select.cc: Auto merged mysql-test/include/mix1.inc: Merge with 5.0-opt. mysql-test/r/create.result: Merge with 5.0-opt. mysql-test/r/innodb_mysql.result: Merge with 5.0-opt. mysql-test/r/type_enum.result: Merge with 5.0-opt. mysql-test/t/type_enum.test: Merge with 5.0-opt. sql/filesort.cc: Merge with 5.0-opt. sql/sql_base.cc: Merge with 5.0-opt. sql/table.cc: Merge with 5.0-opt. storage/innobase/handler/ha_innodb.cc: Merge with 5.0-opt.
-
unknown authored
into xiphis.org:/anubis/antony/work/p2-bug25679.3.merge-5.1 mysql-test/r/federated.result: Auto merged mysql-test/t/federated.test: Auto merged storage/federated/ha_federated.h: Auto merged storage/federated/ha_federated.cc: manual merge 5.0 to 5.1
-
unknown authored
"Federated Denial of Service" Federated storage engine used to attempt to open connections within the ::create() and ::open() methods which are invoked while LOCK_open mutex is being held by mysqld. As a result, no other client sessions can open tables while Federated is attempting to open a connection. Long DNS lookup times would stall mysqld's operation and a rogue connection string which connects to a remote server which simply stalls during handshake can stall mysqld for a much longer period of time. This patch moves the opening of the connection much later, when the federated actually issues queries, by which time the LOCK_open mutex is no longer being held. mysql-test/r/federated.result: change of test/results due to patch for bug25679 mysql-test/t/federated.test: change of test/results due to patch for bug25679 sql/ha_federated.cc: bug25679 remove function check_foreign_fata_source() ha_federated::open() no longer opens the federated connection. ha_federated::create() no longer opens and tests connection. ha_federated::real_connect() opens connection and tests presence of table. ha_federated::real_query() sends query, calling real_connect() if neccessary. sql/ha_federated.h: bug25679 new methods real_query() and real_connect()
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.0-opt
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG29806/mysql-5.1-engines sql/ha_ndbcluster.cc: Auto merged sql/lock.cc: Auto merged
-
unknown authored
Stopping mysql server could result in an entry in mysql error file: "InnoDB: Error: MySQL is freeing a thd". This happened because InnoDB assumes that the server will never call external_lock(F_UNLCK) in case external_lock(READ/WRITE) failed. Prior to this patch we haven't had strict definition whether external_lock(F_UNLCK) must be called in case external_lock(READ/WRITE) fails. This patch states that we never call external_lock(F_UNLCK) in case external_lock(READ/WRITE) fails. mysql-test/suite/binlog/t/disabled.def: Re-enabled binlog_innodb and binlog_killed tests. sql/ha_ndbcluster.cc: Restore handler state in case external_lock() failed. sql/ha_partition.cc: Do not call external_lock(F_UNLCK) in case external_lock(READ/WRITE) failed. sql/lock.cc: Do not call external_lock(F_UNLCK) in case external_lock(READ/WRITE) failed. storage/myisammrg/myrg_locking.c: Restore handler state in case external_lock() failed.
-
- 24 Jul, 2007 10 commits
-
-
unknown authored
into bodhi.(none):/opt/local/work/mysql-5.1-runtime
-
unknown authored
into bodhi.(none):/opt/local/work/mysql-5.1-runtime
-
unknown authored
into bodhi.(none):/opt/local/work/mysql-5.1-runtime
-
unknown authored
into bodhi.(none):/opt/local/work/mysql-5.0-runtime
-
unknown authored
Merge pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.0 into pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.1
-
unknown authored
--- fix compile on Windows for bug25714.c tests/bug25714.c: fix compile on Windows
-
unknown authored
-
unknown authored
Merge pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.0 into pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.1 BitKeeper/deleted/.del-CMakeLists.txt~5: Auto merged
-
unknown authored
-
unknown authored
Merge pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.0 into pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.1
-