1. 04 Oct, 2004 4 commits
    • unknown's avatar
      bug #5872, transactions should only be restarted with transaction.on flag off... · 5e458aac
      unknown authored
      bug #5872, transactions should only be restarted with transaction.on flag off if execute_commit has been performed
      added testcase for this
      use force send for all executes
      
      
      mysql-test/r/ndb_blob.result:
        added testcase for alter table of blob from ndb to myisam
      mysql-test/t/ndb_blob.test:
        added testcase for alter table of blob from ndb to myisam
      sql/ha_ndbcluster.cc:
        bug #5872, transactions should only be restarted with transaction.on flag off if execute_commit has been performed
        use force send for all executes
      5e458aac
    • unknown's avatar
      sql_show.cc: · b3b26c05
      unknown authored
        ctype_recode does not hang anymore. Small fix after Marko's change.
      
      
      sql/sql_show.cc:
        ctype_recode does not hang anymore. Small fix after Marko's change.
      b3b26c05
    • unknown's avatar
      use new function stop_ndbcluster · 9752b315
      unknown authored
      9752b315
    • unknown's avatar
      2ed312ce
  2. 03 Oct, 2004 1 commit
    • unknown's avatar
      mysqldump.c: · 4defd5d5
      unknown authored
        typos in comment.
      
      
      client/mysqldump.c:
        typos in comment.
      4defd5d5
  3. 01 Oct, 2004 26 commits
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 52d5c01d
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
      
      
      52d5c01d
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 4b6fbbc7
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      4b6fbbc7
    • unknown's avatar
      Merge dellis@bk-internal.mysql.com:/home/bk/mysql-4.1 · 61ef4d29
      unknown authored
      into goetia.(none):/home/dellis/mysqlab/bk/mysql-4.1
      
      
      61ef4d29
    • unknown's avatar
      grant.test, grant.result, sql_acl.cc: · f0440c27
      unknown authored
        BUG #5831 Changed mysql_revoke_all() to successfully delete all privileges for a user in one pass.
      
      
      sql/sql_acl.cc:
        BUG #5831 Changed mysql_revoke_all() to successfully delete all privileges for a user in one pass.
      mysql-test/r/grant.result:
        BUG #5831 Changed mysql_revoke_all() to successfully delete all privileges for a user in one pass.
      mysql-test/t/grant.test:
        BUG #5831 Changed mysql_revoke_all() to successfully delete all privileges for a user in one pass.
      f0440c27
    • unknown's avatar
      ha_innodb.cc: · 3fd4bb02
      unknown authored
        A partial bugfix to a multibyte charset / column prefix index bug: my_charpos() does not handle right some cases, we try to mask the bug for ASCII chars < 128 in the UTF-8 charset
      
      
      sql/ha_innodb.cc:
        A partial bugfix to a multibyte charset / column prefix index bug: my_charpos() does not handle right some cases, we try to mask the bug for ASCII chars < 128 in the UTF-8 charset
      3fd4bb02
    • unknown's avatar
      fsp0fsp.h: · 32c36a20
      unknown authored
        Remove accidentally pushed fsp debug code
      
      
      innobase/include/fsp0fsp.h:
        Remove accidentally pushed fsp debug code
      32c36a20
    • unknown's avatar
      Merge heikki@build.mysql.com:/home/bk/mysql-4.1 · 2a4f2f96
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-4.1
      
      
      sql/ha_innodb.cc:
        Auto merged
      2a4f2f96
    • unknown's avatar
      Many files: · d822c6f7
      unknown authored
        Fix bug introduced by the prefix key + multibyte charsets patch today
      
      
      sql/ha_innodb.cc:
        Fix bug introduced by the prefix key + multibyte charsets patch today
      innobase/include/data0type.h:
        Fix bug introduced by the prefix key + multibyte charsets patch today
      innobase/include/fsp0fsp.h:
        Fix bug introduced by the prefix key + multibyte charsets patch today
      innobase/data/data0type.c:
        Fix bug introduced by the prefix key + multibyte charsets patch today
      innobase/row/row0ins.c:
        Fix bug introduced by the prefix key + multibyte charsets patch today
      innobase/row/row0row.c:
        Fix bug introduced by the prefix key + multibyte charsets patch today
      innobase/row/row0sel.c:
        Fix bug introduced by the prefix key + multibyte charsets patch today
      innobase/row/row0upd.c:
        Fix bug introduced by the prefix key + multibyte charsets patch today
      d822c6f7
    • unknown's avatar
      Merge mysql.com:/home/bk/mysql-4.1 · 6da9623b
      unknown authored
      into mysql.com:/users/kboortz/daily/work/mysql-4.1-vax
      
      
      6da9623b
    • unknown's avatar
      client_test.test: · 52760464
      unknown authored
        Temporarely disabled client_test test
        Use MASTER_MYSOCK to get socket path
      
      
      mysql-test/t/client_test.test:
        Temporarely disabled client_test test
      52760464
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 8a8d4163
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_ndbcluster.h:
        Auto merged
      8a8d4163
    • unknown's avatar
      Fix for bug#5782: Don't choose the plan that accesses table with index_prev if... · ed80a84f
      unknown authored
      Fix for bug#5782: Don't choose the plan that accesses table with index_prev if the handler doesn't support it (see also ChangeSet@1.2039)
      
      
      
      ed80a84f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 29a62c11
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-4.1-ryan
      
      
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      29a62c11
    • unknown's avatar
      Support for TIMESTAMP columns holding NULL values. Unlike all other · 7b511544
      unknown authored
      column types TIMESTAMP is NOT NULL by default, so in order to have 
      TIMESTAMP column holding NULL valaues you have to specify NULL as
      one of its attributes (this needed for backward compatibility).
      
      Main changes:
      Replaced TABLE::timestamp_default_now/on_update_now members with
      TABLE::timestamp_auto_set_type flag which is used everywhere
      for determining if we should auto-set value of TIMESTAMP field 
      during this operation or not. We are also use Field_timestamp::set_time()
      instead of handler::update_timestamp() in handlers.
      
      
      mysql-test/r/type_timestamp.result:
        Added test for TIMESTAMP columns which are able to store NULL values.
      mysql-test/t/type_timestamp.test:
        Added test for TIMESTAMP columns which are able to store NULL values.
      sql/field.cc:
        Added support for TIMESTAMP fields holding NULL values.
        We don't need Field_timestamp::set_timestamp_offsets() anymore.
        Instead we need Field_timestamp::get_auto_set_type() function
        which will convert TIMESTAMP auto-set type stored in Field in 
        unireg_check to value from timestamp_auto_set_type_enum.
        (We can't replace this function with additional Field_timestamp member
        and some code in constructor because then we will have troubles
        with Field::new_field() method).
        We should also set field to not null in Field_timestamp::set_time() now.
      sql/field.h:
        Added support for TIMESTAMP fields holding NULL values.
        We don't need Field_timestamp::set_timestamp_offsets() anymore.
        Instead we need Field_timestamp::get_auto_set_type() function,
        which will convert TIMESTAMP auto-set type stored in Field in 
        unireg_check to value from timestamp_auto_set_type_enum.
        We also have to support NULL values in Field_timestamp::get_timestamp()
        function.
      sql/field_conv.cc:
        Added comment clarifying behavior in case of TIMESTAMP fields which are
        able to store NULL values.
      sql/ha_berkeley.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now for determining 
        if we should auto-set value of TIMESTAMP field during this operation.
        We are also use Field_timestamp::set_time() instead of 
        handler::update_timestamp().
      sql/ha_heap.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now for determining 
        if we should auto-set value of TIMESTAMP field during this operation.
        We are also use Field_timestamp::set_time() instead of 
        handler::update_timestamp().
      sql/ha_innodb.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now for determining 
        if we should auto-set value of TIMESTAMP field during this operation.
        We are also use Field_timestamp::set_time() instead of 
        handler::update_timestamp().
      sql/ha_isam.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now for determining 
        if we should auto-set value of TIMESTAMP field during this operation.
        We are also use Field_timestamp::set_time() instead of 
        handler::update_timestamp().
      sql/ha_isammrg.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now for determining 
        if we should auto-set value of TIMESTAMP field during this operation.
        We are also use Field_timestamp::set_time() instead of 
        handler::update_timestamp().
      sql/ha_myisam.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now for determining 
        if we should auto-set value of TIMESTAMP field during this operation.
        We are also use Field_timestamp::set_time() instead of 
        handler::update_timestamp().
      sql/ha_myisammrg.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now for determining 
        if we should auto-set value of TIMESTAMP field during this operation.
        We are also use Field_timestamp::set_time() instead of 
        handler::update_timestamp().
      sql/ha_ndbcluster.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now for determining 
        if we should auto-set value of TIMESTAMP field during this operation.
        We are also use Field_timestamp::set_time() instead of 
        handler::update_timestamp().
      sql/handler.cc:
        handler::update_timestamp() is no longer needed since now we use
        Field_timestamp::set_time() instead.
        (we can't use handler::update_timestamp() anyway since field position
        only is not enough for TIMESTAMP fields which are able to store NULLs)
      sql/handler.h:
        handler::update_timestamp() is no longer needed since now we use
        Field_timestamp::set_time() instead.
      sql/item_timefunc.cc:
        Since now TIMESTAMP fields can hold NULL values we should take this into
        account.
      sql/sql_base.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now. 
        (Here we use Field_timestamp::get_auto_set_type() to setup its value
         before further statement execution).
      sql/sql_insert.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now.
      sql/sql_load.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now.
      sql/sql_parse.cc:
        Added support for TIMESTAMP fields holding NULL values.
        We should distinguish NULL default values and non-specified default
        values for such fields (because latter could mean DEFAULT NOW()
        ON UPDATE NOW() in some cases).
      sql/sql_show.cc:
        Added support for TIMESTAMP fields holding NULL values.
        Unlike all other fields these are NOT NULL by default
        so we have to specify NULL attribute explicitly for them.
      sql/sql_table.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now.
      sql/sql_update.cc:
        Now we use TABLE::timestamp_field_type instead of 
        TABLE::timestamp_default_now/on_update_now.
      sql/sql_yacc.yy:
        Added support for TIMESTAMP fields holding NULL values.
        Unlike all other fields these are NOT NULL by default
        (so we have to set NOT_NULL_FLAG properly for them).
      sql/table.h:
        Added timestamp_auto_set_type enum which values are used for indicating
        during which operations we should automatically set TIMESTAPM field
        value to current timestamp.
        TABLE: Replaced timestamp_default_now/on_update_now members with
        timestamp_auto_set_type flag (Now when TIMESTAMP field are able to 
        store NULL values, single position of field in record is not enough 
        for updating this field anyway).
      7b511544
    • unknown's avatar
      Merge dellis@bk-internal.mysql.com:/home/bk/mysql-4.1 · e5f2eba5
      unknown authored
      into goetia.(none):/home/dellis/mysqlab/bk/mysql-4.1
      
      
      e5f2eba5
    • unknown's avatar
      Merge mskold@build.mysql.com:/home/bk/mysql-4.1 · 0db72d6e
      unknown authored
      into mysql.com:/usr/local/home/marty/MySQL/test/mysql-4.1
      
      
      0db72d6e
    • unknown's avatar
      Added index cardinality check · 33dcc14d
      unknown authored
      33dcc14d
    • unknown's avatar
      logging_ok: · 44d855e7
      unknown authored
        Logging to logging@openlogging.org accepted
      sql_acl.cc, grant.test, grant.result:
        BUG 5831 Changed mysql_revoke_all() to successfully delete all privileges for a user in one pass.
      
      
      mysql-test/r/grant.result:
        BUG 5831 Changed mysql_revoke_all() to successfully delete all privileges for a user in one pass.
      mysql-test/t/grant.test:
        BUG 5831 Changed mysql_revoke_all() to successfully delete all privileges for a user in one pass.
      sql/sql_acl.cc:
        BUG 5831 Changed mysql_revoke_all() to successfully delete all privileges for a user in one pass.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      44d855e7
    • unknown's avatar
      Changed test to be independent on scan order · 4103f231
      unknown authored
      4103f231
    • unknown's avatar
      Merge marko@build.mysql.com:/home/bk/mysql-4.1 · 9e6d1014
      unknown authored
      into hundin.mysql.fi:/home/marko/j/mysql-4.1
      
      
      innobase/btr/btr0btr.c:
        Auto merged
      innobase/lock/lock0lock.c:
        Auto merged
      innobase/row/row0ins.c:
        Auto merged
      innobase/row/row0row.c:
        Auto merged
      innobase/row/row0sel.c:
        Auto merged
      innobase/row/row0upd.c:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/ha_innodb.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      9e6d1014
    • unknown's avatar
      bug#5349 ALTER TABLE corrupts TEXT (and blob?) · fb1b8476
      unknown authored
      fb1b8476
    • unknown's avatar
      Added more comments on the code and made some code polishing. · bff40d61
      unknown authored
      
      sql/ha_innodb.cc:
        Added more comments and some polishing.
      bff40d61
    • unknown's avatar
      Merge mskold@build.mysql.com:/home/bk/mysql-4.1 · 2c049a83
      unknown authored
      into mysql.com:/usr/local/home/marty/MySQL/test/mysql-4.1
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_ndbcluster.h:
        Auto merged
      2c049a83
    • unknown's avatar
      InnoDB: quote identifiers according to MySQL settings (Bug #5292) · a418a35c
      unknown authored
      
      innobase/btr/btr0btr.c:
        Add parameter to ut_print_name() and dict_index_name_print() calls
      innobase/btr/btr0cur.c:
        Add parameter to dict_index_name_print() calls
      innobase/buf/buf0buf.c:
        Add parameter to dict_index_name_print() calls
      innobase/dict/dict0crea.c:
        Add parameter to ut_print_name() calls
      innobase/dict/dict0dict.c:
        Add parameter to ut_print_name() calls
        Update documentation links to http://dev.mysql.com
      innobase/dict/dict0load.c:
        Add parameter to ut_print_name() calls
      innobase/fil/fil0fil.c:
        Use ut_print_filename()
        Update links to documentation to http://dev.mysql.com
      innobase/ibuf/ibuf0ibuf.c:
        Replaced printf(...) with fprintf(stderr,...)
      innobase/include/dict0dict.h:
        Added trx parameters
      innobase/include/row0row.h:
        Added trx parameter
      innobase/include/row0sel.h:
        Added trx parameter
      innobase/include/row0upd.h:
        Added trx parameters
      innobase/include/row0upd.ic:
        Added trx parameter for dict_index_name_print()
      innobase/include/trx0rec.h:
        Added trx parameter
      innobase/include/ut0ut.h:
        Added ut_print_filename()
        Added trx parameter to ut_print_name() and ut_print_namel()
      innobase/lock/lock0lock.c:
        Added parameter to dict_index_name_print() and ut_print_name() calls
      innobase/page/page0page.c:
        Added parameter to dict_index_name_print() calls
      innobase/pars/pars0opt.c:
        Added parameter to dict_index_name_print() call
      innobase/pars/pars0pars.c:
        Added parameter to upd_field_set_field_no() call
      innobase/row/row0ins.c:
        Added trx parameters
      innobase/row/row0mysql.c:
        Added trx parameters
      innobase/row/row0purge.c:
        Added trx parameter
      innobase/row/row0row.c:
        Added trx parameter
      innobase/row/row0sel.c:
        Added trx parameters
      innobase/row/row0umod.c:
        Added trx parameters
      innobase/row/row0upd.c:
        Added trx parameters
      innobase/trx/trx0rec.c:
        Added trx parameters
      innobase/trx/trx0roll.c:
        Added parameter to ut_print_name() calls
      innobase/ut/ut0ut.c:
        Added ut_print_filename()
        Added trx parameter to ut_print_namel() and ut_print_name() calls
      sql/ha_innodb.cc:
        Added trx parameters
        Rewrote mysql_get_identifier_quote_char()
      sql/mysql_priv.h:
        Added get_quote_char_for_identifier()
      sql/sql_show.cc:
        Added get_quote_char_for_identifier()
        Removed append_quoted_simple_identifier()
        Make append_identifier() use get_quote_char_for_identifier()
      a418a35c
    • unknown's avatar
      Merge jlindstrom@build.mysql.com:/home/bk/mysql-4.1 · d70df1b2
      unknown authored
      into hundin.mysql.fi:/home/jan/mysql-4.1
      
      
      d70df1b2
    • unknown's avatar
      restore of auto increment bug#5786 · a72c25b2
      unknown authored
      a72c25b2
  4. 30 Sep, 2004 9 commits
    • unknown's avatar
      client_test.test: · 3f31ebd5
      unknown authored
        Use TESTS_BINDIR to point out bin dir for "client_test"
      mysql-test-run.sh:
        Export TESTS_BINDIR to be used from --exec
      
      
      mysql-test/mysql-test-run.sh:
        Export TESTS_BINDIR to be used from --exec
      mysql-test/t/client_test.test:
        Use TESTS_BINDIR to point out bin dir for "client_test"
      3f31ebd5
    • unknown's avatar
      bug#5782 · f5f55979
      unknown authored
      f5f55979
    • unknown's avatar
      bug#5824 · 8a63a0b5
      unknown authored
      8a63a0b5
    • unknown's avatar
      Merge mysql.com:/home/bk/mysql-4.1 · bfcbca22
      unknown authored
      into mysql.com:/users/kboortz/daily/work/mysql-4.1-vax
      
      
      bfcbca22
    • unknown's avatar
      mysql_protocols.test: · 064f4bf4
      unknown authored
        --exec now checks return code, make all command lines succeed
      
      
      mysql-test/t/mysql_protocols.test:
        --exec now checks return code, make all command lines succeed
      064f4bf4
    • unknown's avatar
      InnoDB: implement innodb_max_purge_lag · 927179ec
      unknown authored
      
      innobase/include/srv0srv.h:
        Added srv_max_purge_lag and srv_dml_needed_delay
      innobase/include/trx0sys.h:
        Added trx_sys->rseg_history_len
      innobase/row/row0mysql.c:
        Added row_mysql_delay_if_needed()
      innobase/srv/srv0srv.c:
        Added srv_max_purge_lag and srv_dml_needed_delay
      innobase/trx/trx0purge.c:
        Update trx_sys->rseg_history_len.
        Calculate srv_dml_needed_delay from srv_max_purge_lag
        and trx_sys->rseg_history_len.
      innobase/trx/trx0rseg.c:
        Initialize trx_sys->rseg_history_len
      sql/ha_innodb.h:
        Add srv_max_purge_lag
      sql/mysqld.cc:
        Add parameter innodb_max_purge_lag
      sql/set_var.cc:
        Add global variable innodb_max_purge_lag
      927179ec
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 92e7d03e
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-4.1-bg4302
      
      
      sql/item.cc:
        Auto merged
      92e7d03e
    • unknown's avatar
      Final solution for bug# 4302 "Ambiguos order by when renamed column is · 53edc92c
      unknown authored
      identical to another in result"
      According to SQL standard queries like 
      "select t1.a as col from t1, t2 order by a" should return an error if
      both tables contain field a.
      
      
      mysql-test/r/order_by.result:
        Updated test to conform SQL-standard.
      mysql-test/t/order_by.test:
        Updated test to conform SQL-standard.
      sql/item.cc:
        find_item_in_list() has now one more out parameter which is not used
        in item.cc functions.
      sql/mysql_priv.h:
        find_item_in_list(): Added boolean out parameter "unaliased" which
        indicates that we have found field by its original name and not by
        its alias in item (select) list.
      sql/sql_base.cc:
        find_item_in_list(): Added boolean out parameter "unaliased" which
        indicates that we have found field by its original name and not by
        its alias in item (select) list. This means that additional check is
        required to ensure there will be no ambiguity if we would search for this
        field in all tables.
      sql/sql_select.cc:
        find_order_in_list(): If we have found field in select list by its
        original name and not by its alias then we should perform additional
        check to ensure that there will be no ambiguity if we will search for
        this field in all tables. Also small cleanup.
      53edc92c
    • unknown's avatar
      Made innodb_autoextend_increment accessible as a global variable. · 1dbc71af
      unknown authored
      
      sql/ha_innodb.cc:
        Removed variable innobase_auto_extend_increment
        (access srv_auto_extend_increment directly)
      sql/ha_innodb.h:
        Removed variable innobase_auto_extend_increment
        (access srv_auto_extend_increment directly)
      sql/mysqld.cc:
        Moved innodb_autoextend_increment to alphabetically correct position.
        Replaced innobase_auto_extend_increment with srv_auto_extend_increment.
      sql/set_var.cc:
        Added innodb_autoextend_increment
      1dbc71af