1. 31 Jul, 2007 8 commits
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 5e5fdc0f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      5e5fdc0f
    • unknown's avatar
      sql_yacc.yy, sp.result, disabled.def: · cae1bff7
      unknown authored
        Post-merge fix.
      
      
      mysql-test/t/disabled.def:
        Post-merge fix.
      mysql-test/r/sp.result:
        Post-merge fix.
      sql/sql_yacc.yy:
        Post-merge fix.
      cae1bff7
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-30120 · 84f05952
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/sp.result:
        Merge with 5.0-opt.
      mysql-test/t/sp.test:
        Merge with 5.0-opt.
      84f05952
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29717/my50-29717 · fb2fb117
      unknown authored
      into  mysql.com:/home/hf/work/29717/my51-29717
      
      
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/insert_select.result:
        Auto merged
      mysql-test/t/group_by.test:
        Auto merged
      mysql-test/t/insert_select.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      fb2fb117
    • unknown's avatar
      merging · f568a416
      unknown authored
      f568a416
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29717/my41-29717 · 9000e83c
      unknown authored
      into  mysql.com:/home/hf/work/29717/my50-29717
      
      
      mysql-test/t/insert_select.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/group_by.result:
        merging
      mysql-test/r/insert_select.result:
        merging
      mysql-test/t/group_by.test:
        merging
      sql/sql_select.h:
        merging
      9000e83c
    • unknown's avatar
      Merge mysql.com:/home/hf/work/029717/my41-29717 · 19d55095
      unknown authored
      into  mysql.com:/home/hf/work/29717/my41-29717
      
      
      sql/sql_select.cc:
        Auto merged
      19d55095
    • unknown's avatar
      Bug #29717 INSERT INTO SELECT inserts values even if · 86ae8436
      unknown authored
       SELECT statement itself returns empty.
      
      As a result of this bug 'SELECT AGGREGATE_FUNCTION(fld) ... GROUP BY'
      can return one row instead of an empty result set.
      
      When GROUP BY only has fields of constant tables
      (with a single row), the optimizer deletes the group_list.
      After that we lose the information about whether we had an
      GROUP BY statement. Though it's important
      as SELECT min(x) from empty_table; and
         SELECT min(x) from empty_table GROUP BY y; have to return
      different results - the first query should return one row,
      second - an empty result set.
      So here we add the 'group_optimized_away' flag to remember this case
      when GROUP BY exists in the query and is removed
      by the optimizer, and check this flag in end_send_group()
      
      
      mysql-test/r/group_by.result:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        test result
      mysql-test/r/insert_select.result:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        test result
      mysql-test/t/group_by.test:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        This is additional testcase that is more basic than the
        original bug's testcase and has the same reason.
      mysql-test/t/insert_select.test:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        test case
      sql/sql_select.cc:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        Remember the 'GROUP BY was optimized away' case in the JOIN::group_optimized
        and check this in the end_send_group()
      sql/sql_select.h:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        JOIN::group_optimized member added to remember the 'GROUP BY optimied away'
        case
      86ae8436
  2. 30 Jul, 2007 2 commits
  3. 29 Jul, 2007 4 commits
    • unknown's avatar
      Fixed bug #30120. · bfea827a
      unknown authored
      SP with local variables with non-ASCII names crashed the server.
      
      The server replaces SP local variable names with NAME_CONST calls
      when putting statements into the binary log. It used UTF8-encoded
      item names as variable names for the replacement inside NAME_CONST
      calls. However, statement string may be encoded by any
      known character set by the SET NAMES statement.
      The server used byte length of UTF8-encoded names to increment
      the position in the query string that led to array index overrun.
      
      
      sql/item.cc:
        Fixed bug #30120.
        The Item_splocal class constructor has been modified to
        accept new parameter `len_in_q': the byte length of
        variable name in the query string.
      sql/item.h:
        Fixed bug #30120.
        The Item_splocal class has been modified to keep new
        field `len_in_query': the byte length of variable name in
        the query string.
      sql/sp_head.cc:
        Fixed bug #30120.
        The subst_spvars function has been modified to increment
        position in the query string by the lengths of not
        encoded variable names instead of byte length of names
        encoded to UTF-8.
      sql/sql_yacc.yy:
        Fixed bug #30120.
        The simple_ident rule action has been modified to
        pass the byte length of the local variable name token
        to the Item_splocal object constructor.
      mysql-test/t/sp.test:
        Updated test case for bug #30120.
      mysql-test/r/sp.result:
        Updated test case for bug #30120.
      bfea827a
    • unknown's avatar
      disabled.def: · a26d2bab
      unknown authored
        ddl_i18n_koi8r.test has been disabled to ignore bug #30120.
      
      
      mysql-test/t/disabled.def:
        ddl_i18n_koi8r.test has been disabled to ignore bug #30120.
      a26d2bab
    • unknown's avatar
      sp_head.cc: · da1c98da
      unknown authored
        Post-merge fix.
      
      
      sql/sp_head.cc:
        Post-merge fix.
      da1c98da
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 8056fcc7
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/query_cache.test:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      mysql-test/t/view.test:
        Merge with 5.0-opt.
      sql/sp_head.cc:
        Merge with 5.0-opt.
      8056fcc7
  4. 28 Jul, 2007 15 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 90a92562
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29856-bug-5.0-opt-mysql
      
      
      sql/sp_head.cc:
        Auto merged
      mysql-test/r/query_cache.result:
        SCCS merged
      mysql-test/t/query_cache.test:
        SCCS merged
      90a92562
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 0c161e15
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      0c161e15
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · d17eee3f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/sql_base.cc:
        Merge with 5.0-opt.
      d17eee3f
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29834 · 95324889
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/sql_base.cc:
        Auto merged
      mysql-test/r/sp.result:
        Merge with local tree.
      mysql-test/t/sp.test:
        Merge with local tree.
      95324889
    • unknown's avatar
      Fixed bug #29834. · 6ed4e3dd
      unknown authored
      Using view columns by their names during an execution of
      a prepared SELECT statement or a SELECT statement inside
      a SP caused a memory leak.
      
      
      sql/sql_base.cc:
        Fixed bug #29834.
        The find_field_in_view function has been modified to
        use the execution memory root for the Item_direct_view_ref
        objects allocation at non-first executions of
        a PS/SP instead of the statement memory.
      mysql-test/t/sp.test:
        Updated test case for bug #29834.
      mysql-test/r/sp.result:
        Updated test case for bug #29834.
      6ed4e3dd
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c8d0796c
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/30020-bug-5.0-opt-mysql
      
      c8d0796c
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 31c3d61f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      31c3d61f
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.1 · 047be65c
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      047be65c
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · 439f5d0f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      439f5d0f
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 214732e5
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      214732e5
    • unknown's avatar
      Bug#30020: Insufficient check led to a wrong info provided by the · 8306d3dc
      unknown authored
      information schema table.
      
      The get_schema_views_record() function fills records in the view table of
      the informations schema with data about given views. Among other info
      the is_updatable flag is set. But the check whether the view is updatable or
      not wasn't covering all cases thus sometimes providing wrong info.
      This might led to a user confusion.
      
      Now the get_schema_views_record function additionally calls to the 
      view->can_be_merge() function to find out whether the view can be updated or
      not.
      
      
      mysql-test/t/view.test:
        Added a test case for the bug#30020: Insufficient check led to a wrong info
        provided by the information schema table.
      mysql-test/r/view.result:
        Added a test case for the bug#30020: Insufficient check led to a wrong info
        provided by the information schema table.
      sql/sql_show.cc:
        Bug#30020: Insufficient check led to a wrong info provided by the
        information schema table.
        Now the get_schema_views_record function additionally calls to the 
        view->can_be_merge() function to find out whether the view can be updated or
        not.
      8306d3dc
    • unknown's avatar
      Bug#29856: Insufficient buffer space led to a server crash. · a1e18414
      unknown authored
      The subst_spvars function is used to create query string with SP variables 
      substituted with their values. This string is used later for the binary log
      and for the query cache. The problem is that the
      query_cache_send_result_to_client function requires some additional space
      after the query to store database name and query cache flags. This 
      space wasn't reserved by the subst_spvars function which led to a memory
      corruption and crash.
      
      Now the subst_spvars function reserves additional space for the query cache.
      
      
      mysql-test/t/query_cache.test:
        Added a test case for the bug#29856: Insufficient buffer space led to a server crash.
      mysql-test/r/query_cache.result:
        Added a test case for the bug#29856: Insufficient buffer space led to a server crash.
      sql/sp_head.cc:
        Bug#29856: Insufficient buffer space led to a server crash.
        Now the subst_spvars function reserves additional space for the query cache.
      a1e18414
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 1bb150e2
      unknown authored
      into  mysql.com:/home/hf/work/29878/my51-29878
      
      1bb150e2
    • unknown's avatar
      rpl_session_var.test fixed to not depend on mysql_test_run parameters · 02736989
      unknown authored
      
      mysql-test/suite/rpl/r/rpl_session_var.result:
        result fixed
      mysql-test/suite/rpl/t/rpl_session_var.test:
        test fixed
      02736989
    • unknown's avatar
      show_check.result: · 7a72380d
      unknown authored
        Addendum to thr fix for bug 30000:
        show procedure/function code defined only in debug builds
      show_check.test:
        Addendum to thr fix for bug 30000: 
        show procedure/function code defined only in debug builds
      
      
      mysql-test/t/show_check.test:
        Addendum to thr fix for bug 30000: 
        show procedure/function code defined only in debug builds
      mysql-test/r/show_check.result:
        Addendum to thr fix for bug 30000:
        show procedure/function code defined only in debug builds
      7a72380d
  5. 27 Jul, 2007 11 commits
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 4f1a6146
      unknown authored
      into  mysql.com:/home/hf/work/29878/my50-29878
      
      4f1a6146
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · b77a4a7b
      unknown authored
      into  mysql.com:/home/hf/work/29878/my51-29878
      
      b77a4a7b
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29878/my50-29878 · 9e33e325
      unknown authored
      into  mysql.com:/home/hf/work/29878/my51-29878
      
      
      mysql-test/suite/rpl/r/rpl_session_var.result:
        Auto merged
      mysql-test/suite/rpl/t/rpl_session_var.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      9e33e325
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 2275dc0e
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B30000-5.1-opt
      
      2275dc0e
    • unknown's avatar
      Bug #30000: SHOW commands once again ends up in the · 4f88fafd
      unknown authored
       slow query log
      Disable the SHOW commands to appear in the show query
      log.
      Update the commands type array.
      
      
      mysql-test/r/show_check.result:
        Bug #30000: test case
      mysql-test/t/show_check.test:
        Bug #30000: test case
      sql/sql_parse.cc:
        Bug #30000: skip SHOW commands from the
        slow query log.
      4f88fafd
    • unknown's avatar
      fixing the 5.1-opt merge of the fix for bug 29571: · 14bc8d09
      unknown authored
      cannot check the statments in the binlog for row based 
      replication.
      
      14bc8d09
    • unknown's avatar
      Bug #29878 Garbage data generation when executing SESSION_USER() on a slave. · e35c8aa4
      unknown authored
      Item_func_user doesn't calculate anything in it's val_str() method,
      just returns saved str_value.
      Though Item::save_in_field method can destroy str_value, relying on
      val_str() return. As a result we get the garbage stored in field.
      
      We cannot use Item::save_in_field implementation for Item_func_user,
      reimplement it in simpler way.
      
      
      mysql-test/r/rpl_session_var.result:
        Bug #29878 Garbage data generation when executing SESSION_USER() on a slave.
        
        test result
      mysql-test/t/rpl_session_var.test:
        Bug #29878 Garbage data generation when executing SESSION_USER() on a slave.
        
        test case
      sql/item.cc:
        Bug #29878 Garbage data generation when executing SESSION_USER() on a slave.
        
        duplicating code moved to Item::save_str_in_field
      sql/item.h:
        Bug #29878 Garbage data generation when executing SESSION_USER() on a slave.
        
        duplicating code moved to Item::save_str_in_field
      sql/item_strfunc.h:
        Bug #29878 Garbage data generation when executing SESSION_USER() on a slave.
        
        Item_func_user::save_in_field implemented as simple storing str_value
      e35c8aa4
    • unknown's avatar
    • unknown's avatar
      5.0-opt -> 5.1-opt merge of the test case for bug 29571: · 28043f17
      unknown authored
       - reset the logs before and after the test.
       - cleanup from the previous tests : use the correct schema.
      
      
      mysql-test/extra/rpl_tests/rpl_insert_delayed.test:
        5.0-opt -> 5.1-opt merge of the test case for bug 29571.
      mysql-test/suite/rpl/r/rpl_stm_insert_delayed.result:
        5.0-opt -> 5.1-opt merge of the test case for bug 29571.
      28043f17
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 6f8f899a
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B30036-5.1-opt
      
      6f8f899a
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG29957/mysql-5.0-engines · 04727a4c
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG29957/mysql-5.1-engines
      
      
      storage/myisam/mi_extra.c:
        Auto merged
      mysql-test/r/alter_table.result:
        Manual merge
      mysql-test/t/alter_table.test:
        Manual merge
      04727a4c