1. 01 Jul, 2005 3 commits
    • unknown's avatar
      trx0trx.h, trx0trx.ic, row0mysql.c: · 5f7c17aa
      unknown authored
        Fix another bug in the fix of Bug #3300
      
      
      innobase/row/row0mysql.c:
        Fix another bug in the fix of Bug #3300
      innobase/include/trx0trx.ic:
        Fix another bug in the fix of Bug #3300
      innobase/include/trx0trx.h:
        Fix another bug in the fix of Bug #3300
      5f7c17aa
    • unknown's avatar
      trx0trx.ic, trx0trx.h: · 122bf0b8
      unknown authored
        Fix bug in the Bug #3300 bug fix
      
      
      innobase/include/trx0trx.h:
        Fix bug in the Bug #3300 bug fix
      innobase/include/trx0trx.ic:
        Fix bug in the Bug #3300 bug fix
      122bf0b8
    • unknown's avatar
      Many files: · 3f767b74
      unknown authored
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      
      
      sql/ha_innodb.cc:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/row/row0mysql.c:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/row/row0sel.c:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/include/trx0trx.ic:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/include/row0mysql.h:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/include/trx0trx.h:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/lock/lock0lock.c:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/trx/trx0trx.c:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      3f767b74
  2. 29 Jun, 2005 13 commits
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · c1820837
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      c1820837
    • unknown's avatar
      ha_innodb.cc: · 14b71228
      unknown authored
        Let InnoDB use a consistent read when it initializes the auto-inc counter for a table: this will eliminate spurious deadlocks, but will ignore an UPDATE if that happens at the same time that we init the auto-inc counter; this has to be documented; this path also fixes most of Bug #11633, but not all: if ::external_lock() is not called on the table in SHOW TABLE STATUS, that might cause a crash if someone simultaneously DROPs the table
      
      
      sql/ha_innodb.cc:
        Let InnoDB use a consistent read when it initializes the auto-inc counter for a table: this will eliminate spurious deadlocks, but will ignore an UPDATE if that happens at the same time that we init the auto-inc counter; this has to be documented; this path also fixes most of Bug #11633, but not all: if ::external_lock() is not called on the table in SHOW TABLE STATUS, that might cause a crash if someone simultaneously DROPs the table
      14b71228
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 2cba36ae
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      2cba36ae
    • unknown's avatar
      Bump required version of autoconf to 2.58 · 447a2cb0
      unknown authored
      
      configure.in:
        Bump required version of autoconf to 2.58(same as in 4.1 and as in the manual)
      447a2cb0
    • unknown's avatar
      Fixed compiler errors (i.e. changed C++-isms into C) · fdea64fe
      unknown authored
      
      client/mysqldump.c:
        Moved variable declaration to beginning of block (and removed const to get rid of warnings).
      client/mysqltest.c:
        Moved DBUG_PRINT after variable declarations.
      fdea64fe
    • unknown's avatar
      Applied some Netware related patches. · 22711360
      unknown authored
      
      include/config-netware.h:
        Netware related fix. Some changes needed when building against latest libc (June 2005)
      netware/my_print_defaults.def:
        Stack size increase.
      sql/mysqld.cc:
        Needed with latest libc.
      22711360
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 1f2b008c
      unknown authored
      into mysql.com:/home/cps/mysql/trees/mysql-5.0
      
      1f2b008c
    • unknown's avatar
      post review fixes (second review) · 126f26d4
      unknown authored
      
      mysys/default_modify.c:
        post review fixes
      126f26d4
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 8924c62e
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-bug7-5.0
      
      8924c62e
    • unknown's avatar
      fixed SP parameter execution · 7721de46
      unknown authored
      
      sql/sp_head.cc:
        execute parameters in statement mem_root
      sql/sql_union.cc:
        additional assert
      7721de46
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 58e01427
      unknown authored
      into mysql.com:/usr/home/ram/work/mysql-5.0
      
      58e01427
    • unknown's avatar
      a fix (bug #11215: BIGINT: can't set DEFAULT to minimum end-range) · d638d79b
      unknown authored
      
      sql/item.cc:
        a fix (bug #11215: BIGINT: can't set DEFAULT to minimum end-range)
        Pass unsig=1 to the constructor.
      d638d79b
    • unknown's avatar
      Added test for bug #5893 "Triggers with dropped functions cause crashes" · 42073a5c
      unknown authored
      (The bug itself was fixed earlier by the patch that fixed bug #5860
       "Multi-table UPDATE does not activate update triggers" and several
       other bugs). 
      
      
      mysql-test/r/trigger.result:
        Added test for bug #5893 "Triggers with dropped functions cause crashes"
      mysql-test/t/trigger.test:
        Added test for bug #5893 "Triggers with dropped functions cause crashes"
      42073a5c
  3. 28 Jun, 2005 8 commits
    • unknown's avatar
      post review fixes to a patch · 9af9c22a
      unknown authored
      
      mysys/default_modify.c:
        post revew fixes to a patch
      9af9c22a
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0 · 1072fab7
      unknown authored
      into rurik.mysql.com:/home/igor/mysql-5.0
      
      
      sql/opt_range.cc:
        Auto merged
      1072fab7
    • unknown's avatar
      opt_range.cc: · dbd1d927
      unknown authored
        Fixed a compilation error.
      
      
      sql/opt_range.cc:
        Fixed a compilation error.
      dbd1d927
    • unknown's avatar
      Fixed comments. · e899af6b
      unknown authored
      
      sql/opt_range.cc:
        comment fixed.
      sql/sp_head.cc:
        An obsolete comment removed.
      e899af6b
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · af78014c
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      
      sql/opt_range.cc:
        Auto merged
      af78014c
    • unknown's avatar
      A fix and a test case for Bug#10736 "mysql_stmt_attr_set · cbb60f5e
      unknown authored
      CURSOR_TYPE_READ_ONLY select within select".
      The bug was caused by the reset of thd->mem_root to thd->main_mem_root in 
      Item_subselect::exec, which in turn triggered too early free_root() for
      data which was needed on subsequent fetches from a cursor.
      This reset also caused a memory leak in stored procedures, as 
      subsequent executions of instructions containing a subselect
      were allocating memory in thd->main_mem_root, which is not freed
      until the end of the entire SP, instead of the per-call mem_root,
      which is freed in the end of execution of the instruction.
      
      
      sql/item_subselect.cc:
        Don't try to protect subqueries from the code that assumes that
        it can reset thd->mem_root and get away with it: it's responsibility
        of the caller to ensure that no assumption about the life span
        of the allocated memory made by the called code is broken.
        Besides, this didn't work well with cursors and stored procedures, 
        where the runtime memory root is not the same as &thd->main_mem_root.
      sql/opt_range.cc:
        In get_mm_leaf restore the original mem_root of the thd which has
        been temporarily reset with the quick select mem_root earlier: if 
        thd->mem_root points to the QUICK...::mem_root, the memory allocated
        in JOIN::exec during evaluation of a subquery gets freed too early.
      tests/mysql_client_test.c:
        A test case for Bug#10736 "mysql_stmt_attr_set CURSOR_TYPE_READ_ONLY
         select within select"
      cbb60f5e
    • unknown's avatar
      range.result, range.test: · c83972fa
      unknown authored
        Added a test case for bug #10031.
      opt_range.cc:
        Fixed bug #10031: range condition was not used with
        views. Range analyzer did not take into account that
        view columns were always referred through Item_ref.
      
      
      sql/opt_range.cc:
        Fixed bug #10031: range condition was not used with
        views. Range analyzer did not take into account that
        view columns were always referred through Item_ref.
      mysql-test/t/range.test:
        Added a test case for bug #10031.
      mysql-test/r/range.result:
        Added a test case for bug #10031.
      c83972fa
    • unknown's avatar
      Merge hundin.mysql.fi:/home/marko/mysql-4.1 · 625c862b
      unknown authored
      into hundin.mysql.fi:/home/marko/mysql-5.0-current
      
      
      innobase/fil/fil0fil.c:
        SCCS merged
      innobase/include/os0file.h:
        SCCS merged
      innobase/os/os0file.c:
        SCCS merged
      625c862b
  4. 27 Jun, 2005 16 commits
    • unknown's avatar
      Fix typo in --default-store-engine help. (Bug #11534) · c3abc8f0
      unknown authored
      
      sql/mysqld.cc:
        Fix typo
      c3abc8f0
    • unknown's avatar
      Many files: · 118978eb
      unknown authored
        Remove compiler warnings on Windows - Bug #11580
      
      
      innobase/btr/btr0btr.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/btr/btr0cur.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/fil/fil0fil.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/ibuf/ibuf0ibuf.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/log/log0recv.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/os/os0file.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/page/page0page.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/row/row0upd.c:
        Remove compiler warnings on Windows - Bug #11580
      118978eb
    • unknown's avatar
      InnoDB: After review fixes · 3e5cc49a
      unknown authored
      
      innobase/os/os0file.c:
        os_file_set_size(): After review fixes (prevent overflows)
      3e5cc49a
    • unknown's avatar
      InnoDB: Optimize the extension of files. This will greatly speed · 1b9e7350
      unknown authored
      up CREATE TABLE in innodb_file_per_table=1 mode.
      
      
      innobase/fil/fil0fil.c:
        fil_extend_space_to_desired_size(): Do not allocate or initialize
        more memory than is necessary.  Write at most one megabyte at a time.
      innobase/include/os0file.h:
        os_file_set_size(): Corrected the synopsis
      innobase/os/os0file.c:
        os_file_set_size(): Corrected the synopsis and some comments.
        s/offset/current_size; s/low/desired_size/;
        Do not allocate or initialize more memory than is necessary.
        Write at most one megabyte at a time.
      1b9e7350
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · f4a72069
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      f4a72069
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1 · 57c8f4ef
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      client/mysqltest.c:
        Auto merged
      57c8f4ef
    • unknown's avatar
      Include <sys/wait.h> to get WEXITSTATUS · dca8f40c
      unknown authored
      dca8f40c
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1 · 9ef5c755
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      client/mysqltest.c:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      9ef5c755
    • unknown's avatar
      Add "#include <stdlib.h>" to define WEXITSTATUS · 952ad99c
      unknown authored
      952ad99c
    • unknown's avatar
      Simpler impl. · 51fa5733
      unknown authored
      
      sql/sql_parse.cc:
        Just do a simple sprintf to format error message.
      51fa5733
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · fed72117
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/bug10466
      
      
      mysql-test/r/alias.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/r/ps_2myisam.result:
        Auto merged
      mysql-test/r/ps_3innodb.result:
        Auto merged
      mysql-test/r/ps_4heap.result:
        Auto merged
      mysql-test/r/ps_5merge.result:
        Auto merged
      mysql-test/r/ps_6bdb.result:
        Auto merged
      mysql-test/r/ps_7ndb.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/alias.test:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/group_by.test:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      fed72117
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 85c0b742
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      85c0b742
    • unknown's avatar
      Merge problem fixes · 69487da2
      unknown authored
      
      mysql-test/r/client_xml.result:
        Update testresult
      mysql-test/r/ndb_autodiscover.result:
        Moving order opf test results to match test execution order
      69487da2
    • unknown's avatar
      Fix the broken test suite in -debug build. · 3bcab50f
      unknown authored
      
      sql/sql_select.cc:
        If we use subqueries, we can have double-free of tmp_table_param.copy_field
        in JOIN::destroy and in JOIN::join_free because.
      3bcab50f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 778a9b56
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      mysql-test/mysql-test-run.sh:
        Auto merged
      778a9b56
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · a6ef5ed9
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      a6ef5ed9