1. 01 Jun, 2005 1 commit
    • unknown's avatar
      Bug#10602 - LOAD INDEX INTO CACHE deadlocks · 606254c9
      unknown authored
      Fixed two deadlocks.
      Made minor changes.
      
      
      mysys/mf_keycache.c:
        Bug#10602 - LOAD INDEX INTO CACHE deadlocks
        Fixed two deadlocks.
        Made keycache traces line buffered.
        Removed unused macro and function.
        Added comments and trace messages.
        Fixed two compiler warnings.
        Fixed some coding style issues.
      606254c9
  2. 31 May, 2005 7 commits
    • unknown's avatar
      Merge · e5755ffe
      unknown authored
      
      mysql-test/r/create.result:
        SCCS merged
      mysql-test/t/create.test:
        SCCS merged
      e5755ffe
    • unknown's avatar
      3417e148
    • unknown's avatar
      Merge acurtis@bk-internal.mysql.com:/home/bk/mysql-4.1 · 4bd217c9
      unknown authored
      into xiphis.org:/usr/home/antony/work2/p4-bug10413.2
      
      4bd217c9
    • unknown's avatar
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement. · d825d48f
      unknown authored
      Hand merged from 4.0.
      
      
      sql/lock.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_handler.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      d825d48f
    • unknown's avatar
      Bug#10413 - Invalid column name is not rejected · 5907a9cd
      unknown authored
        Stop ignoring name parts and check for validity
      
      
      mysql-test/r/create.result:
        Test for bug#10413
      mysql-test/t/create.test:
        Test for bug#10413
      sql/sql_yacc.yy:
        Bug#10413
          Stop ignoring parts of fully qualified names.
      5907a9cd
    • unknown's avatar
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement. · 1ba82d32
      unknown authored
      1.) Added a new option to mysql_lock_tables() for ignoring FLUSH TABLES.
      Used the new option in create_table_from_items().
      It is necessary to prevent the SELECT table from being reopend.
      It would get new storage assigned for its fields, while the
      SELECT part of the command would still use the old (freed) storage.
      2.) Protected the CREATE TABLE and CREATE TABLE ... SELECT commands
      against a global read lock. This prevents a deadlock in
      CREATE TABLE ... SELECT in conjunction with FLUSH TABLES WITH READ LOCK
      and avoids the creation of new tables during a global read lock.
      3.) Replaced set_protect_against_global_read_lock() and
      unset_protect_against_global_read_lock() by
      wait_if_global_read_lock() and start_waiting_global_read_lock()
      in the INSERT DELAYED handling.
      
      
      mysql-test/r/create.result:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Added test results.
      mysql-test/t/create.test:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Added tests which do not require concurrency.
      sql/lock.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Added a new option to mysql_lock_tables() for ignoring FLUSH TABLES.
        Changed the parameter list.
        Removed two unnecessary functions. Their functionality is included in
        wait_if_global_read_lock() and start_waiting_global_read_lock().
      sql/mysql_priv.h:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Changed the declaration of mysql_lock_tables().
        Added definitions for the new options.
      sql/sql_acl.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Adjusted mysql_lock_tables() calls to the new argument list.
      sql/sql_base.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Adjusted mysql_lock_tables() calls to the new argument list.
      sql/sql_handler.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Adjusted mysql_lock_tables() calls to the new argument list.
      sql/sql_insert.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Replaced set_protect_against_global_read_lock() and
        unset_protect_against_global_read_lock() by
        wait_if_global_read_lock() and start_waiting_global_read_lock()
        in the INSERT DELAYED handling.
        Adjusted mysql_lock_tables() calls to the new argument list.
      sql/sql_parse.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Protected the CREATE TABLE and CREATE TABLE ... SELECT commands
        against a global read lock. This prevents a deadlock in
        CREATE TABLE ... SELECT in conjunction with FLUSH TABLES WITH READ LOCK
        and avoids the creation of new tables during a global read lock.
      sql/sql_table.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Adjusted mysql_lock_tables() calls to the new argument list.
        Used the new option in create_table_from_items().
      1ba82d32
    • unknown's avatar
      a fix (bug #7405: group_concat with distinct and rollup => ignores distinct in some rows). · 7582d695
      unknown authored
      
      sql/item_sum.cc:
        a fix (bug #7405: group_concat with distinct and rollup => ignores distinct in some rows).
        Code changed in order to work with rollup extension.
      7582d695
  3. 30 May, 2005 2 commits
    • unknown's avatar
      sql_select.cc: · b8290da9
      unknown authored
        Post-review modifications for the fix of bug #7894.
      
      
      sql/sql_select.cc:
        Post-review modifications for the fix of bug #7894.
      b8290da9
    • unknown's avatar
      olap.result, olap.test: · 14541668
      unknown authored
        Added test cases for bug #7894.
      sql_select.cc:
        Fixed bug #7894: GROUP BY queries with ROLLUP returned
        wrong results for expressions containing group by columns.
        The fix ensured correct results by replacement of all
        occurrences of group by fields in non-aggregate expressions
        for corresponding ref objects and preventing creation of
        fields in temporary tables for expression containing group
        by fields.
      
      
      sql/sql_select.cc:
        Fixed bug #7894: GROUP BY queries with ROLLUP returned
        wrong results for expressions containing group by columns.
        The fix ensured correct results by replacement of all
        occurrences of group by fields in non-aggregate expressions
        for corresponding ref objects and preventing creation of
        fields in temporary tables for expression containing group
        by fields.
      mysql-test/t/olap.test:
        Added test cases for bug #7894.
      mysql-test/r/olap.result:
        Added test cases for bug #7894.
      14541668
  4. 27 May, 2005 3 commits
  5. 26 May, 2005 11 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 4b5728d2
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      sql/item.cc:
        Auto merged
      4b5728d2
    • unknown's avatar
      Merge abelkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 990ee5b6
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-4.1
      
      990ee5b6
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-4.0 · 64086d10
      unknown authored
      into mysql.com:/M40/mysql-4.0
      
      64086d10
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-4.1 · 24e87c6a
      unknown authored
      into mysql.com:/M41/mysql-4.1
      
      24e87c6a
    • unknown's avatar
      merge · a1180e48
      unknown authored
      
      sql/item.cc:
        Auto merged
      a1180e48
    • unknown's avatar
      fixed problem with long string results of expressions in UNIONS (BUG#10025) · 34514477
      unknown authored
      
      mysql-test/r/union.result:
        test for Bug #10025
      mysql-test/t/union.test:
        test for Bug #10025
      sql/item.cc:
        set HA_OPTION_PACK_RECORD and change type to MYSQL_TYPE_STRING, to allow correct field creation in case of length more then 255 (creation STRING field with length more then 255)
      34514477
    • unknown's avatar
      Merge hundin.mysql.fi:/home/marko/k/mysql-4.0 · d8fe4c01
      unknown authored
      into hundin.mysql.fi:/home/marko/mysql-4.1
      
      
      innobase/row/row0mysql.c:
        Auto merged
      d8fe4c01
    • unknown's avatar
      InnoDB: Check all referencing tables in DROP DATABASE (Bug #10335). · f67b7d39
      unknown authored
      
      innobase/row/row0mysql.c:
        row_drop_table_for_mysql(): Check all referencing tables
        when drop_db==TRUE (Bug #10335)
      f67b7d39
    • unknown's avatar
      Fix icc compiler warning · 10ece0ae
      unknown authored
      
      ndb/src/kernel/blocks/dbtux/Dbtux.hpp:
        Removed second forward declaration of "struct DescEnt"
      10ece0ae
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 50ec4964
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      include/my_global.h:
        Auto merged
      sql/ha_myisammrg.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      50ec4964
    • unknown's avatar
      Add ifdefs to control when "#pragma implementation" should be used · 50dfbb61
      unknown authored
      Added some more ifdefs for "#pragma interface"
      
      
      client/sql_string.cc:
        USE_PRAGMA_IMPLEMENTATION
      client/sql_string.h:
        USE_PRAGMA_INTERFACE
      include/my_global.h:
        Use pragma implementation for gcc pre version 3
      mysys/raid.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/field.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/ha_berkeley.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/ha_blackhole.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/ha_heap.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/ha_innodb.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/ha_isam.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/ha_isammrg.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/ha_myisam.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/ha_myisammrg.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/ha_ndbcluster.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/handler.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/hash_filo.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/item.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/item_cmpfunc.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/item_func.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/item_geofunc.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/item_strfunc.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/item_subselect.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/item_sum.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/item_timefunc.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/item_uniq.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/item_uniq.h:
        USE_PRAGMA_INTERFACE
      sql/log_event.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/log_event.h:
        USE_PRAGMA_INTERFACE
      sql/opt_range.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/procedure.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/protocol.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/protocol_cursor.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/set_var.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/sql_analyse.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/sql_analyse.h:
        USE_PRAGMA_INTERFACE
      sql/sql_class.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/sql_crypt.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/sql_crypt.h:
        USE_PRAGMA_IMPLEMENTATION
      sql/sql_list.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/sql_map.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/sql_map.h:
        USE_PRAGMA_INTERFACE
      sql/sql_olap.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/sql_select.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/sql_string.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/sql_udf.cc:
        USE_PRAGMA_IMPLEMENTATION
      sql/tztime.cc:
        USE_PRAGMA_IMPLEMENTATION
      50dfbb61
  6. 25 May, 2005 7 commits
    • unknown's avatar
      Manual merge. · 703d3508
      unknown authored
      703d3508
    • unknown's avatar
      Added a missing "make clean" to the RPM "spec" file which had caused the... · 5950a11a
      unknown authored
      Added a missing "make clean" to the RPM "spec" file which had caused the original 4.1.12 RPMs to be broken.
      (bug#10674, bug#10681)
      
      
      support-files/mysql.spec.sh:
        Added a missing "make clean" which had caused the original 4.1.12 RPMs to be broken.
        (bug#10674, bug#10681)
      5950a11a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · fb776a17
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      sql/sql_parse.cc:
        Auto merged
      fb776a17
    • unknown's avatar
      Cleanup during code review · ad519b77
      unknown authored
      Faster detection of wrong table names (like PRN) on windows
      
      
      include/my_sys.h:
        Added check_if_legal_filename()
      mysys/my_access.c:
        Added check_if_legal_filename()
        Set errno if my_access() fails
      mysys/my_fopen.c:
        USe check_if_legal_filename() instead of my_access() to detect wrong file names on windows
      mysys/my_open.c:
        USe check_if_legal_filename() instead of my_access() to detect wrong file names on windows
      sql/sql_lex.cc:
        Portability fix
      sql/sql_parse.cc:
        Simple cleanup
      sql/sql_repl.cc:
        Cleanup during code review
      ad519b77
    • unknown's avatar
      Use one err file for each master · f0bd7d37
      unknown authored
      
      mysql-test/mysql-test-run.sh:
        Add master id to end of MASTER_MY_ERR  so that both masters doesnt write to the same file.
      f0bd7d37
    • unknown's avatar
      BUG#10831 ndb mgmd LogDestination maxfiles does not rotate logs properly · b7f005ce
      unknown authored
      
      ndb/src/common/util/File.cpp:
        my_stat returns NULL on failure, not non-zero.
        
        i.e. exactly the opposite of stat(2).
        
        providing confusion for unix programmers, who expect errors to be non-zero.
        
        Clean up File_class::exists(char*) to use the my_stat interface properly.
      b7f005ce
    • unknown's avatar
      BUG#10796 Incorrect check-cpu result for ppc linux gcc · 431ef177
      unknown authored
      
      BUILD/check-cpu:
        Add no_march variable to indicate that this architecture doesn't support the -march flag to GCC
      431ef177
  7. 24 May, 2005 9 commits