1. 30 Jul, 2007 4 commits
    • unknown's avatar
      WL#3915 : (NDB) master's cols > slave · 62add8ae
      unknown authored
      Corrective patch to fix test failures in pushbuild and add assertions
      to help debug rpl_extraColmaster test failures.
      
      
      mysql-test/extra/rpl_tests/rpl_row_tabledefs.test:
        WL#3915 : (NDB) master's cols > slave
        
        Change test to omit the port numbers in the result file.
      mysql-test/suite/rpl/r/rpl_row_tabledefs_2myisam.result:
        WL#3915 : (NDB) master's cols > slave
        
        Corrected result file.
      mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result:
        WL#3915 : (NDB) master's cols > slave
        
        Corrected result file.
      sql/rpl_utility.cc:
        WL#3915 : (NDB) master's cols > slave
        
        Added assertions to assist in debugging.
      62add8ae
    • unknown's avatar
      WL#3915 : (NDB) master's cols > slave · 30a9241e
      unknown authored
      Changed test to enable easier debugging. 
      
      
      mysql-test/extra/rpl_tests/rpl_extraMaster_Col.test:
        WL#3915 : (NDB) master's cols > slave
        
        Changes to test in order to aide debugging.
      mysql-test/suite/rpl/r/rpl_extraColmaster_innodb.result:
        WL#3915 : (NDB) master's cols > slave
        
        New result file for test changes.
      mysql-test/suite/rpl/r/rpl_extraColmaster_myisam.result:
        WL#3915 : (NDB) master's cols > slave
        
        New result file for test changes.
      mysql-test/suite/rpl/r/rpl_row_extraColmaster_ndb.result:
        WL#3915 : (NDB) master's cols > slave
        
        New result file for test changes.
      30a9241e
    • unknown's avatar
      WL#3228 (NDB) : RBR using different table defs on slave/master · 972c7199
      unknown authored
      This patch includes changes to result files for tests issuing BINLOG
      queries. The values have changed due to a size difference in the
      table map.
      
      
      mysql-test/suite/rpl/r/rpl_row_tabledefs_2myisam.result:
        WL#3228 (NDB) : RBR using different table defs on slave/master
        
        New results file for changes to binlog table map log event size.
      mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result:
        WL#3228 (NDB) : RBR using different table defs on slave/master
        
        New results file for changes to binlog table map log event size.
      972c7199
    • unknown's avatar
      WL#3228 (RBR using different table defs on slave/master): · ea6e42dd
      unknown authored
      Fixing tests and results to work when replicating to fewer columns on
      slave than on master. One test that previously should fail, now works,
      and some log positions have changed as a result of adding metadata to
      the events.
      
      
      mysql-test/extra/rpl_tests/rpl_row_tabledefs.test:
        Replication to fewer columns on slave now works.
      mysql-test/include/wait_for_slave_to_stop.inc:
        Adding subsitutions for SHOW SLAVE STATUS
      mysql-test/suite/binlog/r/binlog_row_binlog.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_rbr_to_sbr.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_row_tabledefs_2myisam.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_slave_skip.result:
        Result change.
      mysql-test/suite/rpl/t/rpl_skip_error-slave.opt:
        Error number changed [!]
      ea6e42dd
  2. 29 Jul, 2007 2 commits
    • unknown's avatar
      WL#3228 (NDB) : RBR using different table defs on slave/master · 2804bd0f
      unknown authored
      This patch adds the ability to store extra field metadata in the table
      map event. This data can include pack_length() or field_lenght() for
      fields such as CHAR or VARCHAR enabling developers to add code that
      can check for compatibilty between master and slave columns. More 
      importantly, the extra field metadata can be used to store data from the
      master correctly should a VARCHAR field on the master be <= 255 bytes 
      while the same field on the slave is > 255 bytes. 
      
      The patch also includes the needed changes to unpack to ensure that data
      which is smaller on the master can be unpacked correctly on the slave.
      
      WL#3915 : (NDB) master's cols > slave
      
      Slave starts accepting and handling rows of master's tables which have more columns.
      The most important part of implementation is how to caclulate the amount of bytes to
      skip for unknown by slave column.
      
      
      mysql-test/suite/binlog/t/binlog_row_mix_innodb_myisam.test:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch changes the test to coincide with changes to binlog
        size of table map event.
      mysql-test/suite/rpl/r/rpl_row_basic_11bugs.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/r/rpl_row_create_table.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/r/rpl_row_flsh_tbls.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/r/rpl_row_inexist_tbl.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/r/rpl_row_log.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/r/rpl_row_log_innodb.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/r/rpl_row_max_relay_size.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/r/rpl_row_tabledefs_2myisam.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/r/rpl_row_until.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/r/rpl_skip_error.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/t/disabled.def:
        WL#3915  master's cols > slave
        
        Disabled the rpl_stm_extraColmaster_ndb test because statement-based
        replication is not supported in NDB at this time. It can be enabled
        when statement-based replication for NDB is released.
      mysql-test/suite/rpl/t/rpl_row_create_table.test:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch corrects binlog positions a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl/t/rpl_row_flsh_tbls.test:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch corrects binlog positions a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl_ndb/r/rpl_ndb_log.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      mysql-test/suite/rpl_ndb/r/rpl_truncate_7ndb.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new result file as a result of the change to the
        size of the tablemap log event.
      sql/field.cc:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch includes updates to the unpack() methods for the variable
        length fields. A new parameter was added (from_length) that is the
        value stored in the field_metadata of the table map from the table_def
        class. If the value is non-zero and less than what the field on the 
        slave is then use the from_length else use the original value from the
        field on the slave.
      sql/field.h:
        L#3228 : RBR using different table defs on slave/master
        
        This patch includes updates to the unpack() methods for the variable
        length fields. A new parameter was added (from_length) that is the
        value stored in the field_metadata of the table map from the table_def
        class.
      sql/log_event.cc:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch adds methods to calculate the field metadata size, prepare
        the field metadata for writing to the binlog, and additions to the
        Table_map_log_event::write_body method to include the field metadata 
        in the table map that is written to the binlog.
        
        WL#3915  master's cols > slave
        
        copying extra (slave's) fields returns early if master's table version is wider;
        removing assert in the way of master > slave cols.
      sql/log_event.h:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch adds method declarations and variables needed to support
        storing field metadata in the table map that is written to the binlog.
      sql/rpl_record.cc:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch modifies the unpack_row() method to unpack fields passing in
        the value from the table_def class. This value is the extra field
        metadata stored there from the master.
        
        WL#3915  master's cols > slave
        
        adding a snippet that shift exectution curson donw the row skipping unknown by slave
        fields' data.
      sql/rpl_rli.h:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch adds a helper function to retrieve the table_def for a given
        table in the RPL_TABLE_LIST structure.
      sql/rpl_utility.cc:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch adds a helper method that retrieves the correct size 
        parameter for the field. This method is used to compare the size as
        sent by the master with that on the slave for all types of fields that
        can vary in size and storage requirements. 
        
        WL#3915  master's cols > slave
        
        Remove warning message for master's cols > slave.
      sql/rpl_utility.h:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch changes the table_def class constructor to pass in the raw
        data read from the table map and extract it into an array of dimension
        size (number of fields). It also adds a method to return the field 
        metadata for any field. The method returns the data stored in the table
        map or 0 if no data was stored for that field. Lastly, a method to return
        the results of field->maybe_null() is included so that the slave can
        determine if a field that is not on the slave is null.
      mysql-test/suite/rpl/t/rpl_colSize.test:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a new test designed to test the feature of having
        columns on the master that are smaller than what is on the slave.
      mysql-test/suite/rpl/t/rpl_extraColmaster_innodb-master.opt:
        WL#3915  master's cols > slave
        
        option for innodb
      mysql-test/suite/rpl/t/rpl_extraColmaster_innodb-slave.opt:
        WL#3915  master's cols > slave
        
        option for innodb
      mysql-test/suite/rpl/t/rpl_extraColmaster_innodb.test:
        WL#3915  master's cols > slave
        
        Test of innodb. Test runs in both statement- and row-based replication.
      mysql-test/suite/rpl/t/rpl_extraColmaster_myisam.test:
        WL#3915  master's cols > slave
        
        Test of myisam. Test runs in both statement- and row-based replication.
      mysql-test/suite/rpl/r/rpl_colSize.result:
        WL#3228 : RBR using different table defs on slave/master
        
        This patch contains a result file for the new test designed to test the 
        feature of having columns on the master that are smaller than what is 
        on the slave.
      mysql-test/suite/rpl/t/rpl_row_extraColmaster_ndb.test:
        WL#3915  master's cols > slave
        
        Test of ndb. Test runs in row-based replication.
      mysql-test/suite/rpl/t/rpl_stm_extraColmaster_ndb.test:
        WL#3915  master's cols > slave
        
        Test of ndb. Test runs in statement-based replication.
      mysql-test/suite/rpl/r/rpl_extraColmaster_innodb.result:
        WL#3915  master's cols > slave
        
        new results
      mysql-test/suite/rpl/r/rpl_extraColmaster_myisam.result:
        WL#3915  master's cols > slave
        
        new results
      mysql-test/extra/rpl_tests/rpl_extraMaster_Col.test:
        WL#3915  master's cols > slave
        
        basic tests checking altering and skipping extra fields by slave.
        The fields can be of any possible types.
      mysql-test/suite/rpl/r/rpl_row_extraColmaster_ndb.result:
        WL#3915  master's cols > slave
        
        new results
      2804bd0f
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.1-rpl · a1870450
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b27972-mysql-5.1-rpl
      
      
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Auto merged
      a1870450
  3. 27 Jul, 2007 1 commit
    • unknown's avatar
      BUG#27972 (Test failure for rpl_ndb_circular_simplex): · 04642ac1
      unknown authored
      Removing a RESET MASTER inside the test since that will change binlog
      positions in such a manner that the dual masters lose track of where
      they acually are.
      
      
      mysql-test/suite/rpl_ndb/r/rpl_ndb_circular_simplex.result:
        Result change.
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Enabling test.
      mysql-test/suite/rpl_ndb/t/rpl_ndb_circular_simplex.test:
        Removing a RESET MASTER since circular replication don't look kindly
        on truncating binlogs.
      04642ac1
  4. 26 Jul, 2007 1 commit
    • unknown's avatar
      BUG#29809 (Slave SQL errors in warnings file): · 3ee26364
      unknown authored
      Adding code to filter out slave SQL errors since these are checked by
      the tests themselves.
      
      
      mysql-test/lib/mtr_report.pl:
        Filtering out slave SQL errors since these are handled by the
        tests themselves.
      mysql-test/suite/rpl/t/disabled.def:
        Enabling disabled tests.
      mysql-test/suite/rpl_ndb/r/rpl_truncate_7ndb.result:
        Result change.
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Enabling disabled tests.
      3ee26364
  5. 25 Jul, 2007 1 commit
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1-main · d258c587
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-2team
      
      
      include/my_bitmap.h:
        Auto merged
      mysql-test/suite/binlog/r/binlog_multi_engine.result:
        Auto merged
      mysql-test/suite/ndb/r/ndb_binlog_multi.result:
        Auto merged
      mysql-test/suite/ndb/t/ndb_autodiscover3.test:
        Auto merged
      mysql-test/suite/ndb/t/ndb_binlog_basic.test:
        Auto merged
      mysql-test/suite/ndb/t/ndb_binlog_ddl_multi.test:
        Auto merged
      mysql-test/suite/ndb/t/ndb_binlog_discover.test:
        Auto merged
      mysql-test/suite/ndb/t/ndb_binlog_ignore_db.test:
        Auto merged
      mysql-test/suite/ndb/t/ndb_binlog_log_bin.test:
        Auto merged
      mysql-test/suite/ndb/t/ndb_binlog_multi.test:
        Auto merged
      mysql-test/suite/ndb/t/ndb_multi_row.test:
        Auto merged
      mysql-test/suite/rpl/r/rpl_row_log.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_row_log_innodb.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_stm_log.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_truncate_7ndb_2.result:
        Auto merged
      mysql-test/suite/rpl_ndb/r/rpl_ndb_dd_partitions.result:
        Auto merged
      mysql-test/suite/rpl_ndb/r/rpl_ndb_log.result:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_UUID.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_bank.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_basic.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_blob.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_blob2.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_circular.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_circular_simplex.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_dd_advance.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_dd_basic.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_dd_partitions.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_ddl.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_delete_nowhere.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_do_db.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_do_table.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_extraCol.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_func003.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_idempotent.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_insert_ignore.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_multi.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_multi_update2.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_multi_update3.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_rep_ignore.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_row_001.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_sp003.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_sp006.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_sync.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndb_trig004.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_ndbapi_multi.test:
        Auto merged
      mysql-test/suite/rpl_ndb/t/rpl_row_basic_7ndb.test:
        Auto merged
      sql/log_event.cc:
        Auto merged
      mysql-test/suite/rpl_ndb/r/rpl_truncate_7ndb.result:
        Manual merge
      mysql-test/t/disabled.def:
        Manual merge of main tree into replication tree
      d258c587
  6. 24 Jul, 2007 5 commits
  7. 21 Jul, 2007 4 commits
    • unknown's avatar
      Merge bodhi.(none):/opt/local/work/mysql-5.0-runtime · d1e7f32e
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/r/create.result:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      sql/sql_class.h:
        Auto merged
      d1e7f32e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 8b3a5f79
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      8b3a5f79
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · dc830d38
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.0-runtime
      
      
      mysql-test/r/create.result:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      sql/sql_class.h:
        Auto merged
      dc830d38
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · 9e9f196b
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      libmysql/libmysql.c:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql/field.cc:
        Auto merged
      9e9f196b
  8. 20 Jul, 2007 13 commits
  9. 19 Jul, 2007 9 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.1 · 496ddec1
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      mysql-test/t/disabled.def:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        SCCS merged
      tests/mysql_client_test.c:
        SCCS merged
      496ddec1
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · 900f8d8a
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      900f8d8a
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 5c4c5941
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      5c4c5941
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0.44 · 25491503
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0.46
      
      
      configure.in:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      25491503
    • unknown's avatar
      BUG#20815 Errno 12 on Windows after 197 connections · 2163d202
      unknown authored
      
      CMakeLists.txt:
        BUG#20815 Set stack size. This value is really supposed to be the linker's default. I'm not quite sure why we have to specify it manually too.
      2163d202
    • unknown's avatar
      Bug#29898: Item_date_typecast::val_int doesn't reset the null_value flag. · 7122b729
      unknown authored
      The Item_date_typecast::val_int function doesn't reset null_value flag.
      This makes all values that follows the first null value to be treated as nulls
      and led to a wrong result.
      
      Now the Item_date_typecast::val_int function correctly sets the null_value flag
      for both null and non-null values.
      
      
      mysql-test/t/cast.test:
        Added a test case for the bug#29898:  Item_date_typecast::val_int doesn't reset
        the null_value flag.
      mysql-test/r/cast.result:
        Added a test case for the bug#29898:  Item_date_typecast::val_int doesn't reset
        the null_value flag.
      sql/item_timefunc.cc:
        Bug#29898: Item_date_typecast::val_int doesn't reset the null_value flag.
        Now the Item_date_typecast::val_int function correctly sets the null_value flag
        for both null and non-null values.
      7122b729
    • unknown's avatar
      mysql_client_test fixed · f8c9269f
      unknown authored
      
      tests/mysql_client_test.c:
        rc assignement added
      f8c9269f
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · dab67085
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      dab67085
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · 927063c7
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      sql/mysql_priv.h:
        Auto merged
      927063c7