1. 02 Jul, 2024 1 commit
  2. 28 Jun, 2024 2 commits
    • Monty's avatar
      MDEV-34240 galera.MDEV-27862 fails binlog assert in close_thread_tables() · 86770ada
      Monty authored
      Affects:
      MDEV-34150 Assertion failure in Diagnostics_area::set_error_status upon binary
                 logging hitting tmp space limit
      MDEV-9101 Limit size of created disk temporary files and tables
      
      This bug was caused by moving flushing of the in-memory-row-events from
      close_thread_tables() to binlog_commit() in MDEV-34150.
      This was needed to be able to handle the case where binlog writes could
      fail.
      
      Galera have two case where the change caused problems:
      
      - Row events in commit_one_phase_2() was not done in the case the standard
        binary log was not enabled but Galera was using the binary log
        internally.
      - Galera disabled the call to binlog_commit_flush_stmt_cache() for not
        ending transactions.
      
      Fixed by adding code that flushes the in-memory-row-events to the binary
      log (write, but now sync) in the two above cases if Galera is enabled.
      86770ada
    • Monty's avatar
      f385837d
  3. 20 Jun, 2024 1 commit
    • Daniel Black's avatar
      MDEV-34430: remove Debian character-set-collations · 40eb56b6
      Daniel Black authored
      Since MDEV-25829 Change default Unicode collation to uca1400_ai_ci
      there is no need to set character-set-collations explicitly as its
      the default.
      
      Further mode the change in defaults affects all character sets that
      support the uca1400_ai_ci collation.
      40eb56b6
  4. 18 Jun, 2024 1 commit
  5. 30 May, 2024 3 commits
  6. 29 May, 2024 2 commits
  7. 28 May, 2024 2 commits
  8. 27 May, 2024 28 commits
    • Vladislav Vaintroub's avatar
      Fix appveyor build with newer OpenSSL. · aa04bba4
      Vladislav Vaintroub authored
      Using /WX (warning as error) during configuration step caused
      HAVE_OPENSSL_APPLINK_C to be OFF
      
      This made client utilities fail with "Applink not found" during runtime.
      
      Hardcode -DHAVE_OPENSSL_APPLINK_C=1 for CMake for now, fix connector
      later.
      aa04bba4
    • Sergei Golubchik's avatar
      MDEV-32218 PASSWORD_EXPIRATION_TIME column · 173edf60
      Sergei Golubchik authored
      * show it as a datetime, not number of seconds
      * show all users
      * show manually expired users as 0000-00-00 00:00:00
      * show default expiration interval correctly
      * numerous test fixes, add more tests
      * fix compilation of embedded
      173edf60
    • Nikita Malyavin's avatar
      MDEV-23729 MDEV-32218 INFORMATION_SCHEMA table for user data · d229b4af
      Nikita Malyavin authored
      * A new table INFORMATION_SCHEMA.USERS is introduced.
      * It stores auxiliary user data
      * An unprivileged user can access their own data, and that is the main
        difference with what mysql.global_priv provides
      * The fields are currently: USER, PASSWORD_ERRORS, PASSWORD_EXPIRATION_TIME
      * If password_errors is ignored for the user, PASSWORD_ERRORS is NULL
      * PASSWORD_EXPIRATION_TIME is a timestamp with exact point in time, calculated
      from password_last_changed and password_lifetime (i.e. days) stored for the user
      d229b4af
    • Vladislav Vaintroub's avatar
    • Sergei Golubchik's avatar
      disable failing galera test · bec1f321
      Sergei Golubchik authored
      bec1f321
    • Sergei Golubchik's avatar
      columnstore 23.10.1-2 · d88765e6
      Sergei Golubchik authored
      d88765e6
    • Elena Stepanova's avatar
    • Monty's avatar
      MDEV-33151 Add more columns to TABLE_STATISTICS and USER STATS · 94033fcf
      Monty authored
      Columns added to TABLE_STATISTICS
      - ROWS_INSERTED, ROWS_DELETED, ROWS_UPDATED, KEY_READ_HITS and
        KEY_READ_MISSES.
      
      Columns added to CLIENT_STATISTICS and USER_STATISTICS:
      - KEY_READ_HITS and KEY_READ_MISSES.
      
      User visible changes (except new columns):
      - CLIENT_STATISTICS and USER_STATISTICS has columns KEY_READ_HITS and
        KEY_READ_MISSES added after column ROWS_UPDATED before SELECT_COMMANDS.
      
      Other changes:
      - Do not collect table statistics for system tables like index_stats
        table_stats, performance_schema, information_schema etc as the user
        has no control of these and the generate noice in the statistics.
      - All row variables that are part of user_stats are moved to
        'struct rows_stats' to make it easy to clear all of them at once.
      - ha_read_key_misses added to STATUS_VAR
      
      Notes:
      - userstat.result has a change of numbers of rows for handler_read_key.
        This is because use-stat-tables is now disabled for the test.
      94033fcf
    • Sergei Golubchik's avatar
      INFORMATION_SCHEMA.ALL_PLUGINS: filter away more errors · c9445186
      Sergei Golubchik authored
      fixes a failure of period.create on bintar-centos74-amd64
      c9445186
    • Sergei Golubchik's avatar
      my_errno can not be set to EE_ error numbers · bfbdc273
      Sergei Golubchik authored
      EE_ numbers occupy the same range as OS Exxx errors and
      my_errno is generally for OS errors. And for HA_ERR_ handler errors
      which occupy a different range, so can be freely mixed with OS errors.
      bfbdc273
    • Sergei Golubchik's avatar
      aebd1620
    • Sergei Golubchik's avatar
      restore the error message that was changed by mistake · 9cb0bb1d
      Sergei Golubchik authored
      add a test case
      9cb0bb1d
    • Sergei Golubchik's avatar
      fix chi error message · 443aa52c
      Sergei Golubchik authored
      443aa52c
    • Sergei Golubchik's avatar
      cleanup: remove redundant code · fdd27497
      Sergei Golubchik authored
      reinit_io_cache() resets and restores MY_TRACK_WITH_LIMIT internally
      fdd27497
    • Sergei Golubchik's avatar
      cleanup: clarify the function name and purpose · ce5b8e59
      Sergei Golubchik authored
      and make it static
      ce5b8e59
    • Sergei Golubchik's avatar
      remove double-printing of safemalloc report · d500c22f
      Sergei Golubchik authored
      and rephrase memory accounting error message to match tmp_space one
      (besides, memory accounting error could - and did - happen when all
      memory was actually freed)
      d500c22f
    • Monty's avatar
      MDEV-34150 Assertion failure in Diagnostics_area::set_error_status upon binary... · 381e9adb
      Monty authored
      MDEV-34150 Assertion failure in Diagnostics_area::set_error_status upon binary logging hitting tmp space limit
      
      - Moved writing to binlog_cache from close_thread_tables() to
        binlog_commit().
      - In select_create() delete cached row events instead of flushing them
        to disk. This was done to avoid possible disk write error in this code.
      381e9adb
    • Monty's avatar
    • Monty's avatar
    • Monty's avatar
      MDEV-34054 Memory leak in Window_func_runner::exec after encountering... · 7d1467e9
      Monty authored
      MDEV-34054 Memory leak in Window_func_runner::exec after encountering "temporary space limit reached" error
      7d1467e9
    • Monty's avatar
    • Monty's avatar
      MDEV-33751 Assertion `thd' failed in int temp_file_size_cb_func(tmp_file_tracking*, int) · d2304554
      Monty authored
      Changes:
      - Fixed that MyISAM and Aria parallel repair works with tmp file limit.
        This required to add current_thd to all parallel workers and add
        protection in my_malloc_size_cb_func() and temp_file_size_cb_func() to
        be able to handle shared THD's.  I removed the old code in MyISAM to
        set current_thd() as only worked when using with virtal indexed
        columns and I wanted to keep the Aria and MyISAM code identical.
      
      Other things:
      - Improved error messages from Aria parallel repair and
        create_internal_tmp_table_from_heap().
      d2304554
    • Monty's avatar
      MDEV-33680 Server hangs or assertion fails upon SELECT with limited max_tmp_space_usage · 865ef0f5
      Monty authored
      The bug was that Aggregator_distinct::add() did not properly handle
      write errors. (Old bug exposed by the new code).
      865ef0f5
    • Monty's avatar
      MDEV-9101 Limit size of created disk temporary files and tables · b9f57931
      Monty authored
      Two new variables added:
      - max_tmp_space_usage : Limits the the temporary space allowance per user
      - max_total_tmp_space_usage: Limits the temporary space allowance for
        all users.
      
      New status variables: tmp_space_used & max_tmp_space_used
      New field in information_schema.process_list: TMP_SPACE_USED
      
      The temporary space is counted for:
      - All SQL level temporary files. This includes files for filesort,
        transaction temporary space, analyze, binlog_stmt_cache etc.
        It does not include engine internal temporary files used for repair,
        alter table, index pre sorting etc.
      - All internal on disk temporary tables created as part of resolving a
        SELECT, multi-source update etc.
      
      Special cases:
      - When doing a commit, the last flush of the binlog_stmt_cache
        will not cause an error even if the temporary space limit is exceeded.
        This is to avoid giving errors on commit. This means that a user
        can temporary go over the limit with up to binlog_stmt_cache_size.
      
      Noteworthy issue:
      - One has to be careful when using small values for max_tmp_space_limit
        together with binary logging and with non transactional tables.
        If a the binary log entry for the query is bigger than
        binlog_stmt_cache_size and one hits the limit of max_tmp_space_limit
        when flushing the entry to disk, the query will abort and the
        binary log will not contain the last changes to the table.
        This will also stop the slave!
        This is also true for all Aria tables as Aria cannot do rollback
        (except in case of crashes)!
        One way to avoid it is to use @@binlog_format=statement for
        queries that updates a lot of rows.
      
      Implementation:
      - All writes to temporary files or internal temporary tables, that
        increases the file size, are routed through temp_file_size_cb_func()
        which updates and checks the temp space usage.
      - Most of the temporary file monitoring is done inside IO_CACHE.
        Temporary file monitoring is done inside the Aria engine.
      - MY_TRACK and MY_TRACK_WITH_LIMIT are new flags for ini_io_cache().
        MY_TRACK means that we track the file usage. TRACK_WITH_LIMIT means
        that we track the file usage and we give an error if the limit is
        breached. This is used to not give an error on commit when
        binlog_stmp_cache is flushed.
      - global_tmp_space_used contains the total tmp space used so far.
        This is needed quickly check against max_total_tmp_space_usage.
      - Temporary space errors are using EE_LOCAL_TMP_SPACE_FULL and
        handler errors are using HA_ERR_LOCAL_TMP_SPACE_FULL.
        This is needed until we move general errors to it's own error space
        so that they cannot conflict with system error numbers.
      - Return value of my_chsize() and mysql_file_chsize() has changed
        so that -1 is returned in the case my_chsize() could not decrease
        the file size (very unlikely and will not happen on modern systems).
        All calls to _chsize() are updated to check for > 0 as the error
        condition.
      - At the destruction of THD we check that THD::tmp_file_space == 0
      - At server end we check that global_tmp_space_used == 0
      - As a precaution against errors in the tmp_space_used code, one can set
        max_tmp_space_usage and max_total_tmp_space_usage to 0 to disable
        the tmp space quota errors.
      - truncate_io_cache() function added.
      - Aria tables using static or dynamic row length are registered in 8K
        increments to avoid some calls to update_tmp_file_size().
      
      Other things:
      - Ensure that all handler errors are registered.  Before, some engine
        errors could be printed as "Unknown error".
      - Fixed bug in filesort() that causes a assert if there was an error
        when writing to the temporay file.
      - Fixed that compute_window_func() now takes into account write errors.
      - In case of parallel replication, rpl_group_info::cleanup_context()
        could call trans_rollback() with thd->error set, which would cause
        an assert. Fixed by resetting the error before calling trans_rollback().
      - Fixed bug in subselect3.inc which caused following test to use
        heap tables with low value for max_heap_table_size
      - Fixed bug in sql_expression_cache where it did not overflow
        heap table to Aria table.
      - Added Max_tmp_disk_space_used to slow query log.
      - Fixed some bugs in log_slow_innodb.test
      b9f57931
    • Monty's avatar
      fixed that Filesort_on_disk in slow query log works again · b60419e0
      Monty authored
      A commit in 10.10 caused it to be always 'No'
      b60419e0
    • Monty's avatar
      Improve error message for ER_CANT_FIND_DL_ENTRY · 9c7e57a4
      Monty authored
      Added name of the dll/udf that caused the error.
      9c7e57a4
    • Sergei Golubchik's avatar
      MDEV-33145 support for old-mode=OLD_FLUSH_STATUS · 9293d40f
      Sergei Golubchik authored
      add old-mode that restores inconsistent legacy behavior for FLUSH STATUS.
      It doesn't affect FLUSH { SESSION | GLOBAL } STATUS.
      9293d40f
    • Sergei Golubchik's avatar
      cleanup: old_mode_deprecated · 9ecec1f7
      Sergei Golubchik authored
      make it easier to add more old-mode values
      9ecec1f7