1. 11 Feb, 2008 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 64169931
      unknown authored
      into  janus.mylan:/usr/home/serg/Abk/mysql-maria
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      include/my_base.h:
        merged
      64169931
    • unknown's avatar
      Problem: pushbuild has sporadic errors during startup of · bbef4be3
      unknown authored
      rpl_ndb_rep_ignore
      Reason: previous test, rpl_ndb_2multi_eng, does not sync slave with master
      after cleanup, so tables are sometimes left on slave
      Fix: sync_slave_with_master
      
      
      mysql-test/extra/rpl_tests/rpl_ndb_2multi_eng.test:
        Wait until drop table is replicated to slave before terminating. (The
        extra table caused sporadic errors in the next test case, causing
        pushbuild to fail.)
      bbef4be3
  2. 09 Feb, 2008 2 commits
  3. 08 Feb, 2008 8 commits
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/maria/mysql-5.1-release · d406184e
      unknown authored
      into  mysql.com:/home/kent/bk/maria/mysql-maria
      
      
      extra/yassl/src/handshake.cpp:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      d406184e
    • unknown's avatar
      BUG#33247: mysqlbinlog does not clean up after itself on abnormal termination · 42d84bc1
      unknown authored
      Problem: mysqlbinlog does not free memory if an error happens.
      Fix: binlog-processing functions do not call exit() anymore. Instead, they
      print an error and return an error code. Error codes are propagated all
      the way back to main, and all allocated memory is freed on the way.
      
      
      client/mysqlbinlog.cc:
        - New error handling policy: functions processing binlogs don't just
          exit() anymore. Instead, they print a message and return an error
          status.
        - New policy for the global `mysql' and `glob_description_event': these
          are not passed as parameters anymore. The global pointer is used
          instead.
        - More error situations are detected and reported.
        - Better error messages: the program never terminates with exit status 1
          without explanation any more. Fixed spelling errors. Use consistent
          format of messages (a single line beginning with "ERROR: " or
          "WARNING: " and ending with "." is printed to stderr.)
        - New memory handling: memory is always freed on program termination.
        - Better comments: more functions are explained, doxygen is used, and
          more precise formulations in some existing comments.
      mysql-test/suite/binlog/r/binlog_base64_flag.result:
        Result file updated since output format of mysqlbinlog changed while the
        test was disabled.
      mysql-test/suite/binlog/t/binlog_killed.test:
        Mysqlbinlog now works as described when the binlog is open. Hence, the
        --force-if-open flag must be passed
      mysql-test/suite/binlog/t/binlog_killed_simulate.test:
        Mysqlbinlog now works as described when the binlog is open. Hence, the
        --force-if-open flag must be passed
      mysql-test/suite/binlog/t/disabled.def:
        Now that mysqlbinlog cleans up after itself on abnormal termination, we
        can enable this test again.
      42d84bc1
    • unknown's avatar
      Correcting assertion · 6761c498
      unknown authored
      
      storage/maria/ha_maria.cc:
        start_stmt() is passed thr_lock_type (TL_*), not int F_*.
        Though tt does not seem to matter here, F_UNLCK == TL_UNLOCK == 0
        at least on Linux and Windows.
      6761c498
    • unknown's avatar
      ma_pagecache.c: · a6c7eb1b
      unknown authored
        SCCS merged
      
      
      storage/maria/ma_pagecache.c:
        SCCS merged
      a6c7eb1b
    • unknown's avatar
      BUG#34089 "Maria crash on LOAD INDEX after FLUSH TABLES" · 593528fb
      unknown authored
      a typo had not disable LOAD INDEX for Maria.
      BUG#34161 "freeing maria tmp table after fetching rows using prepared statements - crashes"
      running the testcase I was not able to repeat the same crash but
      found a misplaced assertion giving false positive, fixed here.
      
      
      storage/maria/ha_maria.cc:
        important typo
      storage/maria/ma_pagecache.c:
        The assertion on block's type should be after read_block(). Otherwise
        it can give false alarms.
      593528fb
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-maria · dc4b257a
      unknown authored
      into  mysqlwin32.:C:/mysql-maria
      
      dc4b257a
    • unknown's avatar
      Fix for bug in log handler observed when running maria-big · 539bbaae
      unknown authored
      and then maria-connect under Windows 32-bit Visual Studio 2003.
      Build of all Maria unit tests under Windows.
      
      
      storage/maria/ma_loghandler.c:
        Assertion contributed by Sanja. Working around my_stat() bug on Windows
        (st_size is long i.e. 32-bit signed, the file was slightly bigger than
        2GB, so st_size was negative, TRANSLOG_PAGE_SIZE was int, so the
        comparison was done using long, so st_size was still negative in
        the comparison, which was incorrect). Two fixes: cast st_size to uint32
        (belt) and make TRANSLOG_PAGE_SIZE unsigned (suspenders).
        Of course 'long' is not enough for files >=4GB, but all log files of
        Maria are <4GB. The general problem of my_stat() has been passed on to
        our Windows team.
      storage/maria/ma_loghandler.h:
        use unsigned ints for constants which represent sizes of pages, files...
      storage/maria/unittest/CMakeLists.txt:
        a few unit tests were not built under Windows
      539bbaae
    • unknown's avatar
      Postmerge mac compiler warnings fixed. · 9637affb
      unknown authored
      9637affb
  4. 07 Feb, 2008 12 commits
    • unknown's avatar
      Merge oleksandr-byelkins-powerbook-g4-15.local:/Users/bell/mysql/bk/mysql-maria · 3bfa89bd
      unknown authored
      into  oleksandr-byelkins-powerbook-g4-15.local:/Users/bell/mysql/bk/work-maria-wrn
      
      
      storage/maria/ma_blockrec.c:
        Auto merged
      storage/maria/ma_check.c:
        Auto merged
      storage/maria/ma_control_file.c:
        Auto merged
      storage/maria/ma_key_recover.c:
        Auto merged
      storage/maria/ma_page.c:
        Auto merged
      storage/maria/ma_pagecache.c:
        Auto merged
      storage/maria/ma_recovery.c:
        Auto merged
      3bfa89bd
    • unknown's avatar
      Mac compiler warnings fixed. · 1dec5f9e
      unknown authored
      
      include/maria.h:
        mac compiler warnings fixed.
      storage/maria/ma_bitmap.c:
        mac compiler warnings fixed.
      storage/maria/ma_blockrec.c:
        mac compiler warnings fixed.
      storage/maria/ma_check.c:
        mac compiler warnings fixed.
      storage/maria/ma_control_file.c:
        mac compiler warnings fixed.
      storage/maria/ma_create.c:
        mac compiler warnings fixed.
      storage/maria/ma_delete.c:
        mac compiler warnings fixed.
      storage/maria/ma_ft_boolean_search.c:
        mac compiler warnings fixed.
      storage/maria/ma_page.c:
        mac compiler warnings fixed.
      storage/maria/ma_pagecache.c:
        mac compiler warnings fixed.
      storage/maria/ma_recovery.c:
        mac compiler warning fixed.
      storage/maria/ma_rt_test.c:
        mac compiler warnings fixed.
      storage/maria/ma_search.c:
        mac compiler warning fixed.
      storage/maria/ma_write.c:
        mac compiler warnings fixed.
      storage/maria/unittest/ma_control_file-t.c:
        mac compiler warnings fixed.
      storage/maria/unittest/ma_pagecache_consist.c:
        mac compiler warnings fixed.
      storage/maria/unittest/ma_pagecache_single.c:
        mac compiler warnings fixed.
      storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
        mac compiler warning fixed.
      storage/maria/unittest/test_file.c:
        mac compiler warning fixed.
      1dec5f9e
    • unknown's avatar
      missing DBUG_VOID_RETURN · 237f7ae7
      unknown authored
      
      BUILD/SETUP.sh:
        no need to force stack direction anymore
      237f7ae7
    • unknown's avatar
      WL#4078: Document binary format of binlog entries · 9ffce940
      unknown authored
      Documented Table_map_log_event and packed integer format. Improved
      other documentation. No change outside comments.
      
      
      sql/log_event.h:
        Documented Table_map_log_event and packed integer format. Improved
        other documentation. No change outside comments.
      9ffce940
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-maria · 58237d22
      unknown authored
      into  mysqlwin32.:C:/mysql-maria
      
      58237d22
    • unknown's avatar
      Fixes for DBUG_ABORT() · 60c7c7b8
      unknown authored
      
      BitKeeper/deleted/.del-.tree-is-private:
        Delete: .tree-is-private
      include/my_dbug.h:
        To disable the popup of abort() we use _CrtReportMode/File()
        (thanks Wlad)
      mysys/my_thr_init.c:
        Visual Studio 2005 does not allow overloading library functions.
      60c7c7b8
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · c57b2995
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      mysql-test/suite/binlog/t/binlog_old_versions.test:
        Auto merged
      c57b2995
    • unknown's avatar
      Renaming some saved binary log files to avoid 99 characters · a2e6846d
      unknown authored
      limit for v7 tar.
      
      
      mysql-test/suite/binlog/std_data/ver_5_1_17.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1_17.000001 -> mysql-test/suite/binlog/std_data/ver_5_1_17.001
      mysql-test/suite/binlog/std_data/ver_5_1_23.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1_23.000001 -> mysql-test/suite/binlog/std_data/ver_5_1_23.001
      mysql-test/suite/binlog/std_data/ver_5_1-telco.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1-telco.000001 -> mysql-test/suite/binlog/std_data/ver_5_1-telco.001
      mysql-test/suite/binlog/std_data/ver_5_1-wl2325_r.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1-wl2325_row.000001 -> mysql-test/suite/binlog/std_data/ver_5_1-wl2325_r.001
      mysql-test/suite/binlog/std_data/ver_5_1-wl2325_s.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1-wl2325_stm.000001 -> mysql-test/suite/binlog/std_data/ver_5_1-wl2325_s.001
      mysql-test/suite/binlog/std_data/bug32407.001:
        Rename: mysql-test/suite/binlog/std_data/binlog-bug32407.000001 -> mysql-test/suite/binlog/std_data/bug32407.001
      a2e6846d
    • unknown's avatar
      midding DBUG_RETURN · 79031ccc
      unknown authored
      79031ccc
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · 8b281444
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      sql/slave.cc:
        Auto merged
      8b281444
    • unknown's avatar
      Disabling declaration of debug variable for non-debug builds. · ed1bcc02
      unknown authored
      
      sql/slave.cc:
        Disabling declaration in non-debug builds.
      ed1bcc02
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · fb005c4d
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      sql/slave.cc:
        Auto merged
      sql/sql_binlog.cc:
        Auto merged
      fb005c4d
  5. 06 Feb, 2008 16 commits
    • unknown's avatar
      _db_strict_keyword_ is no more · 577d3698
      unknown authored
      577d3698
    • unknown's avatar
      df3502ca
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-maria · c71218c5
      unknown authored
      into  mysql.com:/home/my/mysql-maria
      
      c71218c5
    • unknown's avatar
      dbug/Makefile.am · 73f351d7
      unknown authored
          1. older automakes didn't have builddir, don't use it.
          2. destination can be read-only (think bk -r get)
      
      
      dbug/Makefile.am:
        1. older automakes didn't have builddir, don't use it.
        2. destination can be read-only (think bk -r get)
      73f351d7
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-maria · 539ae15b
      unknown authored
      into  mysql.com:/home/my/mysql-maria
      
      539ae15b
    • unknown's avatar
      Merge riska.(none):/home/sven/bk/b34355-backslash_in_path_name_under_win/5.0-rpl · 7612771d
      unknown authored
      into  riska.(none):/home/sven/bk/b34355-backslash_in_path_name_under_win/5.1-new-rpl
      
      
      client/mysqlbinlog.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      7612771d
    • unknown's avatar
    • unknown's avatar
      Replace windows path separator backslash by unix path separator forward · 270e2f3c
      unknown authored
      slash in filenames also for Create_file_log_event.
      
      
      client/mysqlbinlog.cc:
        BUG#34355: mysqlbinlog outputs backslash as path separator for 4.1 binlogs
        Problem: When the windows version of mysqlbinlog reads 4.1 binlogs
        containing LOAD DATA INFILE, it outputs backslashes as path separators in
        filenames. However, the output is typically piped to a client, and client
        expects forward slashes.
        Fix: Replace '\\' by '/' in filenames.
      270e2f3c
    • unknown's avatar
      dbug/dbug.c · 6d7f997e
      unknown authored
          dbug naming conventions
      dbug/user.r
          unification, documenting DBUG_ABORT()
      include/my_dbug.h
          DBUG_ABORT()
      sql/mysqld.cc
          remove redundant option (--enable-debug and --disable-debug should be
          used instead)
      
      
      dbug/dbug.c:
        dbug naming conventions
      dbug/user.r:
        unification, documenting DBUG_ABORT()
      include/my_dbug.h:
        DBUG_ABORT()
      sql/mysqld.cc:
        remove redundant option (--enable-debug and --disable-debug should be
        used instead)
      6d7f997e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-maria · e2b4c18f
      unknown authored
      into  janus.mylan:/usr/home/serg/Abk/mysql-maria
      
      
      sql/handler.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      include/my_dbug.h:
        merged
      e2b4c18f
    • unknown's avatar
      ma_control_file.c: · 4bd3a99a
      unknown authored
        SCCS merged
      
      
      storage/maria/ma_control_file.c:
        SCCS merged
      4bd3a99a
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-maria · b1138311
      unknown authored
      into  mysqlwin32.:C:/mysql-maria
      
      
      mysql-test/include/wait_until_connected_again.inc:
        Auto merged
      storage/maria/ha_maria.cc:
        Auto merged
      storage/maria/ma_blockrec.c:
        Auto merged
      storage/maria/ma_check.c:
        Auto merged
      storage/maria/ma_loghandler.c:
        Auto merged
      b1138311
    • unknown's avatar
      Fixes for running maria-recovery*.test and maria-purge.test under · 67665c97
      unknown authored
      Windows.
      
      
      include/my_dbug.h:
        a DBUG expression to force a flush of the trace file then an abort of the process
      mysql-test/include/wait_until_connected_again.inc:
        mysqladmin waits for pid file to be gone only under Unix; so
        maria_empty_logs.inc cannot wait for mysqld to be gone, so
        wait_until_connected_again.inc may send its "show status" to a 
        not-yet-dead server hence the 1053 error ("server shutdown in progress")
      mysys/my_thr_init.c:
        overload abort() under Windows, to not have an annoying CRT popup
        ("ignore/abort/retry" buttons) each time a test intentionally
        crashes mysqld
      sql/handler.cc:
        use new expression
      sql/log.cc:
        use new expression
      sql/mysql_priv.h:
        use new expression
      storage/maria/ha_maria.cc:
        use new expression
      storage/maria/ma_blockrec.c:
        use new expression
      storage/maria/ma_check.c:
        use new expression
      storage/maria/ma_checkpoint.c:
        use new expression
      storage/maria/ma_control_file.c:
        Can't yet lock control file under Windows (test suite problems,
        plus concerns about stray lock preventing a fast restart after crash).
      storage/maria/ma_loghandler.c:
        A file which should be closed, otherwise translog_purge() (the caller)
        cannot delete logs.
      67665c97
    • unknown's avatar
      after-merge · 2ca92318
      unknown authored
      *correct* disabling of dbug in mysql-test-run
      
      
      include/atomic/gcc_builtins.h:
        after-merge
      mysql-test/lib/mtr_report.pl:
        after-merge
      mysql-test/mysql-test-run.pl:
        *correct* disabling of dbug in mysql-test-run
      mysql-test/r/ps_maria.result:
        after-merge
      mysql-test/t/crash_commit_before-master.opt:
        *correct* disabling of dbug in mysql-test-run
      mysql-test/t/maria-recovery-big-master.opt:
        *correct* disabling of dbug in mysql-test-run
      mysql-test/t/maria-recovery-bitmap-master.opt:
        *correct* disabling of dbug in mysql-test-run
      mysql-test/t/maria-recovery-master.opt:
        *correct* disabling of dbug in mysql-test-run
      sql/mysqld.cc:
        --disable-debug
      2ca92318
    • unknown's avatar
      Lock control file also when we have created it in this run. Assertions. · ba964f42
      unknown authored
      
      storage/maria/ma_control_file.c:
        Even if the file is just created we have to lock it, otherwise some
        other Maria instance may write to it.
      storage/maria/ma_pagecache.c:
        catch too big page numbers when they enter the pagecache; this helps
        debugging BUG#34250.
      ba964f42
    • unknown's avatar
      Patch to eliminate some valgrind warnings in debug printout code. · 14fb6f70
      unknown authored
      
      sql/rpl_rli.cc:
        Adding variable to mark an instance of Relay_log_info as fake.
      sql/rpl_rli.h:
        Adding variable to mark an instance of Relay_log_info as fake.
      sql/slave.cc:
        Not printing debug information if we are working with a fake
        instance of Relay_log_info. This because the result of calling
        update is nonsense, and trying to print it generates valgrind
        warnings.
      sql/sql_binlog.cc:
        Marking newly created instance of Relay_log_info as a fake instance.
      14fb6f70