1. 25 Mar, 2022 1 commit
  2. 24 Mar, 2022 2 commits
    • Brandon Nesterenko's avatar
      DBAAS-7828: Primary/replica: configuration change of autocommit=0 can not be applied · cd88b083
      Brandon Nesterenko authored
      Problem:
      ========
      When the mysql.gtid_slave_pos table uses the InnoDB engine, and
      mysqld starts, it reads the table and begins a transaction. After
      reading the value, it should end the transaction and release all
      associated locks. The bug reported in DBAAS-7828 shows that when
      autocommit is off, the locks are not released, resulting in
      indefinite hangs on future attempts to change gtid_slave_pos. In
      particular, the transaction was not properly finalized because
      thd->server_status was not updated to reflect the end of the
      transaction.
      
      Solution:
      ========
      This patch updates the code to properly commit the transaction after
      reading gtid_slave_pos during mysqld start-up.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      cd88b083
    • Brandon Nesterenko's avatar
      MDEV-25580: rpl.rpl_semi_sync_slave_compressed_protocol crashes because of wrong packet · 32ab6219
      Brandon Nesterenko authored
      Problem:
      ========
      When both semi-sync and slave compression are enabled, the numbering
      on packet headers can become out of sync between the primary and
      replica servers. More specifically, after the master flushes its
      write, it should increment the counters that track packets. The
      bug is such that the master only updates the normal packet counter
      and leaves the compressed packet counter alone.
      
      Solution:
      ========
      After the master flushes, additionally increment the compressed
      packet counter.
      
      Reviewed By:
      ============
      Andrei Elkin: <andrei.elkin@mariadb.com>
      32ab6219
  3. 23 Mar, 2022 1 commit
    • Igor Babaev's avatar
      MDEV-24281 Reading from freed memory when running main.view with --ps-protocol · bbf02c85
      Igor Babaev authored
      This bug could affect prepared statements for the command CREATE VIEW with
      specification that contained unnamed basic constant in select list. If
      generation of a valid name for the corresponding view column required
      resolution of conflicts with names of other columns that were explicitly
      defined then execution of such prepared statement and following deallocation
      of this statement led to reading from freed memory.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      bbf02c85
  4. 22 Mar, 2022 2 commits
  5. 21 Mar, 2022 2 commits
    • Alexander Barkov's avatar
      MDEV-28131 Unexpected warning while selecting from information_schema.processlist · 0812d0de
      Alexander Barkov authored
      Problem:
      
      DECIMAL columns in I_S must be explicitly set of some value.
      
      I_S columns do not have `DEFAULT 0` (after MDEV-18918), so during
      restore_record() their record fragments pointed by Field::ptr are
      initialized to zero bytes 0x00.
      But an array of 0x00's is not a valid binary DECIMAL value.
      So val_decimal() called for such Field_new_decimal generated a warning
      when seeing a wrong binary encoded DECIMAL value in the record.
      
      Fix:
      
      Explicitly setting INFORMATION_SCHEMA.PROCESSLIST.PROGRESS
      to the decimal value of 0 if no progress information is available.
      0812d0de
    • Oleksandr Byelkin's avatar
      MDEV-26009 Server crash when calling twice procedure using FOR-loop · fbc1cc97
      Oleksandr Byelkin authored
      The problem was that instructions sp_instr_cursor_copy_struct and
      sp_instr_copen uses the same lex, adding and removing "tail" of
      prelocked tables and forgetting that tail of all tables is kept in
      LEX::query_tables_last. If the LEX used only by one instruction
      or the query do not have prelocked tables it is not important.
      But to work correctly in all cases LEX::query_tables_last should
      be reset to make new tables added in the correct list (after last
      table in the LEX instead after last table of the prelocking "tail"
      which was cut).
      fbc1cc97
  6. 19 Mar, 2022 1 commit
  7. 17 Mar, 2022 1 commit
  8. 16 Mar, 2022 2 commits
  9. 15 Mar, 2022 3 commits
    • Daniel Black's avatar
      MDEV-23915 ER_KILL_DENIED_ERROR not passed a thread id (part 2) · 57dbe878
      Daniel Black authored
      Per Marko's comment in JIRA, sql_kill is passing the thread id
      as long long. We change the format of the error messages to match,
      and cast the thread id to long long in sql_kill_user.
      57dbe878
    • Daniel Black's avatar
      MDEV-23915 ER_KILL_DENIED_ERROR not passed a thread id · 99837c61
      Daniel Black authored
      The 10.5 test error main.grant_kill showed up a incorrect
      thread id on a big endian architecture.
      
      The cause of this is the sql_kill_user function assumed the
      error was ER_OUT_OF_RESOURCES, when the the actual error was
      ER_KILL_DENIED_ERROR. ER_KILL_DENIED_ERROR as an error message
      requires a thread id to be passed as unsigned long, however a
      user/host was passed.
      
      ER_OUT_OF_RESOURCES doesn't even take a user/host, despite
      the optimistic comment. We remove this being passed as an
      argument to the function so that when MDEV-21978 is implemented
      one less compiler format warning is generated (which would
      have caught this error sooner).
      
      Thanks Otto for reporting and Marko for analysis.
      99837c61
    • Daniel Black's avatar
      Merge 10.2 (part) into 10.3 · a9500860
      Daniel Black authored
      commit '6de482a6'
      
      10.3 no longer errors in truncate_notembedded.test
      but per comments, a non-crash is all that we are after.
      a9500860
  10. 14 Mar, 2022 3 commits
    • Alexander Barkov's avatar
      MDEV-23210 Assertion `(length % 4) == 0' failed in my_lengthsp_utf32 on ALTER... · 03c3dc63
      Alexander Barkov authored
      MDEV-23210 Assertion `(length % 4) == 0' failed in my_lengthsp_utf32 on ALTER TABLE, SELECT and INSERT
      
      Problem:
      Parse-time conversion from binary to tricky character sets like utf32
      produced ill-formed strings. So, later a chash happened in debug builds,
      or a wrong SHOW CREATE TABLE was returned in release builds.
      
      Fix:
      
      1. Backporting a few methods from 10.3:
        - THD::check_string_for_wellformedness()
        - THD::convert_string() overloads
        - THD::make_text_string_connection()
      
      2. Adding a new method THD::reinterpret_string_from_binary(),
         which makes sure to either returns a well-formed string
         (optionally prepending with zero bytes), or returns an error.
      03c3dc63
    • Sergei Golubchik's avatar
      MDEV-27753 Incorrect ENGINE type of table after crash for CONNECT table · bfed2c7d
      Sergei Golubchik authored
      whenever possible, partitioning should use the full
      partition plugin name, not the one byte legacy code.
      
      Normally, ha_partition can get the engine plugin from
      table_share->default_part_plugin.
      
      But in some cases, e.g. in DROP TABLE, the table isn't
      opened, table_share is NULL, and ha_partition has to parse
      the frm, much like dd_frm_type() does.
      
      temporary_tables.cc, sql_table.cc:
      
      When dropping a table, it must be deleted in the engine
      first, then frm file. Because frm can be the only true
      source of metadata that the engine might need for DROP.
      
      table.cc:
      
      when opening a partitioned table, if the engine for
      partitions is not found, do not fallback to MyISAM.
      bfed2c7d
    • Sergei Golubchik's avatar
      mtr: fix --source lines detection · f217c761
      Sergei Golubchik authored
      mysqltest allows leading spaces before `--`, so mtr should too
      f217c761
  11. 13 Mar, 2022 1 commit
  12. 12 Mar, 2022 1 commit
  13. 11 Mar, 2022 1 commit
  14. 10 Mar, 2022 4 commits
    • Vlad Lesin's avatar
      MDEV-19577 Replication does not work with innodb_autoinc_lock_mode=2 · 1766a18e
      Vlad Lesin authored
      The first step for deprecating innodb_autoinc_lock_mode(see MDEV-27844) is:
      - to switch statement binlog format to ROW if binlog format is MIXED and
      the statement changes autoincremented fields
      - issue warnings if innodb_autoinc_lock_mode == 2 and binlog format is
      STATEMENT
      1766a18e
    • Andrei's avatar
      MDEV-24617 OPTIMIZE on a sequence causes unexpected ER_BINLOG_UNSAFE_STATEMENT · e7cf871d
      Andrei authored
      The warning out of OPTIMIZE
        Statement is unsafe because it uses a system function
      was indeed counterfactual and was resulted by checking an
      insufficiently strict property of lex' sql_command_flags.
      
      Fixed with deploying an additional checking of weather
      the current sql command that modifes a share->non_determinstic_insert
      table is capable of generating ROW format events.
      The extra check rules out the unsafety to OPTIMIZE et al, while the
      existing check continues to do so to CREATE TABLE (which is
      perculiarly tagged as ROW-event generative sql command).
      
      As a side effect sql_sequence.binlog test gets corrected and
      binlog_stm_unsafe_warning.test is reinforced to add up
      an unsafe CREATE..SELECT test.
      e7cf871d
    • Daniel Black's avatar
      MDEV-28011: debian autobake cleanup · 6de482a6
      Daniel Black authored
      Travis is dead to us so we don't need all the conditions around it.
      
      Remove depends for no longer supported versions
      
      Debian Jessies, and Ubuntu Trusty, Xenial, Wily are all eol
      as far as we are concerned.
      
      The dependancy on an apt cache when running autobake broke the
      10.2 aarch64 packages (MDEV-28014). Lets reduce the risk here.
      6de482a6
    • Daniel Black's avatar
      MDEV-28022: Debian stretch has zstd too old · 8ea08505
      Daniel Black authored
      zstd-1.1.3 is needed however stretch has only 1.1.2.
      
      Move to distro version based checks as checks against the
      apt-cache are unreliable if there is no cache.
      8ea08505
  15. 08 Mar, 2022 1 commit
    • Haidong Ji's avatar
      MDEV-27978 fix wrong name in error when max_session_mem_used exceeded · 114476f2
      Haidong Ji authored
      Fixed typo in my_malloc_size_cb_func. There is no max-thread-mem-used
      sys variable in MariaDB, only max-session-mem-used. The relevant entry
      in sys_vars.cc is also fixed.
      
      Added a fallback case in case we could allocate the 256 bytes for the
      error message containing the exact setting.
      114476f2
  16. 07 Mar, 2022 1 commit
  17. 04 Mar, 2022 2 commits
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 02da00a9
      Marko Mäkelä authored
      02da00a9
    • Marko Mäkelä's avatar
      MDEV-28004 ha_innobase::reset_auto_increment() is never executed · 3c06a0b7
      Marko Mäkelä authored
      The virtual member function handler::reset_auto_increment(ulonglong)
      is only ever invoked by the default implementation of the virtual
      member function handler::truncate().
      
      Because ha_innobase::truncate() overrides handler::truncate() without
      ever invoking handler::truncate(), some InnoDB member functions are
      never called.
      
      ha_innobase::innobase_reset_autoinc(), ha_innobase::reset_auto_increment():
      Removed (unreachable code).
      
      ha_innobase::delete_all_rows(): Removed. The default implementation
      handler::delete_all_rows() works just as fine.
      3c06a0b7
  18. 03 Mar, 2022 2 commits
  19. 01 Mar, 2022 3 commits
  20. 28 Feb, 2022 2 commits
    • Marko Mäkelä's avatar
      MDEV-27800: Avoid garbage TRX_UNDO_TRX_NO on TRX_UNDO_CACHED pages · 0635088d
      Marko Mäkelä authored
      In commit c7d04487 (MDEV-15132)
      MariaDB Server 10.3 stopped writing the latest transaction identifier
      to the TRX_SYS page. Instead, the transaction identifier will be
      recovered from undo log pages.
      
      Unfortunately, before commit 3926673c
      and mysql/mysql-server@dc29792ff2996aefbb6e64bb2f0bc3aa8fc879e9
      (MySQL 5.1.48 or MariaDB 5.1.48) InnoDB did not always initialize all
      data fields, but some garbage could be left behind in unused parts
      of data pages.
      
      In undo log pages that are essentially free, but added to a list for
      reuse (TRX_UNDO_CACHED) the TRX_UNDO_TRX_NO fields could contain garbage,
      instead of 0. As long as such undo pages are being reused and never
      marked completely free, the garbage contents may remain forever.
      In fact, the function trx_undo_header_create() and the record
      MLOG_UNDO_HDR_CREATE will only initialize TRX_UNDO_TRX_ID, but leave
      TRX_UNDO_TRX_NO uninitialized.
      
      trx_undo_mem_create_at_db_start(): Only read the TRX_UNDO_TRX_NO
      fields of TRX_UNDO_CACHED pages if the TRX_UNDO_PAGE_TYPE is 0,
      that is, the page was updated by MariaDB Server 10.3. Earlier versions
      would always write the TRX_UNDO_PAGE_TYPE as 1 or 2.
      
      trx_undo_header_create(): Zero out the TRX_UNDO_TRX_NO field.
      Strictly speaking, this will change the semantics of the
      MLOG_UNDO_HDR_CREATE record, but it should not do any harm to
      overwrite a potentially garbage field with zeroes.
      
      Note: This fix will only help future upgrades straight from
      MariaDB Server 10.2 or MySQL 5.6 or earlier. If such an upgrade has
      already been made, then an earlier server startup could have
      fast-forwarded the transaction ID sequence to a large value.
      If this large value cannot be represented in 48 bits (the size of
      the DB_TRX_ID column in clustered index records), then various
      strange things can happen.
      0635088d
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 535bef86
      Marko Mäkelä authored
      535bef86
  21. 25 Feb, 2022 4 commits
    • Brandon Nesterenko's avatar
      MDEV-27850: MTR tests can hang due to DEBUG_SYNC race condition · 905baa64
      Brandon Nesterenko authored
      DEBUG_SYNC signals can get lost in certain tests due to later
      DEBUG_SYNC commands overwriting them. This patch addresses
      these issues in three tests: main.query_cache_debug,
      main.partition_debug_sync, and
      rpl.rpl_dump_request_retry_warning.
      
      Additionally, main.partition_debug_sync needed changes to the
      result file (the others did not). The synchronization happened
      between two commands, one based on ALTER, the other on DROP.
      A new thread/connection was needed to synchronize the DEBUG_SYNC
      actions between these commands, thereby changing the result file.
      Additional comments were added for clarification.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      905baa64
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 9ba385a5
      Marko Mäkelä authored
      9ba385a5
    • Marko Mäkelä's avatar
      ed691eca
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 00b70bbb
      Marko Mäkelä authored
      00b70bbb