1. 11 Feb, 2009 1 commit
    • Alfranio Correia's avatar
      BUG#38197 Errors in @@init_slave not visible in 'show slave status' · 65325b9b
      Alfranio Correia authored
            
      Some errors that cause the slave SQL thread to stop are not shown in the
      Slave_SQL_Error column of "SHOW SLAVE STATUS". Instead, the error is only 
      in the server's error log.
            
      That makes it difficult to analyze the error for the user. One example of an error
      that stops the slave but is not shown by "SHOW SLAVE STATUS" is when @@global.init_slave
      is set incorrectly (e.g., it contains something that is not valid SQL).
            
      Three failures were not correctly reported:
            
      1 - Failures during slave thread initialization
      2 - Failures while initializing the relay log position right after
      starting the slave thread.
      3 - Failures while processing queries passed through the init_slave
      option.
            
      This patch fixes the issues by reporting the errors through relay-info->report.
      65325b9b
  2. 04 Feb, 2009 14 commits
    • Matthias Leich's avatar
    • Matthias Leich's avatar
      f8412b84
    • Sergey Vojtovich's avatar
      Merge 5.0-bugteam -> 5.1-bugteam. · cdd9844a
      Sergey Vojtovich authored
      cdd9844a
    • Matthias Leich's avatar
      Automatic merge, no conflicts · 04614a9f
      Matthias Leich authored
      04614a9f
    • Magnus Svensson's avatar
      Merge · 2f0f4716
      Magnus Svensson authored
      2f0f4716
    • Matthias Leich's avatar
      Merge last changesets, no conflicts · 5a876877
      Matthias Leich authored
      5a876877
    • Staale Smedseng's avatar
      merge from upstream 5.1-bugteam · 47e5ad66
      Staale Smedseng authored
      47e5ad66
    • Sergey Vojtovich's avatar
      BUG#32047 - 'Spurious' errors while opening MERGE tables · 8819e71c
      Sergey Vojtovich authored
      Accessing well defined MERGE table may return an error
      stating that the merge table is incorrectly defined. This
      happens if MERGE child tables were accessed before and we
      failed to open another incorrectly defined MERGE table in
      this connection.
      
      myrg_open() internally used my_errno as a variable for determining
      failure, and thus could be tricked into a wrong decision by other
      uses of my_errno.
      
      With this fix we use function local boolean flag instead of my_errno
      to determine failure.
      
      myisammrg/myrg_open.c:
        There are two requirement for accessing/setting my_errno variable,
        which were not followed by myrg_open():
        - it must be checked immediately after a function returned an error. There
          must be no calls to other functions that may change it's value between.
        - my_errno value must be set right before a function is going to return an
          error. There must be no calls to other functions that may change it's
          value between (that's why we have these tricks with save_errno at the
          bottom of myrg_open()).
        
        myrg_open() internally used my_errno as a variable for determining
        failure, and thus could be tricked into a wrong decision by other
        uses of my_errno.
      mysql-test/r/merge.result:
        A test case for BUG#32047.
      mysql-test/t/merge.test:
        A test case for BUG#32047.
      8819e71c
    • Sergey Glukhov's avatar
      Bug#42495 updatexml: Assertion failed: xpath->context, file .\item_xmlfunc.cc, line 2507 · fe14a7be
      Sergey Glukhov authored
      Problem:
         RelativeLocationPath can appear only after a node-set expression
         in the third and the fourth branches of this rule:
           PathExpr :: =  LocationPath
                          | FilterExpr
                          | FilterExpr '/' RelativeLocationPath
                          | FilterExpr '//' RelativeLocationPath
         XPatch code didn't check the type of FilterExpr and crashed.
      Fix:
         If FilterExpr is a scalar expression
         (variable reference, literal, number, scalar function call)
         return error.
      
      
      mysql-test/r/xml.result:
        test result
      mysql-test/t/xml.test:
        test case
      sql/item_xmlfunc.cc:
        Problem:
           RelativeLocationPath can appear only after a node-set expression
           in the third and the fourth branches of this rule:
             PathExpr :: =  LocationPath
                            | FilterExpr
                            | FilterExpr '/' RelativeLocationPath
                            | FilterExpr '//' RelativeLocationPath
           XPatch code didn't check the type of FilterExpr and crashed.
        Fix:
           If FilterExpr is a scalar expression
           (variable reference, literal, number, scalar function call)
           return error.
      fe14a7be
    • Davi Arnaut's avatar
      Merge from upstream 5.1-bugteam · 948e64ee
      Davi Arnaut authored
      948e64ee
    • Andrei Elkin's avatar
      Bug #41183 rpl_ndb_circular, rpl_ndb_circular_simplex need maintenance, crash · 4b8ba115
      Andrei Elkin authored
      fixing build issue, caused by the previous push.
      
      sql/log_event.cc:
        moving a new declaration out of mysqlbinlog compilation scope.
      4b8ba115
    • Matthias Leich's avatar
      Merge of latest changesets into GCA tree · 56d86a1a
      Matthias Leich authored
      56d86a1a
    • Andrei Elkin's avatar
      Bug #41183 rpl_ndb_circular, rpl_ndb_circular_simplex need maintenance, crash · 0ed77f3a
      Andrei Elkin authored
                  
      The bug happened because filtering-out a STMT_END_F-flagged event so that
      the transaction COMMIT finds traces of incomplete statement commit.
      Such situation is only possible with ndb circular replication. The filtered-out
      rows event is one that immediately preceeds the COMMIT query event.
            
      Fixed with deploying an the rows-log-event statement commit at executing
      of the transaction COMMIT event. 
      Resources that were allocated by other than STMT_END_F-flagged event of
      the last statement are clean up prior execution of the commit logics.
      
      
      mysql-test/suite/rpl_ndb/t/disabled.def:
        re-enabling two tests.
      sql/log_event.cc:
        Adding the statement cleanup to execute at the transaction commit time.
        The statement might not be ended with execution of STMT_END_F-flagged event because of
        the event was filtered out by SERVER_ID rules.
        Small refactoring for Rows_log_event::do_update_pos() to be split on two parts:
        the statement commit that releases its execution time allocated resources, and
        the relay log update.
      0ed77f3a
    • Magnus Svensson's avatar
      Bug#42588 system_mysql_db_fix30020 fails when run from bin dist with mtr2 · a509cb00
      Magnus Svensson authored
       - Properly set --bindir=$path_client_bindir and --basedir=$basedir by adding %s format specifier
      a509cb00
  3. 03 Feb, 2009 3 commits
    • Davi Arnaut's avatar
      Bug#40536: SELECT is blocked by INSERT DELAYED waiting on · e89c9295
      Davi Arnaut authored
                 upgrading lock, even with low_priority_updates
      
      The problem is that there is no mechanism to control whether a
      delayed insert takes a high or low priority lock on a table.
      
      The solution is to modify the delayed insert thread ("handler")
      to take into account the global value of low_priority_updates
      when taking table locks. The value of low_priority_updates is
      retrieved when the insert delayed thread is created and will
      remain the same for the duration of the thread.
      
      
      include/thr_lock.h:
        Update prototype.
      mysql-test/r/delayed.result:
        Add test case result for Bug#40536
      mysql-test/t/delayed.test:
        Add test case for Bug#40536
      mysys/thr_lock.c:
        Add function parameter which specifies the write lock type.
      sql/sql_insert.cc:
        Take a low priority write lock if global value of low_priority_updates
        was ON when the thread was created.
      e89c9295
    • Matthias Leich's avatar
      Merge 5.0 -> 5.1 · 05bac8a2
      Matthias Leich authored
      + fix wrong resultfile have_outfile.require
      05bac8a2
    • Staale Smedseng's avatar
      Bug #41580 opt_threads option is not used anywhere at all · 46d2ce7d
      Staale Smedseng authored
      Option opt_threads is deprecated in 5.1, and a warning is
      printed when used. Will remove in 6.0.
      46d2ce7d
  4. 02 Feb, 2009 16 commits
    • Patrick Crews's avatar
      merge 5.0 -> 5.1 · 247571de
      Patrick Crews authored
      247571de
    • Patrick Crews's avatar
      Bug#39369: execution of "variables.test" with "check-testcases" show differences. · 039f51a0
      Patrick Crews authored
      The original symptoms of this bug have been fixed as a consequence of other bug fixes.
      Taking this time to correct some formatting, such as replacing error numbers with names.
      Beginning this with 5.0
      039f51a0
    • Serge Kozlov's avatar
      Bug#38603: · 63cd72bf
      Serge Kozlov authored
      The patch adds restart of mysql server and replacing of binlog file 
      when mysql server is stopped.
      63cd72bf
    • Matthias Leich's avatar
      1. Slice of fix for Bug#42003 tests missing the disconnect of connections <> default · 400900bd
      Matthias Leich authored
         - If missing: add "disconnect <session>"
         - If physical disconnect of non "default" sessions is not finished
           at test end: add routine which waits till this happened
      + additional improvements like
        - remove superfluous files created by the test
        - replace error numbers by error names
        - remove trailing spaces, replace tabs by spaces
        - unify writing of bugs within comments
        - correct comments
        - minor changes of formatting
      Modifications according to the code review are included.
      Fixed tests:
      grant2
      grant3
      lock_tables_lost_commit
      mysqldump
      openssl_1
      outfile
      400900bd
    • Andrei Elkin's avatar
      Bug #41732 rpl_ndb_circular_2ch needs an updated configuration file · 1f8b037b
      Andrei Elkin authored
      There are two issues: 
            1. 6.0 uses the obsolate master-*** server options;
            2. the test is not deterministic in that although master vs slave consistency is
               fine, two runs of the test can have different results. The reason of the
               non-determinism is the combination of 
               a chosen way to demo results and the ndb_autoincrement_prefetch_sz feature.
      
      The current patch fixes the 2nd issue by putting out results via diff_table macro
      instead of the former run-sensitive method.
      The 1st issue is going to be fixed by a separate patch to 6.0.
      
      mysql-test/suite/rpl_ndb/r/rpl_ndb_circular_2ch.result:
        results changed
      mysql-test/suite/rpl_ndb/t/rpl_ndb_circular_2ch.test:
        Test is refined to put out results via diff_table macro instead of the former run-sensitive
        method.
      1f8b037b
    • Tatiana A. Nurnberg's avatar
      auto-merge · 3616b321
      Tatiana A. Nurnberg authored
      3616b321
    • Alexander Barkov's avatar
      Bug#41084 full-text index added to custom UCA collation not working · 562757a4
      Alexander Barkov authored
      Problem:
      Custom UCA collations didn't set the MY_CS_STRNXFRM flag,
      which resulted in "prefix_search" method instead of
      the required "seq_search".
      
      Problem2: (not metioned in the bug report)
      Custom UCA collations didn't also set the MY_CS_UNICODE flag,
      so an attempt to compare a column with a custom UCA collation
      to another column with a non-Unicode character set led to
      the "illegal mix of collation" error.
      
      Fix:
      the two missing flags was added into collation initialization.
      
        Upgrade:
      
        - All fulltext indexes with custom UCA collations should be rebuilt.
      
        - Non-fulltext custom UCA indexes should likely be rebuild as well.
      562757a4
    • Tatiana A. Nurnberg's avatar
      auto-merge · 5ec41e97
      Tatiana A. Nurnberg authored
      5ec41e97
    • Serge Kozlov's avatar
      post-merge push with patch for rpl_ndb_log · 481f2415
      Serge Kozlov authored
      481f2415
    • Serge Kozlov's avatar
      Post-merge patch for extra/rpl_test/rpl_log.test: · 512eaf42
      Serge Kozlov authored
      Remove size of binlog file from SHOW BINARY LOGS. 
      Changing size of binlog file is an affect of adding or removing events to/from
      binlog and it can be checked in next command of test: SHOW BINLOG EVENTS.
      For SHOW BINARY LOGS statement enough to show the list of file names.
      512eaf42
    • Georgi Kodinov's avatar
      fixed system_mysql_db_fix30020 test faiilure · 339cea2e
      Georgi Kodinov authored
      fixed federated warnings
      339cea2e
    • Sergey Glukhov's avatar
      automerge · f8808ece
      Sergey Glukhov authored
      f8808ece
    • Bjorn Munch's avatar
      merge · 72e6c260
      Bjorn Munch authored
      72e6c260
    • Sergey Glukhov's avatar
      fixed jp test failures · a19b1edd
      Sergey Glukhov authored
      mysql-test/suite/jp/r/jp_create_db_sjis.result:
        hide mtr database
      mysql-test/suite/jp/r/jp_create_db_ucs2.result:
        hide mtr database
      mysql-test/suite/jp/r/jp_create_db_ujis.result:
        hide mtr database
      mysql-test/suite/jp/r/jp_create_db_utf8.result:
        hide mtr database
      mysql-test/suite/jp/t/jp_create_db_sjis.test:
        hide mtr database
      mysql-test/suite/jp/t/jp_create_db_ucs2.test:
        hide mtr database
      mysql-test/suite/jp/t/jp_create_db_ujis.test:
        hide mtr database
      mysql-test/suite/jp/t/jp_create_db_utf8.test:
        hide mtr database
      a19b1edd
    • Bjorn Munch's avatar
      Bug #42535 MTR2 output format for skipped tests should be identical to MTR 1 · 9b22fb44
      Bjorn Munch authored
      Changed [ skip ] to [ skipped ] and removed optional .
      9b22fb44
    • Georgi Kodinov's avatar
  5. 01 Feb, 2009 6 commits