1. 11 Nov, 2005 8 commits
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 65594301
      unknown authored
      into  mysql.com:/usr/home/pem/bug14723/mysql-5.0
      
      
      sql/sp_head.cc:
        Auto merged
      65594301
    • unknown's avatar
      Fixed BUG#14723: Dumping of stored functions seems to cause corruption · 14e74e4a
      unknown authored
                       in the function body
        Changed the way the end of query was found from the lex state.
        The routine body was not extracted correctly when using the
        /*!version ... */ wrapper (in dump files); for some types of routines
        (e.g. with a label at the first begin), the trailing "*/" was not skipped.
      
      
      mysql-test/r/sp.result:
        New test case for BUG#14723.
      mysql-test/t/sp.test:
        New test case for BUG#14723.
      sql/sp_head.cc:
        Changed the way the end of the definition and body is found from the lex state.
        In the case of /*!version */ wrappers we must take the trailing " */" into account.
      14e74e4a
    • unknown's avatar
      Merge mysql.com:/home/timka/mysql/src/5.0-virgin · a8630134
      unknown authored
      into  mysql.com:/home/timka/mysql/src/5.0-bug-14662
      
      a8630134
    • unknown's avatar
      Merge mysql.com:/home/timka/mysql/src/5.0-virgin · b64ca64d
      unknown authored
      into  mysql.com:/home/timka/mysql/src/5.0-bug-14662
      
      b64ca64d
    • unknown's avatar
      Fix for BUG#14662: view column in ORDER BY considered ambiguous if SELECT contains · aa54d403
      unknown authored
      the same column as an aliased and as a non-aliased column.
      
      The problem was that Item_direct_view_ref::eq() was first comparing view columns
      by name, and in this case the name of one of them is different since it is aliased.
      
      
      mysql-test/r/select.result:
        Added test for BUG#14662.
      mysql-test/t/select.test:
        Added test for BUG#14662.
      sql/item.cc:
        Changed the way view column refenreces are compared. Two view columns are
        equal if they resolve to the same result field of a view.
      aa54d403
    • unknown's avatar
      Fix for bug#13818 SHOW CREATE VIEW / TABLE and information_schema.views fail · d2205238
      unknown authored
                        for invalid view
       Permit SHOW CREATE VIEW, SHOW CREATE TABLE, and retrieval of metadata from
       information_schema for invalid views
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#13818 SHOW CREATE VIEW / TABLE and information_schema.views fail 
                          for invalid view
         test case
      mysql-test/t/information_schema.test:
        Fix for bug#13818 SHOW CREATE VIEW / TABLE and information_schema.views fail 
                          for invalid view
         test case
      d2205238
    • unknown's avatar
      Manual merge. · 5db30e3d
      unknown authored
      5db30e3d
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 2cc7a90d
      unknown authored
      into  mysql.com:/home/alik/MySQL/devel/5.0-wl2818
      
      
      sql/sql_show.cc:
        Auto merged
      2cc7a90d
  2. 10 Nov, 2005 26 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · d5a8ae77
      unknown authored
      into  mysql.com:/home/alik/MySQL/devel/5.0-wl2818
      
      d5a8ae77
    • unknown's avatar
      Merge baker@bk-internal.mysql.com:/home/bk/mysql-5.0 · ce5d11fb
      unknown authored
      into  zim.(none):/home/brian/mysql/mysql-5.0
      
      ce5d11fb
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 65330191
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug4-5.0
      
      65330191
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 972c007b
      unknown authored
      into  mysql.com:/home/alik/MySQL/devel/5.0-wl2818
      
      
      mysql-test/r/mysqldump.result:
        Auto merged
      mysql-test/t/mysqldump.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      mysql-test/r/rpl_sp.result:
        Manual merge.
      972c007b
    • unknown's avatar
      WL#2818 (Add creator to the trigger definition for privilege · 9da2ba78
      unknown authored
      checks on trigger activation)
      
      
      mysql-test/r/information_schema.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/mysqldump.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/rpl_ddl.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/rpl_sp.result:
        Update result file: a new clause DEFINER has been added to
        CREATE TRIGGER statement.
      mysql-test/r/rpl_trigger.result:
        Results for new test cases were added.
      mysql-test/r/skip_grants.result:
        Error message has been changed.
      mysql-test/r/trigger.result:
        Added DEFINER column.
      mysql-test/r/view.result:
        Error messages have been changed.
      mysql-test/r/view_grant.result:
        Error messages have been changed.
      mysql-test/t/mysqldump.test:
        Drop created procedure to not affect further tests.
      mysql-test/t/rpl_trigger.test:
        Add tests for new column in information schema.
      mysql-test/t/skip_grants.test:
        Error tag has been renamed.
      mysql-test/t/view.test:
        Error tag has been renamed.
      mysql-test/t/view_grant.test:
        Error tag has been changed.
      sql/item_func.cc:
        Fix typo in comments.
      sql/mysql_priv.h:
        A try to minimize copy&paste:
          - introduce operations to be used from sql_yacc.yy;
          - introduce an operation to be used from trigger and
            view processing code.
      sql/share/errmsg.txt:
        - Rename ER_NO_VIEW_USER to ER_MALFORMED_DEFINER in order to
          be shared for view and trigger implementations;
        - Fix a typo;
        - Add a new error code for trigger warning.
      sql/sp.cc:
        set_info() was split into set_info() and set_definer().
      sql/sp_head.cc:
        set_info() was split into set_info() and set_definer().
      sql/sp_head.h:
        set_info() was split into set_info() and set_definer().
      sql/sql_acl.cc:
        Add a new check: exit from the cycle if the table is NULL.
      sql/sql_lex.h:
        - Rename create_view_definer to definer, since it is used for views
          and triggers;
        - Change st_lex_user to LEX_USER, since st_lex_user is a structure.
          So, formally, it should be "struct st_lex_user", which is longer
          than just LEX_USER;
        - Add trigger_definition_begin.
      sql/sql_parse.cc:
        - Add a new check: exit from the cycle if the table is NULL;
        - Implement definer-related functions.
      sql/sql_show.cc:
        Add DEFINER column.
      sql/sql_trigger.cc:
        Add DEFINER support for triggers.
      sql/sql_trigger.h:
        Add DEFINER support for triggers.
      sql/sql_view.cc:
        Rename create_view_definer to definer.
      sql/sql_yacc.yy:
        Add support for DEFINER-clause in CREATE TRIGGER statement.
        
        Since CREATE TRIGGER and CREATE VIEW can be similar at the start,
        yacc is unable to distinguish between them. So, had to modify both
        statements in order to make it parsable by yacc.
      mysql-test/r/trigger-compat.result:
        Result file for triggers backward compatibility test.
      mysql-test/r/trigger-grant.result:
        Result file of the test for WL#2818.
      mysql-test/t/trigger-compat.test:
        Triggers backward compatibility test: check that the server
        still can load triggers w/o definer attribute and modify
        tables with such triggers (add a new trigger, etc).
      mysql-test/t/trigger-grant.test:
        Test for WL#2818 -- check that DEFINER support in triggers
        works properly
      9da2ba78
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-clean · 89cebd69
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-5.0-clean
      
      
      scripts/mysql_fix_privilege_tables.sql:
        Auto merged
      89cebd69
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-14469 · 33c00f0a
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      33c00f0a
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-5.0-12570 · 5535442a
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-5.0-clean
      
      
      sql/mysqld.cc:
        Auto merged
      5535442a
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 07412f09
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug4-5.0
      
      07412f09
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.0 · 086c4638
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      086c4638
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 16ad3e9b
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug4-5.0
      
      16ad3e9b
    • unknown's avatar
      Merge mysql.com:/home/mysql_src/mysql-5.0-release · 46cad9d1
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      46cad9d1
    • unknown's avatar
      Merge mysqldev@production.mysql.com:my/mysql-5.0-release · fa22ce3f
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0-release
      
      fa22ce3f
    • unknown's avatar
      WL#2971 "change log-bin-trust-routine-creators=0 to apply only to functions". · 20285580
      unknown authored
      Indeed now that stored procedures CALL is not binlogged, but instead the invoked substatements are,
      the restrictions applied by log-bin-trust-routine-creators=0 are superfluous for procedures.
      They still need to apply to functions where function calls are written to the binlog (for example as "DO myfunc(3)").
      We rename the variable to log-bin-trust-function-creators but allow the old name until some future version (and issue a warning if old name is used).
      
      
      mysql-test/mysql-test-run.pl:
        update to new option name
      mysql-test/mysql-test-run.sh:
        update to new option name
      mysql-test/mysql_test_run_new.c:
        update to new option name
      mysql-test/r/rpl_sp.result:
        result update
      mysql-test/t/rpl_sp-slave.opt:
        we need to skip this error to not hit BUG#14769
      mysql-test/t/rpl_sp.test:
        Test update:
        1) as log-bin-trust-routine-creators now affects only functions, the testing of this option, which was
        mainly done on procedures, is moved to functions
        2) cleanup is simplified; and instead of many SHOW BINLOG EVENTS we do a big one in the end, which is more
        maintainable.
        3) we test a few more function and procedures cases to see how they replicate.
        4) removing out-of-date comments
      sql/item_func.cc:
        This warning is wrong since binlogging of functions was changed in August. If a function fails
        in the middle, it will be binlogged with its error code (i.e. properly).
      sql/mysql_priv.h:
        variable name changed
      sql/mysqld.cc:
        option name changes. A precision about --read-only.
      sql/set_var.cc:
        a new class sys_var_trust_routine_creators to be able to issue a "this is a deprecated variable" warning if used.
      sql/set_var.h:
        new class to be able to issue a "this is a deprecated variable" warning if used.
      sql/share/errmsg.txt:
        routine -> function
      sql/sp.cc:
        log-bin-trust-routine-creators now applies only to functions.
      sql/sql_parse.cc:
        1) sending ER_FAILED_ROUTINE_BREAK_BINLOG is wrong since August as we don't binlog CALL anymore but instead binlog the substatements;
        the clear_error() goes away too as it was necessary only when we created a binlog event from the "CALL" statement.
        2) log-bin-trust-routine-creators now applies only to functions.
      sql/sql_trigger.cc:
        comments.
      20285580
    • unknown's avatar
      Merge baker@bk-internal.mysql.com:/home/bk/mysql-5.0 · ec8cd4b0
      unknown authored
      into  zim.(none):/home/brian/mysql/mysql-5.0
      
      ec8cd4b0
    • unknown's avatar
      Added handlerton flag to make storage engines invisable via flag. · b816696e
      unknown authored
      
      mysql-test/r/ps_1general.result:
        Remove binlog from visable engine list.
      sql/handler.h:
        Added documentation to HTON's
      sql/log.cc:
        binlog now has hidden flag show that it does now show up in show storage engine list.
      sql/sql_show.cc:
        Flag removes engines from view in show storage engines
      b816696e
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · d63f0649
      unknown authored
      into mysql.com:/home/hf/work/mysql-5.0.14268
      
      d63f0649
    • unknown's avatar
      Fix for bug #14822: Test "mysqldump" fails, "result" protocol seems wrong. · 73006d11
      unknown authored
      
      mysql-test/t/mysqldump.test:
        Fix for bug #14822: Test "mysqldump" fails, "result" protocol seems wrong.
        2>&1 added to be able to see error messages.
      73006d11
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 3097577d
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug4-5.0
      
      3097577d
    • unknown's avatar
      Merge mysql.com:/home/mysql_src/mysql-4.1-gca · 35e18c29
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-4.1
      
      35e18c29
    • unknown's avatar
      Merge mysql.com:/home/mysql_src/mysql-4.1-gca · 4a90d353
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0-release
      
      
      sql/item_func.h:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      4a90d353
    • unknown's avatar
      Declaring some class members public for BUG#12377: · 15205585
      unknown authored
      "Item_date_add_interval needs to have the int_type member as Public".
      As explained in the bug report, this change is is to help http://search.cpan.org/~philips/DBIx-MyParse-0.20/
      So please keep those members public.
      
      
      sql/item_func.h:
        declaring some class members public for BUG#12377
      sql/item_strfunc.h:
        declaring some class members public for BUG#12377
      sql/item_timefunc.h:
        declaring some class members public for BUG#12377
      15205585
    • unknown's avatar
      Fix a comment. · 3a139b29
      unknown authored
      
      sql/sql_cursor.cc:
        A post-review fix for Bug#13488
      3a139b29
    • unknown's avatar
      Provide a default "minimum thread stack size" PTHREAD_STACK_MIN where it is missing. · ce5da341
      unknown authored
      (Currently, affects only BSD with Linuxthreads)
      
      ce5da341
    • unknown's avatar
      merging · 80a02265
      unknown authored
      
      strings/decimal.c:
        Auto merged
      80a02265
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 287bccd1
      unknown authored
      into  mysql.com:/usr/home/pem/bug14719/mysql-5.0
      
      287bccd1
  3. 09 Nov, 2005 6 commits