1. 12 Jun, 2007 10 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-opt · 65e4212a
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-opt
      
      65e4212a
    • unknown's avatar
      5.0-opt -> 5.1-opt merge · 720dc9b2
      unknown authored
      720dc9b2
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · cb50b1bf
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-opt
      
      
      mysql-test/r/insert_update.result:
        Auto merged
      mysql-test/r/trigger.result:
        Auto merged
      mysql-test/t/insert_update.test:
        Auto merged
      mysql-test/t/trigger.test:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/item_func.cc:
        merge of 5.0-opt -> 5.1-opt
      sql/sql_insert.cc:
        merge of 5.0-opt -> 5.1-opt
      sql/structs.h:
        merge of 5.0-opt -> 5.1-opt
      tests/mysql_client_test.c:
        merge of 5.0-opt -> 5.1-opt
      cb50b1bf
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 220abce4
      unknown authored
      into  mysql.com:/home/hf/work/28757/my51-28757
      
      220abce4
    • unknown's avatar
      Bug #28757 Test program / embedded server crash in test "unsafe_binlog_innodb" · de21986e
      unknown authored
      the reported test failure is fixed by the patch to 28333,
      but there's a bit more to fix in the test itself - to
      drop tables created in this test at the test's beginning.
      
      
      mysql-test/include/unsafe_binlog.inc:
        remove tables created later in this test
        number error codes changed with the appropriate ER_something
      mysql-test/r/unsafe_binlog_innodb.result:
        test result fixed
      de21986e
    • unknown's avatar
      removed compilation warning · c5b42cb3
      unknown authored
      c5b42cb3
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · 9bb186b9
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28992-5.0-opt
      
      9bb186b9
    • unknown's avatar
      Bug #28992: trigger fails in pushbuild · d62f99f8
      unknown authored
       - fixed wrong test case for bug 20903
       - closed the dangling connections in trigger.test
       - GET_LOCK() and RELEASE_LOCK() now produce more detailed log
       - fixed an omission in GET_LOCK() : assign the thread_id when
          acquiring the lock.
      
      
      mysql-test/r/trigger.result:
        Bug #28992: test case updated
      mysql-test/t/trigger.test:
        Bug #28992: test case updated. dangling connections closed.
      sql/item_func.cc:
        Bug #28992: 
         - GET_LOCK() and RELEASE_LOCK() now produce more detailed log
         - fixed an omission in GET_LOCK() : assign the thread_id when
            acquiring the lock.
      d62f99f8
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · a0c123d7
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28934-5.0-opt
      
      a0c123d7
    • unknown's avatar
      Bug #28934: server crash when receiving malformed com_execute packets · bf9b57fd
      unknown authored
       Sometimes a parameter slot may not get a value because of the protocol
       data being plain wrong.
       Such cases should be detected and handled by returning an error.
       Fixed by checking data stream constraints where possible (like maximum
       length) and reacting to the case where a value cannot be constructed.
      
      
      sql/sql_prepare.cc:
        Bug #28934: 
         - check for a parameter slot not being set because 
            of wrong data
         - check if the length read from the stream is not
            greater than the maximum length of the field
      tests/mysql_client_test.c:
        Bug #28934: test case
      bf9b57fd
  2. 11 Jun, 2007 6 commits
    • unknown's avatar
      Bug#28904: INSERT .. ON DUPLICATE was silently updating rows when it shouldn't. · 506a5698
      unknown authored
      When the INSERT .. ON DUPLICATE KEY UPDATE has to update a matched row but
      the new data is the same as in the record then it returns as if
      no rows were inserted or updated. Nevertheless the row is silently
      updated. This leads to a situation when zero updated rows are reported 
      in the case when data has actually been changed.
      
      Now the write_record function updates a row only if new data differs from
      that in the record.
      
      
      sql/sql_insert.cc:
        Bug#28904: INSERT .. ON DUPLICATE was silently updating rows when it shouldn't.
        Now the write_record function updates a row only if new data differs from
        that in the record.
      mysql-test/r/insert_update.result:
        Added a test case for the bug#28904: INSERT .. ON DUPLICATE was silently
        updating rows when it shouldn't.
      mysql-test/t/insert_update.test:
        Added a test case for the bug#28904: INSERT .. ON DUPLICATE was silently
        updating rows when it shouldn't.
      506a5698
    • unknown's avatar
      grant2.result: · 3a9f2717
      unknown authored
        Post merge fix.
      
      
      mysql-test/r/grant2.result:
        Post merge fix.
      3a9f2717
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql · ac970387
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/grant2.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      mysql-test/r/grant2.result:
        SCCS merged
      mysql-test/r/information_schema.result:
        SCCS merged
      mysql-test/t/information_schema.test:
        SCCS merged
      sql/sql_table.cc:
        SCCS merged
      ac970387
    • unknown's avatar
      error_simulation.result, item.cc, subselect.result, error_simulation.test: · dd353f44
      unknown authored
        Post merge fix.
      
      
      mysql-test/t/error_simulation.test:
        Post merge fix.
      mysql-test/r/subselect.result:
        Post merge fix.
      mysql-test/r/error_simulation.result:
        Post merge fix.
      sql/item.cc:
        Post merge fix.
      dd353f44
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql · 81371b0e
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      sql/filesort.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manually merged
      mysql-test/t/subselect.test:
        Manually merged
      81371b0e
    • unknown's avatar
      item_cmpfunc.cc, field.cc, sql_insert.cc, sql_class.h, sql_yacc.yy: · 332ba01a
      unknown authored
        Post merge fix.
      
      
      sql/sql_yacc.yy:
        Post merge fix.
      sql/sql_insert.cc:
        Post merge fix.
      sql/sql_class.h:
        Post merge fix.
      sql/item_cmpfunc.cc:
        Post merge fix.
      sql/field.cc:
        Post merge fix.
      332ba01a
  3. 10 Jun, 2007 1 commit
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql · 9fde014e
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      mysql-test/r/gis.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/gis.test:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      mysql-test/include/mix1.inc:
        Manually merged
      mysql-test/r/innodb_mysql.result:
        Manually merged
      mysql-test/r/type_datetime.result:
        Manually merged
      mysql-test/t/type_datetime.test:
        Manually merged
      sql/field.h:
        Manually merged
      sql/sql_select.cc:
        Manually merged
      sql/sql_yacc.yy:
        Manually merged
      tests/mysql_client_test.c:
        Manually merged
      9fde014e
  4. 09 Jun, 2007 10 commits
    • unknown's avatar
      compiler warning fix · 66866ba3
      unknown authored
      66866ba3
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c9929f29
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      c9929f29
    • unknown's avatar
      Bug#28149 overflow in some "SHOW STATUS"-variables · c628ad58
      unknown authored
      changed bytes_received, bytes_sent status variables to longlong
      
      
      sql/mysqld.cc:
        changed bytes_received, bytes_sent status variables to longlong
      sql/sql_class.h:
        changed bytes_received, bytes_sent status variables to longlong
      sql/sql_show.cc:
        changed bytes_received, bytes_sent status variables to longlong
      sql/structs.h:
        changed bytes_received, bytes_sent status variables to longlong
      c628ad58
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e73854ac
      unknown authored
      into  mysql.com:/home/hf/work/28333/my50-28333
      
      e73854ac
    • unknown's avatar
      Bug#28266 IS_UPDATABLE field on VIEWS table in I_S database is wrong · 9cbd1834
      unknown authored
      IS_UPDATABLE flag is set to 'yes' when the view has at least one updatable column and
      the algorithm is not 'temporary'.
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/r/view.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      mysql-test/t/view.test:
        test case
      sql/sql_show.cc:
        IS_UPDATABLE flag is set to 'yes' when the view has at least one updatable column and
        the algorithm is not 'temporary'.
      9cbd1834
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · f202f018
      unknown authored
      into  mysql.com:/home/hf/work/28333/my51-28333
      
      f202f018
    • unknown's avatar
      compilation error fix · f3e8e45a
      unknown authored
      
      mysql-test/include/have_archive.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_blackhole.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_csv.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_exampledb.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_federated_db.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_innodb.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_multi_ndb.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_ndb.inc:
        test fix(according to new 'support' column values)
      mysql-test/r/information_schema.result:
        result fix
      f3e8e45a
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 748df186
      unknown authored
      into  mysql.com:/home/hf/work/28333/my50-28333
      
      748df186
    • unknown's avatar
      Merge mysql.com:/home/hf/work/28333/my50-28333 · 3816c1ed
      unknown authored
      into  mysql.com:/home/hf/work/28333/my51-28333
      
      
      client/mysqltest.c:
        Auto merged
      3816c1ed
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · b6ad7da8
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28754-5.0-opt
      
      b6ad7da8
  5. 08 Jun, 2007 6 commits
    • unknown's avatar
      Bug #28333 Test "flush" tries to create a new thread - on only one platform · cbe888a4
      unknown authored
      on PPC/Debian Linux default stack size for a thread is too big.
      As we use default thread settings in mysqltest, the
      thread creation fails if we create lots of threads (as it
      happens in flush.test). So now stack size is explicitly specified
      for the mysqltest
      
      
      client/mysqltest.c:
        Bug #28333 Test "flush" tries to create a new thread - on only one platform
        
        specify appropriate stack size for the 'query' thread
      cbe888a4
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 6f73cc11
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28811
      
      6f73cc11
    • unknown's avatar
      Bug#27684 undocumented difference between SHOW ENGINES and I_S.ENGINES · 59214b24
      unknown authored
      Changed SHOW ENGINES to work in the same way as I_S.ENGINES.
      For this: removed the functions mysqld_show_storage_engines and show_handlerton, and
      made SHOW ENGINES work via the common function iter_schema_engines.
      There in no test case because an engine (except of MyISAM) may be not compiled or disabled
      which may affect the test result.
      
      
      sql/sql_parse.cc:
        Changed SHOW ENGINES to work in the same way as I_S.ENGINES.
      sql/sql_show.cc:
        Changed SHOW ENGINES to work in the same way as I_S.ENGINES.
        For this: removed the functions mysqld_show_storage_engines and show_handlerton, and
        made SHOW ENGINES work via the common function iter_schema_engines.
      59214b24
    • unknown's avatar
      Bug #28754: RPM builds differ from tar.gz in "ALTER ... RENAME" on views · 0f6f9b8e
      unknown authored
       When constructing the path to the original .frm file ALTER .. RENAME
       was unnecessary (and incorrectly) lowercasing the whole path when not 
       on a case-insensitive filesystem.
       This path should not be modified because of lower_case_table_names
       as it is already in the correct case according to that setting.
       Fixed by removing the lowercasing.
       Unfortunately testing this would require running the tests on a case
       sensitive filesystem in a directory that has uppercase letters.
       This cannot be guaranteed in all setups so no test case added.
      
      
      sql/sql_table.cc:
        Bug #28754: don't downcase the .frm path
      0f6f9b8e
    • unknown's avatar
      Bug#18660 Can't grant any privileges on single table in database with underscore char · 443ab08d
      unknown authored
      In case of database level grant the database name may be a pattern,
      in case of table|column level grant the database name can not be a pattern.
      We use 'dont_check_global_grants' as a flag to determine
      if it's database level grant command 
      (see SQLCOM_GRANT case, mysql_execute_command() function) and
      set db_is_pattern according to 'dont_check_global_grants' value.
      
      
      mysql-test/r/grant2.result:
        test result
      mysql-test/t/grant2.test:
        test case
      sql/sql_parse.cc:
        In case of database level grant the database name may be a pattern,
        in case of table|column level grant the database name can not be a pattern.
        We use 'dont_check_global_grants' as a flag to determine
        if it's database level grant command 
        (see SQLCOM_GRANT case, mysql_execute_command() function) and
        set db_is_pattern according to 'dont_check_global_grants' value.
      443ab08d
    • unknown's avatar
      Fixed bug #28811: crash for a query containing a subquery with · 00162a46
      unknown authored
      ORDER BY and LIMIT 1. 
      The bug was introduced by the patch for bug 21727. The patch
      erroneously skipped initialization of the array of headers
      for sorted records for non-first evaluations of the subquery.
      
      To fix the problem a new parameter has been added to the
      function make_char_array that performs the initialization.
      Now this function is called for any invocation of the 
      filesort procedure. Yet it allocates the buffer for sorted
      records only if this parameter is NULL.
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #28811.
      mysql-test/t/subselect.test:
        Added a test case for bug #28811.
      00162a46
  6. 07 Jun, 2007 7 commits
    • unknown's avatar
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 80cbbcea
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/28763-bug-5.0-opt-mysql
      
      80cbbcea
    • unknown's avatar
      Bug#28763: Selecting geometry fields in UNION caused server crash. · 6e308347
      unknown authored
      This bug was introduced by the fix for the bug#27300. In this fix a section
      of code was added to the Item::tmp_table_field_from_field_type method.
      This section intended to create Field_geom fields for the Item_geometry_func
      class and its descendants. In order to get the geometry type of the current
      item it casted "this" to the Item_geometry_func* type. But the
      Item::tmp_table_field_from_field_type method is also used for creation of
      fields for UNION and in this case this method is called for an object of the
      Item_type_holder class and the cast to the Item_geometry_func* type causes 
      a server crash.
      
      Now the Item::tmp_table_field_from_field_type method correctly works when it's
      called for both the Item_type_holder and the Item_geometry_func classes.
      The new geometry_type variable is added to the Item_type_holder class.
      The new method called get_geometry_type is added to the Item_field
      and the Field classes. It returns geometry type from the field for the
      Item_field and the Field_geom classes and fails an assert for other Field
      descendants.
      
      
      sql/field.h:
        Bug#28763: Selecting geometry fields in UNION caused server crash.
        The new method called get_geometry_type is added to the Field class.
        It returns geometry type of the field for the Field_geom class
        and fails an assert for other Field descendants.
      sql/item.cc:
        Bug#28763: Selecting geometry fields in UNION caused server crash.
        Now the Item::tmp_table_field_from_field_type method correctly works when it's
        called for both the Item_type_holder and the Item_geometry_func classes.
      mysql-test/r/gis.result:
        Added a test case for the bug#28763: Selecting geometry fields in UNION caused server crash.
      mysql-test/t/gis.test:
        Added a test case for the bug#28763: Selecting geometry fields in UNION caused server crash.
      sql/item.h:
        Bug#28763: Selecting geometry fields in UNION caused server crash.
        The new method called get_geometry_type is added to the Item_field class.
        It returns geometry type from the field.
        The new geometry_type variable is added to the Item_type_holder class.
      6e308347
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 0fb85362
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28449
      
      0fb85362
    • unknown's avatar
      bug #28309 First insert violates UNIQUE constraint - was "memory" table empty? · 4de5c672
      unknown authored
        
      If we have lower_case_table_names == 2 (usually on case insensitive file
      systems) we sometimes make 'homedir' part of the path sent to the
      handler into lowercase. So in this case HEAP engine couldn't properly
      find and remove HP_SHARE, what caused the bug.
      
      
      sql/handler.cc:
        bug #28309 First insert violates UNIQUE constraint - was "memory" table empty?
            
        we don't turn homedirectory part of the path into lowercase
      sql/mysql_priv.h:
        bug #28309 First insert violates UNIQUE constraint - was "memory" table empty?
            
        mysql_data_home_len introduced
      sql/mysqld.cc:
        bug #28309 First insert violates UNIQUE constraint - was "memory" table empty?
            
        mysql_data_home_len value is set with the mysql_data_home
      4de5c672
    • unknown's avatar
      Fixed bug #28449: a crash may happen at some rare conditions when · 80cac2a2
      unknown authored
      a temporary table has grown out of heap memory reserved for it and 
      the remaining disk space is not big enough to store the table as
      a MyISAM table.
      
      The crash happens because the function create_myisam_from_heap
      does not handle safely the mem_root structure associated 
      with the converted table in the case when an error has occurred.
      
      
      sql/sql_select.cc:
        Fixed bug #28449: a crash may happen at some rare conditions when
        a temporary table has grown out of heap memory reserved for it and 
        the remaining disk space is not big enough to store the table as
        a MyISAM table.
        
        The crash happens because the function create_myisam_from_heap
        does not handle safely the mem_root structure associated 
        with the converted table in the case when an error has occurred.
        
        As it's hard to create a sitiation that would throw an error 
        a special code has been added that raises an error for a newly 
        created test called error_simulation.
      mysql-test/r/error_simulation.result:
        New BitKeeper file ``mysql-test/r/error_simulation.result''
        
        Added a test case for bug #28449.
      mysql-test/t/error_simulation-master.opt:
        New BitKeeper file ``mysql-test/t/error_simulation-master.opt''
      mysql-test/t/error_simulation.test:
        New BitKeeper file ``mysql-test/t/error_simulation.test''
        
        Added a test case for bug #28449.
      80cac2a2
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · eeab724f
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28878-5.0-opt
      
      eeab724f