- 09 Apr, 2024 2 commits
-
-
Alexander Barkov authored
The patch for MDEV-18319 BIGINT UNSIGNED Performance issue fixed this problem in 10.5.23. This patch adds only an MTR test to cover MDEV-18319.
-
Vladislav Vaintroub authored
Before patch, maintenance timer will tick every 0.4 seconds. After this patch, timer will tick every 0.4 seconds when necessary( there are delayed thread creation), switching off completely after 20 seconds of being idle.
-
- 08 Apr, 2024 5 commits
-
-
Yuchen Pei authored
Only locked will participate in the query in this case. Chances are that not-locked partitions were not opened, which is the cause of the crash in the added test case spider/bugfix.mdev_33731 without this patch.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
fixes sporadic unit.conc_ps_bugs failures
-
Rucha Deodhar authored
-
- 07 Apr, 2024 2 commits
-
-
Sergei Golubchik authored
the value of 200 isn't enough for some tests anymore, this causes some random threads to become not instrumented and any table operations there are not reflected in the perfschema. If, say, a DROP TABLE doesn't change perfschema state, perfschema tables might show ghost tables that no longer exist in the server
-
Sergei Golubchik authored
32-bit followup for 8bb8820d
-
- 06 Apr, 2024 1 commit
-
-
Sergei Golubchik authored
main.mdl_sync 'innodb' w32 [ fail ] Test ended at 2024-04-06 14:11:15 CURRENT_TEST: main.mdl_sync --- main/mdl_sync.result +++ main/mdl_sync.reject @@ -2458,6 +2458,7 @@ SELECT LOCK_MODE, LOCK_TYPE, TABLE_SCHEMA, TABLE_NAME FROM information_schema.metadata_lock_info; LOCK_MODE LOCK_TYPE TABLE_SCHEMA TABLE_NAME MDL_BACKUP_FTWRL2 Backup lock +MDL_SHARED Table metadata lock test t2 unlock tables; connection default; # Reaping UPDATE
-
- 05 Apr, 2024 13 commits
-
-
Sergei Golubchik authored
in particular, debug_sync timeout and wait_for_pos timeout
-
Sergei Golubchik authored
-
Sergei Golubchik authored
these warnings are expected and are auto-resolved by galera
-
Sergei Golubchik authored
policy CMP0093 was added in cmake 3.15 let's support cmake from 2.8.12, that's what our CMAKE_MINIMUM_REQUIRED() says
-
Daniel Black authored
Its important to fail early and only contine with the include after the boost version check succeeds. Needs to succeed on ealier verisons too so can't just fail if too new. As such, do a version check.
-
Sergei Golubchik authored
improve debuggability
-
Sergei Golubchik authored
as it was thinking it was enabled even if initialize_performance_schema wasn't called at all
-
Monty authored
This commit fixes the following issues: - memory leak checking enabled for mysqltest. This cover all cases except calls to 'die()' that only happens in case of internal failures in mysqltest. die() is not called anymore in the result files differs. - One can now run mtr --embedded without failures (this crashed or hang before) - cleanup_and_exit() has a new parameter that indicates that it is called from die(), in which case we should not do memory leak checks. We now always call cleanup_and_exit() instead of exit() to be able to free up memory and discover memory leaks. - Lots of new assert to catch error conditions - More DBUG statements. - Fixed that all results are freed in mysqltest (Fixed a memory leak in mysqltest when using prepared statements). - Fixed race condition in do_stmt_close() that caused embedded server to not free memory. (Memory leak in mysqltest with embedded server). - Fixed two memory leaks in embedded server when using prepared statements. These memory leaks caused timeout hangs in mtr when server was compiled with safemalloc. This issue was not noticed (except as timeouts) as memory report checking was done but output of it was disabled.
-
Sergei Golubchik authored
not only under valgrind
-
Sergei Golubchik authored
it seems that the test can get IO thread running or not, there's a comment about it. Thus stop_slave_io.inc is told to ignore errors. Make stop_slave_io.inc also disable warnings in this case, in particular "1255 Slave already has been stopped"
-
Sergei Golubchik authored
failed on amd64-centos-stream8
-
Sergei Golubchik authored
on a busy system it might take time for buffer_page_written_index_leaf to reach the correct value. Wait for it. also, tag identical statements to be different in the result file.
-
Sergei Golubchik authored
add 10.5-specific global suppression. the extra warning is gone in 10.6
-
- 04 Apr, 2024 1 commit
-
-
sjaakola authored
Fix in this commit handles foreign key value appending into write set so that db and table names are converted from the filepath format to tablename format. This is compatible with key values appended from elsewhere in the code base There is a mtr test galera.galera_table_with_hyphen for regression testing Reviewer: monty@mariadb.com
-
- 02 Apr, 2024 1 commit
-
-
joshhn authored
"Operator does not exists" should rather read "Operator does not exist".
-
- 29 Mar, 2024 1 commit
-
-
Alexander Barkov authored
Item_func_dyncol_create::print_arguments() printed only CHARSET clause without COLLATE. Therefore, HEX(column_create(1,'1212' AS CHAR CHARACTER SET utf8mb3 COLLATE utf8mb3_bin)) inside a VIEW changed to just: HEX(column_create(1,'1212' AS CHAR CHARACTER SET utf8mb3)) which changed the collation ID seen in the HEX output. Note, the collation ID inside column_create() is not really much important. (It's only important what the character set is). And for COLLATE, the more important thing is what's later written in the AS clause of COLUMN_GET: SELECT COLUMN_GET( column_create(1,'1212' AS CHAR CHARACTER SET utf8mb3 COLLATE utf8mb3_bin) column_nr AS type -- this type is more important ); Still, let's add the COLLATE clause into the COLUMN_CREATE() print output, although it's not important for now for anything else than just the HEX output. At least to make VIEW work in a more predictable way with HEX(COLUMN_CREATE()). Also, in the future we can start using somehow the collation ID written inside COLUMN_CREATE(), for example by making the `AS type` clause optional in COLUMN_GET(): COLUMN_GET(dyncol_blob, column_nr [AS type]); instead of: COLUMN_GET(dyncol_blob, column_nr AS type); SQL Server compatibility layer may need this for the SQL_Variant data type support.
-
- 28 Mar, 2024 3 commits
-
-
Dmitry Shulga authored
MDEV-33768: Memory leak found in the test main.constraints run with --ps-protocol against a server built with the option -DWITH_PROTECT_STATEMENT_MEMROOT The discovered memory leak was introduced by the commit 762bf7a0 (MDEV-22602 Disable UPDATE CASCADE for SQL constraints) The reason why a memory leaked on running the test main.constraints is that a statement arena was used for allocation a memory for storing a constraint name. A constraint name is an entity having temporary nature by its design so runtime arena should be used for its allocation.
-
Dmitry Shulga authored
MDEV-33767: Memory leaks found in some tests run with --ps-protocol against a server built with the option -DWITH_PROTECT_STATEMENT_MEMROOT Found memory leaks were introduced by the commit a896bebf MDEV-18844 Implement EXCEPT ALL and INTERSECT ALL operations and caused by using a statement arena instead a runtime arena for allocation of objects having temporary life span by their nature. Aforementioned memory leaks were produced by running queries that typically use select with intersect, union or table values constructors. To fix these memory leaks use the runtime arena for allocation of Item_field objects used by set operations. Additionally, OOM handling added on allocation of aforementioned Item_field objects.
-
Daniel Black authored
Test case doesn't work on embedded builds.
-
- 27 Mar, 2024 11 commits
-
-
Anson Chung authored
$MYSQL_TZINFO_TO_SQL works by truncating tables. Truncation is an operation that cannot be done in-place and therefore is fundamentally incompatible with alter_algorithm='INPLACE'. As a result, we override the default alter_algorithm setting in tztime.cc to alter_algorithm='COPY' so that timezones can be loaded regardless of the previously set alter_algorithm. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
-
Sergei Golubchik authored
wait for all previous connections to disconnect and for all previous queries to finish running
-
Sergei Golubchik authored
This reverts commit 8b3f470c. because it doesn't work, the test still fails, and even more than before
-
Sergei Golubchik authored
as a side effect --replace and --error now work for shutdown command
-
Sergei Golubchik authored
plugin var check function must store the new variable value in *save
-
Sergei Golubchik authored
-
Sergei Golubchik authored
when the execution is very slow, under valgrind, the event might manage to fire more than once, making the test to fail
-
Sergei Golubchik authored
need at least 2.4 because we use per-type %destructor that was added after 2.3 in 2.3a
-
Sergei Golubchik authored
perfschema aggregation, like SHOW STATUS, is only statistically correct. It doesn't use atomics for performance reasons and might miss individual increments, particularly when two connections are disconnecting at the same time. To have stable results tests should avoid doing it.
-
Sergei Golubchik authored
disable approximate math in icx. and disable ansi aliasing too (aria loghandler unit tests fail)
-
Sergei Golubchik authored
apply the fix from MXS-4686
-