- 24 Jan, 2009 9 commits
-
-
Magnus Svensson authored
- extend debug prints for "permission denied"
-
Magnus Svensson authored
- Clear test variables "comment" and "logfile" to make sure thay aren't already set from previous run of same test - Print warning if test result already set and set it anyway
-
Magnus Svensson authored
- fix typo
-
Magnus Svensson authored
-
Magnus Svensson authored
- Don't save ndb_*_fs directory after test failure
-
Magnus Svensson authored
- Add name of error log file to the erro log table to get better erorr message when warning is found
-
Magnus Svensson authored
-
Magnus Svensson authored
- Add debug prints for analyzing mkdir "Permission denied" failure
-
Magnus Svensson authored
- Rewrite "check testcase" to use LOAD DATA INFILE instead of 'load_file' in order to speed up the reading of the servers error log. mysql-test/include/check-warnings.test: Use LOAD DATA to load the servers error log into error_log table and then call 'check_warning' stored procedure to filter out any unexpected warnings
-
- 22 Jan, 2009 1 commit
-
-
Luis Soares authored
The original goal of the test, as reported on BUG #25721, is to check whether a deadlock happens or not when concurrently CREATING/ALTERING/DROPPING the same server. For that a procedure (p1) is created that runs the exact same CREATE/ALTER/DROP statements for 10K iterations and two different connections (threads - t1 and t2) call p1 concurrently. At the end of the 10K iterations, the test checks if there was errors while running the loop (SELECT e >0). The problem is that In some cases it may happen that one thread, t1, gets scheduled to execute with just enough time to complete the iteration and never bumps into the other thread t2. Meaning that t1 will never run into an SQL exception. On the other hand, the other thread, t2, may run into t1 and never issue any/part of its own statements because it will throw an SQLEXCEPTION. This is probably the case for failures where only one value differs. Furthermore, there is a third scenario: both threads are scheduled to run interleaved for each iteration (or even one thread completes all iterations before the other starts). In this case, both will succeed without any error. This is probably the case for the failure that reports two different values. This patch addresses the failure in pushbuild by removing the error counting and the printout (SELECT > 0) at the end of the test. A timeout should occur if the error that the test is checking surfaces.
-
- 21 Jan, 2009 9 commits
-
-
Magnus Svensson authored
- Additional patch with improved protection by putting it all inside an "eval" - Calling 'hostpath' on a truncated socket may also croak. - Remove the need to create any directory parts of "path" inside the function.
-
Magnus Svensson authored
-
He Zhenxing authored
-
He Zhenxing authored
-
Magnus Svensson authored
- Fix problem with for example ./mtr --timer, caused by new version of "Getopt::Long" - Evaluating the "$opt" variable as a string, returns the name of the parameter to be modified instead of "Getopt::Long::Callback" which is the class name
-
He Zhenxing authored
In mtr.check_warnings, `text` was declares as type text, which is 64K, and when the server log grows larger than this, it would be truncated, and then check_warnings was actually checking the error messages of a previous test and complain warnings. This patch fixed the problem by change the type of `text` to mediumtext, which is 16M. mysql-test/include/mtr_warnings.sql: change the type of `text` to mediumtext
-
Bjorn Munch authored
-
Bjorn Munch authored
SIGABRT is sent to relevant processes after a timeout client/mysqltest.cc: Fixed signal handlers to mysqltest actually dumps core mysql-test/lib/My/CoreDump.pm: Added support for dbx mysql-test/lib/My/SafeProcess.pm: Added dump_core to force process to dump core mysql-test/lib/My/SafeProcess/safe_process.cc: Traps SIGABRT and sends this on to child mysql-test/mysql-test-run.pl: When test times out, force core dumps on mysqltest and servers
-
He Zhenxing authored
Log output of mysqltest when running check-testcase together with errput. Remove --silent option for mysqltest when running check-testcase/check-warnings mysql-test/mysql-test-run.pl: Log output of mysqltest when runinng check-testcase together with errput. Remove --silent option for mysqltest when running check-testcase/check-warnings
-
- 15 Jan, 2009 1 commit
-
-
Magnus Svensson authored
sync_slave_with_master - Additional patch for "disconnect $variable"
-
- 09 Jan, 2009 1 commit
-
-
Sven Sandberg authored
Problem 1: The test waits for an error in the slave sql thread, then resolves the error and issues 'start slave'. However, there is a gap between when the error is reported and the slave sql thread stops. If this gap was long, the slave would still be running when 'start slave' happened, so 'start slave' would fail and cause a test failure. Fix 1: Made wait_for_slave_sql_error wait for the slave to stop instead of wait for error in the IO thread. After stopping, the error code is verified. If the error code is wrong, debug info is printed. To print debug info, the debug printing code in wait_for_slave_param.inc was moved out to a new file, show_rpl_debug_info.inc. Problem 2: rpl_stm_mystery22 is a horrible name, the comments in the file didn't explain anything useful, the test was generally hard to follow, and the test was essentially duplicated between rpl_stm_mystery22 and rpl_row_mystery22. Fix 2: The test is about conflicts in the slave SQL thread, hence I renamed the tests to rpl_{stm,row}_conflicts. Refactored the test so that the work is done in extra/rpl_tests/rpl_conflicts.inc, and rpl.rpl_{row,stm}_conflicts merely sets some variables and then sourced extra/rpl_tests/rpl_conflicts.inc. The tests have been rewritten and comments added. Problem 3: When calling wait_for_slave_sql_error.inc, you always want to verify that the sql thread stops because of the expected error and not because of some other error. Currently, wait_for_slave_sql_error.inc allows the caller to omit the error code, in which case all error codes are accepted. Fix 3: Made wait_for_slave_sql_error.inc fail if no error code is given. Updated rpl_filter_tables_not_exist accordingly. Problem 4: rpl_filter_tables_not_exist had a typo, the dollar sign was missing in a 'let' statement. Fix 4: Added dollar sign. Problem 5: When replicating from other servers than the one named 'master', the wait_for_slave_* macros were unable to print debug info on the master. Fix 5: Replace parameter $slave_keep_connection by $master_connection. mysql-test/extra/rpl_tests/rpl_conflicts.test: rpl_stm_mystery22 and rpl_row_mystery22 have now been refactored and renamed: The two test cases rpl.rpl_stm_conflicts.test and rpl.rpl_row_conflicts.test just set some parameters, and then source include/rpl_tests/rpl_conflicts.test. Also, cleaned up the test case a bit, and fixed BUG#37718. mysql-test/include/show_rpl_debug_info.inc: Factored out the debug printing code from wait_for_slave_param.inc to a new file, show_rpl_debug_info.inc. Also removed the $slave_keep_connection parameter, and replaced it by $master_connection. This allows printing debug info on the master, no matter what the name of the master connection is. mysql-test/include/start_slave.inc: Replaced $slave_keep_connection by $master_connection. mysql-test/include/stop_slave.inc: Replaced $slave_keep_connection by $master_connection. mysql-test/include/sync_slave_io_with_master.inc: Replaced $slave_keep_connection by $master_connection. mysql-test/include/wait_for_slave_io_to_start.inc: Replaced $slave_keep_connection by $master_connection. mysql-test/include/wait_for_slave_io_to_stop.inc: Replaced $slave_keep_connection by $master_connection. mysql-test/include/wait_for_slave_param.inc: Factored out the debug printing code from wait_for_slave_param.inc to a new file, show_rpl_debug_info.inc. Also removed the $slave_keep_connection parameter, and replaced it by $master_connection. This allows printing debug info on the master, no matter what the name of the master connection is. Had to move the printing of debug info out of the while loop because of BUG number 41913. mysql-test/include/wait_for_slave_sql_error.inc: Made it wait until the slave sql thread has stopped. This takes very short time and avoids race condition bugs in test cases (e.g., fixes BUG#37718). Replaced $slave_keep_connection by $master_connection. mysql-test/include/wait_for_slave_sql_error_and_skip.inc: Since wait_for_slave_sql_error now waits for the slave sql thread to stop too, wait_for_slave_sql_error_and_skip does not have to wait for the slave sql thread to stop. Also, since wait_for_slave_sql_error now requires the parameter $slave_sql_errno to be set, wait_for_slave_sql_error_and_skip requires that as well: updated the usage instructions. mysql-test/include/wait_for_slave_sql_to_start.inc: Replaced $slave_keep_connection by $master_connection. mysql-test/include/wait_for_slave_sql_to_stop.inc: Replaced $slave_keep_connection by $master_connection. mysql-test/include/wait_for_slave_to_start.inc: Replaced $slave_keep_connection by $master_connection. mysql-test/include/wait_for_slave_to_stop.inc: Replaced $slave_keep_connection by $master_connection. mysql-test/suite/rpl/r/rpl_row_conflicts.result: update result file mysql-test/suite/rpl/r/rpl_stm_conflicts.result: update result file mysql-test/suite/rpl/t/rpl_dual_pos_advance.test: Replaced $slave_keep_connection by $master_connection. mysql-test/suite/rpl/t/rpl_filter_tables_not_exist.test: Set $slave_sql_errno, since it is now required. Add dollar sign to $show_sql_error (without dollar sign, mtr makes it an environment variable). mysql-test/suite/rpl/t/rpl_row_conflicts.test: rpl_stm_mystery22 and rpl_row_mystery22 have now been refactored and renamed: The two test cases rpl.rpl_stm_conflicts.test and rpl.rpl_row_conflicts.test just set some parameters, and then source include/rpl_tests/rpl_conflicts.test. Also, cleaned up the test case a bit, and fixed BUG#37718. mysql-test/suite/rpl/t/rpl_row_mystery22.test: rpl_stm_mystery22 and rpl_row_mystery22 have now been refactored and renamed: The two test cases rpl.rpl_stm_conflicts.test and rpl.rpl_row_conflicts.test just set some parameters, and then source include/rpl_tests/rpl_conflicts.test. Also, cleaned up the test case a bit, and fixed BUG#37718. mysql-test/suite/rpl/t/rpl_stm_conflicts.test: rpl_stm_mystery22 and rpl_row_mystery22 have now been refactored and renamed: The two test cases rpl.rpl_stm_conflicts.test and rpl.rpl_row_conflicts.test just set some parameters, and then source include/rpl_tests/rpl_conflicts.test. Also, cleaned up the test case a bit, and fixed BUG#37718.
-
- 08 Jan, 2009 2 commits
-
-
Luis Soares authored
conflicts: Text conflict in mysql-test/lib/mtr_report.pm Text conflict in mysql-test/mysql-test-run.pl
-
Sven Sandberg authored
Problem: when mtr tries to create a directory, and the target exists but is a file instead of directory, it tries several times to create the directory again before it fails. Fix: make it check if the target exists and is a non-directory. mysql-test/lib/My/File/Path.pm: mkpath() now stops with appropriate error message if the target exists but is a non-directory.
-
- 07 Jan, 2009 1 commit
-
-
He Zhenxing authored
-
- 28 Dec, 2008 5 commits
-
-
Joerg Bruehe authored
-
Joerg Bruehe authored
-
Kent Boortz authored
-
Kent Boortz authored
-
Kent Boortz authored
-
- 26 Dec, 2008 1 commit
-
-
He Zhenxing authored
If server has not been initialized as a slave (by CHANGE MASTER), then SHOW SLAVE STATUS will return an empty set, and caused the waiting for Slave_IO_running or Slave_SQL_running to 'No' fail. This patch fixed the problem by return immediately if slave is not initialized in include/wait_for_slave_*_to_stop.inc. mysql-test/include/wait_for_slave_io_to_stop.inc: Return immediately if slave is not initialized mysql-test/include/wait_for_slave_sql_to_stop.inc: Return immediately if slave is not initialized mysql-test/include/wait_for_slave_to_stop.inc: Return immediately if slave is not initialized
-
- 25 Dec, 2008 1 commit
-
-
He Zhenxing authored
mysqltest command 'shutdown_server' is supposed to shutdown the server and wait for it to be gone, and kill it when timeout. But because the arguments passed to my_kill were in the wrong order, 'shutdown_server' does not wait nor kill the server at all. So after 'shutdown_server', the server is still running, and the server may still accepting connections. mysql-test/include/mtr_warnings.sql: Suppress forcing close thread messages when server shuts down mysql-test/include/restart_mysqld.inc: wait_until_disconnected.inc is not required after fix shutdown_server command
-
- 19 Dec, 2008 8 commits
-
-
Andrei Elkin authored
a minor improvement to the test to ease merging. mysql-test/suite/rpl/r/rpl_server_id2.result: results changed. mysql-test/suite/rpl/t/rpl_server_id2.test: masking out the until_pos which value is out of interest but it presence hurts merging between trees.
-
Andrei Elkin authored
-
Andrei Elkin authored
Bug#38540 rpl_server_id2 uses show slave status unnecessarily Slave did not perform any event recorded into the relay log from some different master when it was started with --replicate-same-server-id. The reason appeared to be a consequence of BUG#38734 which stopped the sql thread at its startup time. The real fixes for the current bug are in the patch for BUG#38734. This changeset carries only a regression test for the bugs. Bug#38540 gets fixed too by means of eliminating an extra show slave status. mysql-test/suite/rpl/r/rpl_server_id2.result: Bug#38934 Bug#38540 changed results. mysql-test/suite/rpl/t/disabled.def: rpl_server_id2 is re-enabled. mysql-test/suite/rpl/t/rpl_server_id2.test: regression test for BUG#38734 is added. Bug#38540 requirement to get rid of show slave status is implemented.
-
Alfranio Correia authored
-
Magnus Svensson authored
-
Magnus Svensson authored
mysql-test/include/wait_until_disconnected.inc: Allow 2013 as an expected error code
-
Alfranio Correia authored
Note that this result set is different from that in 6.0/6.0-rpl.
-
Alfranio Correia authored
-
- 18 Dec, 2008 1 commit
-
-
Alfranio Correia authored
-