1. 17 Jul, 2005 1 commit
    • unknown's avatar
      Federated Storage Engine, bug 9925 "Federated query processor (step 2 or step 3) not using logic in · 6743f0ee
      unknown authored
      WHERE statement"
      
      
      sql/ha_federated.cc:
        Changes per Jimw's review. 
        
        notes about some suggestions:
        
        1. Tried to replace my_sprintf with strxmov, but had problems. Couldn't 
           get the test suite to run at all, and could not find any particular
           error. Since this is something that is not critical, I'll leave it
           as is for now.
        2. I would like to use my_error to create all of my error messages, but 
           cannot figure out how to get it to take more than one argument to be
           passed to the error message (I tried this once but had errors, and 
           cannot find an example of how to get it to work despite seeing messages
           with obviously more than one arg
        3. Replaced all string building from literals to defined SQL string pieces
           such as "SELECT ", "FROM " ...
        4. Format fixes, spacing fixes completed
        5. Removed records_in_range records calculation functionality
      sql/ha_federated.h:
        Formatting changes, new defines for SQL query string tokens
      sql/share/errmsg.txt:
        changed 'SRC' to 'SOURCE' per Jimw's review
      6743f0ee
  2. 16 Jul, 2005 1 commit
    • unknown's avatar
      This is the same patch as 1.1937, with small variable declaration changes, memory · 11536781
      unknown authored
      deallocation cleanup
      
      
      mysql-test/r/federated.result:
        new test results
      mysql-test/t/federated.test:
        New tests, and added explains per Timour's suggestion. This will keep
                track of whether changes have been made to the optimiser that might affect
                Federated.
                Also changed the error codes to federated error codes in the error tests
      sql/ha_federated.cc:
        1. Not using MAX_REMOTE_SIZE, so removed
                 2. Changed all defines that were IO_SIZE to FEDERATED_QUERY_BUFFER_SIZE
                 3. Now using Federated Error Codes
                 4. Implemented ::info (gets valid 'records' number)
                 5. Implemented ::read_range_first - now uses indexes in range operations
                 6. Better allocation in get_share
                 7. Cleaned up memory bug in get_share
                 8. Better initial query "SELECT * FROM t1 WHERE 1=0" for check_foreign_data_src
                 9. emit_key_part_name and emit_key_part_element for read_range_first to not
                    have redundancy
                 10. Made sure all 'append's pass length, and use append("") to ensure proper
                     null termination of strings being built.
                 11. Better message creation. If ER_QUERY_ON_FOREIGN_DATA_SRC, I also pass
                     the actual error code and message from the foreign data src.
                 12. Cleaned up how the result set and share->scheme is freed.
      sql/share/errmsg.txt:
        New Federated error messages that are more tailored to the type of information
        we want to see when federated has an error.
      mysql-test/include/federated.inc:
        New bitkeeper file, include file for separating setup from main test suite
      mysql-test/include/federated_cleanup.inc:
        New BitKeeper file ``mysql-test/include/federated_cleanup.inc''
      sql/ha_federated.h:
        Added comments where needed, one was already commented about
      11536781
  3. 15 Jul, 2005 34 commits
  4. 14 Jul, 2005 4 commits
    • unknown's avatar
      Merge · 07d75670
      unknown authored
      
      ndb/include/util/SocketServer.hpp:
        Auto merged
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        Auto merged
      ndb/src/common/util/SocketClient.cpp:
        Auto merged
      ndb/src/common/util/SocketServer.cpp:
        Auto merged
      ndb/src/common/util/version.c:
        Auto merged
      ndb/src/kernel/blocks/qmgr/Qmgr.hpp:
        Auto merged
      ndb/src/kernel/blocks/qmgr/QmgrMain.cpp:
        Auto merged
      ndb/src/mgmclient/main.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      ndb/src/ndbapi/ClusterMgr.cpp:
        Auto merged
      ndb/tools/restore/restore_main.cpp:
        Auto merged
      ndb/include/util/ndb_opts.h:
        merge
      ndb/src/common/mgmcommon/IPCConfig.cpp:
        merge
      ndb/src/common/transporter/TransporterRegistry.cpp:
        merge
      ndb/src/mgmapi/mgmapi.cpp:
        merge
      ndb/src/mgmclient/CommandInterpreter.cpp:
        merge
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        merge
      ndb/src/mgmsrv/Services.cpp:
        merge
      ndb/src/mgmsrv/main.cpp:
        merge
      ndb/src/ndbapi/TransporterFacade.cpp:
        merge
      07d75670
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · e70b5569
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug4-5.0
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      e70b5569
    • unknown's avatar
      take into account table lock mode when opening table: · 3d7b4886
      unknown authored
      try to find most suitable table, to avouid pickup table with too low locking mode or occupy table with write mode for select when it will be need for update later
      (BUG#9597)
      
      
      mysql-test/r/view.result:
        opening table in correct locking mode test
      mysql-test/t/view.test:
        opening table in correct locking mode test
      sql/sql_base.cc:
        take into account table lock mode when opening table:
        try to find most suitable table, to avouid pickup table with too low locking mode or occupy table with write mode for select when it will be need for update later
      3d7b4886
    • unknown's avatar
      Merge mysql.com:/opt/local/work/mysql-4.1-root · da918122
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-root
      
      
      mysql-test/t/ps.test:
        Manual merge
      da918122