1. 07 May, 2007 3 commits
  2. 04 May, 2007 14 commits
    • unknown's avatar
      bug #27531: 5.1 part of the fix: · e53847f3
      unknown authored
       - added join cache indication in EXPLAIN (Extra column).
       - prefer filesort over full scan over 
         index for ORDER BY (because it's faster).
       - when switching from REF to RANGE because
         RANGE uses longer key turn off sort on
         the head table only as the resulting 
         RANGE access is a candidate for join cache
         and we don't want to disable it by sorting
         on the first table only. 
      
      
      mysql-test/r/archive_gis.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/compress.result:
        bug #27531:
         - join cache in EXPLAIN. 
         - prefer filesort over full scan over index for ORDER BY.
      mysql-test/r/ctype_utf8.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/derived.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/distinct.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/func_group.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/func_group_innodb.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/gis.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/greedy_optimizer.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/group_by.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/group_min_max.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/index_merge_myisam.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/information_schema.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/innodb_gis.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/innodb_mysql.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/join.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/join_nested.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/key_diff.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/myisam.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/ndb_condition_pushdown.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/ndb_gis.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/range.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/row.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/select.result:
        bug #27531:
         - join cache in EXPLAIN.
         - prefer filesort over full scan over index for ORDER BY.
      mysql-test/r/ssl.result:
        bug #27531:
         - join cache in EXPLAIN.
         - prefer filesort over full scan over index for ORDER BY.
      mysql-test/r/ssl_compress.result:
        bug #27531:
         - join cache in EXPLAIN.
         - prefer filesort over full scan over index for ORDER BY.
      mysql-test/r/subselect.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/subselect3.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/union.result:
        bug #27531: join cache in EXPLAIN
      mysql-test/r/view.result:
        bug #27531: join cache in EXPLAIN
      sql/sql_select.cc:
        bug #27531:
         - join cache in EXPLAIN.
         - prefer filesort over full scan over
           index for ORDER BY.
         - disable sorting on the first table only
           when switching from REF to RANGE.
      e53847f3
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B27531-5.0-opt · c8878433
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B27531-5.1-opt-after-merge
      
      
      mysql-test/r/join.result:
        Auto merged
      mysql-test/t/join.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      c8878433
    • unknown's avatar
      post merge (5.0-opt -> 5.1-opt) fixes · 517181bc
      unknown authored
      517181bc
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B27531-4.1-opt · 17d31dad
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B27531-5.0-opt
      
      
      mysql-test/t/join.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/join.result:
        SCCS merged
      17d31dad
    • unknown's avatar
      Bug #27531: the 4.1 fix. · 0f88bd8c
      unknown authored
      When checking for applicability of join cache
      we must disable its usage only if there is no
      temp table in use.
      When a temp table is used we can use join
      cache (and it will not make the result-set 
      unordered) to fill the temp table. The filesort() 
      operation is then applied to the data in the temp 
      table and hence is not affected by join cache
      usage.
      Fixed by narrowing the condition for disabling 
      join cache to exclude the case where temp table
      is used.
      
      
      mysql-test/r/join.result:
        Bug #27531: test case
      mysql-test/t/join.test:
        Bug #27531: test case
      sql/sql_select.cc:
        Bug #27531: 
        Disable join cache only if not using temp table
      0f88bd8c
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B27531-5.0-opt · e4beed3c
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B27531-5.1-opt
      
      
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/r/join_outer.result:
        Auto merged
      mysql-test/t/cast.test:
        Auto merged
      mysql-test/t/join_outer.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      mysql-test/r/subselect.result:
        merge of 5.0-opt -> 5.1-opt
      mysql-test/t/subselect.test:
        merge of 5.0-opt -> 5.1-opt
      e4beed3c
    • unknown's avatar
      bugfix in checksum with force varpart · 57ec524b
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        bigger needed for running some tests
      57ec524b
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 01f69e13
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      01f69e13
    • unknown's avatar
      Bug#28181 Access denied to 'information_schema when select into out file (regression) · e8163b6c
      unknown authored
      allow select into out file from I_S if user has FILE privilege
      otherwise issue an error
      
      
      mysql-test/r/outfile.result:
        test result
      mysql-test/t/outfile.test:
        test case
      sql/sql_parse.cc:
        allow select into out file from I_S if user has FILE privilege
        otherwise issue an error
      e8163b6c
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.1 · 6870dac6
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-single-user
      
      6870dac6
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 93e68f08
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27807-5.0-opt
      
      93e68f08
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/23656-bug-4.1-opt-mysql · 255d8ef3
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/23656-bug-5.0-opt-mysql
      
      
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/t/cast.test:
        Auto merged
      sql/item_func.cc:
        Manual merge
      255d8ef3
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 766224b4
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27807-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        merge to 5.0-opt
      mysql-test/t/subselect.test:
        merge to 5.0-opt
      766224b4
    • unknown's avatar
      Bug #27807. · e5655cbe
      unknown authored
      Non-correlated scalar subqueries may get executed
      in EXPLAIN at the optimization phase if they are
      part of a right hand sargable expression.
      If the scalar subquery uses a temp table to 
      materialize its results it will replace the 
      subquery structure from the parser with a simple
      select from the materialization table.
      As a result the EXPLAIN will crash as the 
      temporary materialization table is not to be shown
      in EXPLAIN at all.
      Fixed by preserving the original query structure
      right after calling optimize() for scalar subqueries
      with temp tables executed during EXPLAIN.
      
      
      mysql-test/r/subselect.result:
        Bug #27807: test case
      mysql-test/t/subselect.test:
        Bug #27807: test case
      sql/item_subselect.cc:
        Bug #27807: preserve the join structure
      sql/sql_select.cc:
        Bug #27807: introduce initialization function for tmp_join
      sql/sql_select.h:
        Bug #27807: introduce initialization function for tmp_join
      e5655cbe
  3. 03 May, 2007 4 commits
    • unknown's avatar
      Bug#23656: Wrong conversion result of a DATETIME to integer using CAST function. · 4fd339b2
      unknown authored
      The generic string to int conversion was used by the Item_func_signed and
      the Item_func_unsigned classes to convert DATE/DATETIME values to the
      SIGNED/UNSIGNED type. But this conversion produces wrong results for such
      values.
      
      Now if the item which result has to be converted can return its result as
      longlong then the item->val_int() method is used to allow the item to carry
      out the conversion itself and return the correct result.
      This condition is checked in the Item_func_signed::val_int() and the
      Item_func_unsigned::val_int() functions.
      
      
      mysql-test/t/cast.test:
        Added a test case for the bug#23656: Wrong conversion result of a DATETIME to integer using CAST function.
      mysql-test/r/cast.result:
        Added a test case for the bug#23656: Wrong conversion result of a DATETIME to integer using CAST function.
      sql/item_func.cc:
        Bug#23656: Wrong conversion result of a DATETIME to integer using CAST function.
        Now if the item which result has to be converted can return its result as
        longlong then the item->val_int() method is used to allow the item to carry
        out the conversion itself and return the correct result.
        This condition is checked in the Item_func_signed::val_int() and the
        Item_func_unsigned::val_int() functions.
      4fd339b2
    • unknown's avatar
      Merge trift2.:/MySQL/M50/netware-cross-5.0 · d0b59a4b
      unknown authored
      into  trift2.:/MySQL/M51/netware-cross-5.1
      
      
      scripts/Makefile.am:
        Manual merge.
      d0b59a4b
    • unknown's avatar
      Better distinction between "CLEANFILES" and "DISTCLEANFILES" for some generated files · 4c535ca9
      unknown authored
      (here: "scripts/mysql_fix_privilege_tables{.sql,_sql.c}"). Important for cross-builds.
      
      
      scripts/Makefile.am:
        Generated files like "mysql_fix_privilege_tables{.sql,_sql.c}" should survive
        a "make clean", this is essential for cross-builds.
        So move them from "CLEANFILES" to "DISTCLEANFILES".
      4c535ca9
    • unknown's avatar
      Updated funcs_1 files to 5.1.18 level · 4fc4fcd0
      unknown authored
       - validating current result files
       - updating with new features in information_schema / error messages
       - forced order by and removed time stamps
      removed a_version files that are not needed (now that the suite is in the main tree
      Note: datadict tests still fail as a result of bug 28181 (a regression introduced in 
            5.0.42 - and 5.1.18(?) - tests should runn clean once it is fixed
      
      
      BitKeeper/deleted/.del-a_version_check.test~82ea7fb267df9e58:
        Delete: mysql-test/suite/funcs_1/t/a_version_check.test
      BitKeeper/deleted/.del-a_version_check.result~97a8ec1e3211c26:
        Delete: mysql-test/suite/funcs_1/r/a_version_check.result
      mysql-test/suite/funcs_1/datadict/datadict_load.inc:
        Modified to correct failiure to return host name on some systems
      mysql-test/suite/funcs_1/datadict/datadict_master.inc:
        corrections to fooce order by on queries, replace time stamps with strings and enable the
        testing of referential_constraints table
      mysql-test/suite/funcs_1/datadict/datadict_show_schema.inc:
        corrections to force order by on queries
      mysql-test/suite/funcs_1/r/innodb__datadict.result:
        Updated result file with order by selects, elimination of time stamps and selects
        of empty user (that we don't have anymore) and adding the testing 
        of referential_constraints table
      mysql-test/suite/funcs_1/r/innodb_func_view.result:
        confirming existing results as correct - old result file had wrong cast values
      mysql-test/suite/funcs_1/r/innodb_trig_0102.result:
        Corrected error with long trigger name (that was previously quietly trimmed)
      mysql-test/suite/funcs_1/r/innodb_trig_08.result:
        confirmed existing results as corrects ones - updated error message
      mysql-test/suite/funcs_1/r/innodb_views.result:
        confirmed current results as correct - returned results included a wrong 'expected' error message
      mysql-test/suite/funcs_1/r/memory__datadict.result:
        Updated result file with order by selects, elimination of time stamps and selects
        of empty user (that we don't have anymore) and adding the testing 
        of referential_constraints table
      mysql-test/suite/funcs_1/r/memory_func_view.result:
        confirming existing results as correct - old result file had wrong cast values
      mysql-test/suite/funcs_1/r/memory_trig_0102.result:
        Corrected error with long trigger name (that was previously quietly trimmed)
      mysql-test/suite/funcs_1/r/memory_trig_08.result:
        confirmed existing results as corrects ones - updated error message
      mysql-test/suite/funcs_1/r/memory_views.result:
        confirmed current results as correct - returned results included a wrong 'expected' error message
      mysql-test/suite/funcs_1/r/myisam__datadict.result:
        Updated result file with order by selects, elimination of time stamps and selects
        of empty user (that we don't have anymore) and adding the testing 
        of referential_constraints table
      mysql-test/suite/funcs_1/r/myisam_func_view.result:
        confirming existing results as correct - old result file had wrong cast values
      mysql-test/suite/funcs_1/r/myisam_trig_0102.result:
        Corrected error with long trigger name (that was previously quietly trimmed)
      mysql-test/suite/funcs_1/r/myisam_trig_08.result:
        confirmed existing results as corrects ones - updated error message
      mysql-test/suite/funcs_1/r/myisam_views.result:
        confirmed current results as correct - returned results included a wrong 'expected' error message
      mysql-test/suite/funcs_1/r/ndb__datadict.result:
        Updated result file with order by selects, elimination of time stamps and selects
        of empty user (that we don't have anymore) and adding the testing 
        of referential_constraints table
      mysql-test/suite/funcs_1/r/ndb_func_view.result:
        confirming existing results as correct - old result file had wrong cast values
      mysql-test/suite/funcs_1/r/ndb_trig_0102.result:
        Corrected error with long trigger name (that was previously quietly trimmed)
      mysql-test/suite/funcs_1/r/ndb_trig_08.result:
        confirmed existing results as corrects ones - updated error message
      mysql-test/suite/funcs_1/r/ndb_views.result:
        confirmed current results as correct - returned results included a wrong 'expected' error message
      mysql-test/suite/funcs_1/t/disabled.def:
        Updated disabled messages with clearer ones
      mysql-test/suite/funcs_1/triggers/triggers_0102.inc:
        Added code to test for error in case of a trigger name that is to long
      mysql-test/suite/funcs_1/views/views_master.inc:
        Correction to remove wrong '--eror' meaningless tag that generated warnings
      4fc4fcd0
  4. 02 May, 2007 19 commits