1. 07 Mar, 2008 1 commit
    • unknown's avatar
      Bug #34367: sql/sql_show.cc: create_schema_table should handle · 6976876e
      unknown authored
      MYSQL_TYPE_NEWDECIMAL
      
      Added support for the type MYSQL_TYPE_NEWDECIMAL. It now works like
      MYSQL_TYPE_DECIMAL. Unfortunately there cannot be a test case until
      we have a working information_schema plugin as part of the source
      distribution.
      
      
      sql/sql_show.cc:
        Bug#34367: The fix. Corrected wrong comments and a DBUG_ENTER with wrong 
        function name.
      sql/table.h:
        Bug#34367: Added comments to st_field_info.
      6976876e
  2. 27 Feb, 2008 7 commits
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug33834/my51-bug33834 · c5fbcdc4
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      c5fbcdc4
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug33834/my50-bug33834 · 815f5ad5
      unknown authored
      into  kaamos.(none):/data/src/opt/bug33834/my51-bug33834
      
      
      mysql-test/t/func_time.test:
        Auto merged
      815f5ad5
    • unknown's avatar
      Fixed test suite failures with --ps-protocol introduced in PB by · dad47218
      unknown authored
      the patch for bug #33834.
      
      dad47218
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 96a92cab
      unknown authored
      into  mysql.com:/home/hf/work/25097/my51-25097
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/log.cc:
        Auto merged
      96a92cab
    • unknown's avatar
      merging · d13abd50
      unknown authored
      d13abd50
    • unknown's avatar
      Merge mysql.com:/home/hf/work/25097/my50-25097 · bf9e17b1
      unknown authored
      into  mysql.com:/home/hf/work/25097/my51-25097
      
      
      client/mysql.cc:
        Auto merged
      include/sql_common.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql-common/client.c:
        merging
      sql/log.cc:
        merging
      bf9e17b1
    • unknown's avatar
      Bug #25097 mysql_server_init fails silently if no errmsg.sys is present. · 86260744
      unknown authored
      There was no way to return an error from the client library
      if no MYSQL connections was established.
      So here i added variables to store that king of errors and
      made functions like mysql_error(NULL) to return these.
      
      
      client/mysql.cc:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        Show the error message on std_error
      include/sql_common.h:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        cant_connect_sqlstate constant declared
      libmysql/libmysql.c:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        mysql_sqlstate(NULL) returns 'unknown_sqlstate'
      libmysqld/lib_sql.cc:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        EMBEDDED_SERVER version of the vprint_msg_to_log() implemented
      sql-common/client.c:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        mysql_server_last_errno and mysql_server_last_error introduced
        to store errors not related to particular connections.
        
        mysql_error(NULL) and mysql_errno(NULL) now returns these
        mysql_server_last_error and errno respectively
      sql/log.cc:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        EMBEDDED_LIBRARY implementation of the vprint_msg_to_log() moved
        to lib_sql.cc
      86260744
  3. 26 Feb, 2008 1 commit
  4. 25 Feb, 2008 3 commits
    • unknown's avatar
      Post-merge fixes for bug #33834. · 483fe4ba
      unknown authored
      483fe4ba
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug33834/my50-bug33834 · 8700e53c
      unknown authored
      into  kaamos.(none):/data/src/opt/bug33834/my51-bug33834
      
      
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      sql/sql_yacc.yy:
        Manual merge.
      8700e53c
    • unknown's avatar
      Fix for bug #33834: FRAC_SECOND: Applicability not clear in · fe0eafa5
      unknown authored
                          documentation
      
      While the manual mentions FRAC_SECOND only for the TIMESTAMPADD()
      function, it was also possible to use FRAC_SECOND with DATE_ADD(),
      DATE_SUB() and +/- INTERVAL.
      
      Fixed the parser to match the manual, i.e. using FRAC_SECOND for 
      anything other than TIMESTAMPADD()/TIMESTAMPDIFF() now produces a 
      syntax error.
      
      Additionally, the patch allows MICROSECOND to be used in TIMESTAMPADD/
      TIMESTAMPDIFF and marks FRAC_SECOND as deprecated.
      
      
      mysql-test/r/func_time.result:
        Added a test case for bug #33834.
      mysql-test/t/func_time.test:
        Added a test case for bug #33834.
      sql/sql_yacc.yy:
        Reject FRAC_SECOND for anything other than TIMESTAMPADD() or
        TIMESTAMPDIFF().
        Allow MICROSECOND to be used with TIMESTAMPADD()/TIMESTAMPDIFF().
        Warn about FRAC_SECOND being a deprecated unit.
      fe0eafa5
  5. 24 Feb, 2008 5 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · c981603b
      unknown authored
      into  mysql.com:/misc/mysql/99999/51-99999
      
      
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_plugin.cc:
        Auto merged
      c981603b
    • unknown's avatar
      Bug#32757: hang with sql_mode set when setting some global variables · d1d93af3
      unknown authored
      If setting a system-variable provided by a plug-in failed, no OK or
      error was sent in some cases, hanging the client. We now send an error
      in the case from the ticket (integer-argument out of range in STRICT
      mode). We also provide a semi-generic fallback message for possible
      future cases like this where an error is signalled, but no message is
      sent to the client. The error/warning handling is unified so it's the
      same again for variables provided by plugins and those in the server
      proper.
      
      
      mysql-test/r/plugin.result:
        show that on out-of-range values, plugin interface throws errors
        in STRICT mode and warnings otherwise.
      mysql-test/t/plugin.test:
        show that on out-of-range values, plugin interface throws errors
        in STRICT mode and warnings otherwise.
      sql/set_var.cc:
        - handle signedness of values used in warnings
        - in STRICT mode, throw errors rather than warnings
      sql/sql_parse.cc:
        If sql_set_variables() returns with an error but no message
        was sent to the client, send a semi-generic one so the session
        won't hang and we won't fail silently.
      sql/sql_plugin.cc:
        throw a warning if more than just block-size was corrected
        (or an error in STRICT mode). use functions from set_var
        for uniform behaviour of server- and plug-in variables.
      storage/example/ha_example.cc:
        Add a ULONG system variable to example plugin so
        we can test integers in the plugin-interface without
        having to depend on the presence of innobase.
      d1d93af3
    • unknown's avatar
      Bug#32753: PAD_CHAR_TO_FULL_LENGTH is not documented and interferes with grant tables · d6dafaa1
      unknown authored
      SQL-mode PAD_CHAR_TO_FULL_LENGTH affected mysqld's user-table too. If
      enabled, user-name and host were space-padded and no longer matched
      the login-data of incoming connexions.
      
      Patch disregards pad-flag while loading privileges so ability to log
      in does not depend on SQL-mode.
      
      
      mysql-test/r/sql_mode.result:
        show that SQL-mode 'PAD_CHAR_TO_FULL_LENGTH' does not affect
        loading of privileges (and by extension, ability to log in).
      mysql-test/t/sql_mode.test:
        show that SQL-mode 'PAD_CHAR_TO_FULL_LENGTH' does not affect
        loading of privileges (and by extension, ability to log in).
      sql/sql_acl.cc:
        temporarily disable SQL-mode 'PAD_CHAR_TO_FULL_LENGTH' while
        reloading privileges
      d6dafaa1
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · b895c910
      unknown authored
      into  mysql.com:/misc/mysql/20752/51-20752
      
      
      sql/item_func.cc:
        Auto merged
      b895c910
    • unknown's avatar
      Bug#20752: BENCHMARK with many iterations returns too quickly · 1f2c3196
      unknown authored
      In BENCHMARK(count, expr), count could overflow/wrap-around.
      Patch changes to a sufficiently large data-type. Adds a warning
      for negative count values.
      
      
      mysql-test/r/func_str.result:
        show that a negative 'count' for BENCHMARK(count, expr)
        throws a warning and returns NULL.
      mysql-test/t/func_str.test:
        show that a negative 'count' for BENCHMARK(count, expr)
        throws a warning and returns NULL.
      sql/item_func.cc:
        use ulonglong rather than ulong in BENCHMARK(count, expr)
        throw warning on negative 'count'; return SQL-NULL.
      1f2c3196
  6. 22 Feb, 2008 8 commits
  7. 19 Feb, 2008 3 commits
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug31236/my51-bug31236 · 31a70a01
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      configure.in:
        Auto merged
      mysql-test/r/strict.result:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/unireg.h:
        Auto merged
      31a70a01
    • unknown's avatar
      Fix for bug #31236: Inconsistent division by zero behavior for · 832fd6d8
      unknown authored
                          floating point numbers
      
      Some math functions did not check if the result is a valid number
      (i.e. neither of +-inf or nan).
      
      Fixed by validating the result where necessary and returning NULL in
      case of invalid result.
      
      
      BitKeeper/deleted/.del-matherr.c:
        Rename: sql/matherr.c -> BitKeeper/deleted/.del-matherr.c
      configure.in:
        Removed DONT_USE_FINITE, it is not used anywhere.
      include/my_global.h:
        isfinite() is a C99 macro which absoletes finite(). First try to use
        it, then fall back to finite() if the target platform has it,
        otherwise use our own implementation.
      mysql-test/r/func_math.result:
        Added a test case for bug #31236.
      mysql-test/r/strict.result:
        Fixed a test case which relied on old behavior.
      mysql-test/t/func_math.test:
        Added a test case for bug #31236.
      mysql-test/t/strict.test:
        Fixed a test case which relied on old behavior.
      sql/field.cc:
        No need to check if the finite() or its equivalent is available.
      sql/item_func.cc:
        Use fix_result() wherever the result can be one of +-inf or nan, 
        assuming the function arguments are valid numbers.
        Removed fix_result() from functions that are defined for all possible
        input numbers.
      sql/item_func.h:
        Moved fix_result() from Item_dec_func to Item_func which is a common
        ancestor for Item_dec_func and Item_num_op.
      sql/unireg.h:
        Removed POSTFIX_ERROR because no code returns it.
      832fd6d8
    • unknown's avatar
      Bug #30604: different flagging of time_zone_used in normal · e719a221
      unknown authored
        and ps-protocol
      Finding a routine should be a transparent operation as 
      far as the binary log is concerned.
      But it was influencing the binary log because of the TIMESTAMP
      column in the proc table.
      
      Fixed by preserving and restoring the time_zone usage flag when
      searching for a stored routine in the proc table.
      
      
      mysql-test/r/binlog_innodb.result:
        Bug #30604: test case
      mysql-test/r/ctype_cp932_binlog.result:
        Bug #30604: updated test results (a procedure call before that)
      mysql-test/t/binlog_innodb.test:
        Bug #30604: test case
      sql/sp.cc:
        Bug #30604: finding a routine should be a transparent operation as 
        far as the binary log is concerned.
        Fixed by preserving and restoring the time_zone usage flag.
      e719a221
  8. 18 Feb, 2008 8 commits
  9. 17 Feb, 2008 4 commits