1. 11 Oct, 2006 1 commit
    • unknown's avatar
      Merge polly.local:/tmp/maint/bug11655/my41-bug11655 · 6c19837c
      unknown authored
      into  polly.local:/tmp/maint/bug11655/my50-bug11655
      
      
      sql/time.cc:
        Auto merged
      include/my_time.h:
        Manually merged
      mysql-test/r/func_sapdb.result:
        Manually merged
      mysql-test/r/func_time.result:
        Manually merged
      mysql-test/t/func_time.test:
        Manually merged
      sql-common/my_time.c:
        Manually merged
      sql/field.cc:
        Manually merged
      sql/item_timefunc.cc:
        Manually merged
      6c19837c
  2. 04 Oct, 2006 1 commit
    • unknown's avatar
      Fixes a number of problems with time/datetime <-> string conversion functions: · f29045b4
      unknown authored
      - bug #11655 "Wrong time is returning from nested selects - maximum time exists
      - input and output TIME values were not validated properly in several conversion functions
      - bug #20927 "sec_to_time treats big unsigned as signed"
      - integer overflows were not checked in several functions. As a result, input values like 2^32 or 3600*2^32 were treated as 0
      - BIGINT UNSIGNED values were treated as SIGNED in several functions
      - in cases where both input string truncation and out-of-range TIME value occur, only 'truncated incorrect time value' warning was produced
      
      
      include/my_time.h:
        Added defines for the TIME limits
        Added defines for the warning flags set by str_to_time() and check_time_range()
        Added check_time_range() declaration
      mysql-test/r/func_sapdb.result:
        Fixed testcases which relied on incorrect TIMEDIFF() behaviour
      mysql-test/r/func_time.result:
        Fixed testcase which relied on incorrect behaviour
        Added testcases for out-of-range values in SEC_TO_TIME(), TIME_TO_SEC(), ADDTIME(), SUBTIME() and EXTRACT()
      mysql-test/t/func_time.test:
        Added testcases for out-of-range values in SEC_TO_TIME(), TIME_TO_SEC(), ADDTIME(), SUBTIME() and EXTRACT()
      sql-common/my_time.c:
        Added check_time_range() to be used from str_to_time() and item_timefunc.cc
        Added new out-of-range flag to str_to_time() warnings
        Use '%u' instead of '%d' in my_*_to_str() because the arguments are unsigned
      sql/field.cc:
        Replaced out-of-range checks with checks for flags returned by str_to_time()
      sql/item_timefunc.cc:
        Added wrappers over make_datetime() and make_time() which perform out-of-range checks on input values
        Moved common code in Item_func_sec_to_time::val_str() and Item_func_sec_to_time::val_int() into a separate function sec_to_time()
        Replaced calls to make_datetime() with make_datetime_with_warn() in Item_func_add_time and Item_func_timediff
        Checks for 'unsigned int' overflows in Item_func_maketime
        Use make_time_with_warn() instead of make_time() in Item_func_maketime
        Fixed incorrect sizeof() in Item_func_str_to_date::get_time()
      sql/time.cc:
        Check for return value of str_to_time() along with warning flags
      f29045b4
  3. 19 Sep, 2006 3 commits
  4. 18 Sep, 2006 1 commit
  5. 06 Sep, 2006 4 commits
  6. 01 Sep, 2006 1 commit
    • unknown's avatar
      mtr_cases.pl: · 4e985aeb
      unknown authored
        Provide a more extensible, easier-to-change way of reordering
        test cases.
      
      
      mysql-test/lib/mtr_cases.pl:
        Provide a more extensible, easier-to-change way of reordering
        test cases.
      4e985aeb
  7. 15 Aug, 2006 1 commit
    • unknown's avatar
      Bug #20908: Crash if select @@"" · 0ad9cf96
      unknown authored
      Zero-length variables caused failures when using the length to look
      up the name in a hash.  Instead, signal that no zero-length name can
      ever be found and that to encounter one is a syntax error.
      
      
      mysql-test/r/variables.result:
        Results for test.
      mysql-test/t/variables.test:
        Insert tests to prove that zero-length variable names do not cause
        faults.
      sql/gen_lex_hash.cc:
        If the length is zero, then there is nothing to look-up in the 
        hash.
      sql/sql_lex.cc:
        Names of variables must not be empty.  Signal an error of that 
        happens.
      0ad9cf96
  8. 01 Aug, 2006 3 commits
    • unknown's avatar
      Applied innodb-5.0-ss677 snapshot. · bc7a1822
      unknown authored
      Fixes:
      - bug #19834: Using cursors when running in READ-COMMITTED can cause InnoDB to crash
      - bug #21112: InnoDB slow with > 100,000 .ibd files
      - bug #21113: Duplicate printout in SHOW INNODB STATUS
      
      
      innobase/fil/fil0fil.c:
        Applied innodb-5.0-ss677 snapshot.
          Make the tablespace cache hash size 100 or 1000 times bigger. Fixes bug #21112.
      innobase/ibuf/ibuf0ibuf.c:
        Applied innodb-5.0-ss677 snapshot.
          ibuf_print(): Don't print redundant information. Fixes bug #21113.
      sql/ha_innodb.cc:
        Applied innodb-5.0-ss677 snapshot.
          ha_innobase::start_stmt(): patch from Heikki:
          Do not call read_view_close_for_mysql().  (Bug #19834)
      bc7a1822
    • unknown's avatar
      Merge mysql.com:/users/lthalmann/bkroot/mysql-5.0 · 7b8a2f46
      unknown authored
      into  mysql.com:/users/lthalmann/bk/MERGE/mysql-5.0-merge
      
      7b8a2f46
    • unknown's avatar
      Merge mysql.com:/users/lthalmann/bk/MERGE/mysql-4.1-merge · 6be8a9f7
      unknown authored
      into  mysql.com:/users/lthalmann/bk/MERGE/mysql-5.0-merge
      
      6be8a9f7
  9. 31 Jul, 2006 2 commits
  10. 29 Jul, 2006 6 commits
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.1 · d55cc6b8
      unknown authored
      into  mysql.com:/Users/kent/mysql/bk/mysql-5.0
      
      
      configure.in:
        Auto merged
      d55cc6b8
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.0 · 5ae3d614
      unknown authored
      into  mysql.com:/Users/kent/mysql/bk/mysql-4.1
      
      
      configure.in:
        Auto merged
      5ae3d614
    • unknown's avatar
      configure.in: · 7991d78a
      unknown authored
        Corrected typo
      
      
      configure.in:
        Corrected typo
      7991d78a
    • unknown's avatar
      Fix after manual merge. · 56fce638
      unknown authored
      
      tests/mysql_client_test.c:
        Fix after manual merge: add test for bug#21206.
      56fce638
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/tmp_merge · 4028d6ea
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-merge
      
      
      configure.in:
        Auto merged
      man/Makefile.am:
        Auto merged
      mysys/my_bitmap.c:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/sql_locale.cc:
        Auto merged
      support-files/mysql.spec.sh:
        Auto merged
      mysql-test/t/mysqlbinlog.test:
        Manual merge.
      sql/sql_select.cc:
        Manual merge.
      4028d6ea
    • unknown's avatar
      udf_example.c, udf.test, Makefile.am: · 6b6c1724
      unknown authored
        Converted "udf_example.cc" to C, avoids C++ runtime lib dependency (bug#21336)
      
      
      sql/Makefile.am:
        "udf_example.cc" converted to C, avoids C++ runtime lib dependency (bug#21336)
      mysql-test/t/udf.test:
        "udf_example.cc" converted to C, avoids C++ runtime lib dependency (bug#21336)
      sql/udf_example.c:
        Changes to be strict ansi, except long long
      6b6c1724
  11. 28 Jul, 2006 9 commits
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.0 · 608d7e92
      unknown authored
      into  mysql.com:/Users/kent/mysql/bk/mysql-4.1
      
      
      configure.in:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      support-files/mysql.spec.sh:
        SCCS merged
      608d7e92
    • unknown's avatar
      Makefile.am, configure.in: · 4f0c394c
      unknown authored
        Man page for mysqld command move to section 8 (bug#21220)
      
      
      configure.in:
        Man page for mysqld command move to section 8 (bug#21220)
      man/Makefile.am:
        Man page for mysqld command move to section 8 (bug#21220)
      4f0c394c
    • unknown's avatar
      make_binary_distribution.sh: · 3423142a
      unknown authored
        Man page for "mysqld" command move to section 8 (bug#21220)
      
      
      scripts/make_binary_distribution.sh:
        Man page for "mysqld" command move to section 8 (bug#21220)
      3423142a
    • unknown's avatar
      mysql.spec.sh: · 00c97fe0
      unknown authored
        Man page for "mysqld" command move to section 8 (bug#21220)
      
      
      support-files/mysql.spec.sh:
        Man page for "mysqld" command move to section 8 (bug#21220)
      00c97fe0
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/tmp_merge · de11a26d
      unknown authored
      into  mysql.com:/Users/kent/mysql/bk/mysql-5.0-new
      
      
      netware/BUILD/mwasmnlm:
        Auto merged
      netware/BUILD/mwccnlm:
        Auto merged
      netware/BUILD/mwldnlm:
        Auto merged
      de11a26d
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · 40ea9e3f
      unknown authored
      into  mysql.com:/Users/kent/mysql/bk/mysql-5.0-new
      
      
      sql/sql_select.cc:
        Auto merged
      40ea9e3f
    • unknown's avatar
      sql_select.cc: · 342ae61d
      unknown authored
        Renamed variable, to avoid name clash with macro "rem_size"
        on AIX 5.3 and "/usr/include/sys/xmem.h" (bug#17648)
      asn.cpp, asn.hpp:
        Avoid name clash with NAME_MAX
      
      
      sql/sql_select.cc:
        Renamed variable, to avoid name clash with macro "rem_size"
        on AIX 5.3 and "/usr/include/sys/xmem.h" (bug#17648)
      extra/yassl/taocrypt/src/asn.cpp:
        Avoid name clash with NAME_MAX
      extra/yassl/taocrypt/include/asn.hpp:
        Avoid name clash with NAME_MAX
      342ae61d
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0 · b0b5fc60
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/global-50
      
      b0b5fc60
    • unknown's avatar
      Removing temporary changes. · 7c6110d8
      unknown authored
      7c6110d8
  12. 27 Jul, 2006 5 commits
    • unknown's avatar
    • unknown's avatar
      Revert the change after null-merge. · 155de819
      unknown authored
      
      mysys/my_bitmap.c:
        Revert the change forced during null-merge.
      155de819
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-release · 646f2216
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-main
      
      
      sql/sql_select.cc:
        Null-merge
      tests/mysql_client_test.c:
        Null-merge
      646f2216
    • unknown's avatar
      BUG#21206: memory corruption when too many cursors are opened at once · 23f3dd1d
      unknown authored
      Too many cursors (more than 1024) could lead to memory corruption.
      This affects both, stored routines and C API cursors, and the
      threshold is per-server, not per-connection.  Similarly, the
      corruption could happen when the server was under heavy load
      (executing more than 1024 simultaneous complex queries), and this is
      the reason why this bug is fixed in 4.1, which doesn't support
      cursors.
      
      The corruption was caused by a bug in the temporary tables code, when
      an attempt to create a table could lead to a write beyond allocated
      space.  Note, that only internal tables were affected (the tables
      created internally by the server to resolve the query), not tables
      created with CREATE TEMPORARY TABLE.  Another pre-condition for the
      bug is TRUE value of --temp-pool startup option, which, however, is a
      default.
      
      The cause of a bug was that random memory was overwritten in
      bitmap_set_next() due to out-of-bound memory access.
      
      
      mysys/my_bitmap.c:
        Local 'bitmap_size' is measured in bytes, no need to multiply it by 8.
      sql/sql_select.cc:
        Clear the temp_pool_slot bit only if we have set it previously.
      tests/mysql_client_test.c:
        Add test case for bug#21206: memory corruption when too many cursors
        are opened at once.
      23f3dd1d
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-release · d4922cff
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-main
      
      
      VC++Files/sql/mysqld.vcproj:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/r/warnings.result:
        Auto merged
      mysql-test/t/warnings-master.opt:
        Auto merged
      mysql-test/t/warnings.test:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      d4922cff
  13. 26 Jul, 2006 3 commits
    • unknown's avatar
      Merge siva.hindu.god:/usr/home/tim/m/bk/global-41 · 05373cfe
      unknown authored
      into  siva.hindu.god:/usr/home/tim/m/bk/global-50
      
      
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      sql/field.cc:
        Auto merged
      05373cfe
    • unknown's avatar
      BUG#21206: memory corruption when too many cursors are opened at once · 3fcef0c7
      unknown authored
      Too many cursors (more than 1024) could lead to memory corruption.
      This affects both, stored routines and C API cursors, and the
      threshold is per-server, not per-connection.  Similarly, the
      corruption could happen when the server was under heavy load
      (executing more than 1024 simultaneous complex queries), and this is
      the reason why this bug is fixed in 4.1, which doesn't support
      cursors.
      
      The corruption was caused by a bug in the temporary tables code, when
      an attempt to create a table could lead to a write beyond allocated
      space.  Note, that only internal tables were affected (the tables
      created internally by the server to resolve the query), not tables
      created with CREATE TEMPORARY TABLE.  Another pre-condition for the
      bug is TRUE value of --temp-pool startup option, which, however, is a
      default.
      
      The cause of a bug was that random memory was overwritten in
      bitmap_set_next() due to out-of-bound memory access.
      
      
      mysys/my_bitmap.c:
        Local 'bitmap_size' is measured in bytes, no need to multiply it by 8.
      sql/sql_select.cc:
        Clear the temp_pool_slot bit only if we have set it previously.
      3fcef0c7
    • unknown's avatar
      Applied innodb-5.0-ss660 snapshot. · 1c65e1f7
      unknown authored
      
      innobase/btr/btr0cur.c:
        Applied innodb-5.0-ss660 snapshot.
         btr_cur_search_to_nth_level(): Reacquire btr_search_latch after
         inserting to the insert buffer. This was noticed while analyzing
         Bug#19081 but this shold not fix this bug since according to
         Heikki, btr_search_latch is not reserved during an insert.
      innobase/ibuf/ibuf0ibuf.c:
        Applied innodb-5.0-ss660 snapshot.
         ibuf_fixed_addr_page(): Add parameter space. As the insert buffer
         B-tree is only located in the system tablespace (space 0),
         IBUF_TREE_ROOT_PAGE_NO is only special in space 0.
      innobase/include/sync0rw.ic:
        Applied innodb-5.0-ss660 snapshot.
         rw_lock_s_unlock_func(): Change a debug assertion to a
         production assertion in order to track down Bug#19081.
      1c65e1f7