1. 21 Jun, 2007 5 commits
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/50 · 6c70aa11
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      configure.in:
        Auto merged
      6c70aa11
    • unknown's avatar
      66e76447
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/bug28769/my50-bug28769 · 863e3da3
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.0-maint
      
      863e3da3
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/bug28742/my50-bug28742 · bd099cd8
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      bd099cd8
    • unknown's avatar
      Bug#24924: shared-memory-base-name that is too long causes buffer overflow · 26e9aba4
      unknown authored
      long shared-memory-base-names could overflow a static internal buffer
      and thus crash mysqld and various clients.  change both to dynamic
      buffers, show everything but overflowing those buffers still works.
      
      The test case for this would pretty much amount to
      mysqld --shared-memory-base-name=HeyMrBaseNameXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX --shared-memory=1 &
      mysqladmin --no-defaults --shared-memory-base-name=HeyMrBaseNameXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX shutdown
      
      Unfortunately, we can't just use an .opt file for the
      server. The .opt file is used at start-up, before any
      include in the actual test can tell mysqltest to skip
      this one on non-Windows. As a result, such a test would
      break on unices.
      
      Fixing mysql-test-run.pl to export full path for master
      and slave would enable us to start a server from within
      the test which is ugly and, what's more, doesn't work as
      the server blocks (mysqltest offers no fire-and-forget
      fork-and-exec), and mysqladmin never gets run.
      
      Making the test rpl_windows_shm or some such so we can
      is beyond ugly. As is introducing another file-name based
      special case (run "win*.test" only when on Windows). As is
      (yuck) coding half the test into mtr (as in, having it
      hand out a customized environment conductive to the shm-
      thing on Win only).
      
      Situation is exacerbated by the fact that .sh is not
      necessary run as expected on Win.
      
      In short, it's just not worth it. No test-case until we
      have a new-and-improved test framework.
      
      
      sql-common/client.c:
        Bug#24924: shared-memory-base-name that is too long causes buffer overflow
        
        compose shared memory name in dynamic rather than static buffer to prevent
        overflows (clients)
      sql/mysqld.cc:
        Bug#24924: shared-memory-base-name that is too long causes buffer overflow
        
        compose shared memory name in dynamic rather than static buffer to prevent
        overflows (server)
      26e9aba4
  2. 20 Jun, 2007 1 commit
    • unknown's avatar
      Bug#28742 mysql-test-run is very slow on "Stopping All Servers" step · 8c1c0ed1
      unknown authored
       - Improve shutdown algorithm 
       - Wait up to 5 seconds for processes to exit after their port is free
      
      
      mysql-test/lib/mtr_process.pl:
        Improve shutdown algorithm, shutdown the server hard
        if it hasn't responded to "mysqladmin shutdown" and it's port is free.
        Print error to servers error log indicating "hard shutdown"
        Give processes up to 5 seconds to exit after their port is free
      mysql-test/lib/mtr_report.pl:
        Indicate in what file the warning was found
      mysql-test/mysql-test-run.pl:
        Pass path of process error log to 'mtr_check_stop_servers'
      8c1c0ed1
  3. 19 Jun, 2007 8 commits
  4. 18 Jun, 2007 7 commits
    • unknown's avatar
      Bug #28921 Queries containing UDF functions are cached · 624d2d3d
      unknown authored
      Fixed runtime to no longer allow the caching of queries with UDF calls.
      
      
      mysql-test/r/udf.result:
        Added a test that turns on caching and checks that querys calling UDFs don't get cached.
      mysql-test/t/udf.test:
        Added a test that turns on caching and checks that querys calling UDFs don't get cached.
      sql/sql_yacc.yy:
        Fixed code to set safe_to_cache_query=0 regardless if the function call is a UDF or SP. Where it was placed previously -- at the very end of the else testing for UDFs -- it only executed the statement if the function call was a stored procedure call.
      624d2d3d
    • unknown's avatar
      Bug #29053 SQL_CACHE in UNION causes non-deterministic functions to be cached · f89957c7
      unknown authored
      Changed code to enforce that SQL_CACHE only in the first SELECT is used to turn on caching(as documented), but any SQL_NO_CACHE will turn off caching (not documented, but a useful behaviour, especially for machine generated queries). Added test cases to explicitly test the documented caching behaviour and test cases for the reported bug. 
      
      
      mysql-test/r/query_cache.result:
        Added non-bug specific tests that ensure that only SQL_CACHE in the first SELECT is respected when encountered by the parser. These tests validate what is already documented, that only the outer most SELECTS can use the SQL_CACHE option to turn on caching. Because it would break existing SQL applications, we do not return an error if the SQL_CACHE expression is found in nested SELECTs. Also added test to validate nested SELECT can contain SQL_NO_CACHE and it will always turn off caching for the whole query. 
        
        Also added a bug specific test case to validate that the buggy behavior as reported has been fixed.
      mysql-test/t/query_cache.test:
        Added non-bug specific tests that ensure that only SQL_CACHE in the first SELECT is respected when encountered by the parser. These tests validate what is already documented, that only the outer most SELECTS can use the SQL_CACHE option to turn on caching. Because it would break existing SQL applications, we do not return an error if the SQL_CACHE expression is found in nested SELECTs. Also added test to validate nested SELECT can contain SQL_NO_CACHE and it will always turn off caching for the whole query. 
        
        Also added a bug specific test case to validate that the buggy behavior as reported has been fixed.
      sql/sql_yacc.yy:
        Added an explicit check to make sure "SELECT SQL_CACHE" only works on the first select in a query.
        
        The parser will always hit the outermost SELECT first, and if the SQL_CACHE option is found it sets the safe_to_query flag in the lex. Then, if there are subseqent "uncachable" subqueries or functions, as it parses those elements it sets the safe_to_query to 0. However, this cause problems if nested SELECTs also used the SQL_CACHE option, because then it would set back safe_to_query to 1, even though there are uncacheable expressions previously parsed.
        
        By adding the check to ensure only the first SELECT can turn caching on, it means a subsequent SQL_CACHE option can't turn caching back on after a uncacheable subsequery was already encountered.
      f89957c7
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/41 · 60f23378
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      configure.in:
        Auto merged
      60f23378
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/50 · 88c218b3
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      88c218b3
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/41 · 3d46e759
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/41
      
      
      configure.in:
        Auto merged
      3d46e759
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0 · 5004acef
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/merge/mysql-5.0-engines
      
      5004acef
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.0 · 85c7cedd
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0
      
      85c7cedd
  5. 17 Jun, 2007 8 commits
  6. 16 Jun, 2007 3 commits
  7. 15 Jun, 2007 8 commits