1. 24 Jan, 2008 3 commits
  2. 21 Jan, 2008 1 commit
  3. 20 Jan, 2008 2 commits
  4. 19 Jan, 2008 3 commits
    • unknown's avatar
      Post-merge fixes. · 80857e0d
      unknown authored
      
      mysql-test/r/group_by.result:
        Post-merge fix after merging 5.0-opt to 5.1-opt.
      mysql-test/t/disabled.def:
        Disabled innodb_mysql back, bug #32724 is still not fixed.
      80857e0d
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 153771ed
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/type_decimal.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/type_decimal.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manual merge.
      mysql-test/t/group_by.test:
        Manual merge.
      mysql-test/t/subselect.test:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      153771ed
    • unknown's avatar
      Raise version number after cloning 5.1.23-rc · 37ff91b3
      unknown authored
      37ff91b3
  5. 18 Jan, 2008 2 commits
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 35b035cf
      unknown authored
      into  lamia.dupka:/home/mhansson/my50-bug33143-again-pushee
      
      
      35b035cf
    • unknown's avatar
      BUG#33794 "MySQL crashes executing specific query": · c71a6428
      unknown authored
      The problem occurred when one had a subquery that had an equality X=Y where 
      Y referred to a named select list expression from the parent select. MySQL 
      crashed when trying to use the X=Y equality for ref-based access. 
      
      Fixed by allowing non-Item_field items in the described case.
      
      
      mysql-test/r/subselect.result:
        BUG#33794 "MySQL crashes executing specific query"
        - Testcase
      mysql-test/t/subselect.test:
        BUG#33794 "MySQL crashes executing specific query"
        - Testcase
      sql/sql_select.cc:
        BUG#33794 "MySQL crashes executing specific query"
        get_store_key() assumed that if it got a reference
          t.key=Item_outer_ref(Item_direct_ref(x)) 
        then x was an Item_field object, which is not the case when one refers to a
        named select list expression out ot subquery.
      c71a6428
  6. 17 Jan, 2008 4 commits
    • unknown's avatar
      Bug#33067 · 8f3a0ea2
      unknown authored
        "Update of CSV row incorrect for some BLOBs"
        when reading in rows, move blob columns into temporary storage not
        allocated by Field_blob class or else row update operation will
        alter original row and make mysql think that nothing has been changed.
      fix incrementing wrong statistic values.
      
      
      mysql-test/r/csv.result:
        test for bug33067
      mysql-test/t/csv.test:
        test for bug33067
      storage/csv/ha_tina.cc:
        bug33067
          when reading in rows, move blob columns into temporary storage not
          allocated by Field_blob class or else row update operation will
          alter original row and make mysql think that nothing has been changed.
        fix incrementing wrong statistic values.
      storage/csv/ha_tina.h:
        bug33067
          new memroot attribute for blobs
      8f3a0ea2
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.1-opt · a4339cae
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug33143/my51-bug33143-pushee
      
      
      sql/item_func.cc:
        Auto merged
      mysql-test/r/type_decimal.result:
        Bug#33143: Manual merge
      mysql-test/t/type_decimal.test:
        Bug#33143: Manual merge
      a4339cae
    • unknown's avatar
      Merge linux-st28.site:/home/martin/mysql/src/bug33143/my50-bug33143-again · 92141cd4
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug33143/my51-bug33143
      
      
      mysql-test/r/type_decimal.result:
        Auto merged
      sql/item_func.cc:
        Auto merged
      strings/decimal.c:
        Auto merged
      92141cd4
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.0-opt · a22d1bf6
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug33143/my50-bug33143-again-pushee
      
      
      sql/item_func.cc:
        Auto merged
      mysql-test/r/type_decimal.result:
        Bug#33143: Manual merge
      mysql-test/t/type_decimal.test:
        Bug#33143: Manual merge
      a22d1bf6
  7. 16 Jan, 2008 4 commits
    • unknown's avatar
      Bug#32705 - myisam corruption: Key in wrong position · dd40d4ea
      unknown authored
                  at page 1024 with ucs2_bin
      Post merge fix
      
      
      dd40d4ea
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · 794753cd
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/t/ctype_ucs2_def.test:
        Auto merged
      mysql-test/t/myisam.test:
        Auto merged
      mysql-test/r/ctype_ucs2_def.result:
        SCCS merged
      mysql-test/r/myisam.result:
        SCCS merged
      794753cd
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-bug32705 · 8f7c42de
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      mysql-test/r/myisam.result:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Manual merge
      mysql-test/t/myisam.test:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Manual merge
      8f7c42de
    • unknown's avatar
      Bug#32705 - myisam corruption: Key in wrong position · 4fe64cf6
      unknown authored
                  at page 1024 with ucs2_bin
      Post-pushbuild fix.
      Moved test from myisam.test to ctype_ucs2_def.test.
      UCS2 is not always available.
      
      
      mysql-test/r/ctype_ucs2_def.result:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Moved test result from myisam.result to here.
      mysql-test/r/myisam.result:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Moved test result from here to ctype_ucs2_def.result.
      mysql-test/t/ctype_ucs2_def.test:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Moved test from myisam.test to here.
        UCS2 is not always available.
      mysql-test/t/myisam.test:
        Bug#32705 - myisam corruption: Key in wrong position
                    at page 1024 with ucs2_bin
        Moved test from here to ctype_ucs2_def.test.
        UCS2 is not always available.
      4fe64cf6
  8. 15 Jan, 2008 5 commits
    • unknown's avatar
      BUG#28884 - maybe a problem with malloc into base64.c · 082cfb87
      unknown authored
      Fixed that return value of malloc was not checked.
      Fixed wrong argument count (compilation failure) to base64_decode()
      function.
      
      Note:
      - there is no test case for this fix as this code is never compiled
        into mysql clients/server;
      - as this code is used for internal testing purposes only, no changelog
        entry needed.
      
      
      mysys/base64.c:
        Fixed that return value of malloc was not checked.
        Fixed wrong argument count to base64_decode function.
      082cfb87
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · 543cee3e
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/t/myisam.test:
        Auto merged
      storage/myisam/mi_open.c:
        Auto merged
      mysql-test/r/myisam.result:
        Manual merge from 5.0
      543cee3e
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-bug33222 · 99e49a34
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/t/myisam.test:
        Auto merged
      99e49a34
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-amain · 551ec2f7
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      551ec2f7
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-bug32705 · 18a7ec30
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      mysql-test/r/myisam.result:
        Manual merge from 4.1
      mysql-test/t/myisam.test:
        Manual merge from 4.1
      18a7ec30
  9. 14 Jan, 2008 2 commits
    • unknown's avatar
      Bug#33222 - myisam-table drops rows when column is added · c3bf7021
      unknown authored
                 and a char-field > 128 exists
      
      CHECK TABLE (non-QUICK) and any form of repair table did wrongly rate
      records as corrupted under the following conditions:
      1. The table has dynamic row format and
      2. it has a CHAR like column > 127 bytes (but not VARCHAR)
         (for multi-byte character sets this could be less than 127
         characters) and
      3. it has records with > 127 bytes significant length in that column
         (a byte beyond byte position 127 must be non-space).
      Affected were the statements CHECK TABLE, REPAIR TABLE, OPTIMIZE TABLE,
      ALTER TABLE. CHECK TABLE reported and marked the table as crashed if any
      record was present that fulfilled condition 3. The other statements
      deleted these records.
      
      The problem was a signed/unsigned compare in MyISAM code. A
      char to uchar change became necessary after the big byte to uchar
      change.
      
      
      mysql-test/r/myisam.result:
        Bug#33222 - myisam-table drops rows when column is added
                   and a char-field > 128 exists
        Added test result.
      mysql-test/t/myisam.test:
        Bug#33222 - myisam-table drops rows when column is added
                   and a char-field > 128 exists
        Added test.
      storage/myisam/mi_dynrec.c:
        Bug#33222 - myisam-table drops rows when column is added
                   and a char-field > 128 exists
        char -> uchar became necessary after big byte -> uchar change.
        Fixed some small coding style violations near the changes.
      c3bf7021
    • unknown's avatar
      Bug#33143: Incorrect ORDER BY for ROUND()/TRUNCATE() result · f9440588
      unknown authored
      The ROUND(X, D) function would change the Item::decimals field during
      execution to achieve the effect of a dynamic number of decimal digits.
      This caused a series of bugs:
      Bug #30617:Round() function not working under some circumstances in InnoDB
      Bug #33402:ROUND with decimal and non-constant cannot round to 0 decimal places
      Bug #30889:filesort and order by with float/numeric crashes server
      Fixed by never changing the number of shown digits for DECIMAL when
      used with a nonconstant number of decimal digits.
      
      
      mysql-test/r/type_decimal.result:
        Bug#33143: Test result
      mysql-test/t/type_decimal.test:
        Bug#33143: Test case
      sql/item_func.cc:
        Bug#33143: 
        - Moved the DECIMAL_MAX_SCALE limitation to fix_length_and_dec.
        - Removed resetting of Item::decimals field.
        - set the frac field of the output value to current scale.
      strings/decimal.c:
        Bug#33143: It is necessary to set all digits in the buffer following the 
        rounded one to zero, as they may now be displayed.
      f9440588
  10. 12 Jan, 2008 1 commit
  11. 11 Jan, 2008 10 commits
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · a034c714
      unknown authored
      into  lamia.dupka:/home/mhansson/my51-bug31797-pushee
      
      
      a034c714
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.1-opt · c37689f1
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug31797/my51-bug31797-pushee
      
      
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/t/group_by.test:
        Auto merged
      sql/item.cc:
        Auto merged
      c37689f1
    • unknown's avatar
      Merge linux-st28.site:/home/martin/mysql/src/bug31797/my50-bug31797 · ab0f3e46
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug31797/my51-bug31797
      
      
      sql/item.cc:
        Auto merged
      mysql-test/r/group_by.result:
        Bug#31797: Manual merge
      mysql-test/t/group_by.test:
        Bug#31797: Manual merge
      ab0f3e46
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.1-opt · 4ddfa7ba
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.1-opt-bug33697
      
      
      mysql-test/t/disabled.def:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      4ddfa7ba
    • unknown's avatar
      Fixed bug #33697. · d8363a40
      unknown authored
      When the function test_if_skip_sort_order prefers index backward scan 
      to ref access the corresponding access functions must be set accordingly.
      
      
      mysql-test/include/mix1.inc:
        Added a test case for bug #33697.
        Corrected one previous bad merge.
      mysql-test/r/innodb_mysql.result:
        Added a test case for bug #33697.
      mysql-test/t/disabled.def:
        Turned innodb_mysql test on.
      d8363a40
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.0-opt · 7bd7e988
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug31797/my50-bug31797-pushee
      
      
      sql/item.cc:
        Auto merged
      mysql-test/r/group_by.result:
        Bug#31797: Manual merge
      mysql-test/t/group_by.test:
        Bug#31797: Manual merge
      7bd7e988
    • unknown's avatar
      Bug#31797: error while parsing subqueries -- WHERE is parsed as HAVING · df8e9fc2
      unknown authored
      The name resolution for correlated subqueries and HAVING clauses
      failed to distinguish which of two was being performed when there 
      was a reference to an outer aliased field.
      Fixed by adding the condition that HAVING clause name resulotion
      is being performed.
      
      
      mysql-test/r/group_by.result:
        Bug#31797: Test result
      mysql-test/t/group_by.test:
        Bug#31797: Test case
      sql/item.cc:
        Bug#31797: 
        Corrected function comment.
        The fix, raising the error is restricted to HAVING name resolution.
      df8e9fc2
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.1-opt-33699 · d52a1a14
      unknown authored
      into  host.loc:/home/uchum/work/5.1-opt
      
      
      mysql-test/extra/rpl_tests/rpl_extraMaster_Col.test:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/suite/rpl/r/rpl_extraColmaster_innodb.result:
        Merge with local tree (bug#33699).
      mysql-test/suite/rpl/r/rpl_extraColmaster_myisam.result:
        Merge with local tree (bug#33699).
      d52a1a14
    • unknown's avatar
      Bug#29477: Not all fields of the target table were checked to have a default · 72ebb0aa
      unknown authored
      value when inserting into a view.
      
      The mysql_prepare_insert function checks all fields of the target table that
      directly or indirectly (through a view) are specified in the INSERT
      statement to have a default value. This check can be skipped if the INSERT
      statement doesn't mention any insert fields. In case of a view this allows
      fields that aren't mentioned in the view to bypass the check.
      
      Now fields of the target table are always checked to have a default value
      when insert goes into a view.
      
      
      mysql-test/t/view.test:
        Added a test case for the bug#29477: Not all fields of the target table were 
        checked to have a default value when inserting into a view.
      mysql-test/r/view.result:
        Added a test case for the bug#29477: Not all fields of the target table were 
        checked to have a default value when inserting into a view.
      sql/sql_insert.cc:
        Bug#29477: Not all fields of the target table were checked to have a default
        value when inserting into a view.
        Now fields of the target table are always checked to have a default value
        when insert goes into a view.
      72ebb0aa
    • unknown's avatar
      Bug#33699: The UPDATE statement allows NULL as new value on a NOT NULL · a114ede2
      unknown authored
      columns (default datatype value is assigned).
      
      The mysql_update function has been modified to generate
      an error when trying to set a NOT NULL field to NULL rather than a warning
      in the set_field_to_null_with_conversions function.
      
      
      
      mysql-test/extra/rpl_tests/rpl_extraMaster_Col.test:
        Updated test case (for bug#33699).
      mysql-test/include/ps_modify.inc:
        Updated test case (for bug#33699).
      mysql-test/r/auto_increment.result:
        Updated test case (for bug#33699).
      mysql-test/r/null.result:
        Updated test case (for bug#33699).
      mysql-test/r/ps_2myisam.result:
        Updated test case (for bug#33699).
      mysql-test/r/ps_3innodb.result:
        Updated test case (for bug#33699).
      mysql-test/r/ps_4heap.result:
        Updated test case (for bug#33699).
      mysql-test/r/ps_5merge.result:
        Updated test case (for bug#33699).
      mysql-test/r/warnings.result:
        Updated test case (for bug#33699).
      mysql-test/suite/ndb/r/ps_7ndb.result:
        Updated test case (for bug#33699).
      mysql-test/suite/rpl/r/rpl_extraColmaster_innodb.result:
        Updated test case (for bug#33699).
      mysql-test/suite/rpl/r/rpl_extraColmaster_myisam.result:
        Updated test case (for bug#33699).
      mysql-test/suite/rpl/t/rpl_err_ignoredtable.test:
        Updated test case (for bug#33699).
      mysql-test/t/auto_increment.test:
        Updated test case (for bug#33699).
      mysql-test/t/null.test:
        Updated test case (for bug#33699).
      mysql-test/t/warnings.test:
        Updated test case (for bug#33699).
      sql/sql_update.cc:
        Bug#33699: The mysql_update function has been modified to generate
        an error when trying to set a NOT NULL field to NULL rather than
        a warning in the set_field_to_null_with_conversions function.
      tests/mysql_client_test.c:
        Updated test case (for bug#33699).
      a114ede2
  12. 10 Jan, 2008 3 commits
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 8a757010
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      8a757010
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-5.1 · 824ced46
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      client/mysqltest.c:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/repl_failsafe.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      824ced46
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-5.0 · 84762ce2
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      
      client/mysql.cc:
        Auto merged
      84762ce2