1. 01 Oct, 2006 3 commits
  2. 30 Sep, 2006 1 commit
  3. 29 Sep, 2006 13 commits
    • unknown's avatar
      BUG#14940: Update test results · ca2372d7
      unknown authored
      ca2372d7
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · 8b833dc9
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-arch
      
      8b833dc9
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 4fbdc1c3
      unknown authored
      into  mysql.com:/home/psergey/mysql-5.1-bug14940-r10a
      
      
      sql/sql_select.cc:
        Auto merged
      4fbdc1c3
    • unknown's avatar
      Remove empty line · ea930263
      unknown authored
      ea930263
    • unknown's avatar
      merge fixes · edd34f68
      unknown authored
      
      mysql-test/t/view.test:
        moved the new error message last
      sql/share/errmsg.txt:
        moved the new error message last
      edd34f68
    • unknown's avatar
      Merge mysql.com:/home/hf/work/21888/my50-21888 · 51969424
      unknown authored
      into  mysql.com:/home/hf/work/21888/my51-21888
      
      
      mysql-test/r/gis-rtree.result:
        Auto merged
      storage/myisam/mi_range.c:
        Auto merged
      51969424
    • unknown's avatar
      Merge mysql.com:/home/hf/work/21888/my41-21888 · 4de46b74
      unknown authored
      into  mysql.com:/home/hf/work/21888/my50-21888
      
      
      myisam/mi_range.c:
        Auto merged
      mysql-test/r/gis-rtree.result:
        Auto merged
      mysql-test/t/gis-rtree.test:
        Auto merged
      4de46b74
    • unknown's avatar
      bug #21888 (Query on GEOMETRY field crashes the server) · 3950ce57
      unknown authored
      RTree keys are really different from BTree and need specific
      paramters to be set by optimizer to work.
      Sometimes optimizer doesn't set those properly.
      Here we decided just to add code to check that the parameters
      are correct. Hope to fix optimizer sometimes.
      
      
      myisam/mi_range.c:
        return the error if min_key is NULL
      mysql-test/r/gis-rtree.result:
        test result
      mysql-test/t/gis-rtree.test:
        test case
      3950ce57
    • unknown's avatar
      BUG#14940: Slow join order is chosen: [2nd commit with post-review fixes] · aeafddc5
      unknown authored
      - Re-worked the prev_record_reads() function to return the lower bound of
        number of different table access scans that will be performed.
      
      
      mysql-test/r/join.result:
        BUG#14940: testcase
      mysql-test/t/join.test:
        BUG#14940: testcase
      sql/sql_select.cc:
        BUG#14940: Slow join order is chosen: 
        - Re-worked the prev_record_reads() function to return the lower bound of
          number of different table access scans that will be performed.
      sql/sql_select.h:
        BUG#14940: Slow join order is chosen:
        - Added comments in struct POSITION
        - Added POSITION::ref_depend_map: bitmap of tables that the table access
          method depends on.
      aeafddc5
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt · d3612560
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      d3612560
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · d5ea425a
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      d5ea425a
    • unknown's avatar
      Merge mysql.com:/home/hf/work/16813/my50-16813 · c8d8e8a6
      unknown authored
      into  mysql.com:/home/hf/work/16813/my51-16813
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/table.cc:
        Auto merged
      c8d8e8a6
    • unknown's avatar
      bug #16813 (WITH CHECK OPTION fails with UPDATE) · b0a8acab
      unknown authored
      We use the condition from CHECK OPTION twice handling UPDATE command.
      First we construnct 'update_cond' AND 'option_cond'
      condition to select records to be updated, then we check the
      'option_cond' for the updated row.
      The problem is that first 'AND' condition is optimized during the 'select'
      which can break 'option_cond' structure, so it will be unusable for
      the sectond use - to check the updated row.
      Possible soultion is either use copy of the condition in the first
      use or to make optimization less traumatic for the operands.
      I picked the first one. 
      
      
      mysql-test/r/view.result:
        result fixed
      mysql-test/t/view.test:
        testcase
      sql/table.cc:
        now we use the copy of the CHECK OPTION condition to construct
        the select's condition
      b0a8acab
  4. 28 Sep, 2006 18 commits
    • unknown's avatar
      view.test: · 669d8a6f
      unknown authored
        After merge fix
      
      
      mysql-test/t/view.test:
        After merge fix
      669d8a6f
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 024f93c5
      unknown authored
      into  moonbone.local:/work/5505-bug-5.0-opt-mysql
      
      
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      mysql-test/r/view.result:
        Manual merge
      mysql-test/t/view.test:
        Manual merge
      024f93c5
    • unknown's avatar
      Fixed bug#5505: Wrong error message on INSERT into a view · 9cf17a35
      unknown authored
      On an INSERT into an updatable but non-insertable view an error message was
      issued stating the view being not updatable. This can lead to a confusion of a
      user.
      
      A new error message is introduced. Is is showed when a user tries to insert
      into a non-insertable view.
      
      
      sql/sql_base.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        The update_non_unique_table_error() function now issues proper
        error for an INSERT.
      sql/sql_insert.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Issue the ER_NON_INSERTABLE_TABLE error instead of the 
        ER_NON_UPDATABLE_TABLE on insert into a view.
      sql/sql_view.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Issue the ER_NON_INSERTABLE_TABLE error instead of the
        ER_NON_UPDATABLE_TABLE on insert into a view.
      mysql-test/r/view.result:
        Added the test case for bug#5505: Wrong error message on INSERT into a view
        Corrected a few test cases after fixing bug#5505
      mysql-test/t/view.test:
        Added the test case for bug#5505: Wrong error message on INSERT into a view
        Corrected a few test cases after fixing bug#5505
      sql/share/errmsg.txt:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Added the ER_NON_INSERTABLE_TABLE error definition.
      9cf17a35
    • unknown's avatar
      Merge baker@bk-internal.mysql.com:/home/bk/mysql-5.1-arch · e84a740a
      unknown authored
      into  zim.(none):/home/brian/mysql/merge-5.1
      
      
      sql/handler.h:
        Auto merged
      e84a740a
    • unknown's avatar
      Merge baker@bk-internal.mysql.com:/home/bk/mysql-5.1 · 782ae6d9
      unknown authored
      into  zim.(none):/home/brian/mysql/merge-5.1
      
      
      storage/csv/ha_tina.cc:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      782ae6d9
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1 · e9b342ce
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      e9b342ce
    • unknown's avatar
      after merge fix · 30b0b572
      unknown authored
      30b0b572
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · e039d51d
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/mysql_priv.h:
        Auto merged
      e039d51d
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-opt · e43692a1
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/item.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      e43692a1
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · edde4890
      unknown authored
      into  moonbone.local:/work/18360-bug-5.1-opt-mysql
      
      
      mysql-test/t/view.test:
        Auto merged
      sql/item.cc:
        Auto merged
      edde4890
    • unknown's avatar
      Merge gbichot@bk-internal:/home/bk/mysql-5.1-arch · 6b7be4b5
      unknown authored
      into  dl145h.mysql.com:/users/gbichot/mysql-5.1-arch
      
      
      storage/innobase/handler/ha_innodb.cc:
        Auto merged
      6b7be4b5
    • unknown's avatar
      In the handlerton, cursor creation function don't have an argument · 62d6a1b0
      unknown authored
      and so the engine calls current_thd to derive transaction information;
      instead we now pass THD to those functions, it looks more logical
      (it makes the implicit current_thd parameter more visible).
      Approved by Brian and Monty.
      
      
      sql/handler.h:
        cursor's creation functions in the handlerton need a THD,
        it's better than have the engine call current_thd
      sql/sql_cursor.cc:
        pass the THD instead of letting the engine call current_thd
      storage/innobase/handler/ha_innodb.cc:
        use the passed THD instead of current_thd
      storage/innobase/handler/ha_innodb.h:
        use the passed THD instead of current_thd
      62d6a1b0
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0 · ded8eed1
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1
      
      
      include/mysql_com.h:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/type_date.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_repl.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/sp.cc:
        manual merge
      sql/sp_head.cc:
        manual merge
      sql/sql_class.h:
        manual merge
      sql/table.cc:
        manual merge
      ded8eed1
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-5.1 · 5f7aeede
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/field.h:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      5f7aeede
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt · 1b744c77
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      1b744c77
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-5.0 · 757c5dcf
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      757c5dcf
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-4.1 · e2452943
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      e2452943
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.1 · 614235d5
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/5.1-runtime-new
      
      
      sql/handler.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/r/sp.result:
        manual merge
      mysql-test/t/sp.test:
        manual merge
      storage/csv/ha_tina.cc:
        manual merge
      storage/myisam/ha_myisam.cc:
        manual merge
      614235d5
  5. 27 Sep, 2006 5 commits