1. 13 Jan, 2023 7 commits
  2. 12 Jan, 2023 6 commits
  3. 11 Jan, 2023 8 commits
    • Monty's avatar
      MDEV-30345 DML does not find rows it is supposed to · f3d8a546
      Monty authored
      This only happens with 'timestamp_column IN (select ...)
      
      The reason was a missing assignment in Item_cache_timestamp::cache_value()
      f3d8a546
    • Brandon Nesterenko's avatar
      MDEV-25277: mysqlbinlog --verbose cannot read row events with compressed... · b194c83b
      Brandon Nesterenko authored
      MDEV-25277: mysqlbinlog --verbose cannot read row events with compressed columns: Don't know how to handle column type: 140
      
      Problem:
      =======
      Mysqlbinlog cannot show the type of a compressed
      column when two levels of verbosity is provided.
      
      Solution:
      ========
      Extend the log event printing logic to handle and
      tag compressed types.
      
      Behavioral Changes:
      ==================
        Old: When mysqlbinlog is called in verbose mode and
      the database uses compressed columns, an error is
      returned to the user.
      
        New: The output will append “ COMPRESSED” on the
      type of compressed columns
      
      Reviewed By
      ===========
      Andrei Elkin <andrei.elkin@mariadb.com>
      b194c83b
    • Monty's avatar
      MDEV-30373 Wrong result with range access · 7d1df207
      Monty authored
      This issue was caused by the bug fix for
      MDEV-30325 Wrong result upon range query using index condition
      
      The bug could happen in the case of several overlapping key ranges
      with OR
      7d1df207
    • Julius Goryavsky's avatar
      MDEV-30220: rsync SST completely ignores aria-log-dir-path · 53c4be7b
      Julius Goryavsky authored
      This commit adds support for the --aria-log-dir-path
      option on the command line and for the aria-log-dir-path
      option in the configuration file to the SST scripts, since
      before this change these parameters were completely ignored
      during SST - SST scripts assumed that aria logs files are
      always located in the same directory as logs for innodb.
      
      Tests for this change will be added as a separate commit,
      along with tests for MDEV-30157 and MDEV-28669.
      53c4be7b
    • Julius Goryavsky's avatar
      MDEV-30157: Galera SST doesn't properly handle undo* files from innodb · b84f3fa7
      Julius Goryavsky authored
      This fix adds separate handling for "undo*" files that contain undo
      logs as part of innodb files and adds a filter for undo* to the main
      filter used when initially transferring files with rsync.
      b84f3fa7
    • Julius Goryavsky's avatar
      pre-MDEV-30157 & pre-MDEV-28669: fixes before the main corrections · e4a4aad7
      Julius Goryavsky authored
      This commit adds even more correct handling of parameters
      with paths when they contain leading or trailing spaces and/or
      slashes. Also it fixes problems that occur when the user specified
      explicit paths to additional directories, but these paths match
      the specified path of the data directory - in this case, additional
      subdirectories should be treated (in relation to the data directory)
      in the same way as if these paths were not specified or as if they
      are implicitly specified as "." or "./". But prior to this fix,
      existing code treated any values as if they were completely
      separate directories, whether or not they actually point to the
      same location to which datadir points to - and this sometimes
      resulted in incorrect file transfers.
      
      This fix does not contain separate tests, as tests will be
      part of the main commit(s). This fix has been made as a separate
      commit to facilitate review for major substantive fixes related
      to MDEV-30157 and MDEV-28669.
      e4a4aad7
    • Sergei Petrunia's avatar
      MDEV-28602 Wrong result with outer join, merged derived table and view · b928c849
      Sergei Petrunia authored
      (Variant 3, initial variant was by Rex Jonston)
      
      A LEFT JOIN with a constant as a column of the inner table produced wrong
      query result if the optimizer had to write the inner table column into a
      temp table. Query pattern:
      
        SELECT ...
        FROM (SELECT /*non-mergeable select*/
              FROM t1 LEFT JOIN (SELECT 'Y' as Val) t2 ON ...) as tbl
      
      Fixed this by adding Item_direct_view_ref::save_in_field() which follows
      the pattern of Item_direct_view_ref's save_org_in_field(),
      save_in_result_field() and val_XXX() functions:
      * call check_null_ref() and handle NULL value
      * if we didn't get a NULL-complemented row, call Item_direct_ref's function.
      b928c849
    • Marko Mäkelä's avatar
      Remove an unused parameter · b218dfea
      Marko Mäkelä authored
      lock_rec_has_to_wait(): Remove the unused parameter for_locking
      that had been originally added
      in commit df4dd593
      b218dfea
  4. 10 Jan, 2023 8 commits
    • Sergei Golubchik's avatar
      Merge branch '10.3' into 10.4 · fdcfc251
      Sergei Golubchik authored
      fdcfc251
    • Daniel Black's avatar
      clang15 warnings - unused vars and old prototypes · 56948ee5
      Daniel Black authored
      clang15 finally errors on old prototype definations.
      
      Its also a lot fussier about variables that aren't used
      as is the case a number of time with loop counters that
      aren't examined.
      
      RocksDB was complaining that its get_range function was
      declared without the array length in ha_rocksdb.h. While
      a constant is used rather than trying to import the
      Rdb_key_def::INDEX_NUMBER_SIZE header (was causing a lot of
      errors on the defination of other orders). If the constant
      does change can be assured that the same compile warnings will
      tell us of the error.
      
      The ha_rocksdb::index_read_map_impl DBUG_EXECUTE_IF was similar
      to the existing endless functions used in replication tests.
      Its rather moot point as the rocksdb.force_shutdown test that
      uses myrocks_busy_loop_on_row_read is currently disabled.
      56948ee5
    • Marko Mäkelä's avatar
      Merge 10.9 into 10.10 · cae5a032
      Marko Mäkelä authored
      cae5a032
    • Marko Mäkelä's avatar
      Merge 10.8 into 10.9 · 820ebcec
      Marko Mäkelä authored
      820ebcec
    • Marko Mäkelä's avatar
      Merge 10.7 into 10.8 · 92c8d6f1
      Marko Mäkelä authored
      The MDEV-25004 test innodb_fts.versioning is omitted because ever since
      commit 685d958e InnoDB would not allow
      writes to a database where the redo log file ib_logfile0 is missing.
      92c8d6f1
    • Marko Mäkelä's avatar
      Merge 10.6 into 10.7 · ab36eac5
      Marko Mäkelä authored
      ab36eac5
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 56c9b0bc
      Marko Mäkelä authored
      56c9b0bc
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-30179 mariabackup --backup fails with FATAL ERROR: ... failed · 17858e03
      Thirunarayanan Balathandayuthapani authored
      			to copy datafile
      
      - Mariabackup fails to copy the undo log tablespace when it undergoes
      truncation. So Mariabackup should detect the redo log which does
      undo tablespace truncation and also backup should read the minimum
      file size of the tablespace and ignore the error while reading.
      
      - Throw error when innodb undo tablespace read failed, but backup
      doesn't find the redo log for undo tablespace truncation
      17858e03
  5. 09 Jan, 2023 8 commits
  6. 07 Jan, 2023 1 commit
  7. 06 Jan, 2023 2 commits
    • Igor Babaev's avatar
      MDEV-27624 Wrong result for nested left join using not_exists optimization · b21832ef
      Igor Babaev authored
      This bug affected queries with nested left joins having the same last inner
      table such that not_exists optimization could be applied to the most inner
      outer join when optimizer chose to use join buffers. The bug could lead to
      producing wrong a result set.
      If the WHERE condition a query contains a conjunctive IS NULL predicate
      over a non-nullable column of an inner table of a not nested outer join
      then not_exists optimization can be applied to tho the outer join. With
      this optimization when looking for matches for a certain record from the
      outer table of the join the records of the inner table can be ignored
      right after the first match satisfying the ON condition is found.
      In the case of nested outer joins having the same last inner table this
      optimization still can be applied but only if all ON conditions of the
      embedding outer joins are satisfied. Such check was missing in the code
      that tried to apply not_exists optimization when join buffers were used
      for outer join operations.
      This problem has been already fixed in the patch for bug MDEV-7992. Yet
      there it was resolved only for the cases when join buffers were not used
      for outer joins.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      b21832ef
    • Haidong Ji's avatar
      MDEV-17093: SOURCE_REVISION in log and handle_fatal_signal · af0ff8b4
      Haidong Ji authored
      MariaDB MDEV-12583 added `SOURCE_REVISION` variable that exposes the
      SHA1 of source code commit that the current running engine was built
      from. This info is useful for troubleshooting and debugging.
      
      This commit does the following:
      - addes the `SOURCE_REVISION` value into engine error log.
      - when a crash triggers handle_fatal_signal, the `SOURCE_REVISION` will
        be included in crash report.
      - resolves MDEV-20344: startup messages belong in stderr/error-log not
        stdout
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the
      BSD-new license.  I am contributing on behalf of my employer Amazon Web
      Services, Inc.
      af0ff8b4