1. 14 Nov, 2007 1 commit
    • gshchepa/uchum@gleb.loc's avatar
      Fixed bug #32034: On 64bit platforms assigning values of · 70f36562
      gshchepa/uchum@gleb.loc authored
      storage engine system variables was not validated and
      unexpected value was assigned.
      
      The check_func_enum function used subtraction from the uint
      value with the probably negative result. That result of
      type uint was compared with 0 after casting to signed long
      type. On architectures where long type is longer than int
      type the result of comparison was unexpected.
      70f36562
  2. 13 Nov, 2007 5 commits
  3. 12 Nov, 2007 10 commits
  4. 11 Nov, 2007 2 commits
  5. 10 Nov, 2007 21 commits
  6. 09 Nov, 2007 1 commit
    • kaa@polly.(none)'s avatar
      Fix for bug #32202: ORDER BY not working with GROUP BY · 8c193678
      kaa@polly.(none) authored
      The bug is a regression introduced by the fix for bug30596. The problem
      was that in cases when groups in GROUP BY correspond to only one row,
      and there is ORDER BY, the GROUP BY was removed and the ORDER BY
      rewritten to ORDER BY <group_by_columns> without checking if the
      columns in GROUP BY and ORDER BY are compatible. This led to
      incorrect ordering of the result set as it was sorted using the
      GROUP BY columns. Additionaly, the code discarded ASC/DESC modifiers
      from ORDER BY even if its columns were compatible with the GROUP BY
      ones.
      
      This patch fixes the regression by checking if ORDER BY columns form a
      prefix of the GROUP BY ones, and rewriting ORDER BY only in that case,
      preserving the ASC/DESC modifiers. That check is sufficient, since the
      GROUP BY columns contain a unique index.
      8c193678