1. 17 Mar, 2005 4 commits
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 71cd1f9d
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/MySQL-MERGE/mysql-5.0
      
      71cd1f9d
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · b5bdb802
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/MySQL-MERGE/mysql-5.0
      
      b5bdb802
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 8d55ca32
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.0
      
      
      sql/handler.cc:
        Auto merged
      sql/lock.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      8d55ca32
    • unknown's avatar
      Fixed two bugs in MySQL ACL. · 5de05a3a
      unknown authored
      First one is related to Bug#7905. One should not be allowed to
      create new user with password without UPDATE privilege to
      MySQL database. Furthermore, executing the same GRANT statement
      twice would actually crash the server and corrupt privilege database.
      
      Other bug was that one could update a column, using the existing
      value as basis to calculate the new value (e.g. UPDATE t1 SET a=a+1)
      without SELECT privilege to the field (a in the above example)
      
      Fixed tests grant.pl and grant2, which were wrong.
      
      5de05a3a
  2. 16 Mar, 2005 36 commits
    • unknown's avatar
      Merge with global tree · 0436eb08
      unknown authored
      
      mysql-test/r/federated.result:
        merge
      sql/ha_federated.cc:
        merge
      0436eb08
    • unknown's avatar
      Move handler dependent tests to the specific handler (myisam, bdb, innodb) · de53c2b3
      unknown authored
      Enabled VARCHAR testing for innodb
      
      NOTE: innodb.test currently fails becasue of a bug in InnoDB. 
      I have informed Heikki about this and expect him to fix this ASAP
      
      
      mysql-test/include/varchar.inc:
        Move handler dependent tests to the specific handler (myisam, bdb, innodb)
      mysql-test/r/innodb.result:
        Added varchar tests
      mysql-test/r/myisam.result:
        Update results
      mysql-test/t/bdb.test:
        Move handler dependent tests to the specific handler (myisam, bdb, innodb)
      mysql-test/t/innodb.test:
        Enabled VARCHAR testing
      mysql-test/t/myisam.test:
        Move handler dependent tests to the specific handler (myisam, bdb, innodb)
      sql/sql_parse.cc:
        Indentation fixes
      sql/sql_table.cc:
        Fixed bug introduced when doing cleanup
      de53c2b3
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 157e3ada
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      sql/item_func.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      157e3ada
    • unknown's avatar
      Merge pgalbraith@bk-internal.mysql.com:/home/bk/mysql-5.0 · 292edcdd
      unknown authored
      into krsna.:/home/patg/test/mysql-5.0
      
      292edcdd
    • unknown's avatar
      Fixed binlog.test failure which occured after patch implementing · b32ecfc4
      unknown authored
      WL#874 "Extended LOAD DATA" was pushed.
      
      
      mysql-test/r/binlog.result:
        Addition of two new types of binary log events shifted binlog positions.
        Updated test's results and made it more robust for future similar
        changes.
      mysql-test/t/binlog.test:
        Addition of two new types of binary log events shifted binlog positions.
        Updated test's results and made it more robust for future similar
        changes.
      b32ecfc4
    • unknown's avatar
      Merge pgalbraith@bk-internal.mysql.com:/home/bk/mysql-5.0 · 0505c67e
      unknown authored
      into krsna.:/home/patg/test/mysql-5.0
      
      0505c67e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · b09934b1
      unknown authored
      into pcgem.rdg.cyberkinetica.com:/var/db/bk/work-acurtis/bug8670.3
      
      b09934b1
    • unknown's avatar
      Merge pcgem.rdg.cyberkinetica.com:/var/db/bk/work-acurtis/bug8670.2 · 0feec36b
      unknown authored
      into pcgem.rdg.cyberkinetica.com:/var/db/bk/work-acurtis/bug8670.3
      
      
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      0feec36b
    • unknown's avatar
      data0data.c: · 316f2d66
      unknown authored
        Allow also long VARCHARs to be stored externally, not just BLOBs; fixes a bug reported by Trudy Pelzer; needs more testing
      
      
      innobase/data/data0data.c:
        Allow also long VARCHARs to be stored externally, not just BLOBs; fixes a bug reported by Trudy Pelzer; needs more testing
      316f2d66
    • unknown's avatar
    • unknown's avatar
      Merge pgalbraith@bk-internal.mysql.com:/home/bk/mysql-5.0 · 7a5f168f
      unknown authored
      into krsna.:/home/patg/test/mysql-5.0
      
      7a5f168f
    • unknown's avatar
      Small fix to innodb.test that Heikki probably simply forgot to commit. · 84e9ab66
      unknown authored
      
      mysql-test/r/innodb.result:
        Added proper cleanup after test.
      mysql-test/t/innodb.test:
        We don't expect error if we create varchar(16384) column in Innodb
        table anymore. (Heikki already removed error message from .result
        file.) Also we should do proper cleanup after the test.
      84e9ab66
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · a8a49be2
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/MySQL-MERGE/mysql-5.0
      
      a8a49be2
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 01222e08
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/MySQL-MERGE/mysql-5.0
      
      01222e08
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · aa31ea79
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-5.0-eld-exp
      
      aa31ea79
    • unknown's avatar
      Cleanup during reviews · 1637a873
      unknown authored
      Removed some optional arguments
      Fixed portability problem in federated tests
      
      
      client/sql_string.cc:
        update from sql/sql_string.cc
      client/sql_string.h:
        update from sql/sql_string.h
      mysql-test/r/federated.result:
        Fixed error message
      sql/field.cc:
        Cleanup during review
        Remove const in 'const unsigned int'
      sql/field.h:
        Remove const in 'const unsigned int'
      sql/ha_federated.cc:
        Better error string.  Add missing argument to error (before 'errno' was picked up from stack)
      sql/handler.cc:
        Removed compiler warning
      sql/item_func.cc:
        Cleanup during review
      sql/item_sum.cc:
        Cleanup during review
      sql/lock.cc:
        Remove optional arguments
      sql/log_event.cc:
        Remove optional arguments
      sql/mysql_priv.h:
        Remove optional arguments
        cahnge preapre_create_fields to use pointers instead of references
      sql/opt_range.cc:
        Fix arguments so that return value is last
      sql/sql_base.cc:
        Remove optional arguments
      sql/sql_delete.cc:
        Remove optional arguments
      sql/sql_error.cc:
        Remove optional arguments
      sql/sql_help.cc:
        Remove optional arguments
      sql/sql_parse.cc:
        Remove optional arguments
      sql/sql_prepare.cc:
        Remove optional arguments
      sql/sql_rename.cc:
        Remove optional arguments
      sql/sql_select.cc:
        Remove optional arguments
      sql/sql_show.cc:
        Cleanup during review
      sql/sql_string.cc:
        Simple optimization
      sql/sql_table.cc:
        Remove optional arguments
        Fixed indentation
      sql/sql_update.cc:
        Remove optional arguments
      sql/sql_yacc.yy:
        Change references to pointers
      1637a873
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 84f259a4
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-5.0-eld-exp
      
      84f259a4
    • unknown's avatar
      subselect2.result: · aeba80b7
      unknown authored
        Update key lengths in EXPLAIN to reflect true VARCHARs
      
      
      mysql-test/r/subselect2.result:
        Update key lengths in EXPLAIN to reflect true VARCHARs
      aeba80b7
    • unknown's avatar
      ha_innodb.cc: · e4c10e5d
      unknown authored
        Fix bug: InnoDB created all indexes on true VARCHARs as column prefix keys because field->pack_length() for a true VARCHAR is bigger than key_part->length; FOREIGN KEYs could not be created on true VARCHARs then
      
      
      sql/ha_innodb.cc:
        Fix bug: InnoDB created all indexes on true VARCHARs as column prefix keys because field->pack_length() for a true VARCHAR is bigger than key_part->length; FOREIGN KEYs could not be created on true VARCHARs then
      e4c10e5d
    • unknown's avatar
      data0type.h, row0sel.c: · e5c76f5b
      unknown authored
        Fix a crash in a simple search with a key: the dtype->len of a true VARCHAR is the payload maximum len in bytes: it does not include the 2 bytes MySQL uses to store the string length
      ha_innodb.cc:
        Fix a crash in true VARCHARs in test-innodb: we passed a wrong pointer to the column conversion in an UPDATE
      rowid_order_innodb.result, ps_3innodb.result, innodb.result, endspace.result:
        Edit InnoDB test results to reflect the arrival of true VARCHARs
      
      
      mysql-test/r/endspace.result:
        Edit InnoDB test results to reflect the arrival of true VARCHARs
      mysql-test/r/innodb.result:
        Edit InnoDB test results to reflect the arrival of true VARCHARs
      mysql-test/r/ps_3innodb.result:
        Edit InnoDB test results to reflect the arrival of true VARCHARs
      mysql-test/r/rowid_order_innodb.result:
        Edit InnoDB test results to reflect the arrival of true VARCHARs
      sql/ha_innodb.cc:
        Fix a crash in true VARCHARs in test-innodb: we passed a wrong pointer to the column conversion in an UPDATE
      innobase/row/row0sel.c:
        Fix a crash in a simple search with a key: the dtype->len of a true VARCHAR is the payload maximum len in bytes: it does not include the 2 bytes MySQL uses to store the string length
      innobase/include/data0type.h:
        Fix a crash in a simple search with a key: the dtype->len of a true VARCHAR is the payload maximum len in bytes: it does not include the 2 bytes MySQL uses to store the string length
      e5c76f5b
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 2912e0f1
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/MySQL-MERGE/mysql-5.0
      
      2912e0f1
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 725b7604
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/MySQL-MERGE/mysql-5.0
      
      725b7604
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · babb4f05
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/MySQL-MERGE/mysql-5.0
      
      babb4f05
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0 · 1097f773
      unknown authored
      into mysql.com:/usr/local/home/marty/MySQL/mysql-5.0
      
      1097f773
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-4.1 · da125e26
      unknown authored
      into mysql.com:/usr/local/home/marty/MySQL/mysql-5.0
      
      da125e26
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 592ee30c
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      592ee30c
    • unknown's avatar
      DATA_MYSQL_TRUE_VARCHAR can be DATA_VARCHAR, DATA_BINARY, or · b399fe8b
      unknown authored
      DATA_VARMYSQL so remove unnecessary condition.
      
      
      b399fe8b
    • unknown's avatar
      Fixed behavior of LOAD DATA with subqueries in SET clause. · b5a176a5
      unknown authored
      The idea is to use TABLE_LIST::lock_type for passing type of lock for
      target table to mysql_load() instead of using LEX::lock_option 
      (which were rewritten by first subselect in SET clause).
      
      This should also fix potential problem with LOAD DATA in SP
      (it is important for them to have right lock_type in the table
       list by the end of statement parsing).
      
      
      mysql-test/r/loaddata.result:
        Added nice test for LOAD DATA with subquery.
      mysql-test/t/loaddata.test:
        Added nice test for LOAD DATA with subquery.
      sql/log_event.cc:
        Now we don't pass type of lock for target table to mysql_load()
        explicitly . Instead we use TABLE_LIST::lock_type for this table
        which is already properly set here.
      sql/mysql_priv.h:
        Now we don't pass type of lock for target table to mysql_load()
        explicitly . Instead we properly set TABLE_LIST::lock_type for
        this table in parser.
      sql/sql_load.cc:
        Now we don't pass type of lock for target table to mysql_load()
        explicitly . Instead we properly set TABLE_LIST::lock_type for
        this table in parser.
      sql/sql_parse.cc:
        Now we don't pass type of lock for target table to mysql_load()
        explicitly . Instead we properly set TABLE_LIST::lock_type for
        this table in parser.
      sql/sql_yacc.yy:
        load_data:
          Let us use TABLE_LIST::lock_type for passing type of lock for target
          table to mysql_load() instead of using LEX::lock_option (which will
          be rewritten by first subselect in SET clause).
      b5a176a5
    • unknown's avatar
      fba770b3
    • unknown's avatar
      mysql-test-run.sh: · 30da9ba3
      unknown authored
        Check that there is a disabled.def before using it
      disabled.def:
        Reenable ndb tests accidently disabled
      
      
      mysql-test/t/disabled.def:
        Reenable ndb tests accidently disabled
      mysql-test/mysql-test-run.sh:
        Check that there is a disabled.def before using it
      30da9ba3
    • unknown's avatar
      ha_innodb.cc: · d6fa9b6c
      unknown authored
        calc_row_difference(): Use non-inlined functions to avoid linking error.
      
      
      sql/ha_innodb.cc:
        calc_row_difference(): Use non-inlined functions to avoid linking error.
      d6fa9b6c
    • unknown's avatar
      Merge grichter@bk-internal.mysql.com:/home/bk/mysql-5.0 · 692b146b
      unknown authored
      into lmy002.wdf.sap.corp:/home/georg/work/mysql/sap/mysql-5.0
      
      692b146b
    • unknown's avatar
      typecast fix for windows 64-bit compilation error · ff252936
      unknown authored
      
      BitKeeper/etc/ignore:
        Added VC++Files/client/mysql_amd64.dsp to the ignore list
      ff252936
    • unknown's avatar
      sql/handler.cc · 8e649cef
      unknown authored
          smarter xid-to-str routiine
          fixed assert crash in XA RECOVER
      sql/sql_parse.cc
          XA COMMIT/ROLLBACK did not send_ok in some cases
      
      
      sql/handler.cc:
        smarter xid-to-str routiine
        fixed assert crash in XA RECOVER
      sql/sql_parse.cc:
        XA COMMIT/ROLLBACK did not send_ok in some cases
      8e649cef
    • unknown's avatar
      global read lock code now uses a dedicated mutex · 370aca10
      unknown authored
      (otherwise a deadlock when ALTER writes to
      binlog holding LOCK_open, it causes binlog rotation,
      binlog waits for prepared transactions to commit, and commit
      needs LOCK_open to check for global read lock)
      
      
      mysql-test/r/flush.result:
        global read lock code now uses a dedicated mutex
      mysql-test/t/flush.test:
        global read lock code now uses a dedicated mutex
      sql/lock.cc:
        global read lock code now uses a dedicated mutex
      sql/mysql_priv.h:
        global read lock code now uses a dedicated mutex
      sql/mysqld.cc:
        global read lock code now uses a dedicated mutex
      sql/sql_table.cc:
        global read lock code now uses a dedicated mutex
      370aca10
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-4.1 · 936ec001
      unknown authored
      into mysql.com:/usr/local/home/marty/MySQL/mysql-4.1
      
      936ec001