1. 26 Mar, 2008 3 commits
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.0-opt · 73b659ad
      unknown authored
      into  host.loc:/home/uchum/work/5.1-opt
      
      
      mysql-test/r/view.result:
        Merge with 5.0-opt (bug#35193).
      mysql-test/t/view.test:
        Merge with 5.0-opt (bug#35193).
      sql/sql_select.cc:
        Merge with 5.0-opt (bug#35193).
      73b659ad
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.0-opt-35193 · e7efc8b9
      unknown authored
      into  host.loc:/home/uchum/work/5.0-opt
      
      e7efc8b9
    • unknown's avatar
      Fixed bug #35193. · b6bf896b
      unknown authored
      View definition as SELECT ... FROM DUAL WHERE ... has
      valid syntax, but use of such view in SELECT or
      SHOW CREATE VIEW syntax causes unexpected syntax error.
      
      Server omits FROM DUAL clause when storing view body
      string in a .frm file for further evaluation.
      However, syntax of SELECT-witout-FROM query is more
      restrictive than SELECT FROM DUAL syntax, and doesn't
      allow the WHERE clause.
      
      NOTE: this syntax difference is not documented.
      
      
      View registration procedure has been modified to
      preserve original structure of view's body.
      
      
      
      mysql-test/r/view.result:
        Added test case for bug #35193.
      mysql-test/t/view.test:
        Added test case for bug #35193.
      sql/sql_select.cc:
        Fixed bug #35193.
        The st_select_lex::print function always omits FROM DUAL clause,
        even if original SELECT query has the WHERE clause.
        
        The mysql_register_view function uses this function to reconstruct
        a body of view's AS clause for further evaluation and stores that
        reconstructed clause in a .frm file.
        
        SELECT without FROM syntax is more restrictive than 
        SELECT FROM DUAL syntax: second one allows
        the WHERE clause, but first one is not.
        
        Use of this view in SELECT or SHOW CREATE VIEW queries
        causes unexpected syntax errors.
        
        
        The st_select_lex::print function has been modified to
        reconstruct FROM DUAL clause in queries when needed.
        
        
        TODO: Syntax difference is not documented and should be
        eliminated, however improvement of
        the SELECT-without-FROM syntax is not trivial and leads to
        significant modification of grammar file because of additional
        shift/reduce conflicts.
      b6bf896b
  2. 25 Mar, 2008 6 commits
  3. 24 Mar, 2008 2 commits
  4. 23 Mar, 2008 5 commits
  5. 21 Mar, 2008 4 commits
    • unknown's avatar
      Bug#8759 (Stored Procedures: SQLSTATE '00000' should be illegal) · befed2f1
      unknown authored
      Fixed the parser to reject SQLSTATE '00000',
      since '00000' is the successful completion condition,
      and can not be caught by an exception handler in SQL.
      
      
      mysql-test/r/sp-error.result:
        Bug#8759 (Stored Procedures: SQLSTATE '00000' should be illegal)
      mysql-test/t/sp-error.test:
        Bug#8759 (Stored Procedures: SQLSTATE '00000' should be illegal)
      sql/sp_pcontext.cc:
        Bug#8759 (Stored Procedures: SQLSTATE '00000' should be illegal)
      befed2f1
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/autopush/B26461-5.0-opt · 515ba6be
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B26461-5.1-opt
      
      
      CMakeLists.txt:
        Auto merged
      include/config-win.h:
        Auto merged
      include/my_global.h:
        Auto merged
      sql/procedure.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_acl.h:
        Auto merged
      sql/sql_analyse.cc:
        Auto merged
      sql/sql_analyse.h:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_load.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/handler.h:
        merged bug 26461 to 5.1-opt
      sql/mysql_priv.h:
        merged bug 26461 to 5.1-opt
      sql/sql_base.cc:
        merged bug 26461 to 5.1-opt
      sql/sql_prepare.cc:
        merged bug 26461 to 5.1-opt
      515ba6be
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · d4efe068
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26461-5.0-opt
      
      d4efe068
    • unknown's avatar
      Bug #26461: Intrinsic data type bool (1 byte) redefined to BOOL (4 bytes) · edd613be
      unknown authored
      The bool data type was redefined to BOOL (4 bytes on windows).
      Removed the #define and fixed some of the warnings that were uncovered
      by this.
      Note that the fix also disables 2 warnings :
      4800 : 'type' : forcing value to bool 'true' or 'false' (performance warning)
      4805: 'operation' : unsafe mix of type 'type' and type 'type' in operation
      
      These warnings will be handled in a separate bug, as they are performance related or bogus.
      
      Fixed to int the return type of functions that return more than 
      2 distinct values.
      
      
      CMakeLists.txt:
        Bug #26461: disable the C4800 and C4805 warnings temporarily
      include/config-win.h:
        Bug #26461: 
         - no need for this define for Windows.
         - windows C++ compilers have a bool type
      include/my_global.h:
        Bug #26461: removed bool_defined (no longer needed)
      sql/handler.h:
        Bug #26461: bool functions must return boolean values
      sql/mysql_priv.h:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/procedure.h:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_acl.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_acl.h:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_analyse.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_analyse.h:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_base.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_db.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_delete.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_load.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_parse.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_prepare.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_update.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      edd613be
  6. 19 Mar, 2008 10 commits
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.0-opt · 581af684
      unknown authored
      into  host.loc:/home/uchum/work/5.1-opt
      
      
      sql/item.cc:
        Auto merged
      581af684
    • unknown's avatar
      Merge host.loc:/home/uchum/work/PA/5.0-opt-34763 · b9cad609
      unknown authored
      into  host.loc:/home/uchum/work/5.1-opt
      
      
      mysql-test/r/subselect3.result:
        Auto merged
      mysql-test/t/subselect3.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      b9cad609
    • unknown's avatar
      Merge host.loc:/home/uchum/work/PA/5.0-opt-34763 · 622aec64
      unknown authored
      into  host.loc:/home/uchum/work/5.0-opt
      
      
      sql/item.cc:
        Auto merged
      622aec64
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 608f7cab
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      608f7cab
    • unknown's avatar
      Bug#34529: Crash on complex Falcon I_S select after ALTER .. PARTITION BY · 53d310a2
      unknown authored
        
      When swapping out heap I_S tables to disk, this is done after plan refinement.
      Thus, READ_RECORD::file will still point to the (deleted) heap handler at start
      of execution. This causes segmentation fault if join buffering is used and the 
      query is a star query where the result is found to be empty before accessing
      some table. In this case that table has not been initialized (i.e. had its 
      READ_RECORD re-initialized) before the cleanup routine tries to close the handler.
      Fixed by updating READ_RECORD::file when changing handler.
      
      
      mysql-test/r/information_schema.result:
        Bug#34529: Test result.
      mysql-test/t/information_schema.test:
        Bug#34529: Test case.
      sql/sql_show.cc:
        Bug#34529: The fix.
      53d310a2
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug34512/my51 · 74d9e4ec
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      sql/item_sum.cc:
        Auto merged
      74d9e4ec
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug34512/my50 · 6245765c
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      6245765c
    • unknown's avatar
      Bug #33334 mysqltest_embedded crashes when disconnecting before reap. · ac397634
      unknown authored
      Before breaking the connection we have to check that there's no query
        executing at the moment. Otherwise it can lead to crash in embedded server.
      
      
      client/mysqltest.c:
        Bug #33334 mysqltest_embedded crashes when disconnecting before reap.
        
        Wait until the query thread is finished before we break the connection.
        Waiting part moved to a separate wait_query_thread_end() function
      mysql-test/r/flush.result:
        Bug #33334 mysqltest_embedded crashes when disconnecting before reap.
        
        test result
      mysql-test/t/flush.test:
        Bug #33334 mysqltest_embedded crashes when disconnecting before reap.
        
        test case
      ac397634
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug34512/my50 · d1d6193a
      unknown authored
      into  kaamos.(none):/data/src/opt/bug34512/my51
      
      
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/t/func_group.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      d1d6193a
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug34650/my51 · e7d51f0c
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/change_user.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/change_user.test:
        Auto merged
      e7d51f0c
  7. 18 Mar, 2008 1 commit
  8. 14 Mar, 2008 2 commits
    • unknown's avatar
      Fixed bug #34763. · a000e8f0
      unknown authored
      Queries like:
      
        SELECT ROW(1, 2) IN (SELECT t1.a, 2)
          FROM t1 GROUP BY t1.a
      
      or 
      
        SELECT ROW(1, 2) IN (SELECT t1.a, 2 FROM t2)
          FROM t1 GROUP BY t1.a
      
      lead to assertion failure in the
      Item_in_subselect::row_value_transformer method in debugging
      build, or to unexpected error message in release build:
      
        ERROR 1247 (42S22): Reference '<list ref>' not supported (forward
                            reference in item list)
      
      Unexpected error message and assertion failure have been
      eliminated.
      
      
      mysql-test/r/subselect3.result:
        Added test case for bug #34763.
      mysql-test/t/subselect3.test:
        Added test case for bug #34763.
      sql/item.cc:
        Fixed bug #34763.
        The Item_ref::fix_fields method has been modified to silently
        ignore not fixed outer references: by the definition, those
        references should be fixed later by the call to the
        fix_inner_refs function.
      sql/item_subselect.cc:
        Fixed bug #34763.
        The Item_in_subselect::row_value_transformer method has been
        modified to eliminate assertion failure on not fixed outer
        references: by the definition those references are allowed in
        this context and should be fixed later by the call to the
        fix_inner_refs function.
      a000e8f0
    • unknown's avatar
      Bug#35108 SELECT FROM REFERENTIAL_CONSTRAINTS crashes · 82435b14
      unknown authored
      referenced_key_name field can be uninitialized in the case when
      referenced table is dropped.
      Added codition which allows to handle this situation.
      
      
      mysql-test/r/information_schema_inno.result:
        test result
      mysql-test/t/information_schema_inno.test:
        test result
      sql/sql_show.cc:
        referenced_key_name field can be uninitialized in the case when
        referenced table is dropped.
        Added codition which allows to handle this situation.
      82435b14
  9. 13 Mar, 2008 2 commits
  10. 12 Mar, 2008 5 commits