1. 11 Dec, 2007 5 commits
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · 747882ae
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      747882ae
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-bug30273 · 4f540b61
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      sql/lock.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      4f540b61
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-amain · d1b4b680
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/t/disabled.def:
        Auto merged
      sql/partition_info.cc:
        Auto merged
      storage/csv/ha_tina.cc:
        Auto merged
      mysql-test/r/func_misc.result:
        SCCS merged
      mysql-test/t/func_misc.test:
        SCCS merged
      d1b4b680
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · bd6b88bf
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      mysql-test/r/func_misc.result:
        Manual merge
      mysql-test/t/func_misc.test:
        Manual merge
      bd6b88bf
    • unknown's avatar
      Bug#30273 - merge tables: Can't lock file (errno: 155) · 0899a87e
      unknown authored
      The patch for Bug 26379 (Combination of FLUSH TABLE and
      REPAIR TABLE corrupts a MERGE table) fixed this bug too.
      However it revealed a new bug that crashed the server.
      
      Flushing a merge table at the moment when it is between open
      and attach of children crashed the server.
      
      The flushing thread wants to abort locks on the flushed table.
      It calls ha_myisammrg::lock_count() and ha_myisammrg::store_lock()
      on the TABLE object of the other thread.
      
      Changed ha_myisammrg::lock_count() and ha_myisammrg::store_lock()
      to accept non-attached children. ha_myisammrg::lock_count() returns
      the number of MyISAM tables in the MERGE table so that the memory
      allocation done by get_lock_data() is done correctly, even if the
      children become attached before ha_myisammrg::store_lock() is
      called. ha_myisammrg::store_lock() will not return any lock if the
      children are not attached.
      
      This is however a change in the handler interface. lock_count()
      can now return a higher number than store_lock() stores locks.
      This is more safe than the reverse implementation would be.
      get_lock_data() in the SQL layer is adjusted accordingly. It sets
      MYSQL_LOCK::lock_count based on the number of locks returned by
      the handler::store_lock() calls, not based on the numbers returned
      by the handler::lock_count() calls. The latter are only used for
      allocation of memory now.
      
      No test case. The test suite cannot reliably run FLUSH between
      lock_count() and store_lock() of another thread. The bug report
      contains a program that can repeat the problem with some
      probability.
      
      
      include/myisammrg.h:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Added mutex to struct st_myrg_info (MYRG_INFO).
      sql/handler.h:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Extended comments for handler::lock_count() and
        handler::store_lock().
      sql/lock.cc:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Changed get_lock_data() so that the final lock_count is taken
        from the number of locks returned from handler::store_lock()
        instead of from handler::lock_count().
      sql/sql_base.cc:
        Fixed a purecov comment. (unrelated to the rest of the changeset)
      storage/myisammrg/ha_myisammrg.cc:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Changed ha_myisammrg::lock_count() and ha_myisammrg::store_lock()
        to accept non-attached children.
        Protected ha_myisammrg::store_lock() by MYRG_INFO::mutex.
      storage/myisammrg/myrg_close.c:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Added MYRG_INFO::mutex destruction to myrg_parent_close().
      storage/myisammrg/myrg_open.c:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Added MYRG_INFO::mutex initialization to myrg_parent_open().
        Protected myrg_attach_children() and myrg_detach_children()
        by MYRG_INFO::mutex.
        Fixed a purecov comment. (unrelated to the rest of the changeset)
      0899a87e
  2. 10 Dec, 2007 8 commits
  3. 08 Dec, 2007 1 commit
  4. 07 Dec, 2007 18 commits
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · 54c0baee
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      54c0baee
    • unknown's avatar
      Add a way to remove options which mysql-test-run.pl no longer uses. · 5719de73
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Add a way to remove options which mysql-test-run.pl no longer uses.  Since
        mysql-test-run.pl passes unrecognized options through to mysqld directly,
        it is not possible to just remove an option.  Otherwise it would be given
        to mysqld, which probably will not recognize it and will fail to start.
        
        Instead, we now explicitly ignore the option, and print a warning to
        the user.
      5719de73
    • unknown's avatar
      Merge five.local.lan:/work/merge/mysql-5.1-build · 72e65ccd
      unknown authored
      into  five.local.lan:/work/merge/mysql-5.1-build-parts
      
      72e65ccd
    • unknown's avatar
      Merge trift2.:/MySQL/M51/embedtest-5.1 · dcccc96e
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      dcccc96e
    • unknown's avatar
      Makefile.am · 7f0893fc
      unknown authored
          Makefile syntax error, comment should precede the whole target.
      
      
      Makefile.am:
        Makefile syntax error, comment should precede the whole target.
      7f0893fc
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · bd7e299d
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      bd7e299d
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 0eb84b33
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      0eb84b33
    • unknown's avatar
      Merge trift2.:/MySQL/M51/embedtest-5.1 · b512a29c
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      b512a29c
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · c584b458
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      mysql-test/t/disabled.def:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      c584b458
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · 5a52e533
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      sql/sql_table.cc:
        Auto merged
      5a52e533
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1 · b4accb75
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/r/grant.result:
        Manual merge
      mysql-test/t/grant.test:
        Manual merge
      b4accb75
    • unknown's avatar
      Makefile.am · 4a955058
      unknown authored
          In the "test-bt" target, replace the call "$(MAKE) test-embedded" by the actions of that target.
      
      
      Makefile.am:
        In the "test-bt" target, replace the call "$(MAKE) test-embedded" by the actions of that target.
        
        Reason:
        For release builds, we run the tests in a tree that contains just a binary installation.
        So the Makefile is not in the test tree, and we explicitly address it in the build tree.
        This explicit path is not kept by "make", so it is missing in the sub-make.
        There seems to be no way to solve this with (portable!) "make" features -
        we could add a new variable and use it in the sub-make, but it is easier to duplicate these few lines.
      4a955058
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0 · 69ba161c
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/50
      
      
      sql/sql_table.cc:
        Auto merged
      69ba161c
    • unknown's avatar
      BUG#32817 - though CSV is marked as supported create table is rejected · 874d13af
      unknown authored
                  with error 1005.
      
      CSV doesn't support nullable fields. Report descriptive error if create
      table with nullable field is requested.
      
      
      mysql-test/r/csv.result:
        A test case for BUG#32817.
      mysql-test/t/csv.test:
        A test case for BUG#32817.
      storage/csv/ha_tina.cc:
        CSV doesn't support nullable fields. Report descriptive error if create
        table with nullable field is requested.
      874d13af
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · 3d2ff984
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51-merge
      
      
      mysql-test/t/grant.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      mysql-test/r/grant.result:
        Manual merge
      3d2ff984
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/41 · 6c4f81c9
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/50
      
      
      strings/ctype-simple.c:
        use local (null merge)
      6c4f81c9
    • unknown's avatar
      Make tests more robust (clean up better after grant.test) · 47707bd4
      unknown authored
      
      mysql-test/r/grant.result:
        Update test results to .test changes
      mysql-test/t/grant.test:
        Drop users when done with them, to avoid skewing results of later tests.
        
        For example, running some test which examines the cardinality of the
        mysql.user table would fail if run right after this test, due to the
        extra users.
      47707bd4
    • unknown's avatar
      Move the test case for bug #20901 from create.test to grant.test, so · f11b6dbe
      unknown authored
      testing embedded server works correctly.
      
      
      mysql-test/r/create.result:
        Move one test from create.test to grant.test, because it actually tests
        privileges (and thus doesn't work with embedded server).
      mysql-test/r/grant.result:
        Move one test from create.test to grant.test, because it actually tests
        privileges (and thus doesn't work with embedded server).
      mysql-test/t/create.test:
        Move one test from create.test to grant.test, because it actually tests
        privileges (and thus doesn't work with embedded server).
      mysql-test/t/grant.test:
        Move one test from create.test to grant.test, because it actually tests
        privileges (and thus doesn't work with embedded server).
      f11b6dbe
  5. 06 Dec, 2007 3 commits
  6. 05 Dec, 2007 5 commits
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · f4127cc9
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51-merge
      
      
      client/mysqldump.c:
        Auto merged
      include/my_sys.h:
        Auto merged
      libmysql/CMakeLists.txt:
        Auto merged
      libmysql/Makefile.shared:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/suite/binlog/t/binlog_killed.test:
        Auto merged
      mysql-test/t/cast.test:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/set_var.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      storage/myisam/ft_boolean_search.c:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      storage/myisam/sort.c:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      f4127cc9
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/41 · a24c025e
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/50
      
      
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      sql/set_var.cc:
        Auto merged
      a24c025e
    • unknown's avatar
      Post-merge fix (reorder tests in ctype_ucs.test) · 7e0049a4
      unknown authored
      
      mysql-test/t/ctype_ucs.test:
        Post-merge fix (fix order of tests to match results).
      7e0049a4
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/51 · 67da1a19
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51-merge
      
      
      client/mysqldump.c:
        Auto merged
      include/my_base.h:
        Auto merged
      include/my_sys.h:
        Auto merged
      libmysql/CMakeLists.txt:
        Auto merged
      libmysql/Makefile.shared:
        Auto merged
      mysql-test/lib/mtr_cases.pl:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/grant.result:
        Auto merged
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/suite/rpl/t/rpl_ssl.test:
        Auto merged
      mysql-test/t/cast.test:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/records.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/set_var.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/unireg.cc:
        Auto merged
      storage/myisam/ft_boolean_search.c:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      storage/myisam/sort.c:
        Auto merged
      mysql-test/t/log_state.test:
        Manual merge fix-up
      mysql-test/include/mix1.inc:
        Manual merge
      mysql-test/r/ctype_ucs.result:
        Manual merge
      mysql-test/r/func_misc.result:
        Manual merge
      mysql-test/r/innodb_mysql.result:
        Manual merge
      mysql-test/r/key.result:
        Manual merge
      mysql-test/r/log_state.result:
        Manual merge
      mysql-test/suite/binlog/t/binlog_killed.test:
        Manual merge
      mysql-test/t/ctype_ucs.test:
        Manual merge
      mysql-test/t/func_misc.test:
        Manual merge
      mysql-test/t/key.test:
        Manual merge
      sql/item_strfunc.h:
        Manual merge
      strings/ctype-simple.c:
        Manual merge
      67da1a19
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/mysql-5.1-bug30822 · 2d40918a
      unknown authored
      into  witty.:/Users/mattiasj/clones/51to_push
      
      
      sql/ha_partition.cc:
        Auto merged
      sql/sql_partition.cc:
        Auto merged
      2d40918a